From t.wagner@nthfs.jku.at Thu Nov 6 15:18:17 2014 Received: (at submit) by bugs.x2go.org; 6 Nov 2014 14:18:19 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=ham version=3.3.2 X-Greylist: delayed 378 seconds by postgrey-1.34 at ymir.das-netzwerkteam.de; Thu, 06 Nov 2014 15:18:17 CET Received: from email.uni-linz.ac.at (email.edvz.uni-linz.ac.at [140.78.3.65]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 543B05DEA7 for ; Thu, 6 Nov 2014 15:18:17 +0100 (CET) Received: from mail.icie.jku.at (iciemail.mechatronik.uni-linz.ac.at [140.78.138.2]) by email.uni-linz.ac.at (Postfix) with ESMTP id 06EAD1E8CA5 for ; Thu, 6 Nov 2014 15:11:59 +0100 (CET) Received: from [10.78.1.87] (unknown [10.78.1.87]) by mail.icie.jku.at (Postfix) with ESMTPSA id C4437154BC7 for ; Thu, 6 Nov 2014 15:11:48 +0100 (CET) Message-ID: <545B81A3.2000406@nthfs.jku.at> Date: Thu, 06 Nov 2014 15:11:47 +0100 From: Thomas Wagner User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: submit@bugs.x2go.org Subject: Domain\User notation for fails due to missing quotation of "\" Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Package: x2goserver Version 4.0.1.18 Hi folks, I'm using x2goserver on an openSUSE 13.1 which is a member in an AD-Domain. Thus is have usernames like "DOMAIN\USER". Logging in with SSH works fine but starting x2go fails. For some users I get errors like MYDOMAIN\student is not authorized at /usr/lib/x2go/x2gosqlitewrapper.pl line 527. : /usr/lib/x2go/x2gosqlitewrapper insertsession 60 cd-sim MYDOMAINstudent-60-1415280062 at /usr/lib64/x2go/x2godbwrapper.pm line 320. For other users it works. I tracked the problem down to line 525 in x2gosqlitewrapper.pl. The line is: $user =~ s/$realuser-[0-9]{2,}-[0-9]{10,}.*/$realuser/; $realuser is a string like "MYDOMAIN\student". This is what makes the regex fail since \s is a special escape sequence in perl. Also usernames with other special escape sequences like \k fail. best regards Thomas -- Dipl.-Ing. Thomas Wagner Institute for Communications and Information Engineering Johannes Kepler University Linz, 4040 Linz, Austria mailto: t.wagner@nthfs.jku.at Phone: +43 732 2468 6404 http://www.nthfs.jku.at From peter@ludikovsky.name Fri Dec 5 13:35:48 2014 Received: (at 664) by bugs.x2go.org; 5 Dec 2014 12:35:51 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,SPF_HELO_PASS, T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from ludikovsky.name (ludikovsky.name [158.255.212.178]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 9BE515E0DE for <664@bugs.x2go.org>; Fri, 5 Dec 2014 13:35:48 +0100 (CET) Received: by ludikovsky.name (Postfix, from userid 113) id 86A1141FD; Fri, 5 Dec 2014 12:29:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ludikovsky.name; s=mail; t=1417782577; bh=Cth6kRfqo7bhELREgxiHzknWpY2Xs9+FrFT6BbD8jbU=; h=From:To:Subject:Date:From; b=UUOoUO//A8L5q3BpYQCR9MOmXIo73G2Rcyf4FpObsZIyRxAIzkhvODDSgSDVMLPkW BG/YASpNQSZMhXARR3GAEkEcU6Gq6SiKoVRwyMlrD0bW8PSKQH7FAiCAMlA3rxPT2t QE3MHQTllBRivXVPSfVreyN8+vPayjhMEBnUVDsM= Received: from HBDLAP7424.lan.hbd. (localhost [127.0.0.1]) by ludikovsky.name (Postfix) with ESMTPSA id F214441EF for <664@bugs.x2go.org>; Fri, 5 Dec 2014 12:29:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ludikovsky.name; s=mail; t=1417782577; bh=Cth6kRfqo7bhELREgxiHzknWpY2Xs9+FrFT6BbD8jbU=; h=From:To:Subject:Date:From; b=UUOoUO//A8L5q3BpYQCR9MOmXIo73G2Rcyf4FpObsZIyRxAIzkhvODDSgSDVMLPkW BG/YASpNQSZMhXARR3GAEkEcU6Gq6SiKoVRwyMlrD0bW8PSKQH7FAiCAMlA3rxPT2t QE3MHQTllBRivXVPSfVreyN8+vPayjhMEBnUVDsM= From: Peter Ludikovsky To: 664@bugs.x2go.org Subject: Confirmed Bug & Patch against git HEAD Date: Fri, 5 Dec 2014 13:29:26 +0100 Message-Id: <1417782567-17916-1-git-send-email-peter@ludikovsky.name> X-Mailer: git-send-email 1.9.3 Hello, I can confirm this bug for x2goserver 4.0.1.15 on CentOS 6. Attached is a patch against the current HEAD. Regards, Peter Ludikovsky From peter@ludikovsky.name Fri Dec 5 13:35:48 2014 Received: (at 664) by bugs.x2go.org; 5 Dec 2014 12:35:58 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,SPF_HELO_PASS, T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham version=3.3.2 X-Greylist: delayed 370 seconds by postgrey-1.34 at ymir.das-netzwerkteam.de; Fri, 05 Dec 2014 13:35:48 CET Received: from ludikovsky.name (ludikovsky.name [158.255.212.178]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 97DD35E0DD for <664@bugs.x2go.org>; Fri, 5 Dec 2014 13:35:48 +0100 (CET) Received: by ludikovsky.name (Postfix, from userid 113) id A679641FC; Fri, 5 Dec 2014 12:29:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ludikovsky.name; s=mail; t=1417782577; bh=KKAnx7tG3j9IXrM1Hd/Ky9umaSVNn4BTEsksZyykP5k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JhOzsddRCcxyVt4s3HUvSpFx0ikW5m+w5OASXgIaJuV5Z/VUvQegnSCzCLLJcAWkN 5mAh3VgKPNE6WEMtMR9UBRp70fpIE/7ybrmsB3otnI7/YqLcGMXtOD1nbsMOz03tKr VzeMtvqbJaDiIa2+ZDg3/QqXsUqS5i70OlQ4ZV48= Received: from HBDLAP7424.lan.hbd. (localhost [127.0.0.1]) by ludikovsky.name (Postfix) with ESMTPSA id 3464241FB; Fri, 5 Dec 2014 12:29:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ludikovsky.name; s=mail; t=1417782577; bh=KKAnx7tG3j9IXrM1Hd/Ky9umaSVNn4BTEsksZyykP5k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JhOzsddRCcxyVt4s3HUvSpFx0ikW5m+w5OASXgIaJuV5Z/VUvQegnSCzCLLJcAWkN 5mAh3VgKPNE6WEMtMR9UBRp70fpIE/7ybrmsB3otnI7/YqLcGMXtOD1nbsMOz03tKr VzeMtvqbJaDiIa2+ZDg3/QqXsUqS5i70OlQ4ZV48= From: Peter Ludikovsky To: 664@bugs.x2go.org Cc: Peter Ludikovsky Subject: [PATCH] Patch for Bug #664 Date: Fri, 5 Dec 2014 13:29:27 +0100 Message-Id: <1417782567-17916-2-git-send-email-peter@ludikovsky.name> X-Mailer: git-send-email 1.9.3 In-Reply-To: <1417782567-17916-1-git-send-email-peter@ludikovsky.name> References: <1417782567-17916-1-git-send-email-peter@ludikovsky.name> --- X2Go/Server/DB/SQLite3.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/X2Go/Server/DB/SQLite3.pm b/X2Go/Server/DB/SQLite3.pm index d693809..dd4e403 100644 --- a/X2Go/Server/DB/SQLite3.pm +++ b/X2Go/Server/DB/SQLite3.pm @@ -656,6 +656,7 @@ sub check_user # session id looks like someuser-51-1304005895_stDgnome-session_dp24 # during DB insertsession it only looks like someuser-51-1304005895 my $user = "$sid"; + $realuser =~ s/\\//; $user =~ s/($realuser-[0-9]{2,}-[0-9]{10,}_st(D|R).*|.*-[0-9]{2,}-[0-9]{10,}_stS(0|1)XSHAD$realuser.*)/$realuser/; $user eq $realuser or die "$realuser is not authorized"; } -- 1.9.3 From x2go@ymir.das-netzwerkteam.de Sat Dec 6 22:46:56 2014 Received: (at 664) by bugs.x2go.org; 6 Dec 2014 21:46:58 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_RELAYS, URIBL_BLOCKED autolearn=ham version=3.3.2 Received: by ymir.das-netzwerkteam.de (Postfix, from userid 1005) id 6C6605E0DE; Sat, 6 Dec 2014 22:46:56 +0100 (CET) From: Mike Gabriel To: 664-submitter@bugs.x2go.org Cc: control@bugs.x2go.org, 664@bugs.x2go.org Subject: X2Go issue (in src:x2goserver) has been marked as pending for release Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Mailer: http://snipr.com/post-receive-tag-pending Message-Id: <20141206214656.6C6605E0DE@ymir.das-netzwerkteam.de> Date: Sat, 6 Dec 2014 22:46:56 +0100 (CET) tag #664 pending fixed #664 4.0.1.19 thanks Hello, X2Go issue #664 (src:x2goserver) reported by you has been fixed in X2Go Git. You can see the changelog below, and you can check the diff of the fix at: http://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=7be656c The issue will most likely be fixed in src:x2goserver (4.0.1.19). light+love X2Go Git Admin (on behalf of the sender of this mail) --- commit 7be656cd888024baba6df01d06e7ed93258dfc35 Author: Mike Gabriel Date: Sat Dec 6 22:46:08 2014 +0100 Handle AD domain users gracefully when X2Go is used with SQLite DB backend. (Fixes: #664). diff --git a/debian/changelog b/debian/changelog index 5c71034..84cdd56 100644 --- a/debian/changelog +++ b/debian/changelog @@ -50,6 +50,8 @@ x2goserver (4.0.1.19-0x2go1) UNRELEASED; urgency=medium clipboard mode feature (and probably other code changes). - Document session startup / resumption failures (and their reasons) in server-side log output. + - Handle AD domain users gracefully when X2Go is used with SQLite DB + backend. (Fixes: #664). * debian/control: + Add D (x2goserver): libfile-which-perl. + Add C (x2goserver: x2godesktopsharing (<< 3.1.1.2). From x2go@ymir.das-netzwerkteam.de Tue Feb 24 21:54:09 2015 Received: (at 664) by bugs.x2go.org; 24 Feb 2015 20:54:50 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_RELAYS, URIBL_BLOCKED autolearn=unavailable version=3.3.2 Received: by ymir.das-netzwerkteam.de (Postfix, from userid 1005) id 641253BE63; Tue, 24 Feb 2015 21:54:08 +0100 (CET) From: X2Go Release Manager To: 664-submitter@bugs.x2go.org Cc: control@bugs.x2go.org, 664@bugs.x2go.org Subject: X2Go issue (in src:x2goserver) has been marked as closed Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Message-Id: <20150224205409.641253BE63@ymir.das-netzwerkteam.de> Date: Tue, 24 Feb 2015 21:54:08 +0100 (CET) close #664 thanks Hello, we are very hopeful that X2Go issue #664 reported by you has been resolved in the new release (4.0.1.19) of the X2Go source project »src:x2goserver«. You can view the complete changelog entry of src:x2goserver (4.0.1.19) below, and you can use the following link to view all the code changes between this and the last release of src:x2goserver. http://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=49c91751e560ad09ab4490cc3bd6687509c05755;hp=724d2eefe399485a71e79c705a0aad125e853230 If you feel that the issue has not been resolved satisfyingly, feel free to reopen this bug report or submit a follow-up report with further observations described based on the new released version of src:x2goserver. Thanks a lot for contributing to X2Go!!! light+love X2Go Git Admin (on behalf of the sender of this mail) --- X2Go Component: src:x2goserver Version: 4.0.1.19-0x2go1 Status: RELEASE Date: Tue, 24 Feb 2015 21:49:22 +0100 Fixes: 405 632 633 638 644 664 668 671 672 675 676 678 697 698 700 712 715 727 728 770 Changes: x2goserver (4.0.1.19-0x2go1) RELEASED; urgency=medium . [ Mike Gabriel ] * New upstream version (4.0.1.19): - Use File::Which to detect if sshfs command is available before trying to mount a client-side folder. - Be a bit more tolerant when trying to detect if a desktop icon is to be removed (using regexp, not eq). - Xsession script: Prevent bash failures when sourcing external bash scripts beyond our scope. (Fixes: #632, #675). - x2gogetapps: Support scanning of sub-directories when searching for .desktop files. We allow to dive down one level into subdirs, we on purpose do not recursively dive into the complete subtree. (Fixes: #633). - Make man2html an optional tool. Don't fail if it is missing on the build system (required for openSUSE/SLES builds). - Fix x2goserver-xsession/Makefile on SUSE. Detect SUSE distro and create Xsession related directory symlinks (xinitrc.d and Xclients.d). - Hack for x2goserver-xsession/Makefile during SUSE builds. If directoy /usr/share/doc/packages/brp-check-suse is present, the build env is also considered to be a SUSE system. - Trigger Xsession code for SUSE systems (look for /etc/SUSE-brand or /etc/SuSE-release for SUSE system recognition). (Fixes: #671). - x2gosqlitewrapper.c: Fix rpmlint error: no-return-in-nonvoid-function. Return the exitcode of execve(). - Fix gramma in error message (in x2goresume-session). - x2gocleansessions: Call x2gormforward also on terminated sessions. This will make sure that re-assigned ports are really available on new session startup. - x2golistsessions(_root): Only update session state in session DB if x2goagent's state file really exists. This addresses a problem that occurs when x2golistsessions gets called via an x2gobroker-agent. The x2golistsessions script may show session states (--all-servers) of sessions on other servers that have session states files on their remote /tmp dirs. These files are not accessible for that x2golistsessions script and should simply be ignored. (Fixes: #638). - Provide pam_namespace support for has_agent_state_file() function. - Fix missing session list output if state file does not exist on the machine that runs x2golistsessions(_root). - Accept more verbose "DENY" output from x2godesktopsharing. - Make sure that all "su"-to-user-contexts use /bin/sh for wrapping around the executed command (in x2gocleansessions and x2golistsessions_root). - Also enforce /bin/sh as shell in su command in x2goprint. - README.i18n: Add file that explains the translation workflow for this package. Thanks to Mark Pedersen-Cook for drafting this file. - Make SSH agent forwarding work after having reconnected via SSH and having resumed a session. (Fixes: #672). Thanks to Robert Siemer for coming up with that idea. - Fix cross-user X2Go Desktop Sharing after being broken by implementing clipboard mode feature (and probably other code changes). - Document session startup / resumption failures (and their reasons) in server-side log output. - Handle AD domain users gracefully when X2Go is used with SQLite DB backend. (Fixes: #664). - Improve sanitizer, use 'x2gosid' sanitizer for session IDs everywhere. Drop unused 'pnixusername' sanitizer in 4.0.1.x release of X2Go Server. - Allow usernames in session IDs of length 48 chars. - Start sshfs with a timeout of 30 seconds (because it never finishes if something is wrong with the client-side TCP socket). Also remove/unmount mountpoints erroneously registered sshfs mountpoints if sshfs command times out. Furthermore, print errors to STDERR (not STDOUT). (Fixes: #405). - Handle execution of ss command from Perl script x2golistdesktops in a way that not only works on Debian, but also on Fedora et al. (Fixes: #727). - Provide legacy support for old File::Path packages in x2godbadmin. (Fixes: #715). - Fix wrong evocation of x2gosyslog ("error" -> "err"). - Use "undef $dbh" instead of "$dbh->disconnect()". Fixes SQLite3 issues on SLE 11.x. - Only call $dbh->sqlite_busy_timeout() if the $dbh object is capable of that. Works around a too-old DBD::SQLite package on SLE 11.x. - Legacy for applications (and X2Go scripts) that expect $SSH_CLIENT to be set in the X2Go session's environment. (Fixes: #644). - Add man page for x2gogetapps. Weave into that a security / disclaimer message as proposed by Stefan Baur. (Fixes: #728). * debian/control: + Add D (x2goserver): libfile-which-perl. + Add C (x2goserver: x2godesktopsharing (<< 3.1.1.2-0~). (Fixes: #700). + Bump Standards: to 3.9.6. No changes needed. + Don't depend on libdb-pg-perl for armhf builds. (Fixes: #712). Thanks to Heinrich Schuchardt for providing information on this. + Upgrade to D again (bin:package x2goserver): xfonts-base (Fixes: #770). * debian/x2goserver.docs: + Install README.i18n file into bin:package x2goserver. * x2goserver.spec: + Add to R: perl(File::Which). + Additionally adapt to building on openSUSE/SLES. + No shell expansion possible in obs-build, detect perl version only for non-SUSE builds. + Add to R: x2goserver-xsession. + Don't mention /etc/x2go/x2gosql/sql twice (directly and with wildcard). + No %{_sysconfdir}/x2go/Xclients.d on SUSE systems. + Use %{_localstatedir} instead of %{_sharedstatedir}. + Use proper if... then... clauses. + For SUSE builds: Add to R: shadow (useradd, groupadd). + Replace historical "egrep" with "grep -E". + Systemd support for SUSE >= 12.10. + Set %defattr macro for every bin:package. + SUSE and Fedora/RHEL have different package group names. + Add x2goserver-rpmlintrc file to handle some rpmlint errors and warnings. + SUSE has openssh, but no openssh-server. + Add to R (x2goserver): perl-X2Go-Server. + Add to R (diverse): perl(Config::Simple), perl(Switch) and perl(Capture::Tiny). + Add to R (x2goserver): perl(File::BaseDir). + Don't hard-code /var/lib/ in $HOME path of to-be-created user "x2gouser". + Add to BR: findutils. + For Fedora-like systems, don't make x2goserver bin:package authoritative for non-X2Go directories. (Fixes: #676). + Remove macro call %systemd_pre for Fedora/EPEL-7 builds. No such macro in Fedora/RHEL7. (Fixes: 698). + Create system user x2gouser with $HOME in /var/lib/x2go. (Fixes: #697). + Always set BuildRoot: parameter. + BuildRequires: SUSE <= 11.3 has xorg-x11, not xinit. + Requires (x2goserver-xsession): SUSE <= 11.3 has xorg-x11, not xinit. + No Bashisms in scriptlets. + rpmlint requires shared-mime-info at build time on SLE <= 11.3. + "%set_permissions" / "%verify_permissions" macros are not know in SLE <= 11.3. Using "%run permissions" and "%verify permissions" instead. + On SUSE, add permissions.d/x2goserver. + Fix SQLite wrapper permissions (02775 -> 02755) + Use if then clauses for creating user/group x2goprint. . [ Matthew L. Dailey ] * New upstream version (4.0.1.19): - x2gocleansessions: Redirect stdin, stdout and stderr to /dev/null, test for the existence of the file descriptor before issuing the close, only capture the file descriptor backreference in the regex and send any close failures to syslog. (Fixes: #678). . [ Lars Wendler ] * New upstream version (4.0.1.19): - Use "printf" instead of "echo -n". (Fixes: #668). From unknown Fri Mar 29 07:43:48 2024 MIME-Version: 1.0 X-Mailer: MIME-tools 5.502 (Entity 5.502) X-Loop: owner@bugs.x2go.org From: owner@bugs.x2go.org (X2Go Bug Tracking System) Subject: Bug#664 closed by X2Go Release Manager (X2Go issue (in src:x2goserver) has been marked as closed) Message-ID: References: <20150224205409.641253BE63@ymir.das-netzwerkteam.de> X-X2go-PR-Keywords: pending X-X2go-PR-Message: they-closed 664 X-X2go-PR-Package: x2goserver X-X2go-PR-Source: x2goserver Date: Tue, 24 Feb 2015 20:55:33 +0000 Content-Type: multipart/mixed; boundary="----------=_1424811333-13756-0" This is a multi-part message in MIME format... ------------=_1424811333-13756-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 This is an automatic notification regarding your Bug report which was filed against the x2goserver package: #664: Domain\User notation for fails due to missing quotation of "\" It has been closed by X2Go Release Manager . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact X2Go Release Manager <= git-admin@x2go.org> by replying to this email. --=20 X2Go Bug Tracking System Contact owner@bugs.x2go.org with problems ------------=_1424811333-13756-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at control) by bugs.x2go.org; 24 Feb 2015 20:54:30 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_RELAYS, URIBL_BLOCKED autolearn=ham version=3.3.2 Received: by ymir.das-netzwerkteam.de (Postfix, from userid 1005) id 641253BE63; Tue, 24 Feb 2015 21:54:08 +0100 (CET) From: X2Go Release Manager To: 664-submitter@bugs.x2go.org Cc: control@bugs.x2go.org, 664@bugs.x2go.org Subject: X2Go issue (in src:x2goserver) has been marked as closed Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Message-Id: <20150224205409.641253BE63@ymir.das-netzwerkteam.de> Date: Tue, 24 Feb 2015 21:54:08 +0100 (CET) close #664 thanks Hello, we are very hopeful that X2Go issue #664 reported by you has been resolved in the new release (4.0.1.19) of the X2Go source project »src:x2goserver«. You can view the complete changelog entry of src:x2goserver (4.0.1.19) below, and you can use the following link to view all the code changes between this and the last release of src:x2goserver. http://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=49c91751e560ad09ab4490cc3bd6687509c05755;hp=724d2eefe399485a71e79c705a0aad125e853230 If you feel that the issue has not been resolved satisfyingly, feel free to reopen this bug report or submit a follow-up report with further observations described based on the new released version of src:x2goserver. Thanks a lot for contributing to X2Go!!! light+love X2Go Git Admin (on behalf of the sender of this mail) --- X2Go Component: src:x2goserver Version: 4.0.1.19-0x2go1 Status: RELEASE Date: Tue, 24 Feb 2015 21:49:22 +0100 Fixes: 405 632 633 638 644 664 668 671 672 675 676 678 697 698 700 712 715 727 728 770 Changes: x2goserver (4.0.1.19-0x2go1) RELEASED; urgency=medium . [ Mike Gabriel ] * New upstream version (4.0.1.19): - Use File::Which to detect if sshfs command is available before trying to mount a client-side folder. - Be a bit more tolerant when trying to detect if a desktop icon is to be removed (using regexp, not eq). - Xsession script: Prevent bash failures when sourcing external bash scripts beyond our scope. (Fixes: #632, #675). - x2gogetapps: Support scanning of sub-directories when searching for .desktop files. We allow to dive down one level into subdirs, we on purpose do not recursively dive into the complete subtree. (Fixes: #633). - Make man2html an optional tool. Don't fail if it is missing on the build system (required for openSUSE/SLES builds). - Fix x2goserver-xsession/Makefile on SUSE. Detect SUSE distro and create Xsession related directory symlinks (xinitrc.d and Xclients.d). - Hack for x2goserver-xsession/Makefile during SUSE builds. If directoy /usr/share/doc/packages/brp-check-suse is present, the build env is also considered to be a SUSE system. - Trigger Xsession code for SUSE systems (look for /etc/SUSE-brand or /etc/SuSE-release for SUSE system recognition). (Fixes: #671). - x2gosqlitewrapper.c: Fix rpmlint error: no-return-in-nonvoid-function. Return the exitcode of execve(). - Fix gramma in error message (in x2goresume-session). - x2gocleansessions: Call x2gormforward also on terminated sessions. This will make sure that re-assigned ports are really available on new session startup. - x2golistsessions(_root): Only update session state in session DB if x2goagent's state file really exists. This addresses a problem that occurs when x2golistsessions gets called via an x2gobroker-agent. The x2golistsessions script may show session states (--all-servers) of sessions on other servers that have session states files on their remote /tmp dirs. These files are not accessible for that x2golistsessions script and should simply be ignored. (Fixes: #638). - Provide pam_namespace support for has_agent_state_file() function. - Fix missing session list output if state file does not exist on the machine that runs x2golistsessions(_root). - Accept more verbose "DENY" output from x2godesktopsharing. - Make sure that all "su"-to-user-contexts use /bin/sh for wrapping around the executed command (in x2gocleansessions and x2golistsessions_root). - Also enforce /bin/sh as shell in su command in x2goprint. - README.i18n: Add file that explains the translation workflow for this package. Thanks to Mark Pedersen-Cook for drafting this file. - Make SSH agent forwarding work after having reconnected via SSH and having resumed a session. (Fixes: #672). Thanks to Robert Siemer for coming up with that idea. - Fix cross-user X2Go Desktop Sharing after being broken by implementing clipboard mode feature (and probably other code changes). - Document session startup / resumption failures (and their reasons) in server-side log output. - Handle AD domain users gracefully when X2Go is used with SQLite DB backend. (Fixes: #664). - Improve sanitizer, use 'x2gosid' sanitizer for session IDs everywhere. Drop unused 'pnixusername' sanitizer in 4.0.1.x release of X2Go Server. - Allow usernames in session IDs of length 48 chars. - Start sshfs with a timeout of 30 seconds (because it never finishes if something is wrong with the client-side TCP socket). Also remove/unmount mountpoints erroneously registered sshfs mountpoints if sshfs command times out. Furthermore, print errors to STDERR (not STDOUT). (Fixes: #405). - Handle execution of ss command from Perl script x2golistdesktops in a way that not only works on Debian, but also on Fedora et al. (Fixes: #727). - Provide legacy support for old File::Path packages in x2godbadmin. (Fixes: #715). - Fix wrong evocation of x2gosyslog ("error" -> "err"). - Use "undef $dbh" instead of "$dbh->disconnect()". Fixes SQLite3 issues on SLE 11.x. - Only call $dbh->sqlite_busy_timeout() if the $dbh object is capable of that. Works around a too-old DBD::SQLite package on SLE 11.x. - Legacy for applications (and X2Go scripts) that expect $SSH_CLIENT to be set in the X2Go session's environment. (Fixes: #644). - Add man page for x2gogetapps. Weave into that a security / disclaimer message as proposed by Stefan Baur. (Fixes: #728). * debian/control: + Add D (x2goserver): libfile-which-perl. + Add C (x2goserver: x2godesktopsharing (<< 3.1.1.2-0~). (Fixes: #700). + Bump Standards: to 3.9.6. No changes needed. + Don't depend on libdb-pg-perl for armhf builds. (Fixes: #712). Thanks to Heinrich Schuchardt for providing information on this. + Upgrade to D again (bin:package x2goserver): xfonts-base (Fixes: #770). * debian/x2goserver.docs: + Install README.i18n file into bin:package x2goserver. * x2goserver.spec: + Add to R: perl(File::Which). + Additionally adapt to building on openSUSE/SLES. + No shell expansion possible in obs-build, detect perl version only for non-SUSE builds. + Add to R: x2goserver-xsession. + Don't mention /etc/x2go/x2gosql/sql twice (directly and with wildcard). + No %{_sysconfdir}/x2go/Xclients.d on SUSE systems. + Use %{_localstatedir} instead of %{_sharedstatedir}. + Use proper if... then... clauses. + For SUSE builds: Add to R: shadow (useradd, groupadd). + Replace historical "egrep" with "grep -E". + Systemd support for SUSE >= 12.10. + Set %defattr macro for every bin:package. + SUSE and Fedora/RHEL have different package group names. + Add x2goserver-rpmlintrc file to handle some rpmlint errors and warnings. + SUSE has openssh, but no openssh-server. + Add to R (x2goserver): perl-X2Go-Server. + Add to R (diverse): perl(Config::Simple), perl(Switch) and perl(Capture::Tiny). + Add to R (x2goserver): perl(File::BaseDir). + Don't hard-code /var/lib/ in $HOME path of to-be-created user "x2gouser". + Add to BR: findutils. + For Fedora-like systems, don't make x2goserver bin:package authoritative for non-X2Go directories. (Fixes: #676). + Remove macro call %systemd_pre for Fedora/EPEL-7 builds. No such macro in Fedora/RHEL7. (Fixes: 698). + Create system user x2gouser with $HOME in /var/lib/x2go. (Fixes: #697). + Always set BuildRoot: parameter. + BuildRequires: SUSE <= 11.3 has xorg-x11, not xinit. + Requires (x2goserver-xsession): SUSE <= 11.3 has xorg-x11, not xinit. + No Bashisms in scriptlets. + rpmlint requires shared-mime-info at build time on SLE <= 11.3. + "%set_permissions" / "%verify_permissions" macros are not know in SLE <= 11.3. Using "%run permissions" and "%verify permissions" instead. + On SUSE, add permissions.d/x2goserver. + Fix SQLite wrapper permissions (02775 -> 02755) + Use if then clauses for creating user/group x2goprint. . [ Matthew L. Dailey ] * New upstream version (4.0.1.19): - x2gocleansessions: Redirect stdin, stdout and stderr to /dev/null, test for the existence of the file descriptor before issuing the close, only capture the file descriptor backreference in the regex and send any close failures to syslog. (Fixes: #678). . [ Lars Wendler ] * New upstream version (4.0.1.19): - Use "printf" instead of "echo -n". (Fixes: #668). ------------=_1424811333-13756-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by bugs.x2go.org; 6 Nov 2014 14:18:19 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=ham version=3.3.2 X-Greylist: delayed 378 seconds by postgrey-1.34 at ymir.das-netzwerkteam.de; Thu, 06 Nov 2014 15:18:17 CET Received: from email.uni-linz.ac.at (email.edvz.uni-linz.ac.at [140.78.3.65]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 543B05DEA7 for ; Thu, 6 Nov 2014 15:18:17 +0100 (CET) Received: from mail.icie.jku.at (iciemail.mechatronik.uni-linz.ac.at [140.78.138.2]) by email.uni-linz.ac.at (Postfix) with ESMTP id 06EAD1E8CA5 for ; Thu, 6 Nov 2014 15:11:59 +0100 (CET) Received: from [10.78.1.87] (unknown [10.78.1.87]) by mail.icie.jku.at (Postfix) with ESMTPSA id C4437154BC7 for ; Thu, 6 Nov 2014 15:11:48 +0100 (CET) Message-ID: <545B81A3.2000406@nthfs.jku.at> Date: Thu, 06 Nov 2014 15:11:47 +0100 From: Thomas Wagner User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: submit@bugs.x2go.org Subject: Domain\User notation for fails due to missing quotation of "\" Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Package: x2goserver Version 4.0.1.18 Hi folks, I'm using x2goserver on an openSUSE 13.1 which is a member in an AD-Domain. Thus is have usernames like "DOMAIN\USER". Logging in with SSH works fine but starting x2go fails. For some users I get errors like MYDOMAIN\student is not authorized at /usr/lib/x2go/x2gosqlitewrapper.pl line 527. : /usr/lib/x2go/x2gosqlitewrapper insertsession 60 cd-sim MYDOMAINstudent-60-1415280062 at /usr/lib64/x2go/x2godbwrapper.pm line 320. For other users it works. I tracked the problem down to line 525 in x2gosqlitewrapper.pl. The line is: $user =~ s/$realuser-[0-9]{2,}-[0-9]{10,}.*/$realuser/; $realuser is a string like "MYDOMAIN\student". This is what makes the regex fail since \s is a special escape sequence in perl. Also usernames with other special escape sequences like \k fail. best regards Thomas -- Dipl.-Ing. Thomas Wagner Institute for Communications and Information Engineering Johannes Kepler University Linz, 4040 Linz, Austria mailto: t.wagner@nthfs.jku.at Phone: +43 732 2468 6404 http://www.nthfs.jku.at ------------=_1424811333-13756-0-- From unknown Fri Mar 29 07:43:48 2024 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@bugs.x2go.org From: Debbugs Internal Request Subject: Internal Control Message-Id: Bug archived. Date: Mi, 25 =?UTF-8?Q?M=C3=83=C2=A4r?= 2015 06:24:02 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A long time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # Bug archived. thanks # This fakemail brought to you by your local debbugs # administrator