X2Go Bug report logs - #642
Changes in X2GoClient for Windows to enable it conform to Visual Studio's stricter type checking

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: "George Trakatelis" <trakatelis@uom.edu.gr>

Date: Wed, 15 Oct 2014 14:50:01 UTC

Severity: wishlist

Tags: pending

Found in version 4.0.2.1

Fixed in version 4.0.3.2

Done: X2Go Release Manager <git-admin@x2go.org>

Bug is archived. No further changes may be made.

Full log


Message #97 received at 642@bugs.x2go.org (full text, mbox, reply):

Received: (at 642) by bugs.x2go.org; 4 Dec 2014 01:20:11 +0000
From trakatelis@uom.edu.gr  Thu Dec  4 02:20:09 2014
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,T_DKIM_INVALID,
	URIBL_BLOCKED autolearn=ham version=3.3.2
Received: from mail-wg0-f50.google.com (mail-wg0-f50.google.com [74.125.82.50])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 19D775DCAE
	for <642@bugs.x2go.org>; Thu,  4 Dec 2014 02:20:09 +0100 (CET)
Received: by mail-wg0-f50.google.com with SMTP id k14so21435717wgh.9
        for <642@bugs.x2go.org>; Wed, 03 Dec 2014 17:20:08 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=uom.edu.gr; s=google;
        h=from:to:cc:subject:date:message-id:mime-version:content-type
         :thread-index:content-language;
        bh=nuGwNZ3FAT1ETeiQgUwRSgNlJEGcG3wl5sT4KrGahOo=;
        b=TCXILJwe0oA8VCJicyADIz9xbeS3iPZ8AHkEF1gC4gV9OgG/LKQuK/r4AzatUBA+5a
         44+kc+/xW8FeAJiqIxsbIsDt/dMivngGuJBokgcgjt1O6X83fEqEXgm3BBdLAzC6GfDP
         KlBUGK/+Ppr8ARWok+4x1v6OBOI12cdwexzyM=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-type:thread-index:content-language;
        bh=nuGwNZ3FAT1ETeiQgUwRSgNlJEGcG3wl5sT4KrGahOo=;
        b=I6NXwDl7QhthzkmtJgCPYB0F0BKusOrunlPuonpBsEV7/3RSGJnnID08CBfhSUSAhD
         451bGYDqSJUr0GdcCoFgxB2mCn2dtX0RMrinZaWpGuOv+CBXNkvdLPIwoagZ/oFmABXW
         pWQ5Cf2HuE5DtSChVKaVcC8tlaOkQnogJXIwSMGW+kLLX3zL7m7BxoNu6XmgqDymNU5/
         ohm8pBQ0DNo2wDRuCBr3eBH6dAiqeT6fpv6WSqsLjOHnMR6Hk8W8eEVVNGi/Rj3bHsu9
         IBfiU/UcUzSce2hEkC2SCgy0MnvTw/vkWytBh+ttsyax95+0+xb7iF1zyMgBDunYtfgQ
         Z9EA==
X-Gm-Message-State: ALoCoQlofmrj1MeKkCFRfOIa/QjuEAPoplmky1dUdTaxafQ6RIaejtYgCVPfAyABSesNaPuuaXU1
X-Received: by 10.181.13.242 with SMTP id fb18mr21155425wid.1.1417656008684;
        Wed, 03 Dec 2014 17:20:08 -0800 (PST)
Received: from HomePC (46-198-96-210.adsl.cyta.gr. [46.198.96.210])
        by mx.google.com with ESMTPSA id p14sm10440884wie.1.2014.12.03.17.20.05
        for <multiple recipients>
        (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);
        Wed, 03 Dec 2014 17:20:07 -0800 (PST)
From: "George Trakatelis" <trakatelis@uom.edu.gr>
To: "'Michael DePaulo'" <mikedep333@gmail.com>
Cc: <642@bugs.x2go.org>
Subject: RE: Bug#642: Changes in X2Go Client for Windows to enable it conform to Visual Studio's stricter type checking
Date: Thu, 4 Dec 2014 03:20:02 +0200
Message-ID: <000501d00f60$6eb38440$4c1a8cc0$@edu.gr>
MIME-Version: 1.0
Content-Type: multipart/mixed;
	boundary="----=_NextPart_000_0006_01D00F71.323C5440"
X-Mailer: Microsoft Office Outlook 12.0
Thread-Index: AdAPYG3AraGa+3RsRX217WMku5N4NQ==
Content-Language: el
[Message part 1 (text/plain, inline)]
Hi Michael, 

I attached a triple-patch to help you build libssh-0.6.3 using VS2010's IDE.


> When I try to "generate" the VS2010 project files under CMake 3.0.2, I get
these 2 errors: 
> 
> You have called ADD_LIBRARY for library ssh_threads_shared without any
source files. 
> This typically indicates a problem with your CMakeLists.txt file 
> 
> CMake Error: CMake cannot determine linker language for target: 
> ssh_threads_shared 

To fix that I had to alter src/threads/CMakeLists.txt as explained in 
http://comments.gmane.org/gmane.network.ssh.libssh.general/1783

If you compiled now, you would get the following error: 
'error C1083: Cannot open include file: 'sys/time.h': No such file or
directory' 
So I also patched libcrypto.c 

That would be enough, if one planned to build libssh with VS2013 (builds
just fine). 

Unfortunately, VS2010 is missing the isblank() function, 
so to accommodate for that I had to patch ConfigureChecks.cmake. 
For more information on C99 library support in Visual Studio, please see 
http://blogs.msdn.com/b/vcblog/archive/2013/07/19/c99-library-support-in-vis
ual-studio-2013.aspx

> It doesn't matter anymore, but I was referring to this:
> http://www.libssh.org/files/win32/0.5/
> Which is linked to from here:
> http://www.libssh.org/get-it/

Apparently, the provided old .lib file lacks ssh_channel_accept_forward
support (it is unpatched). 

> It sounds like libssh 0.5 is too old. Let's not worry about it since we
have 0.6.3 working. 

I agree. 

Please note that I patched the libssh-0.6.3 source. 
To summarize things (correct me if I'm wrong): 

----------------------------------------------------------------------------
----------------------------------
| Patch applied                                              | libssh-0.6.3
|
----------------------------------------------------------------------------
----------------------------------
| implement-support-for-putty-s-pageant-0.6.3-de62963.patch  |
libssh-0.6.3-de62963-pageant-support          |
| libssh-0.6.3-pthread.c.relativepaths.patch                 |
libssh-0.6.3-762055b-pageant-support-mingw482 |
| libssh-0.6.3-vs2010.patch                                  |
libssh-0.6.3-you_name_it                      |
----------------------------------------------------------------------------
----------------------------------

I also attached a new release build with zlib support (please rename .doc to
.zip). 

George 
[libssh-0.6.3-vs2010.patch (application/octet-stream, attachment)]
[release-build-of-libssh-0.6.3-with-vs2010_zlib-support.doc (application/msword, attachment)]

Send a report that this bug log contains spam.


X2Go Developers <owner@bugs.x2go.org>. Last modified: Sat Nov 28 17:15:32 2020; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.