X2Go Bug report logs - #642
Changes in X2GoClient for Windows to enable it conform to Visual Studio's stricter type checking

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: "George Trakatelis" <trakatelis@uom.edu.gr>

Date: Wed, 15 Oct 2014 14:50:01 UTC

Severity: wishlist

Tags: pending

Found in version

Fixed in version

Done: X2Go Release Manager <git-admin@x2go.org>

Bug is archived. No further changes may be made.

Full log

🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#642: [X2Go-Dev] Bug#642: Bug#642: Changes in X2GoClient for Windows to enable it conform to Visual Studio's stricter type checking
Reply-To: "George Trakatelis" <trakatelis@uom.edu.gr>, 642@bugs.x2go.org
Resent-From: "George Trakatelis" <trakatelis@uom.edu.gr>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Thu, 30 Oct 2014 06:45:01 +0000
Resent-Message-ID: <handler.642.B642.141465146112381@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 642
X-X2Go-PR-Package: x2goclient
Received: via spool by 642-submit@bugs.x2go.org id=B642.141465146112381
          (code B ref 642); Thu, 30 Oct 2014 06:45:01 +0000
Received: (at 642) by bugs.x2go.org; 30 Oct 2014 06:44:21 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID,
	URIBL_BLOCKED autolearn=ham version=3.3.2
Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 22E345DB48
	for <642@bugs.x2go.org>; Thu, 30 Oct 2014 07:44:17 +0100 (CET)
Received: by mail-wi0-f178.google.com with SMTP id q5so6456159wiv.11
        for <642@bugs.x2go.org>; Wed, 29 Oct 2014 23:44:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=uom.edu.gr; s=google;
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
X-Gm-Message-State: ALoCoQnQb12OM9lj3IKbiZOyPphDnK7MSAzcLqCZVVIxTLOv0OoCwR/GPTUGDGM8lBfKuIg0BKfi
X-Received: by with SMTP id mp6mr18191965wjc.2.1414651456770;
        Wed, 29 Oct 2014 23:44:16 -0700 (PDT)
Received: from HomePC (46-198-96-210.adsl.cyta.gr. [])
        by mx.google.com with ESMTPSA id j20sm7601081wjn.0.2014.
        for <multiple recipients>
        (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);
        Wed, 29 Oct 2014 23:44:15 -0700 (PDT)
From: "George Trakatelis" <trakatelis@uom.edu.gr>
To: <642@bugs.x2go.org>
Cc: "'Mike Gabriel'" <mike.gabriel@das-netzwerkteam.de>,
	"'Mike DePaulo'" <mikedep333@gmail.com>
References: <20141015203358.Horde.KocdhaNWJNwyU7IDPf0Pug5@mail.das-netzwerkteam.de> <543F84ED.6030207@phoca-gmbh.de> <CAMKht8ggkVX2zF8wf5AFrNqGODAB+10EcX9VW0SN4K_XCaaSpg@mail.gmail.com> <20141016143029.Horde.DtEVLqASiFwRgVFw5c35nw1@mail.das-netzwerkteam.de> <000301cff26e$40b79090$c226b1b0$@edu.gr> <20141028075509.Horde.alDesymTpPfVMqGsvA6MeQ1@mail.das-netzwerkteam.de> <000301cff2d0$09ec8a90$1dc59fb0$@edu.gr> <20141028174910.Horde.If4Hris3URMROk_TY9keEA2@mail.das-netzwerkteam.de>
In-Reply-To: <20141028174910.Horde.If4Hris3URMROk_TY9keEA2@mail.das-netzwerkteam.de>
Date: Thu, 30 Oct 2014 08:44:14 +0200
Message-ID: <000601cff40c$ec4da490$c4e8edb0$@edu.gr>
MIME-Version: 1.0
Content-Type: multipart/mixed;
X-Mailer: Microsoft Office Outlook 12.0
Thread-Index: Ac/y13wKwrRDz+xVRiKDGaVNqQ61FABMsZGg
Content-Language: el
[Message part 1 (text/plain, inline)]
Hi Mikes,

I have just discovered an error in one of the previously provided patch files.
Windows sockets cleanup is handled in SshProcess::~SshProcess() (as it should be),
so I had to remove WSACleanup() from patched SshMasterConnection::finalize(int)
which caused a connection error if someone -after logging out- tried to login to the same server.

To avoid any ambiguity I re-attach the correct patch files.


PS. I wish a constructive gathering to all participants.

> -----Original Message-----
> From: Mike Gabriel [mailto:mike.gabriel@das-netzwerkteam.de]
> Sent: Tuesday, October 28, 2014 7:49 PM
> To: George Trakatelis
> Cc: 642@bugs.x2go.org; 'Mike DePaulo'
> Subject: Re: [X2Go-Dev] Bug#642: Bug#642: Changes in X2GoClient for
> Windows to enable it conform to Visual Studio's stricter type checking
> HI Mike#2
> On  Di 28 Okt 2014 17:55:52 CET, George Trakatelis wrote:
> > As this wishlist bug is actually resolved by applying the 3 patches,
> > my answer is 'Yes, you can close it, provided that at least one
> > volunteer confirms its validity'.
>    ^^^^^^^^^^^^^^^^^^^^^
> @Mike#2: I fear, this is on you...
> Mike#1
> --
> mike gabriel, herweg 7, 24357 fleckeby
> fon: +49 (1520) 1976 148
> GnuPG Key ID 0x25771B31
> mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
> freeBusy:
> https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-
> netzwerkteam.de.xfb
[conform-to-stricter-type-checking-mingw482.patch (application/octet-stream, attachment)]
[conform-to-stricter-type-checking-VS2010-close-socket.patch (application/octet-stream, attachment)]
[add-libraries-to-build-with-VS2010-command-line.patch (application/octet-stream, attachment)]

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Sat Nov 28 07:51:08 2020; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.