From unknown Mon Jun 15 14:30:55 2026 X-Loop: owner@bugs.x2go.org Subject: Bug#642: Changes in X2Go Client for Windows to enable it conform to Visual Studio's stricter type checking Reply-To: Michael DePaulo , 642@bugs.x2go.org Resent-From: Michael DePaulo Resent-To: x2go-dev@lists.x2go.org Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Wed, 03 Dec 2014 05:30:01 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: followup 642 X-X2Go-PR-Package: x2goclient X-X2Go-PR-Keywords: pending Received: via spool by 642-submit@bugs.x2go.org id=B642.141758446920305 (code B ref 642); Wed, 03 Dec 2014 05:30:01 +0000 Received: (at 642) by bugs.x2go.org; 3 Dec 2014 05:27:49 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 2691E5DCAE for <642@bugs.x2go.org>; Wed, 3 Dec 2014 06:27:46 +0100 (CET) Received: by mail-wi0-f178.google.com with SMTP id em10so3670215wid.17 for <642@bugs.x2go.org>; Tue, 02 Dec 2014 21:27:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=y7MfvtwnqlLTdeH1JnnGxua84Vf6PWX6w+BrUoVfDlU=; b=oIKNVJes0YoV0Z3JfYSGCzjoNC3G5JobegdJqQuRKPRiM43x3aVg/IXxuP4X/Q6dzF sAvn6o4brtiEAhO2cTMTJilWZuotjgAxAi0ykmyI48AVzF2d3QC4tc7P1Cy8pLa4RFBv QU/wb3kTGBo8kMd7JGLEc48tGRFUO7V3GotUa+Jau0/IOTr0YxNXi7JaYRB4pUhUbL+g 6bXO7EHP1+3ur+Q1AR4+DLdgH3o+DtFs4Y4p4Zbfgxs0SNOa2SAC4CilfYzOCxaPRCSz Yj4fl/82nN92yIqAaePbvfueIAEQbFjomxypQgpkhSxkBQQRVBZDiaw41nA5yF5lsl2W WXfQ== MIME-Version: 1.0 X-Received: by 10.194.6.199 with SMTP id d7mr4215337wja.124.1417584465781; Tue, 02 Dec 2014 21:27:45 -0800 (PST) Received: by 10.180.20.226 with HTTP; Tue, 2 Dec 2014 21:27:45 -0800 (PST) In-Reply-To: <000a01d00e8a$836403f0$8a2c0bd0$@edu.gr> References: <000a01d00e8a$836403f0$8a2c0bd0$@edu.gr> Date: Wed, 3 Dec 2014 00:27:45 -0500 Message-ID: From: Michael DePaulo To: George Trakatelis Cc: 642@bugs.x2go.org Content-Type: multipart/mixed; boundary=047d7b5d43a685c3790509491afd --047d7b5d43a685c3790509491afd Content-Type: text/plain; charset=UTF-8 Hi George, see below On Tue, Dec 2, 2014 at 6:48 PM, George Trakatelis wrote: > > Hi Michael, > > I built x2goclient 4.0.3.0 with MSVC2010's nmake. > Unfortunately couldn't do so with Visual Studio 2010 IDE. > > > I have made a lot of progress, but I am having trouble finding a build > > of libssh that includes the .lib file(s), and that is new enough. I > > think the .lib file(s) are specific to MSVC. > > I attach a release build of libssh 0.6.3 (please rename .doc to .zip). > The sources are from libssh-0.6.3-762055b-pageant-support-mingw482.src.zip > with a minor patch to enable libssh compile under MSVC2010. > Please share that patch. When I try to "generate" the VS2010 project files under CMake 3.0.2, I get these 2 errors: You have called ADD_LIBRARY for library ssh_threads_shared without any source files. This typically indicates a problem with your CMakeLists.txt file CMake Error: CMake can not determine linker language for target: ssh_threads_shared I've attached the log from CMake. > > The 0.5.0 win32 build that includes the .lib file appears to be too old > > I'm not aware of the build you are referring to. > It doesn't matter anymore, but I was referring to this: http://www.libssh.org/files/win32/0.5/ Which is linked to from here: http://www.libssh.org/get-it/ > > I get this error during compile: > > .\sshmasterconnection.cpp(297) : error C3861: > > 'ssh_channel_accept_forward': identifier not found > > That seems to be a missing function declaration from libssh.h. > Apparently, something like > ... > LIBSSH_API ssh_channel ssh_channel_accept_forward(ssh_session session, int > timeout_ms, int *destination_port); > ... > is missing. > It sounds like libssh 0.5 is too old. Let's not worry about it since we have 0.6.3 working. > > Please let me know if the attached ssh.lib (for compiling) and ssh.dll (for > runtime) are ok. > They work :) I had to copy over the .h files, but that took me minimal time. Please share the aforementioned patch though. > George I committed an update to the x2goclient changelog. This bug should be marked as fixed based on that commit. Also, I am keeping rough notes on how to compile X2Go Client under VS2010 here: https://docs.google.com/spreadsheets/d/1F5cVkCesXzTlo4oDJrGTdVFB074kkY-5q5-hgJUiXr4/edit?usp=sharing Think of that as the delta against the MinGW instructions: http://wiki.x2go.org/doku.php/wiki:development:build-howto-mswin:x2goclient -Mike --047d7b5d43a685c3790509491afd Content-Type: text/plain; charset=US-ASCII; name="libssh-0.6.3-762055b-pageant-support-mingw482.src - VS2010 - CMake 3.0.2 Generate log.txt" Content-Disposition: attachment; filename="libssh-0.6.3-762055b-pageant-support-mingw482.src - VS2010 - CMake 3.0.2 Generate log.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i388yccs1 Q291bGQgTk9UIGZpbmQgTlNJUyAobWlzc2luZzogIE5TSVNfTUFLRSkgDQpGb3VuZCBaTElCOiBD Oi9Vc2Vycy9taWtlLkRFUEFVTE8vRG93bmxvYWRzL3psaWIxMjgtZGxsL2luY2x1ZGUgIA0KRm91 bmQgT3BlblNTTDogb3B0aW1pemVkO0M6L09wZW5TU0wtV2luMzIvbGliL1ZDL3NzbGVheTMyTUQu bGliO2RlYnVnO0M6L09wZW5TU0wtV2luMzIvbGliL1ZDL3NzbGVheTMyTURkLmxpYjtvcHRpbWl6 ZWQ7QzovT3BlblNTTC1XaW4zMi9saWIvVkMvbGliZWF5MzJNRC5saWI7ZGVidWc7QzovT3BlblNT TC1XaW4zMi9saWIvVkMvbGliZWF5MzJNRGQubGliICANCkxvb2tpbmcgZm9yIGluY2x1ZGUgZmls ZSBwdGhyZWFkLmgNCkxvb2tpbmcgZm9yIGluY2x1ZGUgZmlsZSBwdGhyZWFkLmggLSBub3QgZm91 bmQNCkZvdW5kIFRocmVhZHM6IFRSVUUgIA0KQ291bGQgTk9UIGZpbmQgR1NTQVBJIChtaXNzaW5n OiAgR1NTQVBJX0xJQlJBUklFUyBHU1NBUElfSU5DTFVERV9ESVIpIA0KQ291bGQgTk9UIGZpbmQg TmFDbCAobWlzc2luZzogIE5BQ0xfTElCUkFSSUVTIE5BQ0xfSU5DTFVERV9ESVJTKSANCkxvb2tp bmcgZm9yIGFyZ3AuaA0KTG9va2luZyBmb3IgYXJncC5oIC0gbm90IGZvdW5kDQpMb29raW5nIGZv ciBwdHkuaA0KTG9va2luZyBmb3IgcHR5LmggLSBub3QgZm91bmQNCkxvb2tpbmcgZm9yIHRlcm1p b3MuaA0KTG9va2luZyBmb3IgdGVybWlvcy5oIC0gbm90IGZvdW5kDQpMb29raW5nIGZvciB1bmlz dGQuaA0KTG9va2luZyBmb3IgdW5pc3RkLmggLSBub3QgZm91bmQNCkxvb2tpbmcgZm9yIHV0aWwu aA0KTG9va2luZyBmb3IgdXRpbC5oIC0gbm90IGZvdW5kDQpMb29raW5nIGZvciAzIGluY2x1ZGUg ZmlsZXMgd2luc29jazIuaCwgLi4uLCB3c3BpYXBpLmgNCkxvb2tpbmcgZm9yIDMgaW5jbHVkZSBm aWxlcyB3aW5zb2NrMi5oLCAuLi4sIHdzcGlhcGkuaCAtIGZvdW5kDQpMb29raW5nIGZvciBpbmNs dWRlIGZpbGVzIHdpbnNvY2syLmgsIHdzMnRjcGlwLmgNCkxvb2tpbmcgZm9yIGluY2x1ZGUgZmls ZXMgd2luc29jazIuaCwgd3MydGNwaXAuaCAtIGZvdW5kDQpMb29raW5nIGZvciBvcGVuc3NsL2Fl cy5oDQpMb29raW5nIGZvciBvcGVuc3NsL2Flcy5oIC0gZm91bmQNCkxvb2tpbmcgZm9yIG9wZW5z c2wvYmxvd2Zpc2guaA0KTG9va2luZyBmb3Igb3BlbnNzbC9ibG93ZmlzaC5oIC0gZm91bmQNCkxv b2tpbmcgZm9yIG9wZW5zc2wvZGVzLmgNCkxvb2tpbmcgZm9yIG9wZW5zc2wvZGVzLmggLSBmb3Vu ZA0KTG9va2luZyBmb3Igb3BlbnNzbC9lY2RoLmgNCkxvb2tpbmcgZm9yIG9wZW5zc2wvZWNkaC5o IC0gZm91bmQNCkxvb2tpbmcgZm9yIG9wZW5zc2wvZWMuaA0KTG9va2luZyBmb3Igb3BlbnNzbC9l Yy5oIC0gZm91bmQNCkxvb2tpbmcgZm9yIG9wZW5zc2wvZWNkc2EuaA0KTG9va2luZyBmb3Igb3Bl bnNzbC9lY2RzYS5oIC0gZm91bmQNCkxvb2tpbmcgZm9yIGlzYmxhbmsNCkxvb2tpbmcgZm9yIGlz YmxhbmsgLSBub3QgZm91bmQNCkxvb2tpbmcgZm9yIHN0cm5jcHkNCkxvb2tpbmcgZm9yIHN0cm5j cHkgLSBmb3VuZA0KTG9va2luZyBmb3IgdnNucHJpbnRmDQpMb29raW5nIGZvciB2c25wcmludGYg LSBmb3VuZA0KTG9va2luZyBmb3Igc25wcmludGYNCkxvb2tpbmcgZm9yIHNucHJpbnRmIC0gbm90 IGZvdW5kDQpMb29raW5nIGZvciBwb2xsDQpMb29raW5nIGZvciBwb2xsIC0gbm90IGZvdW5kDQpM b29raW5nIGZvciBzZWxlY3QNCkxvb2tpbmcgZm9yIHNlbGVjdCAtIG5vdCBmb3VuZA0KTG9va2lu ZyBmb3IgZ2V0YWRkcmluZm8NCkxvb2tpbmcgZm9yIGdldGFkZHJpbmZvIC0gbm90IGZvdW5kDQpM b29raW5nIGZvciBudG9obGwNCkxvb2tpbmcgZm9yIG50b2hsbCAtIG5vdCBmb3VuZA0KTG9va2lu ZyBmb3IgaHRvbmxsDQpMb29raW5nIGZvciBodG9ubGwgLSBub3QgZm91bmQNCkxvb2tpbmcgZm9y IF9zdHJ0b3VpNjQNCkxvb2tpbmcgZm9yIF9zdHJ0b3VpNjQgLSBmb3VuZA0KTG9va2luZyBmb3Ig X3ZzbnByaW50Zl9zDQpMb29raW5nIGZvciBfdnNucHJpbnRmX3MgLSBmb3VuZA0KTG9va2luZyBm b3IgX3ZzbnByaW50Zg0KTG9va2luZyBmb3IgX3ZzbnByaW50ZiAtIGZvdW5kDQpMb29raW5nIGZv ciBfc25wcmludGYNCkxvb2tpbmcgZm9yIF9zbnByaW50ZiAtIGZvdW5kDQpMb29raW5nIGZvciBf c25wcmludGZfcw0KTG9va2luZyBmb3IgX3NucHJpbnRmX3MgLSBmb3VuZA0KUGVyZm9ybWluZyBU ZXN0IEhBVkVfR0NDX1RIUkVBRF9MT0NBTF9TVE9SQUdFDQpQZXJmb3JtaW5nIFRlc3QgSEFWRV9H Q0NfVEhSRUFEX0xPQ0FMX1NUT1JBR0UgLSBGYWlsZWQNClBlcmZvcm1pbmcgVGVzdCBIQVZFX01T Q19USFJFQURfTE9DQUxfU1RPUkFHRQ0KUGVyZm9ybWluZyBUZXN0IEhBVkVfTVNDX1RIUkVBRF9M T0NBTF9TVE9SQUdFIC0gU3VjY2Vzcw0KUGVyZm9ybWluZyBUZXN0IEhBVkVfR0NDX1ZPTEFUSUxF X01FTU9SWV9QUk9URUNUSU9ODQpQZXJmb3JtaW5nIFRlc3QgSEFWRV9HQ0NfVk9MQVRJTEVfTUVN T1JZX1BST1RFQ1RJT04gLSBGYWlsZWQNCkNvdWxkIE5PVCBmaW5kIERveHlnZW4gKG1pc3Npbmc6 ICBET1hZR0VOX0VYRUNVVEFCTEUpIA0KWW91IGhhdmUgY2FsbGVkIEFERF9MSUJSQVJZIGZvciBs aWJyYXJ5IHNzaF90aHJlYWRzX3NoYXJlZCB3aXRob3V0IGFueSBzb3VyY2UgZmlsZXMuIFRoaXMg dHlwaWNhbGx5IGluZGljYXRlcyBhIHByb2JsZW0gd2l0aCB5b3VyIENNYWtlTGlzdHMudHh0IGZp bGUNClRoZSBDWFggY29tcGlsZXIgaWRlbnRpZmljYXRpb24gaXMgTVNWQyAxNi4wLjQwMjE5LjEN CkNoZWNrIGZvciB3b3JraW5nIENYWCBjb21waWxlciB1c2luZzogVmlzdWFsIFN0dWRpbyAxMCAy MDEwDQpDaGVjayBmb3Igd29ya2luZyBDWFggY29tcGlsZXIgdXNpbmc6IFZpc3VhbCBTdHVkaW8g MTAgMjAxMCAtLSB3b3Jrcw0KRGV0ZWN0aW5nIENYWCBjb21waWxlciBBQkkgaW5mbw0KRGV0ZWN0 aW5nIENYWCBjb21waWxlciBBQkkgaW5mbyAtIGRvbmUNCioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqDQoqKioqKioqKioqIGxpYnNzaCBidWlsZCBvcHRpb25zIDog KioqKioqKioqKg0KemxpYiBzdXBwb3J0OiBPTg0KbGliZ2NyeXB0IHN1cHBvcnQ6IE9GRg0KbGli bmFjbCBzdXBwb3J0OiBPRkYNClNTSC0xIHN1cHBvcnQ6IE9GRg0KU0ZUUCBzdXBwb3J0OiBPTg0K U2VydmVyIHN1cHBvcnQgOiBPTg0KR1NTQVBJIHN1cHBvcnQgOiAwDQpQY2FwIGRlYnVnZ2luZyBz dXBwb3J0IDogT04NCldpdGggc3RhdGljIGxpYnJhcnk6IE9GRg0KVW5pdCB0ZXN0aW5nOiBPRkYN CkNsaWVudCBjb2RlIFVuaXQgdGVzdGluZzogT0ZGDQpQdWJsaWMgQVBJIGRvY3VtZW50YXRpb24g Z2VuZXJhdGlvbg0KQmVuY2htYXJrczogT0ZGDQoqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKg0KQ29uZmlndXJpbmcgZG9uZQ0KQ01ha2UgRXJyb3I6IENNYWtlIGNh biBub3QgZGV0ZXJtaW5lIGxpbmtlciBsYW5ndWFnZSBmb3IgdGFyZ2V0OiBzc2hfdGhyZWFkc19z aGFyZWQNCkdlbmVyYXRpbmcgZG9uZQ== --047d7b5d43a685c3790509491afd--