From trakatelis@uom.edu.gr Tue Oct 28 17:55:57 2014 Received: (at 642) by bugs.x2go.org; 28 Oct 2014 16:55:58 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID, URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 19C905DB41 for <642@bugs.x2go.org>; Tue, 28 Oct 2014 17:55:56 +0100 (CET) Received: by mail-wg0-f49.google.com with SMTP id x13so1384386wgg.32 for <642@bugs.x2go.org>; Tue, 28 Oct 2014 09:55:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uom.edu.gr; s=google; h=from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-type:thread-index:content-language; bh=IUPO+ib6Av5OVb5rGoK+x/xPH6xQhHmBzLhejAgAIjg=; b=TVvLq4xpYqPo9Lu0qQzhArNhNl02f6wCcSLB+KKvlL1RLvdLyPvnSKeyb03XRE/hlP rWV0ZHcoS0IuCJthBXFqvY9MBp7+Hvas2wnZ5QXtx3ma2HM+yyBRnTj5uZCEm/aIOMpj tx8stkofPWCrwqhwvilLvpBpeghl9xggbKyyE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:references:in-reply-to:subject:date :message-id:mime-version:content-type:thread-index:content-language; bh=IUPO+ib6Av5OVb5rGoK+x/xPH6xQhHmBzLhejAgAIjg=; b=B165H//99ySNVFqi3qEr/4W50mv23p+ORsjN4oYatYfhpAtccBt4n2zCeclxA3DRD9 ZNjx5ERgSra2GwzEiucNckM7es7hX7y7XBZ5UphGfoXzU5nW/ICiPL0L2fp9gdIDd9P4 bLgS2meyvcXIR3/24HopIu+sQ3fpux4lCB6zwp1mOU3n3I/uVS4L1B5Swclv9sw42Sxh tGclagnOa4vVezkS5QqxiNc/iF4bam+0EE0dLdyOq2lHHqzMovtWIx+nQ29CwtV2r9+/ 3Od9pERvsKA7PoTvzEyoIGlx85hprGeQLx+GfyCQeooWoOqwSbkOuWyJawqfKx3/5aT+ sgBg== X-Gm-Message-State: ALoCoQnvbxdHHdJBYCdTwUSGbbvYMqkB75vsA3YRWvChQ15/40E3/H3HHB59Lmr2E+/LknAGvxcV X-Received: by 10.194.223.67 with SMTP id qs3mr4718911wjc.127.1414515356609; Tue, 28 Oct 2014 09:55:56 -0700 (PDT) Received: from HomePC ([176.92.52.205]) by mx.google.com with ESMTPSA id f7sm2811360wiz.13.2014.10.28.09.55.55 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 28 Oct 2014 09:55:55 -0700 (PDT) From: "George Trakatelis" To: <642@bugs.x2go.org> Cc: "'Mike Gabriel'" , "'Mike DePaulo'" References: <20141015203358.Horde.KocdhaNWJNwyU7IDPf0Pug5@mail.das-netzwerkteam.de> <543F84ED.6030207@phoca-gmbh.de> <20141016143029.Horde.DtEVLqASiFwRgVFw5c35nw1@mail.das-netzwerkteam.de> <000301cff26e$40b79090$c226b1b0$@edu.gr> <20141028075509.Horde.alDesymTpPfVMqGsvA6MeQ1@mail.das-netzwerkteam.de> In-Reply-To: <20141028075509.Horde.alDesymTpPfVMqGsvA6MeQ1@mail.das-netzwerkteam.de> Subject: RE: [X2Go-Dev] Bug#642: Bug#642: Changes in X2GoClient for Windows to enable it conform to Visual Studio's stricter type checking Date: Tue, 28 Oct 2014 18:55:52 +0200 Message-ID: <000301cff2d0$09ec8a90$1dc59fb0$@edu.gr> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_NextPart_000_0004_01CFF2E0.CD755A90" X-Mailer: Microsoft Office Outlook 12.0 Thread-Index: Ac/yhH/BLG6aYhAPS0W2qLFumiw3UwAR+tBA Content-Language: el This is a multi-part message in MIME format. ------=_NextPart_000_0004_01CFF2E0.CD755A90 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Mike, My initial intention was to build X2GoClient for Windows using the = VS2010 IDE,=20 but that seems to be impossible for the time being due to a Qt4 Visual = Studio Add-in limitation.=20 The provided patches: 1. 'conform-to-stricter-type-checking-mingw482.patch',=20 2. 'conform-to-stricter-type-checking-VS2010.patch', and=20 3. the now attached = 'add-libraries-to-build-with-VS2010-command-line.patch'=20 (which supersedes previously attached = 'add-libraries-to-build-with-VS2010.patch')=20 make it possible to build X2GoClient for Windows 4.0.3.0 from the = command line=20 using Visual Studio's nmake (one has to install VS2010 and Qt 4.8.6 for = VS2010).=20 As this wishlist bug is actually resolved by applying the 3 patches, my = answer is=20 'Yes, you can close it, provided that at least one volunteer confirms = its validity'. George > -----Original Message----- > From: Mike Gabriel [mailto:mike.gabriel@das-netzwerkteam.de] > Sent: Tuesday, October 28, 2014 9:55 AM > To: George Trakatelis; 642@bugs.x2go.org > Subject: Re: [X2Go-Dev] Bug#642: Bug#642: Changes in X2GoClient for > Windows to enable it conform to Visual Studio's stricter type checking >=20 > Hi George, >=20 > On Di 28 Okt 2014 06:15:54 CET, George Trakatelis wrote: >=20 > > Hi Michael, > > > > Now that release 4.0.3.0 of x2goclient is out, I attach my proposed > > changes and comment on each one: > > > > 1. conform-to-stricter-type-checking-mingw482.patch > > > > Even mingw's debug build complains about this char * not having been > > declared as ought to be (const char *) and suggests using - > fpermissive > > (not recommended). > > > > 2. conform-to-stricter-type-checking-VS2010.patch > > > > a. A type-cast to match one of pow's declarations {float pow(float = x, > > int y);} b. In pure Windows there's no close() function to close a > > socket. > > So you have to use closesocket() instead. > > c. Include winsock2.h just before windows.h (also recommended by > mingw). > > > > 3. add-libraries-to-build-with-VS2010.patch > > > > a. A new batch file to configure x2goclient for VS2010 build > > (config_win_vs.bat). > > I have just substituted nmake for mingw32-make. > > Please remember to also use 'nmake' or 'nmake debug' when building. > > b. Added necessary win32 libraries. > > > > George >=20 > Thanks a lot for providing those patches. >=20 > Will applying all those patches provide enough reason/solution to = close > this bug (#642)? >=20 > Mike >=20 >=20 > -- >=20 > DAS-NETZWERKTEAM > mike gabriel, herweg 7, 24357 fleckeby > fon: +49 (1520) 1976 148 >=20 > GnuPG Key ID 0x25771B31 > mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de >=20 > freeBusy: > https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das- > netzwerkteam.de.xfb ------=_NextPart_000_0004_01CFF2E0.CD755A90 Content-Type: application/octet-stream; name="add-libraries-to-build-with-VS2010-command-line.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="add-libraries-to-build-with-VS2010-command-line.patch" diff --git a/config_win_vs.bat b/config_win_vs.bat=0A= new file mode 100644=0A= index 0000000..49bda97=0A= --- /dev/null=0A= +++ b/config_win_vs.bat=0A= @@ -0,0 +1,7 @@=0A= +nmake distclean=0A= +lrelease x2goclient.pro=0A= +set X2GO_CLIENT_TARGET=3D=0A= +qmake=0A= +cd x2gohelper=0A= +nmake clean=0A= +cd ..=0A= diff --git a/x2goclient.pro b/x2goclient.pro=0A= index e6eee01..740d0d3 100755=0A= --- a/x2goclient.pro=0A= +++ b/x2goclient.pro=0A= @@ -119,6 +119,7 @@ SOURCES +=3D sharewidget.cpp \=0A= folderexplorer.cpp=0A= =0A= LIBS +=3D -lssh=0A= +win32:LIBS +=3D -lAdvAPI32 -lshell32 -lUser32=0A= =0A= plugin {=0A= TARGET =3D x2goplugin=0A= @@ -133,7 +134,7 @@ else {=0A= =0A= !isEmpty(TRANSLATIONS) {=0A= isEmpty(QMAKE_LRELEASE) {=0A= - win32:QMAKE_LRELEASE =3D $$[QT_INSTALL_BINS]\lrelease.exe=0A= + win32:QMAKE_LRELEASE =3D $$[QT_INSTALL_BINS]\\lrelease.exe=0A= else:QMAKE_LRELEASE =3D $$[QT_INSTALL_BINS]/lrelease=0A= }=0A= =0A= ------=_NextPart_000_0004_01CFF2E0.CD755A90--