Subject: Bug#642: [X2Go-Dev] Bug#642: Bug#642: Changes in X2GoClient for Windows to enable it conform to Visual Studio's stricter type checking

From: "George Trakatelis" <[email-masked]>
Date: Tue, 28 Oct 2014 18:55:52 +0200

Hi Mike,

My initial intention was to build X2GoClient for Windows using the VS2010 IDE, 
but that seems to be impossible for the time being due to a Qt4 Visual Studio Add-in limitation. 
The provided patches:

1. 'conform-to-stricter-type-checking-mingw482.patch', 
2. 'conform-to-stricter-type-checking-VS2010.patch', and 
3. the now attached 'add-libraries-to-build-with-VS2010-command-line.patch' 
   (which supersedes previously attached 'add-libraries-to-build-with-VS2010.patch') 

make it possible to build X2GoClient for Windows 4.0.3.0 from the command line 
using Visual Studio's nmake (one has to install VS2010 and Qt 4.8.6 for VS2010). 
As this wishlist bug is actually resolved by applying the 3 patches, my answer is 
'Yes, you can close it, provided that at least one volunteer confirms its validity'.

George

> -----Original Message-----
> From: Mike Gabriel [mailto:[email-masked]]
> Sent: Tuesday, October 28, 2014 9:55 AM
> To: George Trakatelis; [email-masked]
> Subject: Re: [X2Go-Dev] Bug#642: Bug#642: Changes in X2GoClient for
> Windows to enable it conform to Visual Studio's stricter type checking
> 
> Hi George,
> 
> On  Di 28 Okt 2014 06:15:54 CET, George Trakatelis wrote:
> 
> > Hi Michael,
> >
> > Now that release 4.0.3.0 of x2goclient is out, I attach my proposed
> > changes and comment on each one:
> >
> > 1. conform-to-stricter-type-checking-mingw482.patch
> >
> > Even mingw's debug build complains about this char * not having been
> > declared as ought to be (const char *) and suggests using -
> fpermissive
> > (not recommended).
> >
> > 2. conform-to-stricter-type-checking-VS2010.patch
> >
> > a. A type-cast to match one of pow's declarations {float pow(float x,
> > int y);} b. In pure Windows there's no close() function to close a
> > socket.
> >    So you have to use closesocket() instead.
> > c. Include winsock2.h just before windows.h (also recommended by
> mingw).
> >
> > 3. add-libraries-to-build-with-VS2010.patch
> >
> > a. A new batch file to configure x2goclient for VS2010 build
> > (config_win_vs.bat).
> > I have just substituted nmake for mingw32-make.
> > Please remember to also use 'nmake' or 'nmake debug' when building.
> > b. Added necessary win32 libraries.
> >
> > George
> 
> Thanks a lot for providing those patches.
> 
> Will applying all those patches provide enough reason/solution to close
> this bug (#642)?
> 
> Mike
> 
> 
> --
> 
> DAS-NETZWERKTEAM
> mike gabriel, herweg 7, 24357 fleckeby
> fon: +49 (1520) 1976 148
> 
> GnuPG Key ID 0x25771B31
> mail: [email-masked], http://das-netzwerkteam.de
> 
> freeBusy:
> https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-
> netzwerkteam.de.xfb