From unknown Mon Jun 15 14:32:44 2026
MIME-Version: 1.0
X-Mailer: MIME-tools 5.502 (Entity 5.502)
X-Loop: owner@bugs.x2go.org
From: owner@bugs.x2go.org (X2Go Bug Tracking System)
Subject: Bug#642 closed by X2Go Release Manager <git-admin@x2go.org> (X2Go
 issue (in src:x2goclient) has been marked as closed)
Message-ID: <handler.642.c.142434711920071.notifdone@bugs.x2go.org>
References: <20150219115757.BC1A65DB4A@ymir.das-netzwerkteam.de>
X-X2go-PR-Keywords: pending
X-X2go-PR-Message: they-closed 642
X-X2go-PR-Package: x2goclient
X-X2go-PR-Source: x2goclient
Date: Thu, 19 Feb 2015 12:00:25 +0000
Content-Type: multipart/mixed; boundary="----------=_1424347225-20600-0"

This is a multi-part message in MIME format...

------------=_1424347225-20600-0
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=utf-8

This is an automatic notification regarding your Bug report
which was filed against the x2goclient package:

#642: Changes in X2GoClient for Windows to enable it conform to Visual Stud=
io's stricter type checking

It has been closed by X2Go Release Manager <git-admin@x2go.org>.

Their explanation is attached below along with your original report.
If this explanation is unsatisfactory and you have not received a
better one in a separate message then please contact X2Go Release Manager <=
git-admin@x2go.org> by
replying to this email.


--=20
X2Go Bug Tracking System
Contact owner@bugs.x2go.org with problems

------------=_1424347225-20600-0
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

Received: (at control) by bugs.x2go.org; 19 Feb 2015 11:58:39 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_RELAYS,
	URIBL_BLOCKED autolearn=unavailable version=3.3.2
Received: by ymir.das-netzwerkteam.de (Postfix, from userid 1005)
	id BC1A65DB4A; Thu, 19 Feb 2015 12:57:57 +0100 (CET)
From: X2Go Release Manager <git-admin@x2go.org>
To: 642-submitter@bugs.x2go.org
Cc: control@bugs.x2go.org, 642@bugs.x2go.org
Subject: X2Go issue (in src:x2goclient) has been marked as closed
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
Message-Id: <20150219115757.BC1A65DB4A@ymir.das-netzwerkteam.de>
Date: Thu, 19 Feb 2015 12:57:57 +0100 (CET)

close #642
thanks

Hello,

we are very hopeful that X2Go issue #642 reported by you
has been resolved in the new release (4.0.3.2) of the
X2Go source project »src:x2goclient«.

You can view the complete changelog entry of src:x2goclient (4.0.3.2)
below, and you can use the following link to view all the code changes
between this and the last release of src:x2goclient.

    http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=3b7ca68412005521d45d9751a370549ab1c80e58;hp=5290218751cc68a1fc1711ebd169e195eb3daeed

If you feel that the issue has not been resolved satisfyingly, feel
free to reopen this bug report or submit a follow-up report with
further observations described based on the new released version
of src:x2goclient.

Thanks a lot for contributing to X2Go!!!

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
X2Go Component: src:x2goclient
Version: 4.0.3.2-0x2go1
Status: RELEASE
Date: Thu, 19 Feb 2015 12:49:22 +0100
Fixes: 616 642 681 702 705 713 720 742 781 782
Changes: 
 x2goclient (4.0.3.2-0x2go1) RELEASED; urgency=medium
 .
   [ Oleksandr Shneyder ]
   * New upstream release (4.0.3.2):
     - Fix placement of session folders in session card column. (Fixes: #681).
     - Send empty message in x2gohelper to stop AppStarting cursor. (Fixes: #616).
     - Fix multiple creations of modmap timer (OS_DARWIN).
 .
   [ Mike Gabriel ]
   * New upstream release (4.0.3.2):
     - Add several info/error/debug log message while hunting down #702.
     - Use app.setQuitOnLastWindowClosed(false) for the X2Go Client QtApplication
       to assure that X2Go Client does not arbitrarily exit during a running
       session. This fixes X2Go Client crashes that occur when printing via
       the CUPS-X2Go printing mechanism with activate print dialog popup on
       incoming print jobs and minimized main window. (Fixes: #702).
     - Be more exact when reporting rev forwarding tunnel request failures to
       the GUI user. Include the purpose of the tunnel (NX, audio, foldersharing)
       in the error message.
     - Enable debugging in sshprocess.cpp and sshmasterconnection.cpp if
       --debug is given.
     - sshmasterconnection.cpp: Fix several grammar issues in error messages.
     - When sharing a client-side folder, do not write the SSH pub key to
       client-side authorized_keys file if the folder-to-be-shared does not
       exist on the client. (Partially solves #405).
     - Fix string concatenation/layout of error message when tunnel I/O errors
       occur.
     - Improve debugging/logging the SSH connections made by X2Go Client.
     - Fix quotes when calling remote commands via SSH (esp. allow same quoting/
       escaping style for libssh and openSSH+Krb based connections). (Fixes: #720).
     - FIXME: Disable PubkeyAuthentication _and_ PasswordAuthentication if
       GSSAPI authentication is activated. This is counter intuitive, though,
       and requires several other fixes in the authentication code.
   * x2goclient.spec:
     - Always set BuildRoot: parameter.
 .
   [ Sergey Savko ]
   * New upstream release (4.0.3.2):
     - Prevent passwordless re-logins into X2Go Session Broker if
       --broker-autologoff is used on the cmdline. (Fixes: #782).
     - Add new cmdline option --broker-noauth-use-session-username.
       When --broker-noauth is used, the broker does not know on behalf
       of which user to operate. This new option enables username syncing.
       When logging into X2Go Server, that username will be sent to the
       broker and be used for querying X2Go Broker Agents etc. (Fixes: #781).
 .
   [ Heinrich Schuchardt ]
   * New upstream release (4.0.3.2):
     - Base the layout dialogue "Session ID" (which shows up when starting a
       connection) on typographic points (instead of pixels). (Fixes: #713).
 .
   [ Jason Alavaliant ]
   * New upstream verson (4.0.3.2):
     - Use QUrl::toPercentEncoding() method to properly encode passwords sent
       to X2Go Session Broker. (Fixes: #705).
 .
   [ Mike DePaulo ]
   * New upstream release (4.0.3.2):
     - Windows: Win32 OpenSSL updates from 1.0.1j to 1.0.1L, which
       fixes the CVEs announced on 2015-01-08.
     - Windows: Cygwin OpenSSL updated from 1.0.1j-1 to 1.0.1k-1, which
       fixes the CVEs announced on 2015-01-08.
     - Windows: Bundle new version of VcXsrv: 1.15.2.2-xp+vc2013+x2go1.
       The differences from 1.15.2.1-xp+vc2013+x2go1 are that its bundled
       OpenSSL has been updated to 1.0.1k, and that xorg-server
       CVE-2014-8091..8103 have been fixed.
     - Windows: Update libssh from 0.6.3 to 0.6.4 (while maintaining
       Pageant support). This fixes CVE-2014-8132, which shouldn't
       affect x2goclient because x2goclient uses the SSH client
       functionality, not the SSH server functionality.
       0.6.4 also added 4 features related to ECDSA keys.
     - Windows: Fix compatibility with PulseAudio 6.0
     - Windows: Remove workaround for audio input with old versions of
       PulseAudio (calling parec once per second)
       (Fixes: #742)
       Thanks George Trakatelis (uom.edu.gr) for submitting this change.
     - Windows: Enable X2Go Client for Windows to build under VS2010 nmake
       (but not the VS2010 IDE due to a Qt4 Visual Studio Add-in limitation)
       Note that the official builds are still build under MinGW.
       (Fixes: #642)
       Thanks George Trakatelis (uom.edu.gr) for submitting this feature.
     - Windows: Make builds easier, and updating bundled dependencies
       easier, by adding copy-deps-win32.bat. It copies the exact
       version of each dependency (DLL, executable, data, folder, etc)
       from x2goclient-contrib.git.
 .
   [ Kaan Ozdincer ]
   * New upstream version (4.0.3.2):
     - Add Turkish translation file.


------------=_1424347225-20600-0
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

Received: (at submit) by bugs.x2go.org; 15 Oct 2014 14:45:59 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: **
X-Spam-Status: No, score=2.3 required=5.0 tests=BAYES_50,T_DKIM_INVALID,
	URIBL_BLOCKED,URIBL_RHS_DOB autolearn=no version=3.3.2
Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 5FD7F3D5FB
	for <submit@bugs.x2go.org>; Wed, 15 Oct 2014 16:45:59 +0200 (CEST)
Received: by mail-wi0-f180.google.com with SMTP id em10so2126182wid.13
        for <submit@bugs.x2go.org>; Wed, 15 Oct 2014 07:45:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=uom.edu.gr; s=google;
        h=from:to:cc:subject:date:message-id:mime-version:content-type
         :thread-index:content-language;
        bh=VG27IqTc1pisT30lvvAZJJ3Vhs0PEnhRwdGV9ZrCLbY=;
        b=eNhfs4UnOy7C8JCf+Nx8rqnflENIRYZpveIrHHEkLQ9bFFfkKaozq5nXn+m4lutpOq
         tqPV21GkB2wv90p3KEVrhhzbMvHgV452lDHUj6ubZk9lpXb40xGeyp6Hk8jqwd7ZV5Db
         oOVZr+TFolJ8ddOZFD2ttjS1X0EiMrsVfAY2g=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-type:thread-index:content-language;
        bh=VG27IqTc1pisT30lvvAZJJ3Vhs0PEnhRwdGV9ZrCLbY=;
        b=NGbm9lwDFdyyxrmZW7DRAqW3+az0J7rtC7YgtQaSBS3e0gYWV4Bu+SbZRyiANYxuts
         iZCm1IgzXeXKpM2e4qiKyjDY5gkr4nXz6iVHjL9ipXCX04GCWCtVl+Q26w8E/cQEW6Bd
         vexT1XkoT3fwO1ildbuRC49NxWF3jhJzY9DbsQiuafYfwxp/2/JQxYWpknrahLc9viB3
         sHxokAW27ylnuwnLCoBiodAlzcPOrjRwe4O0OqJ70OP1DMsmzkKRUoMgzQwJr1SBRkVr
         R1OvyN0MvWNz4fGOY1/yBKk7kyC3z9ADuGOSzsOjzRFaxtx9rDDizNfIm+5aoVp3GjuF
         no/A==
X-Gm-Message-State: ALoCoQmxs8oM58GfQz8Hrt+7edtZH8KYFJJaco0OleLLW4X5pAbLvdxfkMaH7h5YhodF7akEY5I8
X-Received: by 10.181.29.10 with SMTP id js10mr12523244wid.71.1413384358856;
        Wed, 15 Oct 2014 07:45:58 -0700 (PDT)
Received: from HomePC (46-4-59.adsl.cyta.gr. [46.103.4.59])
        by mx.google.com with ESMTPSA id ji10sm19648980wid.7.2014.10.15.07.45.57
        for <multiple recipients>
        (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);
        Wed, 15 Oct 2014 07:45:58 -0700 (PDT)
From: "George Trakatelis" <trakatelis@uom.edu.gr>
To: <submit@bugs.x2go.org>
Cc: "'Mike DePaulo'" <mikedep333@gmail.com>
Subject: Changes in X2GoClient for Windows to enable it conform to Visual Studio's stricter type checking
Date: Wed, 15 Oct 2014 17:45:54 +0300
Message-ID: <000001cfe886$ba6f6d00$2f4e4700$@edu.gr>
MIME-Version: 1.0
Content-Type: multipart/mixed;
	boundary="----=_NextPart_000_0001_01CFE89F.DFBCA500"
X-Mailer: Microsoft Office Outlook 12.0
Thread-Index: Ac/ohrisvKSXF3TdSz+Rt+6ybkFPAQ==
Content-Language: el

This is a multi-part message in MIME format.

------=_NextPart_000_0001_01CFE89F.DFBCA500
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit

Package: x2goclient
Version: 4.0.2.1
Severity: wishlist

Given the ease of use of Visual Studio's built-in debugger, 
the ability to compile X2GoClient in Visual Studio 2010 
would be highly appreciated by developers eager to contribute 
in the evolution of X2GoClient for Windows.

Using the attached patch (also added config_win_vs.bat) 
I have only managed to compile x2gofree (with VS2010 nmake) 
on the command line. Despite my changes in x2goclient.pro,
Qt4 Visual Studio Add-in cannot produce a working project file
(x2goclient.vcxproj). 
Any help to enable building x2gofree in Visual Studio 2010 is welcome.

PS. The change in ONMainWindow::slotRetResumeSess 
is also mandatory for GCC 4.8.2 (i686-4.8.2-release-posix-dwarf-rt_v3-rev3).

-----------------------------------------------------------------
George Trakatelis 
Department of Applied Informatics, School of Information Sciences 
University of Macedonia, Greece
-----------------------------------------------------------------

------=_NextPart_000_0001_01CFE89F.DFBCA500
Content-Type: application/octet-stream;
	name="conform-to-stricter-type-checking.diff"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
	filename="conform-to-stricter-type-checking.diff"

diff --git a/onmainwindow.cpp b/onmainwindow.cpp=0A=
index 7fe7501..f31ee80 100644=0A=
--- a/onmainwindow.cpp=0A=
+++ b/onmainwindow.cpp=0A=
@@ -5087,7 +5087,7 @@ void ONMainWindow::slotRetResumeSess ( bool result,=0A=
 #endif //Q_OS_WIN=0A=
         if ( sshSndTunnel )=0A=
         {=0A=
-            char* okSlot=3D0;=0A=
+            const char* okSlot=3D0;=0A=
 #ifdef Q_OS_WIN=0A=
             if ( sndSystem=3D=3DPULSE )=0A=
             {=0A=
diff --git a/sshmasterconnection.cpp b/sshmasterconnection.cpp=0A=
index c3f78d7..26d37dd 100755=0A=
--- a/sshmasterconnection.cpp=0A=
+++ b/sshmasterconnection.cpp=0A=
@@ -104,10 +104,10 @@ void SshMasterConnection::parseKnownHosts()=0A=
         for (int i=3D0; i<bytes.count();)=0A=
         {=0A=
             int size=3D0;=0A=
-            //first 4 bytes are for size of data fild (big-endian)=0A=
+            //first 4 bytes are for size of data field (big-endian)=0A=
             for (int j=3D0; j<4; ++j)=0A=
             {=0A=
-                size+=3D((uchar)(bytes[i])) * pow(256,3-j);=0A=
+                size+=3D((uchar)(bytes[i])) * pow((long double)256,3-j);=0A=
                 i++;=0A=
             }=0A=
             QByteArray data;=0A=
@@ -1674,8 +1674,11 @@ void SshMasterConnection::finalize ( int item )=0A=
     {=0A=
 #ifndef Q_OS_WIN=0A=
         shutdown(tcpSocket, SHUT_RDWR);=0A=
-#endif=0A=
         close ( tcpSocket );=0A=
+#else=0A=
+        shutdown(tcpSocket, SD_BOTH);=0A=
+        closesocket ( tcpSocket );=0A=
+#endif=0A=
     }=0A=
     SshProcess* proc=3DchannelConnections[item].creator;=0A=
     QString uuid=3DchannelConnections[item].uuid;=0A=
diff --git a/wapi.cpp b/wapi.cpp=0A=
index f167669..f0972d7 100644=0A=
--- a/wapi.cpp=0A=
+++ b/wapi.cpp=0A=
@@ -22,6 +22,7 @@=0A=
 #endif=0A=
 #include "x2goclientconfig.h"=0A=
 #ifdef Q_OS_WIN=0A=
+#include <winsock2.h>=0A=
 #include <windows.h>=0A=
 #include <sddl.h>=0A=
 #include "wapi.h"=0A=
diff --git a/x2goclient.pro b/x2goclient.pro=0A=
index 7bae04c..f41cc09 100755=0A=
--- a/x2goclient.pro=0A=
+++ b/x2goclient.pro=0A=
@@ -118,6 +118,11 @@ SOURCES +=3D sharewidget.cpp \=0A=
            folderbutton.cpp \=0A=
            folderexplorer.cpp=0A=
 =0A=
+#CAUTION: Substitute C:/Program Files/Microsoft SDK/Windows/v7.0A/Lib=0A=
+#with the folder that AdvAPI32.Lib, shell32.lib, and User32.Lib =
actually reside in=0A=
+message(Please make sure AdvAPI32.Lib, shell32.lib, and User32.Lib are =
accessible)=0A=
+win32:LIBS +=3D -L"C:/Program Files/Microsoft SDK/Windows/v7.0A/Lib" =
-ladvapi32 -lshell32 -luser32=0A=
+=0A=
 LIBS +=3D -lssh=0A=
 =0A=
 plugin {=0A=
@@ -133,7 +138,7 @@ else {=0A=
 =0A=
 !isEmpty(TRANSLATIONS) {=0A=
   isEmpty(QMAKE_LRELEASE) {=0A=
-    win32:QMAKE_LRELEASE =3D $$[QT_INSTALL_BINS]\lrelease.exe=0A=
+    win32:QMAKE_LRELEASE =3D $$[QT_INSTALL_BINS]/lrelease.exe=0A=
     else:QMAKE_LRELEASE =3D $$[QT_INSTALL_BINS]/lrelease=0A=
   }=0A=
 =0A=

------=_NextPart_000_0001_01CFE89F.DFBCA500
Content-Type: text/plain;
	name="config_win_vs.bat.txt"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
	filename="config_win_vs.bat.txt"

nmake distclean=0A=
lrelease x2goclient.pro=0A=
set X2GO_CLIENT_TARGET=3D=0A=
qmake=0A=
cd x2gohelper=0A=
nmake clean=0A=
cd ..=0A=

------=_NextPart_000_0001_01CFE89F.DFBCA500--

------------=_1424347225-20600-0--
