From msongd@gmail.com Tue Sep 16 09:57:44 2014 Received: (at submit) by bugs.x2go.org; 16 Sep 2014 07:57:45 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=ham version=3.3.2 Received: from mail-qg0-f67.google.com (mail-qg0-f67.google.com [209.85.192.67]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id DB3365DB54 for ; Tue, 16 Sep 2014 09:57:43 +0200 (CEST) Received: by mail-qg0-f67.google.com with SMTP id a108so1720272qge.10 for ; Tue, 16 Sep 2014 00:57:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=R8HMQtsUjk/7PtXeInX5VJJHjS0tCKI4DuPBhu30Ng8=; b=NEE8kc713AiHmDrr90HUozKorDjHKKYrlfZutvPv3AruiOY4oDwobsviTb4GgadD6A ZfdE4k7tIzSA+p2rxqmPXP2Fnhu6FENEYUrB8vYq+sVBBPgoyglXXQG2SMm2q62rTFYJ bnwkIe5NMkSRUiEqFEXsjhOfS1JpNYIXaJlHrjqfZxju996GL6u5+BgI09pZE1aX9RcY nlvb0iWY6kooMt1dVL0u5TTvfqm/uIk+ud2NQ0Es/Cuw14NXoPAiZJ01thoIMgg1c/9i TYHe/7I0q+WPmJYcSw51RldzETuFV8dyJ00BfwtL3Nzrhy8CxU2zEOXAGahwehq5V208 A4tw== MIME-Version: 1.0 X-Received: by 10.140.16.194 with SMTP id 60mr12508263qgb.105.1410854262446; Tue, 16 Sep 2014 00:57:42 -0700 (PDT) Received: by 10.140.85.177 with HTTP; Tue, 16 Sep 2014 00:57:42 -0700 (PDT) Date: Tue, 16 Sep 2014 14:57:42 +0700 Message-ID: Subject: x2goclient does not honor export from broker From: MIng Song To: submit@bugs.x2go.org Content-Type: multipart/mixed; boundary=001a11c0a65424cc3005032a1b93 --001a11c0a65424cc3005032a1b93 Content-Type: multipart/alternative; boundary=001a11c0a65424cc2c05032a1b91 --001a11c0a65424cc2c05032a1b91 Content-Type: text/plain; charset=UTF-8 Package: x2goclient Version: 4.0.2.1 Severity: major Hi, it seems x2goclient does not load export (local folder sharing) from broker. Direct connect with local session profile is ok. My x2gobroker_sessionprofiles.conf contains export directory and disable printing, however, when using x2goclient with broker, it still forwards spooling directory & does not mount exported directory. If i create a session profile in client workstation, and use x2goclient directly, printing can be disabled and local directory can be forwarded. Look at the source code, file onmainwindow.cpp, method exportDefaultDirs load X2goSettings directly without consult config.iniFile. I have attached here a patch that modifies exportDefaultDirs() to use config.iniFile incase x2goclient using broker mode. The patch works with x2goclient linux. I am not familiar with compiling x2goclient in Windows env, therefore I am unable to test with x2goclient in Windows. Any comments? Thank you very much for such a wonderful project. Regards, msongd. --001a11c0a65424cc2c05032a1b91 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Package: x2goclient
Version: 4.0.2.1
<= div>Severity: major

Hi,

i= t seems x2goclient does not load export (local folder sharing) from broker.= Direct connect with local session profile is ok.

= My x2gobroker_sessionprofiles.conf contains export directory and disable pr= inting, however, when using x2goclient with broker, it still forwards spool= ing directory & does not mount exported directory.

=
If i create a session profile in client workstation, and use x2goclien= t directly, printing can be disabled and local directory can be forwarded.<= /div>

Look at the source code, file onmainwindow.cpp, me= thod exportDefaultDirs load X2goSettings directly without consult config.in= iFile.

I have attached here a patch that modifies = exportDefaultDirs() to use config.iniFile incase x2goclient using broker mo= de. The patch works with x2goclient linux.

I am no= t familiar with compiling x2goclient in Windows env, therefore I am unable = to test with x2goclient in Windows.

Any comments?<= /div>

Thank you very much for such a wonderful project.<= /div>

Regards,
msongd.

--001a11c0a65424cc2c05032a1b91-- --001a11c0a65424cc3005032a1b93 Content-Type: text/x-patch; charset=US-ASCII; name="aware_broker_export_dir.patch" Content-Disposition: attachment; filename="aware_broker_export_dir.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i04y5k8w0 LS0tIHgyZ29jbGllbnQtNC4wLjIuMS9vbm1haW53aW5kb3cuY3BwCTIwMTQtMDctMTEgMTg6MjI6 NDIuMDAwMDAwMDAwICswNzAwCisrKyB4MmdvY2xpZW50LTQuMC4yLjEtbmV3L29ubWFpbndpbmRv dy5jcHAJMjAxNC0wOS0xNiAxMzo1NDozMi4zOTU1NDQ2MjggKzA3MDAKQEAgLTc2NTUsMTggKzc2 NTUsMjQgQEAKIHsKICAgICBRU3RyaW5nTGlzdCBkaXJzOwogICAgIGJvb2wgY2xpZW50UHJpbnRp bmc9ICggdXNlTGRhcCAmJiBMREFQUHJpbnRTdXBwb3J0ICk7CisgICAgWDJnb1NldHRpbmdzKiBz dDsKIAogICAgIGlmICggIXVzZUxkYXAgKQogICAgIHsKICAgICAgICAgaWYgKCAhZW1iZWRNb2Rl ICkKICAgICAgICAgewogCi0gICAgICAgICAgICBYMmdvU2V0dGluZ3Mgc3QgKCAic2Vzc2lvbnMi ICk7Ci0gICAgICAgICAgICBjbGllbnRQcmludGluZz0gc3Quc2V0dGluZygpLT52YWx1ZSAoCisg ICAgICAgICAgIGlmICghYnJva2VyTW9kZSkKKyAgICAgICAgICAgICAgIHN0PSBuZXcgWDJnb1Nl dHRpbmdzKCAic2Vzc2lvbnMiICk7CisgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgIHN0 PSBuZXcgWDJnb1NldHRpbmdzKGNvbmZpZy5pbmlGaWxlLFFTZXR0aW5nczo6SW5pRm9ybWF0KTsK KworICAgICAgICAgICAgLy9YMmdvU2V0dGluZ3Mgc3QgKCAic2Vzc2lvbnMiICk7CisgICAgICAg ICAgICBjbGllbnRQcmludGluZz0gc3QtPnNldHRpbmcoKS0+dmFsdWUgKAogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBsYXN0U2Vzc2lvbi0+aWQoKSArCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICIvcHJpbnQiLCB0cnVlICkudG9Cb29sKCk7CiAKLSAgICAgICAgICAg IFFTdHJpbmcgZXhkPXN0LnNldHRpbmcoKS0+dmFsdWUgKAorICAgICAgICAgICAgUVN0cmluZyBl eGQ9c3QtPnNldHRpbmcoKS0+dmFsdWUgKAogICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxh c3RTZXNzaW9uLT5pZCgpICsiL2V4cG9ydCIsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg KCBRVmFyaWFudCApIFFTdHJpbmc6Om51bGwgKS50b1N0cmluZygpOwogICAgICAgICAgICAgUVN0 cmluZ0xpc3QgbHN0PWV4ZC5zcGxpdCAoICI7IiwKQEAgLTc3NTIsNiArNzc1OCw3IEBACiAgICAg ICAgICAgICAgICAgICBTTE9UICggc2xvdENoZWNrUHJpbnRTcG9vbCgpICkgKTsKICAgICAgICAg c3Bvb2xUaW1lci0+c3RhcnQgKCAyMDAwICk7CiAgICAgfQorICAgIGRlbGV0ZSBzdDsKICAgICBp ZiAoIGRpcnMuc2l6ZSgpIDw9MCApCiAgICAgICAgIHJldHVybjsKICAgICBleHBvcnREaXJzICgg ZGlycy5qb2luICggIjoiICkgKTsK --001a11c0a65424cc3005032a1b93--