X2Go Bug report logs - #611
X2Go Client for Windows cannot create C:\Users\<username>\ssh\known_hosts file when the username has characters from languages other than the system locale

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: <trakatelis@uom.gr>

Date: Mon, 11 Aug 2014 10:55:01 UTC

Severity: normal

Found in version 4.0.2.1

Full log

🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#566: [X2Go-Dev] Bug#566: X2Go Client for Windows 4.0.2.1 cannon create C:\Users\<username>\ssh\known_hosts file when the local Windows account username has non-English characters
Reply-To: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>, 566@bugs.x2go.org
Resent-From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Mon, 01 Sep 2014 19:55:02 +0000
Resent-Message-ID: <handler.566.B566.1409601068766@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 566
X-X2Go-PR-Package: x2goclient
X-X2Go-PR-Keywords: 
Received: via spool by 566-submit@bugs.x2go.org id=B566.1409601068766
          (code B ref 566); Mon, 01 Sep 2014 19:55:02 +0000
Received: (at 566) by bugs.x2go.org; 1 Sep 2014 19:51:08 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham
	version=3.3.2
Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 3B0CF5DCA4
	for <566@bugs.x2go.org>; Mon,  1 Sep 2014 21:51:07 +0200 (CEST)
Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98])
	by freya.das-netzwerkteam.de (Postfix) with ESMTPS id 672B6B70;
	Mon,  1 Sep 2014 21:51:06 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id BFD333C4E5;
	Mon,  1 Sep 2014 21:51:05 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de
Received: from grimnir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id RoP6lqUMhAVu; Mon,  1 Sep 2014 21:51:05 +0200 (CEST)
Received: from grimnir.das-netzwerkteam.de (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id 40F283C4E3;
	Mon,  1 Sep 2014 21:51:04 +0200 (CEST)
Received: from p5B2852C0.dip0.t-ipconnect.de (p5B2852C0.dip0.t-ipconnect.de
 [91.40.82.192]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP;
 Mon, 01 Sep 2014 19:51:03 +0000
Date: Mon, 01 Sep 2014 19:51:03 +0000
Message-ID: <20140901195103.Horde.HOAd34FDzvE7MwwNBCtaAg1@mail.das-netzwerkteam.de>
From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
To: trakatelis@uom.gr, 566@bugs.x2go.org, George Trakatelis
 <trakatelis@uom.edu.gr>
References: <000001cfb552$3193a8a0$94baf9e0$@gr>
 <handler.566.B.140775428816658.ack@bugs.x2go.org>
 <000001cfc60a$32831de0$978959a0$@gr>
In-Reply-To: <000001cfc60a$32831de0$978959a0$@gr>
User-Agent: Internet Messaging Program (IMP) H5 (6.2.0)
Accept-Language: en,de
Organization: DAS-NETZWERKTEAM
X-Originating-IP: 91.40.82.192
X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101
 Firefox/31.0 Iceweasel/31.0
Content-Type: multipart/signed; boundary="=_8bHyu9XQour_PWURghjQGw1";
 protocol="application/pgp-signature"; micalg=pgp-sha1
MIME-Version: 1.0

[Message part 1 (text/plain, inline)]
Hi Mike#2,

On  Mo 01 Sep 2014 19:28:50 CEST, George Trakatelis wrote:

> A suggested patch is to substitute the Qt4 toAscii() function with  
> toLocal8Bit()
> in two specific places of SshMasterConnection::run().
> A git diff is as follows:
>
> $ diff /c/a/sshmasterconnection.cpp /c/b/sshmasterconnection.cpp
> 521c521
> <     ssh_options_set ( my_ssh_session, SSH_OPTIONS_SSH_DIR,  
> (mainWnd->getHomeDirectory()+"/ssh").toAscii());
> ---
>>     ssh_options_set ( my_ssh_session, SSH_OPTIONS_SSH_DIR,  
>> (mainWnd->getHomeDirectory()+"/ssh").toLocal8Bit());
> 630c630
> <     ssh_options_set ( my_ssh_session, SSH_OPTIONS_SSH_DIR,  
> (mainWnd->getHomeDirectory()+"/ssh").toAscii());
> ---
>>     ssh_options_set ( my_ssh_session, SSH_OPTIONS_SSH_DIR,  
>> (mainWnd->getHomeDirectory()+"/ssh").toLocal8Bit());
>
> The change affects only Windows builds and was tested in Windows 8.1  
> Pro and Windows 7 Professional.
>
> G. Trakatelis

Can you review these changes and if appropriate commit them to the  
master branch of x2goclient.git?

Thanks!
Mike


-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

[Message part 2 (application/pgp-signature, inline)]

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Tue Apr 23 19:45:33 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.