From trakatelis@uom.edu.gr  Mon Sep  8 02:13:54 2014
Received: (at 566) by bugs.x2go.org; 8 Sep 2014 00:13:55 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID
	autolearn=ham version=3.3.2
Received: from mail-wg0-f46.google.com (mail-wg0-f46.google.com [74.125.82.46])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 097385DEA7
	for <566@bugs.x2go.org>; Mon,  8 Sep 2014 02:13:53 +0200 (CEST)
Received: by mail-wg0-f46.google.com with SMTP id n12so2952733wgh.17
        for <566@bugs.x2go.org>; Sun, 07 Sep 2014 17:13:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=uom.edu.gr; s=google;
        h=from:to:cc:references:in-reply-to:subject:date:message-id
         :mime-version:content-type:content-transfer-encoding:thread-index
         :content-language;
        bh=AbalAK2LBQ8spJkNP6Z8yiH7mWbGa2Xtf1PlRVnhjyE=;
        b=A6dxu/IDFQsSWzL1ZVdJj5T6Mxej6zyYxhC9hmg1PUU66Jrw7Y5MatQ6+ICyayPI2l
         cO8G08gbjXN2fk78b8eaL7toxxiCRtBxgAGrWMYL529bqp41gz7AJrUuV7bkyUtkL1hG
         +1s2L6VVvNOjRT8Eytph/2O78dtuNksKygXLE=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:from:to:cc:references:in-reply-to:subject:date
         :message-id:mime-version:content-type:content-transfer-encoding
         :thread-index:content-language;
        bh=AbalAK2LBQ8spJkNP6Z8yiH7mWbGa2Xtf1PlRVnhjyE=;
        b=V4VLSFEJIRvlBwOJA89NURJxrA/RzqxJa+XtTgLE7vCZrlU9iGpNhQPrXopt0uZ1Gw
         XSpC9TWA6/GLSHGbjt/SLYeemk1TXqu+4XbfdkkYyqF0h1zpSFR+tTBOauiWiBnts9Iq
         eytsAaRVcvxHxm4TwVIxvfu0cpmfPVc0s+CE7kqGknSEFkLZmldUiNEeoTwv3NNOaEge
         y7cLU0GrtTWrwXPTCNPtjPGx4C5eL1iDDMjUxVEQeVjG+Rhqm24xfkoD5O/DXNBw6XE2
         1zArhGsEclhXwhHLXs6LTWgrL7xrsEwRe7IFKymMQrTGzyP1Wql40XzVXe6yRj6KcUN/
         xcQA==
X-Gm-Message-State: ALoCoQn1iWBeftfST3/31EtPtIBkJKxfWJlQ8rh6ibARN80ccYm2MhG5zjByXIpCApOQcJ2u9uDG
X-Received: by 10.180.35.133 with SMTP id h5mr18496371wij.74.1410135233583;
        Sun, 07 Sep 2014 17:13:53 -0700 (PDT)
Received: from HomePC (46-4-59.adsl.cyta.gr. [46.103.4.59])
        by mx.google.com with ESMTPSA id y5sm9243718wje.32.2014.09.07.17.13.52
        for <multiple recipients>
        (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);
        Sun, 07 Sep 2014 17:13:53 -0700 (PDT)
From: "George Trakatelis" <trakatelis@uom.edu.gr>
To: <566@bugs.x2go.org>
Cc: "'Michael DePaulo'" <mikedep333@gmail.com>,
	"'Mike Gabriel'" <mike.gabriel@das-netzwerkteam.de>
References: <000001cfb552$3193a8a0$94baf9e0$@gr> <handler.566.B.140775428816658.ack@bugs.x2go.org> <000001cfc60a$32831de0$978959a0$@gr> <20140901195103.Horde.HOAd34FDzvE7MwwNBCtaAg1@mail.das-netzwerkteam.de> <CAMKht8gaM7uupVMhTkPR3pg2jcO5sBRHCbYkMV8kCf0EvKK8sg@mail.gmail.com> <CAMKht8jxisag8A9F3yFBSg3BQ+PODLzrayu90S0G8OaQKZXtfQ@mail.gmail.com> <000001cfca83$2b11d830$81358890$@edu.gr> <CAMKht8hMDouAZr0zh0jQ8HhA_COJOfC-d0BKY4u6hTcCDEoQmQ@mail.gmail.com>
In-Reply-To: <CAMKht8hMDouAZr0zh0jQ8HhA_COJOfC-d0BKY4u6hTcCDEoQmQ@mail.gmail.com>
Subject: RE: [X2Go-Dev] Bug#566: X2Go Client for Windows 4.0.2.1 cannot create C:\Users\<username>\ssh\known_hosts file when the local Windows account username has non-Ascii characters
Date: Mon, 8 Sep 2014 03:13:48 +0300
Message-ID: <000001cfcaf9$c4160a80$4c421f80$@edu.gr>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Microsoft Office Outlook 12.0
Thread-Index: Ac/KnuYIWjGav6pXSUeitgd4YbP9+AAWSXaQ
Content-Language: el

Hi Mike,

1. If you recompile libssh 0.6.3 with Unicode support and provide me =
with a download link,
I will happily test it on all Windows platforms (namely Windows 8, 7, =
and XP).

2. I agree.

-George

-----Original Message-----
From: Michael DePaulo [mailto:mikedep333@gmail.com]=20
Sent: Sunday, September 7, 2014 4:23 PM
To: George Trakatelis; 566@bugs.x2go.org; Mike Gabriel
Subject: Re: [X2Go-Dev] Bug#566: X2Go Client for Windows 4.0.2.1 cannot =
create C:\Users\<username>\ssh\known_hosts file when the local Windows =
account username has non-Ascii characters

[...]

Hi Mike#1 and George,

1. What do you think of using toUtf8() instead? I am hoping that will =
fix the bug regardless of the locale.

I tried changing it to that (bug566.utf8.test.patch), but it still did =
not fix this bug with the greek username on my system with the locale =
set to English. It did not introduce a regression for my ASCII user =
account at least.

If libssh needs to be recompiled for Unicode, I can do that. I just =
recompiled it for bug #590.

FYI: This is the API we are calling:
http://api.libssh.org/stable/group__libssh__session.html#ga7a801b85800baa=
3f4e16f5b47db0a73d

2. in sshmasterconnection.cpp, we also set "SSH_OPTIONS_USER" . I think =
that we should also change its value from to.Ascii() to
toLocal8Bit() or toUtf8(). bug566.test.v2.patch has this change for =
toLocal8Bit(), and bug566.utf8.test.patch has it for toUtf8().

-Mike#2

