From mikedep333@gmail.com Sun Sep 7 06:44:27 2014 Received: (at 566) by bugs.x2go.org; 7 Sep 2014 04:44:28 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=ham version=3.3.2 Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 828F95DEA7 for <566@bugs.x2go.org>; Sun, 7 Sep 2014 06:44:27 +0200 (CEST) Received: by mail-wi0-f180.google.com with SMTP id ex7so1112874wid.13 for <566@bugs.x2go.org>; Sat, 06 Sep 2014 21:44:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=KjcmSxSyyIHF0aKcNu8nIEw0OBZczwimAoNhmMpdaMU=; b=biVF71DjEzzmmciSE7H5r2YB26NHMlYw3NS3/k0ob5Hw0wzksSoqdcozU5D05tdR9R WFLwmC3txxeg8wOc5gqes0ZQn0uEAwGHSdkCu+8zzN8iZ0BeTQGksb6mQ9u0BT9omqy/ NsAm4MPnNe/cCw9EEC35B0x6SFVjHyk8n7NtEimP6hfbI+sCzkJBIUk4U2Is5pz6snLi jA4WQdi07mpO2GV9WFcdS+XM0AYnCjM0ZYJmUjVVTXJGVuj/DWbEKqB8UB/YfAJNQPgk NPloNCy9rcP/0JLm5n74TKBwS67QPajPDCYfqpqcZuK9InQL63jT9wsRlAnvF79wFU7A AGqQ== MIME-Version: 1.0 X-Received: by 10.194.185.230 with SMTP id ff6mr27039wjc.120.1410065067092; Sat, 06 Sep 2014 21:44:27 -0700 (PDT) Received: by 10.180.238.66 with HTTP; Sat, 6 Sep 2014 21:44:25 -0700 (PDT) In-Reply-To: References: <000001cfb552$3193a8a0$94baf9e0$@gr> <000001cfc60a$32831de0$978959a0$@gr> <20140901195103.Horde.HOAd34FDzvE7MwwNBCtaAg1@mail.das-netzwerkteam.de> Date: Sun, 7 Sep 2014 00:44:25 -0400 Message-ID: Subject: Re: [X2Go-Dev] Bug#566: Bug#566: X2Go Client for Windows 4.0.2.1 cannon create C:\Users\\ssh\known_hosts file when the local Windows account username has non-English characters From: Michael DePaulo To: Mike Gabriel , 566@bugs.x2go.org Cc: trakatelis@uom.gr, George Trakatelis Content-Type: multipart/mixed; boundary=047d7bb0398c6f50e90502725b88 --047d7bb0398c6f50e90502725b88 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi George, 1st, please use either "diff -c" or "git diff" to prepare the patch. You can even use "git diff" on a files/folders that are outisde of a git source tree. 2nd, I tried what I think was your patch. I've attached the change I used, it is outputted with "git diff". I used the x2goclient master branch (4.0.3.0.) Unfortunately, it failed to fix the bug. I did not experience any regressions though. I tested it on both a Windows XP 32-bit SP3 machine and a Windows 8.1 64-bit machine (with the latest required updates & optional updates from MS.) 3rd, the username I used was "=CE=B4=CE=BF=CE=BA=CE=B9=CE=BC=CE=B1=CF=83=CF= =84=CE=B9=CE=BA=CF=8C =CF=87=CF=81=CE=AE=CF=83=CF=84=CE=B7". That is how Go= ogle Translate translated "test user" into Greek. Because it is not easy for me to type that name into the Windows login prompt, I simply ran commands like the following to test it: runas "/user:=CE=B4=CE=BF=CE=BA=CE=B9=CE=BC=CE=B1=CF=83=CF=84=CE=B9=CE=BA= =CF=8C =CF=87=CF=81=CE=AE=CF=83=CF=84=CE=B7" "c:\x2gobuilds\x2goclient\dist= \x2goclient.exe" -Mike On Mon, Sep 1, 2014 at 7:23 PM, Michael DePaulo wrot= e: > On Mon, Sep 1, 2014 at 3:51 PM, Mike Gabriel > wrote: >> Hi Mike#2, >> >> On Mo 01 Sep 2014 19:28:50 CEST, George Trakatelis wrote: >> >>> A suggested patch is to substitute the Qt4 toAscii() function with >>> toLocal8Bit() >>> in two specific places of SshMasterConnection::run(). >>> A git diff is as follows: >>> >>> $ diff /c/a/sshmasterconnection.cpp /c/b/sshmasterconnection.cpp >>> 521c521 >>> < ssh_options_set ( my_ssh_session, SSH_OPTIONS_SSH_DIR, >>> (mainWnd->getHomeDirectory()+"/ssh").toAscii()); >>> --- >>>> >>>> ssh_options_set ( my_ssh_session, SSH_OPTIONS_SSH_DIR, >>>> (mainWnd->getHomeDirectory()+"/ssh").toLocal8Bit()); >>> >>> 630c630 >>> < ssh_options_set ( my_ssh_session, SSH_OPTIONS_SSH_DIR, >>> (mainWnd->getHomeDirectory()+"/ssh").toAscii()); >>> --- >>>> >>>> ssh_options_set ( my_ssh_session, SSH_OPTIONS_SSH_DIR, >>>> (mainWnd->getHomeDirectory()+"/ssh").toLocal8Bit()); >>> >>> >>> The change affects only Windows builds and was tested in Windows 8.1 Pr= o >>> and Windows 7 Professional. >>> >>> G. Trakatelis >> >> >> Can you review these changes and if appropriate commit them to the maste= r >> branch of x2goclient.git? >> >> Thanks! >> Mike >> >> [...] > > Sure. I'm busy today, but I'll do so within the next few/several days. > > -Mike --047d7bb0398c6f50e90502725b88 Content-Type: application/octet-stream; name="bug566.test.patch" Content-Disposition: attachment; filename="bug566.test.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hzrw4a6d0 ZGlmZiAtLWdpdCBhL3NzaG1hc3RlcmNvbm5lY3Rpb24uY3BwIGIvc3NobWFzdGVyY29ubmVjdGlv bi5jcHAKaW5kZXggODI3ZWVmZS4uOTBjZjljNyAxMDA3NTUKLS0tIGEvc3NobWFzdGVyY29ubmVj dGlvbi5jcHAKKysrIGIvc3NobWFzdGVyY29ubmVjdGlvbi5jcHAKQEAgLTUxOCw3ICs1MTgsNyBA QCB2b2lkIFNzaE1hc3RlckNvbm5lY3Rpb246OnJ1bigpCiAgICAgfQogCiAjaWZkZWYgUV9PU19X SU4KLSAgICBzc2hfb3B0aW9uc19zZXQgKCBteV9zc2hfc2Vzc2lvbiwgU1NIX09QVElPTlNfU1NI X0RJUiwgKG1haW5XbmQtPmdldEhvbWVEaXJlY3RvcnkoKSsiL3NzaCIpLnRvQXNjaWkoKSk7Cisg ICAgc3NoX29wdGlvbnNfc2V0ICggbXlfc3NoX3Nlc3Npb24sIFNTSF9PUFRJT05TX1NTSF9ESVIs IChtYWluV25kLT5nZXRIb21lRGlyZWN0b3J5KCkrIi9zc2giKS50b0xvY2FsOEJpdCgpKTsKICAg ICBpZiAoa2VyYmVyb3MpCiAgICAgewogICAgICAgICBwYXJzZUtub3duSG9zdHMoKTsKQEAgLTYy Nyw3ICs2MjcsNyBAQCB2b2lkIFNzaE1hc3RlckNvbm5lY3Rpb246OnJ1bigpCiAgICAgfQogICAg IHNzaF9vcHRpb25zX3NldCAoIG15X3NzaF9zZXNzaW9uLCBTU0hfT1BUSU9OU19VU0VSLCB1c2Vy LnRvQXNjaWkoKSApOwogI2lmZGVmIFFfT1NfV0lOCi0gICAgc3NoX29wdGlvbnNfc2V0ICggbXlf c3NoX3Nlc3Npb24sIFNTSF9PUFRJT05TX1NTSF9ESVIsIChtYWluV25kLT5nZXRIb21lRGlyZWN0 b3J5KCkrIi9zc2giKS50b0FzY2lpKCkpOworICAgIHNzaF9vcHRpb25zX3NldCAoIG15X3NzaF9z ZXNzaW9uLCBTU0hfT1BUSU9OU19TU0hfRElSLCAobWFpblduZC0+Z2V0SG9tZURpcmVjdG9yeSgp KyIvc3NoIikudG9Mb2NhbDhCaXQoKSk7CiAKICNpZmRlZiBERUJVRwogICAgIHgyZ29EZWJ1Zzw8 InNldHRpbmcgU1NIIERJUiB0byAiPDxtYWluV25kLT5nZXRIb21lRGlyZWN0b3J5KCkrIi9zc2gi Owo= --047d7bb0398c6f50e90502725b88--