From unknown Mon Apr 13 09:28:51 2026 X-Loop: owner@bugs.x2go.org Subject: Bug#566: [X2Go-Dev] Bug#566: X2Go Client for Windows 4.0.2.1 cannon create C:\Users\\ssh\known_hosts file when the local Windows account username has non-English characters Reply-To: Mike Gabriel , 566@bugs.x2go.org Resent-From: Mike Gabriel Resent-To: x2go-dev@lists.x2go.org Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Mon, 01 Sep 2014 19:55:02 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: followup 566 X-X2Go-PR-Package: x2goclient X-X2Go-PR-Keywords: Received: via spool by 566-submit@bugs.x2go.org id=B566.1409601068766 (code B ref 566); Mon, 01 Sep 2014 19:55:02 +0000 Received: (at 566) by bugs.x2go.org; 1 Sep 2014 19:51:08 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.2 Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 3B0CF5DCA4 for <566@bugs.x2go.org>; Mon, 1 Sep 2014 21:51:07 +0200 (CEST) Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98]) by freya.das-netzwerkteam.de (Postfix) with ESMTPS id 672B6B70; Mon, 1 Sep 2014 21:51:06 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id BFD333C4E5; Mon, 1 Sep 2014 21:51:05 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de Received: from grimnir.das-netzwerkteam.de ([127.0.0.1]) by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RoP6lqUMhAVu; Mon, 1 Sep 2014 21:51:05 +0200 (CEST) Received: from grimnir.das-netzwerkteam.de (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id 40F283C4E3; Mon, 1 Sep 2014 21:51:04 +0200 (CEST) Received: from p5B2852C0.dip0.t-ipconnect.de (p5B2852C0.dip0.t-ipconnect.de [91.40.82.192]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP; Mon, 01 Sep 2014 19:51:03 +0000 Date: Mon, 01 Sep 2014 19:51:03 +0000 Message-ID: <20140901195103.Horde.HOAd34FDzvE7MwwNBCtaAg1@mail.das-netzwerkteam.de> From: Mike Gabriel To: trakatelis@uom.gr, 566@bugs.x2go.org, George Trakatelis References: <000001cfb552$3193a8a0$94baf9e0$@gr> <000001cfc60a$32831de0$978959a0$@gr> In-Reply-To: <000001cfc60a$32831de0$978959a0$@gr> User-Agent: Internet Messaging Program (IMP) H5 (6.2.0) Accept-Language: en,de Organization: DAS-NETZWERKTEAM X-Originating-IP: 91.40.82.192 X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Firefox/31.0 Iceweasel/31.0 Content-Type: multipart/signed; boundary="=_8bHyu9XQour_PWURghjQGw1"; protocol="application/pgp-signature"; micalg=pgp-sha1 MIME-Version: 1.0 This message is in MIME format and has been PGP signed. --=_8bHyu9XQour_PWURghjQGw1 Content-Type: text/plain; charset=us-ascii; format=flowed; DelSp=Yes Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Mike#2, On Mo 01 Sep 2014 19:28:50 CEST, George Trakatelis wrote: > A suggested patch is to substitute the Qt4 toAscii() function with=20=20 >=20toLocal8Bit() > in two specific places of SshMasterConnection::run(). > A git diff is as follows: > > $ diff /c/a/sshmasterconnection.cpp /c/b/sshmasterconnection.cpp > 521c521 > < ssh_options_set ( my_ssh_session, SSH_OPTIONS_SSH_DIR,=20=20 >=20(mainWnd->getHomeDirectory()+"/ssh").toAscii()); > --- >> ssh_options_set ( my_ssh_session, SSH_OPTIONS_SSH_DIR,=20=20 >>=20(mainWnd->getHomeDirectory()+"/ssh").toLocal8Bit()); > 630c630 > < ssh_options_set ( my_ssh_session, SSH_OPTIONS_SSH_DIR,=20=20 >=20(mainWnd->getHomeDirectory()+"/ssh").toAscii()); > --- >> ssh_options_set ( my_ssh_session, SSH_OPTIONS_SSH_DIR,=20=20 >>=20(mainWnd->getHomeDirectory()+"/ssh").toLocal8Bit()); > > The change affects only Windows builds and was tested in Windows 8.1=20= =20 >=20Pro and Windows 7 Professional. > > G. Trakatelis Can you review these changes and if appropriate commit them to the=20=20 master=20branch of x2goclient.git? Thanks! Mike --=20 DAS-NETZWERKTEAM mike=20gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.x= fb --=_8bHyu9XQour_PWURghjQGw1 Content-Type: application/pgp-signature Content-Description: Digitale PGP-Signatur Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABAgAGBQJUBM4nAAoJEJr0azAldxsxYgQP/jS5En2i86zbzqhxrHvUXAGN KYynAPLWuvRShK0oOMt1RNoxFux8GAIuJbPA4zAwcdCKKs4fsjVXr4MoXNnTVzYX FlY0+iThpj6gQyLeR3Bu48At0w5m48PltsnfeiwozR8NeIrcMIhBOgRdkElk6DOB WFdJ0Ny/gIxKy0IJTq8uBGnAwW6he8J2DzW47GoAFKum8aZsIRP5/MSaGTqWiLCW dwtywqfR6TiPEKNv2gl3jPZkUwQpyS8bblmijM1o7/w6tO2WvrvNPP9emuJTc4kc grXYmbfVG1sK76T8sL1v3hgdO7VznfaH/kdmrElK3LUUf2b60m9naW6dgqOjilJl HflWZ4GahGTSKgCPnVhkoUeJFAfeixLaIx1sR1VE1UdpomQYXJ9GrQEI288aC99n gn+OKPlQFXiRLbFf80aYlmc7N31g3FbVe/dCQRlghjhNPOVIC1xHKyhNl4x2J+XB aB02hb8x8dkk4RTcjTgVYR1EN2F/O2Q229+ljtfnJcsMLCLpYVVRtAGbdUwIpIDh /oYelKQQxKdjSMcjNqRUyjGtpbSNm9GosumiP2dyoaFJqUuobW++tK+ed2SHvin9 ACYZcGydTU0HAoooKgJ+3pK4MYrPmN7IhgFeImKtvKe7Bko3ATLIhTguR+oGpfAg /sLfhno+71SwOiFmWtHR =hVxP -----END PGP SIGNATURE----- --=_8bHyu9XQour_PWURghjQGw1--