From mike.gabriel@das-netzwerkteam.de Mon Sep 15 12:02:34 2014 Received: (at 610) by bugs.x2go.org; 15 Sep 2014 10:02:36 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.2 Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 47A495DB54 for <610@bugs.x2go.org>; Mon, 15 Sep 2014 12:02:33 +0200 (CEST) Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98]) by freya.das-netzwerkteam.de (Postfix) with ESMTPS id BB84810A7; Mon, 15 Sep 2014 12:02:32 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 6CD6F3BCB5; Mon, 15 Sep 2014 12:02:32 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de Received: from grimnir.das-netzwerkteam.de ([127.0.0.1]) by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JAquQSnH91t7; Mon, 15 Sep 2014 12:02:31 +0200 (CEST) Received: from grimnir.das-netzwerkteam.de (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id B5C2E3BCC3; Mon, 15 Sep 2014 12:02:29 +0200 (CEST) Received: from m-031.informatik.uni-kiel.de (m-031.informatik.uni-kiel.de [134.245.254.31]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP; Mon, 15 Sep 2014 10:02:26 +0000 Date: Mon, 15 Sep 2014 10:02:26 +0000 Message-ID: <20140915100226.Horde.D6SPBRPnuoLmC3FHixJFeA1@mail.das-netzwerkteam.de> From: Mike Gabriel To: Nito Martinez , 610@bugs.x2go.org Subject: Re: [X2Go-Dev] Bug#610: Add versioning information to nxcomp In-Reply-To: <541616A3.2020300@Qindel.ES> User-Agent: Internet Messaging Program (IMP) H5 (6.2.0) Accept-Language: en,de Organization: DAS-NETZWERKTEAM X-Originating-IP: 134.245.254.31 X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0 Iceweasel/32.0 Content-Type: multipart/signed; boundary="=_XMY1_0dQneGD2gIjdwdZ3A1"; protocol="application/pgp-signature"; micalg=pgp-sha1 MIME-Version: 1.0 This message is in MIME format and has been PGP signed. --=_XMY1_0dQneGD2gIjdwdZ3A1 Content-Type: text/plain; charset=ISO-8859-1; format=flowed; DelSp=Yes Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Control: notfound -1 3.5.0-27 Control: found -1 3.5.0.27 Hi Nito, On Mo 15 Sep 2014 00:28:51 CEST, Nito Martinez wrote: > Package: nx-libs > Version: 3.5.0-27 > > It would be desirable to add some versions to be able to get the=20=20 >=20version of the > NXComp library. > These should be defined in NX.h, to be used from other clients, and > > Attached is a patch that defines the following functions: > > extern const char* NXVersion(); > extern int NXMajorVersion(); > extern int NXMinorVersion(); > extern int NXPatchVersion(); > > In the patch assigned the VERSION has been set to 3.5.28, just to=20=20 >=20highlight that > it would be good to change the VERSION of nxcomp whenever a patch is appl= ied > to the code. > > Regards, > > Nito Thanks for sending in that patch. However, the next upstream release of NX redistributed is planned to=20=20 be=203.5.0.28. The idea starting the NX version with 3.5.0 was to reflect what=20=20 "upstream"=20version we obtained from NoMachine (they use three digits,=20= =20 NX=20redistributed uses _four_ digits in the version string). The fourth=20= =20 part=20of the version quadruple is the NX/X2Go/QVD redistributed patch=20= =20 level,=20so to say. If that will not cause any technical issues, can you rewrite that=20=20 patch=20so it handles four digit version strings (major, minor, micro,=20= =20=20 X2Go/QVD-patchlevel). Please=20also note that an upstream version like 3.5.0-28 will cause=20=20 convention=20issues with most Linux distributions. In Debian, for=20=20 example,=20the part left of the "-" denotes the upstream version, the=20=20 part=20right of the "-" denotes the package revision inside Debian. So=20= =20 we=20should avoid using a dash in the NX-libs upstream version. Thanks! Mike --=20 DAS-NETZWERKTEAM mike=20gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.x= fb --=_XMY1_0dQneGD2gIjdwdZ3A1 Content-Type: application/pgp-signature Content-Description: Digitale PGP-Signatur Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABAgAGBQJUFrkyAAoJEJr0azAldxsxcgYP/A++yE3rPxyBt1Zs21YuvzlM z4o+Sb+5SYp1wWsHMP2+NPX32hSctBabgJTYoGJDiLaXt+wNMkwyi8TkfQVByDJU IDGVk+E4tBgL0W3STGLtoF+n4NZjSXdn6uJDN6cikZODq1VB3BYj7Z4O/e+BURDB UQNjhWJAZ3fqsRDfuXTFJxiRTZoqXGlQb0G+McCgca5sh9OchJWVb6mpQobdFkxx pSoIocQoBwcoEPkginEX7sQOekk8SEBmo27cdsBKWDfK8b7qymkpMt1KlLPDHjPt ISWtNvsxcAWhC1kExUnQioOrHMsNT+MK7TcFxxaQHkyudfVfriEkHIuHKId/VSvN wLd3/czMykhxnyKht+ckQO5pHXbke+FPGUuskMe3FjmcZAsfZ1A/epCnWV+fNYLy uZ6F2gLEFVXw2YoYeZynG7Lw9yBOC/Ar+tHa3r2bDh5E1nq+oEPWZKB/ntsd7oaL 1Rw0JG4R77JV7EyeGrnOcpgAxFh3FCz+UJkAZ0KPliB6SCloYzWHIiqeByEoQ5z1 GAIAz6Dy4gO9DZwDzPFQqr9jRwQzJxBxeqFkZWkiD1D12SYleM+D36hhkus1YC0f yH/sVD/aPmLBbsFhujkODqRlYJt41nmNWXY04plNB+moKWREDRvZAY0JyCSL9V1G koA3c9FJXK6Gmkxs8iQH =wCz8 -----END PGP SIGNATURE----- --=_XMY1_0dQneGD2gIjdwdZ3A1--