From unknown Fri Apr 17 12:12:18 2026 X-Loop: owner@bugs.x2go.org Subject: Bug#599: X2Go fails to launch gnome-fallback properly on distros other than Debian and Ubuntu Reply-To: Michael DePaulo , 599@bugs.x2go.org Resent-From: Michael DePaulo Resent-To: x2go-dev@lists.x2go.org Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Sun, 07 Sep 2014 23:20:02 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: report 599 X-X2Go-PR-Package: x2goserver X-X2Go-PR-Keywords: Received: via spool by submit@bugs.x2go.org id=B.141013187512102 (code B); Sun, 07 Sep 2014 23:20:02 +0000 Received: (at submit) by bugs.x2go.org; 7 Sep 2014 23:17:55 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=ham version=3.3.2 Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 393CE5DEA7 for ; Mon, 8 Sep 2014 01:17:54 +0200 (CEST) Received: by mail-wi0-f179.google.com with SMTP id q5so1767261wiv.12 for ; Sun, 07 Sep 2014 16:17:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=KXiV+OJqsYKYiCeLQ5ir+WqAYqlag+N1er8PSN6vb90=; b=Quo6AYzF60hBRkKmoOly7FOzylppS38flT3/jp1TyPhplBeg/pJfQWtKnxcM6RNiDm kpcCo/LsP6ou95H7WK40Ds453a8kFYKbYf1y0cVXFlhiUMMv06KpfjNQq5IwyN9ROoA+ 4yWIVO/1alsfliYEsdRvpbnhDBt43o8g5VI9gVmCPVq7DKt56G/zLO4drWb7NzQZH2Hq 9WVih2+SikJJ9CCg+CHcfr/ul7doz2p7ffUX4wGskYmpB8uKYwEidDA9q/9dhl5cBJ6T +eNFuaNINuk7DjIyjB84GuV9fWy/axVXOsHhTWBim6Y1ANloJ3TJHjlAv7skcOJsk0QD bQvQ== MIME-Version: 1.0 X-Received: by 10.180.205.168 with SMTP id lh8mr18669149wic.67.1410131873851; Sun, 07 Sep 2014 16:17:53 -0700 (PDT) Received: by 10.180.238.66 with HTTP; Sun, 7 Sep 2014 16:17:53 -0700 (PDT) Date: Sun, 7 Sep 2014 19:17:53 -0400 Message-ID: From: Michael DePaulo To: submit@bugs.x2go.org Content-Type: multipart/mixed; boundary=001a11c38ace6e615f050281e970 --001a11c38ace6e615f050281e970 Content-Type: text/plain; charset=UTF-8 Package: x2goserver Version: 4.0.1.15 Severity: normal In /usr/bin/x2goruncommand , the logic for deciding to launch the "gnome-fallback" session instead of the default instead of "gnome" session is specific to Debian and Ubuntu. The same is true for "gnome-2d", and "gnome-flashback". (Although there are bugs in gnome-session preventing gnome-flashback from working with X2Go. See X2Go bug #598.) Rather than adding logic for every other distro, I have prepared a patch that is distro-neutral. It looks for the presence of session files under /usr/share/gnome-session/sessions/ to decide which session to (attempt to) launch. It uses the following priority: gnome-flashback (GNOME 3.8 and later) gnome-fallback (GNOME 3.4 and GNOME 3.6) gnome-2d (GNOME 3.2) gnome (GNOME2, or gnome-shell on GNOME3) I tested it on openSUSE 12.3 (GNOME 3.6) successfully. Without this patch, GNOME gives a warning dialog saying that it could not launch a regular session and had to resort to a fallback session. With this patch, it does not give that warning (because the fallback session was intentional.) I also tested Ubuntu 12.04: No regression -Mike#2 --001a11c38ace6e615f050281e970 Content-Type: application/octet-stream; name="x2goserver-make-gnome3-logic-distro-neutral.patch" Content-Disposition: attachment; filename="x2goserver-make-gnome3-logic-distro-neutral.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hzszuznh0 ZGlmZiAtLWdpdCBhL3gyZ29zZXJ2ZXIvYmluL3gyZ29ydW5jb21tYW5kIGIveDJnb3NlcnZlci9i aW4veDJnb3J1bmNvbW1hbmQKaW5kZXggZjMyNGQyNi4uZjQzNTJiMCAxMDA3NTUKLS0tIGEveDJn b3NlcnZlci9iaW4veDJnb3J1bmNvbW1hbmQKKysrIGIveDJnb3NlcnZlci9iaW4veDJnb3J1bmNv bW1hbmQKQEAgLTc3LDEwICs3NywxMCBAQCBmaQogIyBOT1RFUyBvbiBHTk9NRSBzdGFydHVwIGJl aGF2aW91ciBpbiBkaWZmZXJlbnQgZGlzdHJpYnV0aW9ucwogIyA9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQogCi0jIERlYmlhbiBsYXVu Y2hlcyBHTk9NRTMgKGluIGFjY2VsZXJhdGVkIG1vZGUpIHdoZW4gY2FsbGluZyBnbm9tZS1zZXNz aW9uCisjIERlYmlhbiBhbmQgZXZlcnkgb3RoZXIgbm9uLVVidW50dSBkaXN0cm8gbGF1bmNocyBH Tk9NRTMgKGluIGFjY2VsZXJhdGVkIG1vZGUpIHdoZW4gY2FsbGluZyBnbm9tZS1zZXNzaW9uCiAK ICMgVWJ1bnR1IGxhdW5jaGVzIFVuaXR5IChpbiBhY2NlbGVyYXRlZCBtb2RlKSB3aGVuIGNhbGxp bmcgZ25vbWUtc2Vzc2lvbi4KLSMgVG8gbWFrZSB0aGUgR05PTUUgdmFyaWFudHMgc3RhcnQgdXAg cHJvcGVybHkgb24gRGViaWFuL1VidW50dSB3ZSBoYXZlIHRvIG1ha2UgdGhlIGZvbGxvd2luZyBk aWZmZXJlbnRpYXRpb25zCisjIFRvIG1ha2UgdGhlIEdOT01FIHZhcmlhbnRzIHN0YXJ0IHVwIHBy b3Blcmx5IG9uIFVidW50dSwgd2UgaGF2ZSB0byBtYWtlIHRoZSBmb2xsb3dpbmcgZGlmZmVyZW50 aWF0aW9ucwogCiAjIFVidW50dSAxMC4xMCBhbmQgZWFybGllciAobWF2ZXJpY2spOgogIwkJIEdO T01FIC0+IGdub21lLXNlc3Npb24KQEAgLTEwMSwxOCArMTAxLDE1IEBAIGZpCiAjCQkgR05PTUUg LT4gZ25vbWUtc2Vzc2lvbiAtLXNlc3Npb249Z25vbWUtZmxhc2hiYWNrCiAjCQkgVU5JVFkgLT4g Z25vbWUtc2Vzc2lvbiAtLXNlc3Npb249dWJ1bnR1CiAjCQkgKEdOT01FMyBiYXNlZCBkZXNrdG9w IHNoZWxscykKLQotIyBEZWJpYW4gc3F1ZWV6ZSBhbmQgZWFybGllcjoKLSMJCSBHTk9NRSAtPiBn bm9tZS1zZXNzaW9uCi0jCQkgKHdvdWxkIHN0YXJ0IEdOT01FMikKLSMgRGViaWFuIHdoZWV6eToK LSMJCSBHTk9NRSAtPiBnbm9tZS1zZXNzaW9uIC0tc2Vzc2lvbj1nbm9tZS1mYWxsYmFjawotIwkJ IFVOSVRZOiBub3QgYXZhaWxhYmxlCi0jCQkgKEdOT01FMyBiYXNlZCBkZXNrdG9wIHNoZWxscykK LSMgRGViaWFuIGplc3NpZToKLSMJCSBHTk9NRSAtPiBnbm9tZS1zZXNzaW9uIC0tc2Vzc2lvbj1n bm9tZS1mbGFzaGJhY2sKLSMJCSBVTklUWTogbm90IGF2YWlsYWJsZQotIwkJIChHTk9NRTMgYmFz ZWQgZGVza3RvcCBzaGVsbHMpCisjCQkgQWRkaXRpb25hbGx5LCAkR1RLX01PRFVMRVMgbXVzdCBp bmNsdWRlICJ1bml0eS1ndGstbW9kdWxlIi4KKyMJCSAkR1RLX01PRFVMRVMgZG9lcyBub3QgbmVl ZCB0aGEgdmFsdWUgZm9yIGFueSBvdGhlciBkaXN0cm8KKyMgICAgICAgICAgICAgICAgb3IgYW55 IGVhcmxpZXIgcmVsZWFzZSBvZiBVYnVudHUuCisjCisjCQkgVGhlIGxvZ2ljIGZvciBsYXVuY2hp bmcgR05PTUUgc2hvdWxkIGJlIGdlbmVyaWMgZW5vdWdoCisjICAgICAgICAgICAgICAgIHRvIHdv cmsgd2l0aCBldmVyeSBvdGhlciBkaXN0cm8uCisjCisjCQkgQWxzbywgaXQgYXBwZWFycyB0aGF0 IHNvbWUgTGludXggR05PTUUyIGRpc3Ryb3MgbmVlZCBERVNLVE9QX1NFU1NJT049Imdub21lIgor IyAgICAgICAgICAgICAgICB3aGlsZSBvdGhlcnMgZG8gbm90LgogCiBpZiBbICIkY21kIiA9PSAi R05PTUUiIF0gfHwgWyAiJGNtZCIgPT0gImdub21lLXNlc3Npb24iIF07IHRoZW4KIAljbWQ9Ii91 c3IvYmluL2dub21lLXNlc3Npb24iCkBAIC0xMjQsMjMgKzEyMSwyMCBAQCBpZiBbICIkY21kIiA9 PSAiR05PTUUiIF0gfHwgWyAiJGNtZCIgPT0gImdub21lLXNlc3Npb24iIF07IHRoZW4KIAkJCWV4 cG9ydCBHVEtfTU9EVUxFUz0iJEdUS19NT0RVTEVTOnVuaXR5LWd0ay1tb2R1bGUiCiAJCWZpCiAJ CWFyZ3M9IiAtLXNlc3Npb249JERFU0tUT1BfU0VTU0lPTiIKLQllbGlmIFsgIiRESVNUUklCX0lE IiA9PSAiVWJ1bnR1IiBdICYmIFsgIiQoZWNobyAiJERJU1RSSUJfUkVMRUFTRSA+PSAxMS4xMCIg fCBiYykiID09ICIxIiBdOyB0aGVuCi0JCWV4cG9ydCBERVNLVE9QX1NFU1NJT049Imdub21lLWZh bGxiYWNrIgotCQlhcmdzPSIgLS1zZXNzaW9uPSRERVNLVE9QX1NFU1NJT04iCi0JZWxpZiBbICIk RElTVFJJQl9JRCIgPT0gIlVidW50dSIgXSAmJiBbICIkKGVjaG8gIiRESVNUUklCX1JFTEVBU0Ug PT0gMTEuMDQiIHwgYmMpIiA9PSAiMSIgXTsgdGhlbgotCQlleHBvcnQgREVTS1RPUF9TRVNTSU9O PSIyZC1nbm9tZSIKLQkJYXJncz0iIC0tc2Vzc2lvbj0kREVTS1RPUF9TRVNTSU9OIgotCWVsaWYg WyAiJERJU1RSSUJfSUQiID09ICJVYnVudHUiIF0gJiYgWyAiJChlY2hvICIkRElTVFJJQl9SRUxF QVNFIDw9IDEwLjEwIiB8IGJjKSIgPT0gIjEiIF07IHRoZW4KLQkJZXhwb3J0IERFU0tUT1BfU0VT U0lPTj0iZ25vbWUiCisgICAgICAgIGVsaWYgWyAtZSAvdXNyL3NoYXJlL2dub21lLXNlc3Npb24v c2Vzc2lvbnMvZ25vbWUtZmxhc2hiYWNrLnNlc3Npb24gXTsgdGhlbgorICAgICAgICAgICAgICAg IGV4cG9ydCBERVNLVE9QX1NFU1NJT049Imdub21lLWZsYXNoYmFjayIKKyAgICAgICAgICAgICAg ICBhcmdzPSIgLS1zZXNzaW9uPSRERVNLVE9QX1NFU1NJT04iCisgICAgICAgIGVsaWYgWyAtZSAv dXNyL3NoYXJlL2dub21lLXNlc3Npb24vc2Vzc2lvbnMvZ25vbWUtZmFsbGJhY2suc2Vzc2lvbiBd OyB0aGVuCisgICAgICAgICAgICAgICAgZXhwb3J0IERFU0tUT1BfU0VTU0lPTj0iZ25vbWUtZmFs bGJhY2siCisgICAgICAgICAgICAgICAgYXJncz0iIC0tc2Vzc2lvbj0kREVTS1RPUF9TRVNTSU9O IgorICAgICAgICBlbGlmIFsgLWUgL3Vzci9zaGFyZS9nbm9tZS1zZXNzaW9uL3Nlc3Npb25zLzJk LWdub21lLnNlc3Npb24gXTsgdGhlbgorICAgICAgICAgICAgICAgIGV4cG9ydCBERVNLVE9QX1NF U1NJT049IjJkLWdub21lIgorICAgICAgICAgICAgICAgIGFyZ3M9IiAtLXNlc3Npb249JERFU0tU T1BfU0VTU0lPTiIKKyAgICAgICAgZWxpZiBbICIkRElTVFJJQl9JRCIgPT0gIlVidW50dSIgXSAm JiBbICIkKGVjaG8gIiRESVNUUklCX1JFTEVBU0UgPD0gMTAuMTAiIHwgYmMpIiA9PSAiMSIgXTsg dGhlbgorICAgICAgICAgICAgICAgIGV4cG9ydCBERVNLVE9QX1NFU1NJT049Imdub21lIgogCWVs aWYgY2F0IC9ldGMvZGViaWFuX3ZlcnNpb24gfCBlZ3JlcCAiXihzcXVlZXplfDZcLikuKiIgPi9k ZXYvbnVsbDsgdGhlbgotCQlleHBvcnQgREVTS1RPUF9TRVNTSU9OPSJnbm9tZSIKLQllbGlmIGNh dCAvZXRjL2RlYmlhbl92ZXJzaW9uIHwgZWdyZXAgIl4od2hlZXp5fDdcLikuKiIgPi9kZXYvbnVs bDsgdGhlbgotCQlleHBvcnQgREVTS1RPUF9TRVNTSU9OPSJnbm9tZS1mYWxsYmFjayIKLQkJYXJn cz0iIC0tc2Vzc2lvbj0kREVTS1RPUF9TRVNTSU9OIgotCWVsaWYgY2F0IC9ldGMvZGViaWFuX3Zl cnNpb24gfCBlZ3JlcCAiXihqZXNzaWV8OFwuKS4qIiA+L2Rldi9udWxsOyB0aGVuCi0JCWV4cG9y dCBERVNLVE9QX1NFU1NJT049Imdub21lLWZsYXNoYmFjayIKLQkJYXJncz0iIC0tc2Vzc2lvbj0k REVTS1RPUF9TRVNTSU9OIgotCWZpCisgICAgICAgICAgICAgICAgZXhwb3J0IERFU0tUT1BfU0VT U0lPTj0iZ25vbWUiCisgICAgICAgIGZpCiAKIGVsaWYgKFsgIiRjbWQiID09ICJVTklUWSIgXSB8 fCBbICIkY21kIiA9PSAidW5pdHkiIF0pOyB0aGVuCiAJY21kPSIvdXNyL2Jpbi9nbm9tZS1zZXNz aW9uIgo= --001a11c38ace6e615f050281e970--