X2Go Bug report logs - #585
Clipboard handling with XFIXES broken

version graph

Package: nx-libs; Maintainer for nx-libs is X2Go Developers <x2go-dev@lists.x2go.org>;

Reported by: Ulrich Sibiller <u.sibiller@science-computing.de>

Date: Wed, 27 Aug 2014 21:35:01 UTC

Severity: normal

Tags: patch, pending

Found in version 3.5.0-27

Fixed in version 2:3.5.0.28

Done: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

Bug is archived. No further changes may be made.

Full log

🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#585: [X2Go-Dev] Bug#585: Bug#585: Fix
Reply-To: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>, 585@bugs.x2go.org
Resent-From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Wed, 05 Nov 2014 11:15:01 +0000
Resent-Message-ID: <handler.585.B585.14151860393558@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 585
X-X2Go-PR-Package: nx-libs
X-X2Go-PR-Keywords: pending patch
Received: via spool by 585-submit@bugs.x2go.org id=B585.14151860393558
          (code B ref 585); Wed, 05 Nov 2014 11:15:01 +0000
Received: (at 585) by bugs.x2go.org; 5 Nov 2014 11:13:59 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED
	autolearn=ham version=3.3.2
Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 679C25DB48
	for <585@bugs.x2go.org>; Wed,  5 Nov 2014 12:13:58 +0100 (CET)
Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98])
	by freya.das-netzwerkteam.de (Postfix) with ESMTPS id 0CBE5D02;
	Wed,  5 Nov 2014 12:13:58 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 024DF3BA1F;
	Wed,  5 Nov 2014 12:13:58 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de
Received: from grimnir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id YgK9m7mxwx5B; Wed,  5 Nov 2014 12:13:57 +0100 (CET)
Received: from grimnir.das-netzwerkteam.de (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id C91513B9F9;
	Wed,  5 Nov 2014 12:13:57 +0100 (CET)
Received: from listrac.informatik.uni-kiel.de
 (listrac.informatik.uni-kiel.de [134.245.252.114]) by
 mail.das-netzwerkteam.de (Horde Framework) with HTTP; Wed, 05 Nov 2014
 11:13:57 +0000
Date: Wed, 05 Nov 2014 11:13:57 +0000
Message-ID: <20141105111357.Horde.s8UY27Nq4sSwr6JV0x50DA1@mail.das-netzwerkteam.de>
From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
To: 585@bugs.x2go.org, Ulrich Sibiller <uli42@gmx.de>
References: <CANVnVY+A0cy1GH713LxuaYuQEF4m-g0Zs_wh1=XMecixRKEjiA@mail.gmail.com>
 <20141105090453.Horde.89Mm-Nb1SFXPjSk6jw-9TQ1@mail.das-netzwerkteam.de>
In-Reply-To: <20141105090453.Horde.89Mm-Nb1SFXPjSk6jw-9TQ1@mail.das-netzwerkteam.de>
User-Agent: Internet Messaging Program (IMP) H5 (6.2.2)
Accept-Language: en,de
Organization: DAS-NETZWERKTEAM
X-Originating-IP: 134.245.252.114
X-Remote-Browser: Mozilla/5.0 (X11; Linux i686; rv:33.0) Gecko/20100101
 Firefox/33.0 Iceweasel/33.0
Content-Type: multipart/signed; boundary="=_tC9fKgmbR2HcxRKue2utEw9";
 protocol="application/pgp-signature"; micalg=pgp-sha1
MIME-Version: 1.0

[Message part 1 (text/plain, inline)]
Hi Ulrich,

On  Mi 05 Nov 2014 10:04:53 CET, Mike Gabriel wrote:

> Control: tag -1 patch
>
>
> Hi Uli,
>
> On  Di 04 Nov 2014 23:51:35 CET, Ulrich Sibiller wrote:
>
>> Without XFIXES the client calls GetSelectionOwner() before every paste
>> operation and therefor always knows the current selection owner.
>>
>> With XFIXES some clients rely solely on the
>> XFixesSelectSelectionInput/XFixesSelectionNotify mechanism. But they
>> never receive any notifications because the nxagent does not register
>> at the real X server to receive those notifications itself and so
>> never gets anything to forward to the clients. A client assuming it
>> will get informed about owner changes skips the GetSelectionOwner()
>> call. So it never knows that the selection owner has changed and
>> refers to what it thinks the current owner is (itself).
>>
>> Attached is a fix for this bug. nxagent calls
>> XFixesSelectSelectionInput for all its selections (t.i. CLIPBOARD and
>> PRIMARY, _not_ SECONDARY) now. It (still) does not check the return
>> code but the original code registering only CLIPBOARD did neither...
>>
>> This is a complete patch generated by git format-patch after using
>> (d)quilt as documented in the wiki.
>>
>> As I did not find any hints of what patch number to choose I took 207
>> to put it as close as possible to other clipboard related patches.
>> Feel free to change that...
>>
>>
>> Uli
>
> Cool! The patch looks good. Even the integration in the quilt based  
> patching mechanism we use with nx-libs.
>
> I will apply your patch and run a test build in a minute.
>
> Mike

The patch indeed fixes the problem! Thanks for your good work!!!

Mike

-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

[Message part 2 (application/pgp-signature, inline)]

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Nov 21 14:49:22 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.