X2Go Bug report logs - #585
Clipboard handling with XFIXES broken

version graph

Package: nx-libs; Maintainer for nx-libs is X2Go Developers <x2go-dev@lists.x2go.org>;

Reported by: Ulrich Sibiller <u.sibiller@science-computing.de>

Date: Wed, 27 Aug 2014 21:35:01 UTC

Severity: normal

Tags: patch, pending

Found in version 3.5.0-27

Fixed in version 2:3.5.0.28

Done: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

Bug is archived. No further changes may be made.

Full log

🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#585: Fix
Reply-To: Ulrich Sibiller <uli42@gmx.de>, 585@bugs.x2go.org
Resent-From: Ulrich Sibiller <uli42@gmx.de>
Original-Sender: ulrich.sibiller@gmail.com
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Tue, 04 Nov 2014 22:55:01 +0000
Resent-Message-ID: <handler.585.B585.141514151824608@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 585
X-X2Go-PR-Package: nx-libs
X-X2Go-PR-Keywords: 
Received: via spool by 585-submit@bugs.x2go.org id=B585.141514151824608
          (code B ref 585); Tue, 04 Nov 2014 22:55:01 +0000
Received: (at 585) by bugs.x2go.org; 4 Nov 2014 22:51:58 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,
	T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham version=3.3.2
Received: from mail-lb0-f174.google.com (mail-lb0-f174.google.com [209.85.217.174])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 8E33A5DB48
	for <585@bugs.x2go.org>; Tue,  4 Nov 2014 23:51:56 +0100 (CET)
Received: by mail-lb0-f174.google.com with SMTP id p9so1098847lbv.19
        for <585@bugs.x2go.org>; Tue, 04 Nov 2014 14:51:56 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:sender:from:date:message-id:subject:to:content-type;
        bh=Empm84Iw8OuxDo81lCo1c5+XEBRKRSANbQ5/7e5TtQk=;
        b=UAIJMzOElQGysGvo3OCdedHfirgG/IvdcbPasmCRKmZEDK9WnznTUKyhbms6EOqqsW
         FY9qeLUvrp571kRotdyuGVAmhWwqZkeCC3KTlt32lQFiCtRO9OtHZ79CSRCfAXa43NFM
         XBMZhsj1odBjbKwEWLeC4tWVVr+yZAkvEZbw/YA/p+UPeqnlYk/xSSIzTk41Maxrqlwh
         wcu/igFp9CGDYJfftEwFT3o0GOIv4gANhjCP4NGo/RWu3R1oaNY5hHOLj3uIQokFzh3M
         g8EtdKeLJwDjGQQp16P9tzamE7uC2Zsxpfp8GJoHpSluXerWHRUiFZjKonOe4ks8tDG7
         dt5g==
X-Received: by 10.112.131.33 with SMTP id oj1mr8851074lbb.97.1415141515870;
 Tue, 04 Nov 2014 14:51:55 -0800 (PST)
MIME-Version: 1.0
Sender: ulrich.sibiller@gmail.com
Received: by 10.112.180.197 with HTTP; Tue, 4 Nov 2014 14:51:35 -0800 (PST)
From: Ulrich Sibiller <uli42@gmx.de>
Date: Tue, 4 Nov 2014 23:51:35 +0100
X-Google-Sender-Auth: Fq3kZb2T8K1-fsnvCABpcCogxr0
Message-ID: <CANVnVY+A0cy1GH713LxuaYuQEF4m-g0Zs_wh1=XMecixRKEjiA@mail.gmail.com>
To: 585@bugs.x2go.org
Content-Type: multipart/mixed; boundary=047d7b343a325c5cf50507104fe2

[Message part 1 (text/plain, inline)]
Without XFIXES the client calls GetSelectionOwner() before every paste
operation and therefor always knows the current selection owner.

With XFIXES some clients rely solely on the
XFixesSelectSelectionInput/XFixesSelectionNotify mechanism. But they
never receive any notifications because the nxagent does not register
at the real X server to receive those notifications itself and so
never gets anything to forward to the clients. A client assuming it
will get informed about owner changes skips the GetSelectionOwner()
call. So it never knows that the selection owner has changed and
refers to what it thinks the current owner is (itself).

Attached is a fix for this bug. nxagent calls
XFixesSelectSelectionInput for all its selections (t.i. CLIPBOARD and
PRIMARY, _not_ SECONDARY) now. It (still) does not check the return
code but the original code registering only CLIPBOARD did neither...

This is a complete patch generated by git format-patch after using
(d)quilt as documented in the wiki.

As I did not find any hints of what patch number to choose I took 207
to put it as close as possible to other clipboard related patches.
Feel free to change that...


Uli

[fix_585.diff (text/plain, attachment)]

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Nov 21 14:46:17 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.