From mike.gabriel@das-netzwerkteam.de Wed Nov 5 10:04:55 2014 Received: (at 585) by bugs.x2go.org; 5 Nov 2014 09:04:56 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 136A55DB48 for <585@bugs.x2go.org>; Wed, 5 Nov 2014 10:04:55 +0100 (CET) Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98]) by freya.das-netzwerkteam.de (Postfix) with ESMTPS id A6AFCC6C; Wed, 5 Nov 2014 10:04:54 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 7DAC33BA68; Wed, 5 Nov 2014 10:04:54 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de Received: from grimnir.das-netzwerkteam.de ([127.0.0.1]) by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8Y52CeTDphtk; Wed, 5 Nov 2014 10:04:54 +0100 (CET) Received: from grimnir.das-netzwerkteam.de (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id 332133BA61; Wed, 5 Nov 2014 10:04:54 +0100 (CET) Received: from listrac.informatik.uni-kiel.de (listrac.informatik.uni-kiel.de [134.245.252.114]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP; Wed, 05 Nov 2014 09:04:54 +0000 Date: Wed, 05 Nov 2014 09:04:53 +0000 Message-ID: <20141105090453.Horde.89Mm-Nb1SFXPjSk6jw-9TQ1@mail.das-netzwerkteam.de> From: Mike Gabriel To: Ulrich Sibiller , 585@bugs.x2go.org Subject: Re: [X2Go-Dev] Bug#585: Fix In-Reply-To: User-Agent: Internet Messaging Program (IMP) H5 (6.2.2) Accept-Language: en,de Organization: DAS-NETZWERKTEAM X-Originating-IP: 134.245.252.114 X-Remote-Browser: Mozilla/5.0 (X11; Linux i686; rv:33.0) Gecko/20100101 Firefox/33.0 Iceweasel/33.0 Content-Type: multipart/signed; boundary="=_DoMPcAA0dcoybUqfUpDKJQ2"; protocol="application/pgp-signature"; micalg=pgp-sha1 MIME-Version: 1.0 This message is in MIME format and has been PGP signed. --=_DoMPcAA0dcoybUqfUpDKJQ2 Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Control: tag -1 patch Hi Uli, On Di 04 Nov 2014 23:51:35 CET, Ulrich Sibiller wrote: > Without XFIXES the client calls GetSelectionOwner() before every paste > operation and therefor always knows the current selection owner. > > With XFIXES some clients rely solely on the > XFixesSelectSelectionInput/XFixesSelectionNotify mechanism. But they > never receive any notifications because the nxagent does not register > at the real X server to receive those notifications itself and so > never gets anything to forward to the clients. A client assuming it > will get informed about owner changes skips the GetSelectionOwner() > call. So it never knows that the selection owner has changed and > refers to what it thinks the current owner is (itself). > > Attached is a fix for this bug. nxagent calls > XFixesSelectSelectionInput for all its selections (t.i. CLIPBOARD and > PRIMARY, _not_ SECONDARY) now. It (still) does not check the return > code but the original code registering only CLIPBOARD did neither... > > This is a complete patch generated by git format-patch after using > (d)quilt as documented in the wiki. > > As I did not find any hints of what patch number to choose I took 207 > to put it as close as possible to other clipboard related patches. > Feel free to change that... > > > Uli Cool! The patch looks good. Even the integration in the quilt based=20=20 patching=20mechanism we use with nx-libs. I will apply your patch and run a test build in a minute. Mike --=20 DAS-NETZWERKTEAM mike=20gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.x= fb --=_DoMPcAA0dcoybUqfUpDKJQ2 Content-Type: application/pgp-signature Content-Description: Digitale PGP-Signatur Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABAgAGBQJUWeg1AAoJEJr0azAldxsxGJgP/11xuBiVvxau9+XjRryETrcz UgsycWWmZZaHhf1zfTNMVujNIerWMP5pe1l5a7MBCvMFCR+jPvRbGYgfay1ZUelc C4C1tEa6Fv3zREvwfCXNaulLbKu02zjEDUcrzS+OABP5o9aJU4+a+0vqnDOZ//ir yBjb/cZ7IK1EYphxjnwMlnDgE/dNwO/6ly22IJ1m2cmWGUilVpVXCDYQx2DSZdv7 /RBSyTy1diS/VJ3AVpByYw97tYdZU7+Kg+pOSBRAWu+ySjThpDma/wEISO+IxrDn 9vLKbcPv/uQvpA5rXFL69SG8p1J/vrroZLZnYDgVYC5jseEtKDm6/I26SQ4/RwBc KeGJ3s4Q4EPeJ8k41UAZbYtiRYczXJNTsqggTCsC6du7fPIyamHvFSjj7oebDf33 liH51zqxpxpYmPP1jhWP65+ah/0YLL7CbyFazEQhM231XG7rgv+7zBqCULFBQCcX u9MkyBcGWVEycLuJzWogLFrstkKfxxQ4oddq8ma+OR9R4gSouzqbpBEOCJJiUS20 KOvblixRl44OypVKLL1l5BcPxEoTLecGynivxeE1zuko2IE1ooRUQcyToK2espZ1 iIHy02jkvm2g3DgGJUu/vsweWvJQ1I9rAMqHZuabDVAEFNeLG/sV0sHukto+KClJ wIIJfy8F5hGtYPQyW+0n =H1Xa -----END PGP SIGNATURE----- --=_DoMPcAA0dcoybUqfUpDKJQ2--