From unknown Sun Apr 12 23:50:54 2026 X-Loop: owner@bugs.x2go.org Subject: Bug#585: Fix Reply-To: Ulrich Sibiller , 585@bugs.x2go.org Resent-From: Ulrich Sibiller Original-Sender: ulrich.sibiller@gmail.com Resent-To: x2go-dev@lists.x2go.org Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Tue, 04 Nov 2014 22:55:01 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: followup 585 X-X2Go-PR-Package: nx-libs X-X2Go-PR-Keywords: Received: via spool by 585-submit@bugs.x2go.org id=B585.141514151824608 (code B ref 585); Tue, 04 Nov 2014 22:55:01 +0000 Received: (at 585) by bugs.x2go.org; 4 Nov 2014 22:51:58 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from mail-lb0-f174.google.com (mail-lb0-f174.google.com [209.85.217.174]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 8E33A5DB48 for <585@bugs.x2go.org>; Tue, 4 Nov 2014 23:51:56 +0100 (CET) Received: by mail-lb0-f174.google.com with SMTP id p9so1098847lbv.19 for <585@bugs.x2go.org>; Tue, 04 Nov 2014 14:51:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:from:date:message-id:subject:to:content-type; bh=Empm84Iw8OuxDo81lCo1c5+XEBRKRSANbQ5/7e5TtQk=; b=UAIJMzOElQGysGvo3OCdedHfirgG/IvdcbPasmCRKmZEDK9WnznTUKyhbms6EOqqsW FY9qeLUvrp571kRotdyuGVAmhWwqZkeCC3KTlt32lQFiCtRO9OtHZ79CSRCfAXa43NFM XBMZhsj1odBjbKwEWLeC4tWVVr+yZAkvEZbw/YA/p+UPeqnlYk/xSSIzTk41Maxrqlwh wcu/igFp9CGDYJfftEwFT3o0GOIv4gANhjCP4NGo/RWu3R1oaNY5hHOLj3uIQokFzh3M g8EtdKeLJwDjGQQp16P9tzamE7uC2Zsxpfp8GJoHpSluXerWHRUiFZjKonOe4ks8tDG7 dt5g== X-Received: by 10.112.131.33 with SMTP id oj1mr8851074lbb.97.1415141515870; Tue, 04 Nov 2014 14:51:55 -0800 (PST) MIME-Version: 1.0 Sender: ulrich.sibiller@gmail.com Received: by 10.112.180.197 with HTTP; Tue, 4 Nov 2014 14:51:35 -0800 (PST) From: Ulrich Sibiller Date: Tue, 4 Nov 2014 23:51:35 +0100 X-Google-Sender-Auth: Fq3kZb2T8K1-fsnvCABpcCogxr0 Message-ID: To: 585@bugs.x2go.org Content-Type: multipart/mixed; boundary=047d7b343a325c5cf50507104fe2 --047d7b343a325c5cf50507104fe2 Content-Type: text/plain; charset=UTF-8 Without XFIXES the client calls GetSelectionOwner() before every paste operation and therefor always knows the current selection owner. With XFIXES some clients rely solely on the XFixesSelectSelectionInput/XFixesSelectionNotify mechanism. But they never receive any notifications because the nxagent does not register at the real X server to receive those notifications itself and so never gets anything to forward to the clients. A client assuming it will get informed about owner changes skips the GetSelectionOwner() call. So it never knows that the selection owner has changed and refers to what it thinks the current owner is (itself). Attached is a fix for this bug. nxagent calls XFixesSelectSelectionInput for all its selections (t.i. CLIPBOARD and PRIMARY, _not_ SECONDARY) now. It (still) does not check the return code but the original code registering only CLIPBOARD did neither... This is a complete patch generated by git format-patch after using (d)quilt as documented in the wiki. As I did not find any hints of what patch number to choose I took 207 to put it as close as possible to other clipboard related patches. Feel free to change that... Uli --047d7b343a325c5cf50507104fe2 Content-Type: text/plain; charset=US-ASCII; name="fix_585.diff" Content-Disposition: attachment; filename="fix_585.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i23tllbi0 RnJvbSBmYTI5NGNjMDIwZDI4NWRmNjI4NjE5NWZkNDM1YzVjMzg2MjU3NzExIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBVbHJpY2ggU2liaWxsZXIgPHVsaTQyQGdteC5kZT4KRGF0ZTog VHVlLCA0IE5vdiAyMDE0IDIyOjI0OjE5ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gQWRkIDIwN19u eGFnZW50X2ZpeC14Zml4ZXMtc2VsZWN0aW9uLmZ1bGwucGF0Y2guIEZpeAogc2VsZWN0aW9uIGhh bmRsaW5nIHdoZW4gWEZJWEVTIGlzIGVuYWJsZWQuIChGaXhlczogIzU4NSkuCgotLS0KIGRlYmlh bi9jaGFuZ2Vsb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgIDQgKysrCiAu Li4vMjA3X254YWdlbnRfZml4LXhmaXhlcy1zZWxlY3Rpb24uZnVsbC5wYXRjaCAgICB8IDMyICsr KysrKysrKysrKysrKysrKysrKysKIGRlYmlhbi9wYXRjaGVzL3NlcmllcyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHwgIDEgKwogMyBmaWxlcyBjaGFuZ2VkLCAzNyBpbnNlcnRpb25zKCsp CiBjcmVhdGUgbW9kZSAxMDA2NDQgZGViaWFuL3BhdGNoZXMvMjA3X254YWdlbnRfZml4LXhmaXhl cy1zZWxlY3Rpb24uZnVsbC5wYXRjaAoKZGlmZiAtLWdpdCBhL2RlYmlhbi9jaGFuZ2Vsb2cgYi9k ZWJpYW4vY2hhbmdlbG9nCmluZGV4IDc2NmRiNTIuLjAzNTZiZjggMTAwNjQ0Ci0tLSBhL2RlYmlh bi9jaGFuZ2Vsb2cKKysrIGIvZGViaWFuL2NoYW5nZWxvZwpAQCAtMzcsNiArMzcsMTAgQEAgbngt bGlicyAoMjozLjUuMC4yOC0weDJnbzEpIFVOUkVMRUFTRUQ7IHVyZ2VuY3k9bWVkaXVtCiAgICog QWRkIDQwMF9ueGNvbXAtdmVyc2lvbi5mdWxsK2xpdGUucGF0Y2guIEFsbG93IDQtZGlnaXQgdmVy c2lvbiBjb21wYXJpc29uCiAgICAgZHVyaW5nIE5YIHNlc3Npb24gaGFuZHNoYWtlLiAoRml4ZXM6 ICM2MTApLgogCisgIFsgVWxyaWNoIFNpYmlsbGVyIF0KKyAgKiBBZGQgMjA3X254YWdlbnRfZml4 LXhmaXhlcy1zZWxlY3Rpb24uZnVsbC5wYXRjaC4gRml4IHNlbGVjdGlvbiBoYW5kbGluZworICAg IHdoZW4gWEZJWEVTIGlzIGVuYWJsZWQuIChGaXhlczogIzU4NSkKKwogIC0tIE1pa2UgR2Ficmll bCA8bWlrZS5nYWJyaWVsQGRhcy1uZXR6d2Vya3RlYW0uZGU+ICBNb24sIDMwIEp1biAyMDE0IDE1 OjA1OjU0ICswMjAwCiAKIG54LWxpYnMgKDI6My41LjAuMjctMHgyZ28xKSB1bnN0YWJsZTsgdXJn ZW5jeT1tZWRpdW0KZGlmZiAtLWdpdCBhL2RlYmlhbi9wYXRjaGVzLzIwN19ueGFnZW50X2ZpeC14 Zml4ZXMtc2VsZWN0aW9uLmZ1bGwucGF0Y2ggYi9kZWJpYW4vcGF0Y2hlcy8yMDdfbnhhZ2VudF9m aXgteGZpeGVzLXNlbGVjdGlvbi5mdWxsLnBhdGNoCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAuLjBlZTc0ZTUKLS0tIC9kZXYvbnVsbAorKysgYi9kZWJpYW4vcGF0Y2hlcy8yMDdf bnhhZ2VudF9maXgteGZpeGVzLXNlbGVjdGlvbi5mdWxsLnBhdGNoCkBAIC0wLDAgKzEsMzIgQEAK K0Rlc2NyaXB0aW9uOiBGaXggWEZJWEVTIHNlbGVjdGlvbiBoYW5kbGluZyAoY29weSBhbmQgcGFz dGUgdmlhIG1pZGRsZQorIG1vdXNlIGJ1dHRvbikuIFdoZW4gbnhhZ2VudCBoYXMgdGhlIFhGSVhF UyBleHRlbnNpb24gZW5hYmxlZCBjb3B5IGFuZAorIHBhc3RlIGZyb20gb3V0c2lkZSBhcHBsaWNh dGlvbnMgdG8gYXBwbGljYXRpb25zIHdpdGhpbiB0aGUgc2Vzc2lvbgorIHRoYXQgcmVseSBvbiBY Rml4ZXNTZWxlY3RTZWxlY3Rpb25JbnB1dCAoZS5nLiBxdCBhcHBsaWNhdGlvbnMgbGlrZQorIGtv bnNvbGUpIGRpZCBuZXZlciByZWNlaXZlIGFueSBub3RpZmljYXRpb25zIGJlY2F1c2UgdGhlIG54 YWdlbnQgZGlkCisgbm90IHJlZ2lzdGVyIGl0c2VsZiBhdCB0aGUgcmVhbCBYIHNlcnZlciB0byBy ZWNlaXZlIHRoZW0uIEZpeGVzIEJ1ZworICM1ODUuCitBdXRob3I6IFVscmljaCBTaWJpbGxlciA8 dWxpNDJAZ214LmRlPgorCitJbmRleDogbngtbGlicy9ueC1YMTEvcHJvZ3JhbXMvWHNlcnZlci9o dy9ueGFnZW50L0NsaXBib2FyZC5jCis9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09CistLS0gbngtbGlicy5vcmlnL254LVgx MS9wcm9ncmFtcy9Yc2VydmVyL2h3L254YWdlbnQvQ2xpcGJvYXJkLmMJMjAxNC0xMS0wNCAyMjo0 Mjo1MC44OTM1Njk2MjQgKzAxMDAKKysrKyBueC1saWJzL254LVgxMS9wcm9ncmFtcy9Yc2VydmVy L2h3L254YWdlbnQvQ2xpcGJvYXJkLmMJMjAxNC0xMS0wNCAyMjo0Mjo1MC44OTM1Njk2MjQgKzAx MDAKK0BAIC0xNTU2LDEwICsxNTU2LDE0IEBACisgICAgIGZwcmludGYoc3RkZXJyLCAibnhhZ2Vu dEluaXRDbGlwYm9hcmQ6IFJlZ2lzdGVyaW5nIGZvciBYRml4ZXNTZWxlY3Rpb25Ob3RpZnkgZXZl bnRzLlxuIik7CisgICAgICNlbmRpZgorCistICAgIFhGaXhlc1NlbGVjdFNlbGVjdGlvbklucHV0 KG54YWdlbnREaXNwbGF5LCBpV2luZG93LCBueGFnZW50Q2xpcGJvYXJkQXRvbSwKKy0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgWEZpeGVzU2V0U2VsZWN0aW9uT3duZXJOb3RpZnlNYXNr IHwKKy0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgWEZpeGVzU2VsZWN0aW9uV2luZG93 RGVzdHJveU5vdGlmeU1hc2sgfAorLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBYRml4 ZXNTZWxlY3Rpb25DbGllbnRDbG9zZU5vdGlmeU1hc2spOworKyAgICBmb3IgKGkgPSAwOyBpIDwg bnhhZ2VudE1heFNlbGVjdGlvbnM7IGkrKykKKysgICAgeworKyAgICAgIFhGaXhlc1NlbGVjdFNl bGVjdGlvbklucHV0KG54YWdlbnREaXNwbGF5LCBpV2luZG93LAorKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGxhc3RTZWxlY3Rpb25Pd25lcltpXS5zZWxlY3Rpb24sCisrICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgWEZpeGVzU2V0U2VsZWN0aW9uT3duZXJOb3RpZnlN YXNrIHwKKysgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBYRml4ZXNTZWxlY3Rpb25X aW5kb3dEZXN0cm95Tm90aWZ5TWFzayB8CisrICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgWEZpeGVzU2VsZWN0aW9uQ2xpZW50Q2xvc2VOb3RpZnlNYXNrKTsKKysgICAgfQorCisgICAg IG54YWdlbnRYRml4ZXNJbmZvLkluaXRpYWxpemVkID0gMTsKKyAgIH0KZGlmZiAtLWdpdCBhL2Rl Ymlhbi9wYXRjaGVzL3NlcmllcyBiL2RlYmlhbi9wYXRjaGVzL3NlcmllcwppbmRleCAzYTM3YWM1 Li40ZTc5MmEyIDEwMDY0NAotLS0gYS9kZWJpYW4vcGF0Y2hlcy9zZXJpZXMKKysrIGIvZGViaWFu L3BhdGNoZXMvc2VyaWVzCkBAIC01MCw2ICs1MCw3IEBACiAyMDRfbnhhZ2VudF9yZXBhaW50LXNv bGlkcGljdC5mdWxsLnBhdGNoCiAyMDVfbnhhZ2VudF9yZWZyZXNoLWFkc2wuZnVsbC5wYXRjaAog MjA2X254YWdlbnRfY2xpcGJvYXJkLWFzLW54b3B0aW9uLmZ1bGwucGF0Y2gKKzIwN19ueGFnZW50 X2ZpeC14Zml4ZXMtc2VsZWN0aW9uLmZ1bGwucGF0Y2gKIDIwOV94MmdvYWdlbnRfYWRkLW1hbi1w YWdlLmZ1bGwucGF0Y2gKIDIxMF9ueGFnZW50X3NhdmVfc2Vzc2lvbl9zdGF0ZS5mdWxsLnBhdGNo CiAyMTBfbnhjb21wX3NhdmVfc2Vzc2lvbl9zdGF0ZS5mdWxsK2xpdGUucGF0Y2gKLS0gCjEuOS4x Cgo= --047d7b343a325c5cf50507104fe2--