From gabemarcano@yahoo.com  Wed Aug 20 05:26:04 2014
Received: (at submit) by bugs.x2go.org; 20 Aug 2014 03:26:06 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,
	T_DKIM_INVALID autolearn=ham version=3.3.2
Received: from nm13-vm5.bullet.mail.ne1.yahoo.com (nm13-vm5.bullet.mail.ne1.yahoo.com [98.138.91.235])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id B1CEA5DB11
	for <submit@bugs.x2go.org>; Wed, 20 Aug 2014 05:26:03 +0200 (CEST)
Received: from [98.138.100.115] by nm13.bullet.mail.ne1.yahoo.com with NNFMP; 20 Aug 2014 03:26:01 -0000
Received: from [98.138.89.199] by tm106.bullet.mail.ne1.yahoo.com with NNFMP; 20 Aug 2014 03:26:01 -0000
Received: from [127.0.0.1] by omp1057.mail.ne1.yahoo.com with NNFMP; 20 Aug 2014 03:26:01 -0000
X-Yahoo-Newman-Property: ymail-3
X-Yahoo-Newman-Id: 930882.80504.bm@omp1057.mail.ne1.yahoo.com
Received: (qmail 33761 invoked by uid 60001); 20 Aug 2014 03:26:01 -0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1408505161; bh=YC1mYz0vTc14E3WsSbkdhKiQezRQAif99m+dahgm4ZQ=; h=References:Message-ID:Date:From:Reply-To:Subject:To:MIME-Version:Content-Type; b=ZUUVEOE+v971zBPSZOgCBGJ/vDId4KWnTUuqfW3hWla7g6wqPnzdcPHgaPvQh4St4AeFpZChGy19iDTpXVfFmIiIe7pvYRRDogFuStOgvuw8xCs8bFUoDLJz6jRtjj24dcQRWtxpMEuNIg4ghNHPQfklp3J7Tstitg/F80DIXwo=
X-YMail-OSG: LCKKMfgVM1k6Zy6v70eoGirprsKiUbGXvg0mEXpLhUW3HRg
 PVkBFwBqpi6VYHGYi8BsnFAL3c3yMHwCkvSq0fW_kX0RmvjeZhekK.Kt5NjM
 sxifzo3IMecH724dJs_2UFrrvkBZTmoNEZvZmQSOZYV09zwOsLVLWIji05Zb
 3sw8vja3DbXNt8NgCGl9ie0q1gek0gOhB01XxA5ebabSpIs48yY5Z9RypAC_
 dWqWaBHmotdwaw6KKRbgLffp.tjvOcGcVF04BQZa6SvQHCMQQRwzD0ulm4um
 cyDMf7EfQMrUou40hTuFbV3tbPFy1_GzM6XQnJ1a7WbdfUDzsuyrgURdK1PV
 6Y7Ks1nkredFDO10smbisRcdaZsciut9RiPGZRxtz2FFjyx3Tjdd05nW_tn8
 3lOJjX1zQq512TrzDxbZcNav0t7n3g0B_Drltwf.L8nbkEkEIKeWy66pBqTS
 YpEaRjxQuyA0Ik8lrPzMGNu2wcUzBY2wvyO9oK8AhHr0Jduo7BUmVWgVFo1e
 JD2B5Gu0Ac_kzvaC3wgJ.89tg7iLTEkvEAmB.dHmkeERbPUjFfWtS4IxpuId
 8pT6zexY1tlcZQm9hWX9cZDyd9Spp0G31k3F4eZ08GPDfCLVkTG7waKozdDJ
 ZeU3ZDHojm32YYA5jwRla96eWCEiBtJ61W0ikxFU2ps4n0tb7WMJX_KI-
Received: from [68.187.217.134] by web125206.mail.ne1.yahoo.com via HTTP; Tue, 19 Aug 2014 20:26:01 PDT
X-Rocket-MIMEInfo: 002.001,UGFja2FnZTogbngtbGlicwpWZXJzaW9uOiBIRUFEClRhZ3M6IFBhdGNoCgpGb3VuZCB0aGlzIHByb2JsZW0gd2hpbGUgYnJvd3Npbmc6CgrCoMKgwqAgaHR0cHM6Ly9idWdzLmdlbnRvby5vcmcvc2hvd19idWcuY2dpP2lkPTQ4MTM2MAoKCkNvbXBpbGluZyBueC1saWJzIGFnYWluc3QganBlZy05YSBsZWFkcyB0byBhIGNvbXBpbGF0aW9uIGVycm9yLiBTcGVjaWZpY2FsbHk6CgrCoMKgwqAgZysrIC1jIC1PMyAtZm5vLXJ0dGkgLWZuby1leGNlcHRpb25zIC1JLi4vbngtWDExL2V4cG9ydHMvaW5jbHVkZQrCoAEwAQEBAQ--
X-Mailer: YahooMailWebService/0.8.201.700
References: 
Message-ID: <1408505140.1532.YahooMailNeo@web125206.mail.ne1.yahoo.com>
Date: Tue, 19 Aug 2014 20:25:40 -0700
From: Gabriel Marcano <gabemarcano@yahoo.com>
Reply-To: Gabriel Marcano <gabemarcano@yahoo.com>
Subject: nx-libs, Jpeg.cpp compilation error with jpeg-9a, with suggested patch
To: "submit@bugs.x2go.org" <submit@bugs.x2go.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="-2097669038-308448619-1408505161=:1532"

---2097669038-308448619-1408505161=:1532
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Package: nx-libs=0AVersion: HEAD=0ATags: Patch=0A=0AFound this problem whil=
e browsing:=0A=0A=C2=A0=C2=A0=C2=A0 https://bugs.gentoo.org/show_bug.cgi?id=
=3D481360=0A=0A=0ACompiling nx-libs against jpeg-9a leads to a compilation =
error. Specifically:=0A=0A=C2=A0=C2=A0=C2=A0 g++ -c -O3 -fno-rtti -fno-exce=
ptions -I../nx-X11/exports/include=0A=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0 -Wmissing-declarations -fPIC -DIN_ADDR_T=3Din_addr_t -DVERSION=3D\"3=
.5.0\"=0A=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -DPACKAGE_NAME=3D\"\" -=
DPACKAGE_TARNAME=3D\"\" -DPACKAGE_VERSION=3D\"\"=0A=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0 -DPACKAGE_STRING=3D\"\" -DPACKAGE_BUGREPORT=3D\"\" -DPAC=
KAGE_URL=3D\"\" -Wall=0A=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -Wpointe=
r-arith=C2=A0=C2=A0 Jpeg.cpp=0A=C2=A0=C2=A0=C2=A0 Jpeg.cpp: In function =E2=
=80=98int DecompressJpeg16(unsigned char*, int,=0A=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0 unsigned int, unsigned int, unsigned char*, int)=E2=80=
=99:=0A=C2=A0=C2=A0=C2=A0 Jpeg.cpp:443:29: error: invalid conversion from =
=E2=80=98int=E2=80=99 to =E2=80=98boolean=E2=80=99=0A=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0 [-fpermissive]=0A=C2=A0=C2=A0=C2=A0 jpeg_read_header(=
&cinfo, 1);=0A=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^=0A=C2=A0=C2=A0=C2=A0 =
In file included from Jpeg.cpp:29:0:=0A=C2=A0=C2=A0=C2=A0 /usr/include/jpeg=
lib.h:1039:13: note: initializing argument 2 of =E2=80=98int=0A=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 jpeg_read_header(j_decompress_ptr, boolean)=
=E2=80=99=0A=C2=A0=C2=A0=C2=A0 EXTERN(int) jpeg_read_header JPP((j_decompre=
ss_ptr cinfo,=0A=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^=0A=C2=A0=C2=A0=C2=A0 Jpeg.cpp: In funct=
ion =E2=80=98int DecompressJpeg24(unsigned char*, int,=0A=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0 unsigned int, unsigned int, unsigned char*, int)=
=E2=80=99:=0A=C2=A0=C2=A0=C2=A0 Jpeg.cpp:584:29: error: invalid conversion =
from =E2=80=98int=E2=80=99 to =E2=80=98boolean=E2=80=99=0A=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0 [-fpermissive]=0A=C2=A0=C2=A0=C2=A0 jpeg_read_h=
eader(&cinfo, 1);=0A=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^=0A=C2=A0=C2=A0=
=C2=A0 In file included from Jpeg.cpp:29:0:=0A=C2=A0=C2=A0=C2=A0 /usr/inclu=
de/jpeglib.h:1039:13: note: initializing argument 2 of =E2=80=98int=0A=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 jpeg_read_header(j_decompress_ptr, =
boolean)=E2=80=99=0A=C2=A0=C2=A0=C2=A0 EXTERN(int) jpeg_read_header JPP((j_=
decompress_ptr cinfo,=0A=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^=0A=C2=A0=C2=A0=C2=A0 Jpeg.cpp: In=
 function =E2=80=98int DecompressJpeg32(unsigned char*, int, unsigned=0A=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 int, unsigned int, unsigned char*, =
int)=E2=80=99:=0A=C2=A0=C2=A0=C2=A0 Jpeg.cpp:721:29: error: invalid convers=
ion from =E2=80=98int=E2=80=99 to =E2=80=98boolean=E2=80=99=0A=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [-fpermissive]=0A=C2=A0=C2=A0=C2=A0 jpeg_rea=
d_header(&cinfo, 1);=0A=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^=0A=C2=A0=C2=
=A0=C2=A0 In file included from Jpeg.cpp:29:0:=0A=C2=A0=C2=A0=C2=A0 /usr/in=
clude/jpeglib.h:1039:13: note: initializing argument 2 of =E2=80=98int=0A=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 jpeg_read_header(j_decompress_pt=
r, boolean)=E2=80=99=0A=C2=A0=C2=A0=C2=A0 EXTERN(int) jpeg_read_header JPP(=
(j_decompress_ptr cinfo,=0A=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^=0A=C2=A0=C2=A0=C2=A0 Jpeg.cpp:=
 In function =E2=80=98boolean JpegFillInputBuffer(j_decompress_ptr)=E2=80=
=99:=0A=C2=A0=C2=A0=C2=A0 Jpeg.cpp:836:10: error: invalid conversion from =
=E2=80=98int=E2=80=99 to =E2=80=98boolean=E2=80=99=0A=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0 [-fpermissive]=0A=C2=A0=C2=A0=C2=A0 return 1;=0A=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^=0A=C2=A0=
=C2=A0=C2=A0 Makefile:82: recipe for target 'Jpeg.o' failed=0A=C2=A0=C2=A0=
=C2=A0 make: *** [Jpeg.o] Error 1=0A=0AI am attaching a patch to address th=
e problem. Specifically, it appears that=0Ajpeg-9a changed the definition f=
or its "boolean" type from an int to some other=0A=C2=A0type (bool in C++, =
it seems). Using TRUE and FALSE, as provided by the jpeg=0Alibrary, is what=
 was done to address the problem. After applying the patch=0Ato HEAD (commi=
t 0e3b414ea6ecb6cc359d3b95f5cfeb6096066139), Jpeg.cpp compiles=0Afine.=0A=
=0A=0AConfiguration:=0A=0ACompiling against jpeg-9a.=0A=0A$ gcc -v=0A=C2=A0=
=C2=A0=C2=A0 Using built-in specs.=0A=C2=A0=C2=A0=C2=A0 COLLECT_GCC=3D/usr/=
x86_64-pc-linux-gnu/gcc-bin/4.9.0/gcc=0A=C2=A0=C2=A0=C2=A0 COLLECT_LTO_WRAP=
PER=3D/usr/libexec/gcc/x86_64-pc-linux-gnu/4.9.0/lto-wrapper=0A=C2=A0=C2=A0=
=C2=A0 Target: x86_64-pc-linux-gnu=0A=C2=A0=C2=A0=C2=A0 Configured with: /v=
ar/tmp/portage/sys-devel/gcc-4.9.0/work/gcc-4.9.0/configure=0A=C2=A0=C2=A0=
=C2=A0 --host=3Dx86_64-pc-linux-gnu --build=3Dx86_64-pc-linux-gnu --prefix=
=3D/usr=0A=C2=A0=C2=A0=C2=A0 --bindir=3D/usr/x86_64-pc-linux-gnu/gcc-bin/4.=
9.0=0A=C2=A0=C2=A0=C2=A0 --includedir=3D/usr/lib/gcc/x86_64-pc-linux-gnu/4.=
9.0/include=0A=C2=A0=C2=A0=C2=A0 --datadir=3D/usr/share/gcc-data/x86_64-pc-=
linux-gnu/4.9.0=0A=C2=A0=C2=A0=C2=A0 --mandir=3D/usr/share/gcc-data/x86_64-=
pc-linux-gnu/4.9.0/man=0A=C2=A0=C2=A0=C2=A0 --infodir=3D/usr/share/gcc-data=
/x86_64-pc-linux-gnu/4.9.0/info=0A=C2=A0=C2=A0=C2=A0 --with-gxx-include-dir=
=3D/usr/lib/gcc/x86_64-pc-linux-gnu/4.9.0/include/g++-v4=0A=C2=A0=C2=A0=C2=
=A0 --with-python-dir=3D/share/gcc-data/x86_64-pc-linux-gnu/4.9.0/python=0A=
=C2=A0=C2=A0=C2=A0 --enable-languages=3Dc,c++,fortran --enable-obsolete --e=
nable-secureplt=0A=C2=A0=C2=A0=C2=A0 --disable-werror --with-system-zlib --=
enable-nls --without-included-gettext=0A=C2=A0=C2=A0=C2=A0 --enable-checkin=
g=3Drelease --with-bugurl=3Dhttps://bugs.gentoo.org/=0A=C2=A0=C2=A0=C2=A0 -=
-with-pkgversion=3D'Gentoo 4.9.0 p1.0, pie-0.6.0' --enable-libstdcxx-time=
=0A=C2=A0=C2=A0=C2=A0 --enable-shared --enable-threads=3Dposix --enable-__c=
xa_atexit=0A=C2=A0=C2=A0=C2=A0 --enable-clocale=3Dgnu --enable-multilib --w=
ith-multilib-list=3Dm32,m64=0A=C2=A0=C2=A0=C2=A0 --disable-altivec --disabl=
e-fixed-point --enable-targets=3Dall=0A=C2=A0=C2=A0=C2=A0 --disable-libgcj =
--enable-libgomp --disable-libmudflap --disable-libssp=0A=C2=A0=C2=A0=C2=A0=
 --enable-lto --without-cloog=0A=C2=A0=C2=A0=C2=A0 Thread model: posix=0A=
=C2=A0=C2=A0=C2=A0 gcc version 4.9.0 (Gentoo 4.9.0 p1.0, pie-0.6.0)=0A=0A$ =
autoreconf --version=0A=C2=A0=C2=A0=C2=A0 autoreconf (GNU Autoconf) 2.69=0A=
=0A=0ASteps to reproduce:=0A=0A1. "git clone git://code.x2go.org/nx-libs.gi=
t" repository.=0A2. Change to the "nxcomp" directory.=0A3. Run "autoreconf"=
 and then do "make Jpeg.o".=0A=0AExpected outcome:=0ASuccessful compilation=
.=0A=0AActual outcome:=0ACompilation failure, see earlier in the report for=
 the error messages.
---2097669038-308448619-1408505161=:1532
Content-Type: text/x-patch; name="nxlibs-jpeg9a.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="nxlibs-jpeg9a.patch"

LS0tIG54Y29tcC9KcGVnLmNwcC5vcmlnCTIwMTQtMDgtMTkgMjI6MjM6MzYu
MTM5MDcyNDAwIC0wNDAwCisrKyBueGNvbXAvSnBlZy5jcHAJMjAxNC0wOC0x
OSAyMjoyNToyNC4zMjMxODI4MDAgLTA0MDAKQEAgLTQ0MCw3ICs0NDAsNyBA
QAogCiAgIEpwZWdTZXRTcmNNYW5hZ2VyKCZjaW5mbywgY29tcHJlc3NlZERh
dGEsIGNvbXByZXNzZWRMZW4pOwogCi0gIGpwZWdfcmVhZF9oZWFkZXIoJmNp
bmZvLCAxKTsKKyAganBlZ19yZWFkX2hlYWRlcigmY2luZm8sIFRSVUUpOwog
CiAgIGlmIChqcGVnRXJyb3IpIGdvdG8gQWJvcnREZWNvbXByZXNzSnBlZzE2
OwogCkBAIC01ODEsNyArNTgxLDcgQEAKIAogICBKcGVnU2V0U3JjTWFuYWdl
cigmY2luZm8sIGNvbXByZXNzZWREYXRhLCBjb21wcmVzc2VkTGVuKTsKIAot
ICBqcGVnX3JlYWRfaGVhZGVyKCZjaW5mbywgMSk7CisgIGpwZWdfcmVhZF9o
ZWFkZXIoJmNpbmZvLCBUUlVFKTsKIAogICBpZiAoanBlZ0Vycm9yKSBnb3Rv
IEFib3J0RGVjb21wcmVzc0pwZWcyNDsKIApAQCAtNzE4LDcgKzcxOCw3IEBA
CiAKICAgSnBlZ1NldFNyY01hbmFnZXIoJmNpbmZvLCBjb21wcmVzc2VkRGF0
YSwgY29tcHJlc3NlZExlbik7CiAKLSAganBlZ19yZWFkX2hlYWRlcigmY2lu
Zm8sIDEpOworICBqcGVnX3JlYWRfaGVhZGVyKCZjaW5mbywgVFJVRSk7CiAK
ICAgaWYgKGpwZWdFcnJvcikgZ290byBBYm9ydERlY29tcHJlc3NKcGVnMzI7
CiAKQEAgLTgzMyw3ICs4MzMsNyBAQAogICBqcGVnU3JjTWFuYWdlci5ieXRl
c19pbl9idWZmZXIgPSBqcGVnQnVmZmVyTGVuOwogICBqcGVnU3JjTWFuYWdl
ci5uZXh0X2lucHV0X2J5dGUgPSAoSk9DVEVUICopanBlZ0J1ZmZlclB0cjsK
IAotICByZXR1cm4gMTsKKyAgcmV0dXJuIFRSVUU7CiB9CiAKIHN0YXRpYyB2
b2lkIEpwZWdTa2lwSW5wdXREYXRhKGpfZGVjb21wcmVzc19wdHIgY2luZm8s
IGxvbmcgbnVtX2J5dGVzKQo=

---2097669038-308448619-1408505161=:1532--