From unknown Mon Apr 27 22:52:39 2026
X-Loop: owner@bugs.x2go.org
Subject: Bug#566: X2Go issue (in src:x2goclient) has been marked as pending for release
Reply-To: "George Trakatelis" <trakatelis@uom.edu.gr>, 566@bugs.x2go.org
Resent-From: "George Trakatelis" <trakatelis@uom.edu.gr>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Thu, 09 Oct 2014 17:25:01 +0000
Resent-Message-ID: <handler.566.B566.141287524615320@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 566
X-X2Go-PR-Package: x2goclient
X-X2Go-PR-Keywords: pending
Received: via spool by 566-submit@bugs.x2go.org id=B566.141287524615320
          (code B ref 566); Thu, 09 Oct 2014 17:25:01 +0000
Received: (at 566) by bugs.x2go.org; 9 Oct 2014 17:20:46 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID
	autolearn=ham version=3.3.2
Received: from mail-wg0-f47.google.com (mail-wg0-f47.google.com [74.125.82.47])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 93ECE5DB16
	for <566@bugs.x2go.org>; Thu,  9 Oct 2014 19:20:44 +0200 (CEST)
Received: by mail-wg0-f47.google.com with SMTP id x13so1888995wgg.30
        for <566@bugs.x2go.org>; Thu, 09 Oct 2014 10:20:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=uom.edu.gr; s=google;
        h=from:to:cc:references:in-reply-to:subject:date:message-id
         :mime-version:content-type:thread-index:content-language;
        bh=HMZRobBOuyIklkzI9jF0HnRlw4+dqtm81VcaXan0MmY=;
        b=JHeXtL/CVZUSCvzVPm5h3SfwDdOV2JLwYCbyPVURKdt0X9/yVLpAG1oDEgYAM3dRFx
         j/Mk8sRg02EguQEVkV1/kCkJPHeLJcZwFbKdm2Ax4wjsKBV5kP8gR7a3sn6pqqW3jVRT
         znS8c2h7QjNRpb89qOVOIMidNobDCbo025jR0=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:from:to:cc:references:in-reply-to:subject:date
         :message-id:mime-version:content-type:thread-index:content-language;
        bh=HMZRobBOuyIklkzI9jF0HnRlw4+dqtm81VcaXan0MmY=;
        b=dQd8UcFU0DbnEONt1vIF9yn0Yq5aYm0/FQKAFPhO5+2XD1p7A3IskQzDA081cV+CZJ
         5h71uidlSaTYxiWiJMdrnOc32sXPm3LJwQDtP3ZlZtyFwphFh+xDyScxrkXwgQkEg2Rx
         yVAkH5zGnW/DdiDpJFgrZJkzncWXgljnxWh32tWiqTLwcybo4R9n9aTlchdrrFYFHzrJ
         HGNhxOnTOom0gt5/g9XNw0nRjT22VlMqnMwatX/Tf+VPTxPzYFesXuZCUhh41TdRRs1B
         wuPHUaPCNaxXjTU6xKzqAvOfvEUv8Ne1NG6yyIpCkkD2lBClCcTNJZG3j62RpzVyMFRv
         H5GQ==
X-Gm-Message-State: ALoCoQmZDDodmk7XzTXHf7N957rrV7ztdA8+oa9OiCE4tpHIf1d24uzxuG+1pHtgnzuEhX3dg5na
X-Received: by 10.180.75.229 with SMTP id f5mr5530730wiw.81.1412875244194;
        Thu, 09 Oct 2014 10:20:44 -0700 (PDT)
Received: from HomePC (46-4-59.adsl.cyta.gr. [46.103.4.59])
        by mx.google.com with ESMTPSA id ic4sm15489174wid.19.2014.10.09.10.20.42
        for <multiple recipients>
        (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);
        Thu, 09 Oct 2014 10:20:43 -0700 (PDT)
From: "George Trakatelis" <trakatelis@uom.edu.gr>
To: <566@bugs.x2go.org>
Cc: "'Mike DePaulo'" <mikedep333@gmail.com>
References: <20140917114415.E89B45DB35@ymir.das-netzwerkteam.de>
In-Reply-To: <20140917114415.E89B45DB35@ymir.das-netzwerkteam.de>
Date: Thu, 9 Oct 2014 20:20:41 +0300
Message-ID: <000001cfe3e5$5b2a52b0$117ef810$@edu.gr>
MIME-Version: 1.0
Content-Type: multipart/mixed;
	boundary="----=_NextPart_000_0001_01CFE3FE.80778AB0"
X-Mailer: Microsoft Office Outlook 12.0
Thread-Index: Ac/SbOxPZbA3kN3dRXmXM5VmsrxkzARdiupw
Content-Language: el

This is a multi-part message in MIME format.

------=_NextPart_000_0001_01CFE3FE.80778AB0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Dear Michael,=20

With regard to bug #566 and proposed patch bug566.test.v2.patch,=20
please review a minor addition of mine to the aforementioned patch=20
which aids debugging of x2goclient.=20

With bug566.test.v2.patch applied,=20
SSH_OPTIONS_SSH_DIR is correctly set in X2GoFree for Windows=20
but its new value is not passed to x2goDebug.=20
Attached bug566.aid-debugging.patch corrects just that.=20

-- George


-----Original Message-----
From: Mike DePaulo [mailto:mikedep333@gmail.com]=20
Sent: Wednesday, September 17, 2014 2:44 PM
To: 566-submitter@bugs.x2go.org
Cc: control@bugs.x2go.org; 566@bugs.x2go.org
Subject: Bug#566: X2Go issue (in src:x2goclient) has been marked as =
pending for release

tag #566 pending
fixed #566 4.0.3.0
thanks

Hello,

X2Go issue #566 (src:x2goclient) reported by you has been fixed in X2Go =
Git.=20

You can see the changelog below, and you can check the diff of the fix =
at:

    =
http://code.x2go.org/gitweb?p=3Dx2goclient.git;a=3Dcommitdiff;h=3D0e3aff0=


The issue will most likely be fixed in src:x2goclient (4.0.3.0).

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
commit 0e3aff054195de9eb09e7c280aca017f9e891c10
Author: Mike DePaulo <mikedep333@gmail.com>
Date:   Wed Sep 17 07:44:07 2014 -0400

    Update changelog: Last commit (2ffcad0) fixes bug #566

diff --git a/debian/changelog b/debian/changelog index a58e2b3..00ff9c3 =
100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -45,7 +45,7 @@ x2goclient (4.0.3.0-0x2go1) UNRELEASED; urgency=3Dlow
   [ Mike DePaulo ]
   * New upstream release (4.0.3.0):
     - Windows: Fix not being able to add the server to the known_hosts =
file when
-      the username has non-English characters.
+      the username has non-English characters. (Fixes: #566)
       (NOTE: This fix only works when the non-English characters are in =
the same
       language as the Windows "system locale" AKA "Language for =
non-Unicode
       programs." Bug #611 was written for fixing the issue for =
languages other

------=_NextPart_000_0001_01CFE3FE.80778AB0
Content-Type: application/octet-stream;
	name="bug566.aid-debugging.patch"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
	filename="bug566.aid-debugging.patch"

diff --git a/sshmasterconnection.cpp b/sshmasterconnection.cpp=0A=
index 8c89194..c3f78d7 100755=0A=
--- a/sshmasterconnection.cpp=0A=
+++ b/sshmasterconnection.cpp=0A=
@@ -519,6 +519,9 @@ void SshMasterConnection::run()=0A=
 =0A=
 #ifdef Q_OS_WIN=0A=
     ssh_options_set ( my_ssh_session, SSH_OPTIONS_SSH_DIR, =
(mainWnd->getHomeDirectory()+"/ssh").toLocal8Bit());=0A=
+#ifdef DEBUG=0A=
+    x2goDebug<<"setting SSH DIR to =
"<<(mainWnd->getHomeDirectory()+"/ssh").toLocal8Bit();=0A=
+#endif=0A=
     if (kerberos)=0A=
     {=0A=
         parseKnownHosts();=0A=
@@ -635,7 +638,7 @@ void SshMasterConnection::run()=0A=
 #ifdef Q_OS_WIN=0A=
     ssh_options_set ( my_ssh_session, SSH_OPTIONS_SSH_DIR, =
(mainWnd->getHomeDirectory()+"/ssh").toLocal8Bit());=0A=
 #ifdef DEBUG=0A=
-    x2goDebug<<"setting SSH DIR to =
"<<mainWnd->getHomeDirectory()+"/ssh";=0A=
+    x2goDebug<<"setting SSH DIR to =
"<<(mainWnd->getHomeDirectory()+"/ssh").toLocal8Bit();=0A=
 #endif=0A=
 #endif=0A=
 =0A=

------=_NextPart_000_0001_01CFE3FE.80778AB0--
