From unknown Thu Mar 28 23:04:12 2024 X-Loop: owner@bugs.x2go.org Subject: Bug#559: x2goclient: the local user name that is passed to x2gomountdirs command needs to be enclosed in quotation marks Reply-To: Rok Mandeljc , 559@bugs.x2go.org Resent-From: Rok Mandeljc Resent-To: x2go-dev@lists.x2go.org Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Mon, 28 Jul 2014 20:15:01 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: report 559 X-X2Go-PR-Package: x2goclient X-X2Go-PR-Keywords: Received: via spool by submit@bugs.x2go.org id=B.140657827521288 (code B); Mon, 28 Jul 2014 20:15:01 +0000 Received: (at submit) by bugs.x2go.org; 28 Jul 2014 20:11:15 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=ham version=3.3.2 Received: from mail-we0-f176.google.com (mail-we0-f176.google.com [74.125.82.176]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 7CD2A5DB52 for ; Mon, 28 Jul 2014 22:11:13 +0200 (CEST) Received: by mail-we0-f176.google.com with SMTP id q58so7949039wes.35 for ; Mon, 28 Jul 2014 13:11:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject :content-type; bh=2tLXrs9ymn6KN8vfbjhLpdIZeIPMJMHHsNjtP/c44SU=; b=Ud2OPIwwEQK41O6qjRrBme+HOXlRjva7++zeSBcTOJna1RNwyY1hpKTir1afpzbIzT dzNflYUgNo6+q0b0N0k1mlCM5uoHb1URJWmSack4mxl/+RtYdIhZ0L7LVCLdi2k1AxWA d/LjCiZS4dXZuZMIuwO3rK+LLNrWzXYu/UKN4hMuhtptqFERMCGdXbnMqm9cFnX0s9SV UUclQWL3OSN3wvaHrGi8kMmnIvryu1TgGb9bDXBcdDwqJLFlFZN7rczzbZhwWwCc/isx TpiGUQpX/QvoTji0HELX8z19UiTwdtDyRrb/Zdf0xFcmcmLkvEvnXfMUNJTexe8qnJXk LiDA== X-Received: by 10.180.99.102 with SMTP id ep6mr34671985wib.1.1406578272207; Mon, 28 Jul 2014 13:11:12 -0700 (PDT) Received: from [172.24.1.101] (BSN-143-119-239.dial-up.dsl.siol.net. [89.143.119.239]) by mx.google.com with ESMTPSA id lg7sm36426556wjb.9.2014.07.28.13.11.10 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 28 Jul 2014 13:11:11 -0700 (PDT) Message-ID: <53D6AE5D.5010107@gmail.com> Date: Mon, 28 Jul 2014 22:11:09 +0200 From: Rok Mandeljc User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: submit@bugs.x2go.org Content-Type: multipart/mixed; boundary="------------050208050306070000040809" This is a multi-part message in MIME format. --------------050208050306070000040809 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Package: x2goclient Version: 4.0.2.1+hotfix1 In startX2goMount(), the local user name (cuser) is passed as the third argument to the x2gomountdirs command that will be executed on the server side. This user name should be enclosed in quotation marks, otherwise the x2gomountdirs on server side fails for users who are unfortunate enough to have put a whitespace character in their Windows user name. --------------050208050306070000040809 Content-Type: text/x-patch; name="0001-startX2goMount-insert-quotation-marks-around-the-loc.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-startX2goMount-insert-quotation-marks-around-the-loc.pa"; filename*1="tch" >From 8e51e6835b2935777e83adb1823a7bbd37bbede0 Mon Sep 17 00:00:00 2001 From: Rok Mandeljc Date: Mon, 28 Jul 2014 21:51:12 +0200 Subject: [PATCH] startX2goMount(): insert quotation marks around the local user name (cuser) that is passed to x2gomountdirs command Unquoted user name means that the server-side x2gomountdirs command will fail for users who are unfortunate enough to have put a whitespace character in their Windows user name. Signed-off-by: Rok Mandeljc --- onmainwindow.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/onmainwindow.cpp b/onmainwindow.cpp index 8acec61..7751c69 100644 --- a/onmainwindow.cpp +++ b/onmainwindow.cpp @@ -9230,11 +9230,11 @@ void ONMainWindow::startX2goMount() dirs=dirs+"__REVERSESSH_PORT__"+resumingSession.fsPort; } if ( !rem ) - cmd="export HOSTNAME && x2gomountdirs dir "+sessionId+" "+cuser+ - " "+dir->dstKey+" "+dirs; + cmd="export HOSTNAME && x2gomountdirs dir "+sessionId+" \""+cuser+ + "\" "+dir->dstKey+" "+dirs; else - cmd="export HOSTNAME && x2gomountdirs rem "+sessionId+" "+cuser+ - " "+dir->dstKey+" "+dirs; + cmd="export HOSTNAME && x2gomountdirs rem "+sessionId+" \""+cuser+ + "\" "+dir->dstKey+" "+dirs; #ifdef Q_OS_WIN -- 1.9.3 --------------050208050306070000040809-- From unknown Thu Mar 28 23:04:12 2024 X-Loop: owner@bugs.x2go.org Subject: Bug#559: [X2Go-Dev] Bug#559: x2goclient: the local user name that is passed to x2gomountdirs command needs to be enclosed in quotation marks Reply-To: "Andy Sinatra" , 559@bugs.x2go.org Resent-From: "Andy Sinatra" Resent-To: x2go-dev@lists.x2go.org Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Tue, 29 Jul 2014 15:25:02 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: followup 559 X-X2Go-PR-Package: x2goclient X-X2Go-PR-Keywords: Received: via spool by 559-submit@bugs.x2go.org id=B559.140664720525987 (code B ref 559); Tue, 29 Jul 2014 15:25:02 +0000 Received: (at 559) by bugs.x2go.org; 29 Jul 2014 15:20:05 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=ham version=3.3.2 X-Greylist: delayed 436 seconds by postgrey-1.34 at ymir.das-netzwerkteam.de; Tue, 29 Jul 2014 17:20:03 CEST Received: from p3plsmtpa12-04.prod.phx3.secureserver.net (p3plsmtpa12-04.prod.phx3.secureserver.net [68.178.252.233]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id E85E45DB52 for <559@bugs.x2go.org>; Tue, 29 Jul 2014 17:20:03 +0200 (CEST) Received: from Andy ([71.177.137.146]) by p3plsmtpa12-04.prod.phx3.secureserver.net with id YFCl1o00N39hvvr01FClBY; Tue, 29 Jul 2014 08:12:46 -0700 From: "Andy Sinatra" To: "'Rok Mandeljc'" , <559@bugs.x2go.org> References: <53D6AE5D.5010107@gmail.com> In-Reply-To: <53D6AE5D.5010107@gmail.com> Date: Tue, 29 Jul 2014 08:12:44 -0700 Message-ID: <007501cfab3f$8d9c8c10$a8d5a430$@pertronix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 15.0 Thread-Index: AQH99W1a1szdXYzeTnBPuwCu0Ee3Kptakm2g Content-Language: en-us I checked my logs and this fits with my issue earlier this month (Bug #550) Pyhoca-gtk uses my Windows User with the space, x2Goclient for Windows only passes the first portion of my username for sshfs. Andy Sinatra -----Original Message----- From: x2go-dev-bounces@lists.x2go.org [mailto:x2go-dev-bounces@lists.x2go.org] On Behalf Of Rok Mandeljc Sent: Monday, July 28, 2014 1:11 PM To: submit@bugs.x2go.org Subject: [X2Go-Dev] Bug#559: x2goclient: the local user name that is passed to x2gomountdirs command needs to be enclosed in quotation marks Package: x2goclient Version: 4.0.2.1+hotfix1 In startX2goMount(), the local user name (cuser) is passed as the third argument to the x2gomountdirs command that will be executed on the server side. This user name should be enclosed in quotation marks, otherwise the x2gomountdirs on server side fails for users who are unfortunate enough to have put a whitespace character in their Windows user name. From unknown Thu Mar 28 23:04:12 2024 X-Loop: owner@bugs.x2go.org Subject: Bug#559: X2Go issue (in src:x2goclient) has been marked as pending for release Reply-To: Mihai Moldovan , 559@bugs.x2go.org Resent-From: Mihai Moldovan Resent-To: x2go-dev@lists.x2go.org Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Tue, 14 Nov 2017 00:35:02 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: followup 559 X-X2Go-PR-Package: x2goclient X-X2Go-PR-Keywords: Received: via spool by 559-submit@bugs.x2go.org id=B559.15106196476767 (code B ref 559); Tue, 14 Nov 2017 00:35:02 +0000 Received: (at 559) by bugs.x2go.org; 14 Nov 2017 00:34:07 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.1 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 837765DAD2; Tue, 14 Nov 2017 01:33:58 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0zzU5SP3Io_R; Tue, 14 Nov 2017 01:33:53 +0100 (CET) Received: by ymir.das-netzwerkteam.de (Postfix, from userid 1005) id 9A5455DACF; Tue, 14 Nov 2017 01:33:53 +0100 (CET) From: Mihai Moldovan To: 559-submitter@bugs.x2go.org Cc: control@bugs.x2go.org, 559@bugs.x2go.org Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Mailer: http://snipr.com/post-receive-tag-pending Message-Id: <20171114003353.9A5455DACF@ymir.das-netzwerkteam.de> Date: Tue, 14 Nov 2017 01:33:53 +0100 (CET) tag #559 pending fixed #559 4.1.1.1 thanks Hello, X2Go issue #559 (src:x2goclient) reported by you has been fixed in X2Go Git. You can see the changelog below, and you can check the diff of the fix at: http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=812753b The issue will most likely be fixed in src:x2goclient (4.1.1.1). light+love X2Go Git Admin (on behalf of the sender of this mail) --- commit 812753b3f1b6b31cf6391440b6768168e66bcbca Author: Mihai Moldovan Date: Tue Nov 14 01:30:01 2017 +0100 src/onmainwindow.cpp: wrap user name for client-side mounts in quotes. Fixes: #559. Will fail with user names that contain quotes, but oh well... diff --git a/debian/changelog b/debian/changelog index afc8103..ded9f24 100644 --- a/debian/changelog +++ b/debian/changelog @@ -32,6 +32,9 @@ x2goclient (4.1.1.1-0x2go1) UNRELEASED; urgency=medium - src/sshmasterconnection.cpp: don't output an empty error message if password authencation has been requested but the server does not support this mechanism. Fixes: #408. + - src/onmainwindow.cpp: wrap user name for client-side mounts in quotes. + Fixes: #559. Will fail with user names that contain quotes, but oh + well... [ Oleksandr Shneyder ] * New upstream version (4.1.1.1): From unknown Thu Mar 28 23:04:12 2024 X-Loop: owner@bugs.x2go.org Subject: Bug#559: X2Go issue (in src:x2goclient) has been marked as closed Reply-To: X2Go Release Manager X2Go Release Manager , 559@bugs.x2go.org Resent-From: X2Go Release Manager X2Go Release Manager Resent-To: x2go-dev@lists.x2go.org Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Thu, 15 Feb 2018 20:45:04 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: followup 559 X-X2Go-PR-Package: x2goclient X-X2Go-PR-Keywords: pending Received: via spool by 559-submit@bugs.x2go.org id=B559.15187273417203 (code B ref 559); Thu, 15 Feb 2018 20:45:04 +0000 Received: (at 559) by bugs.x2go.org; 15 Feb 2018 20:42:21 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.1 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id D208D5DAF0; Thu, 15 Feb 2018 21:42:12 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id W8mlbJLMk6Oz; Thu, 15 Feb 2018 21:42:06 +0100 (CET) Received: by ymir.das-netzwerkteam.de (Postfix, from userid 1005) id 916825DAEB; Thu, 15 Feb 2018 21:42:04 +0100 (CET) From: X2Go Release Manager X2Go Release Manager To: 559-submitter@bugs.x2go.org Cc: control@bugs.x2go.org, 559@bugs.x2go.org Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Message-Id: <20180215204204.916825DAEB@ymir.das-netzwerkteam.de> Date: Thu, 15 Feb 2018 21:42:04 +0100 (CET) close #559 thanks Hello, we are very hopeful that X2Go issue #559 reported by you has been resolved in the new release (4.1.1.1) of the X2Go source project »src:x2goclient«. You can view the complete changelog entry of src:x2goclient (4.1.1.1) below, and you can use the following link to view all the code changes between this and the last release of src:x2goclient. http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=eef4bf3e0e618b15cbf6649e9dbb07d99e57ad00;hp=f0fb9c49b1c30fd025c2c7c9094fa662b8b09b4d If you feel that the issue has not been resolved satisfyingly, feel free to reopen this bug report or submit a follow-up report with further observations described based on the new released version of src:x2goclient. Thanks a lot for contributing to X2Go!!! light+love X2Go Git Admin (on behalf of the sender of this mail) --- X2Go Component: src:x2goclient Version: 4.1.1.1-0x2go1 Status: RELEASE Date: Thu, 15 Feb 2018 21:38:31 +0100 Fixes: 408 559 1122 1209 1214 1227 Changes: x2goclient (4.1.1.1-0x2go1) RELEASED; urgency=medium . [ Mihai Moldovan ] * New upstream version (4.1.1.1): - src/pulsemanager.cpp: print out PA --version output as a debug message. - macbuild.sh: also bundle xauth binary as nxauth binary. - macbuild.sh: switch to bundling PulseAudio 11.1 since it's now available in MacPorts. - src/sshmasterconnection.cpp: don't ask for private key passphrase if auto-login merely failed due to the server denying the public key. Fixes: #1122. - src/{httpbrokerclient,onmainwindow,sshmasterconnection}.{cpp,h}: introduce new passphrase_type enum and replace the old verificationCode boolean value with that. Allows using more messages, including a new one for plain password prompts. Adapt usage accordingly. The implementation is ugly, but there's no good way around that (short of using C++11 features). The enum would really logically belong to ONMainWindow, but since we also have to use it in SshMasterConnection, that may not include onmainwindow.h to avoid a circular dependency, it has to be part of SshMasterConnection for now. - src/sshmasterconnection.cpp: query for password if it wasn't already provided. Fixes: #1122. This usually happens if auto-login is enabled, which bypasses the password prompt. If auto-login fails, authentication normally continues via challenge auth or plain passwords, but since users had no chance to input a password, such authentication will always fail. Give users a way to enter passwords, in case the auto-login failed. - src/onmainwindow.cpp: finally include version information in debug output. - res/i18n/x2goclient_*.ts: apply last change to translation files directly. - src/sshmasterconnection.cpp: error out with a useful error message in case no password has been provided when doing password authentication. - src/sshmasterconnection.cpp: don't output an empty error message if password authencation has been requested but the server does not support this mechanism. Fixes: #408. - src/onmainwindow.cpp: wrap user name for client-side mounts in quotes. Fixes: #559. Will fail with user names that contain quotes, but oh well... - {example/x2goclient-cli,src/onmainwindow.cpp}: remove hopefully obsolete HOSTNAME exporting into environment. - src/onmainwindow.cpp: remove client-side LD_LIBRARY_PATH meddling. Nothing of value is in that directory and nxproxy hasn't needed that for years. - src/settingswidgets.cpp: don't incorrectly enable whole display settings in single display setups. Let debugging mode override this behavior, though. - src/onmainwindow.cpp: pass X2GO_RANDR_XINERAMA=[yes,no] to x2gostartagent as an environment variable based upon the xinerama session setting. Has no effect when connecting to older X2Go Server versions and handles startup correctly with X2Go Server 4.1.0.0. - src/onmainwindow.cpp: fix another leaked X2goSettings object. - src/onmainwindow.cpp: rename xinerama env variable on session startup to X2GO_XINERAMA in accordance with server changes. - src/onmainwindow.cpp: supply xinerama option as another parameter to x2goresume-session on session resume. - src/sessionbutton.cpp: make button non-sensitive in bottom right part if it's editable. Fixes: #1214. - {src/{help.cpp,onmainwindow.{cpp,h}},man/man1/x2goclient.1}: reformat, whitespace fixes, split out close button slot in a separate function. - src/onmainwindow.{cpp,h}: let close button be a member variable. - src/onmainwindow.cpp: disable and enable close button during and after connection startup. - src/onmainwindow.cpp: initialize directRDP to false to be able to call slotSuspendSessFromSt () even if no session has previously been started. - src/onmainwindow.cpp: only initialize directRDP variable if platform is Linux. Fixes compile failures on Windows and OS X. - src/onmainwindow.cpp: always create close button, but either hide or show it based upon whether --closebt was provided or not. - src/onmainwindow.cpp: revert 3060183a78d8b6bd81bec9968c985c38bfd1e5c2. Being able to suspend sessions via the close button is complex and unnecessary, since in thinclient mode, for which this feature is useful, users will not be able to see the client window while a session is executing, due to it running in full screen mode. - src/onmainwindow.cpp: always enable close button, let it log out from a broker if already authenticated or close the client on click. Fixes: #1209. - man/man1/x2goclient.1: clarify what the close button now does. It either lets the user re-login to the broker or closes the client. - src/onmainwindow.cpp: correctly initialize brokerAuthentication member of ConfigFile struct. - {res/{img/png/close-button.png,resources.qrc}, src/{{onmainwindow,httpbrokerclient}.{cpp,h},help.cpp}, man/man1/x2goclient.1}: rename close button to broker logout button. Reimplement the way it is shown - disable it upon startup and only enable it after successful broker authentication. - man/man1/x2goclient.1: add missing escape signs before dash/minus characters. . [ Oleksandr Shneyder ] * New upstream version (4.1.1.1): - Change echo mode for user input in InteractionDialog. . [ Walid Moghrabi ] * New upstream version (4.1.1.1): - {res/img/png/,res/resources.qrc}: add close-button.png file. - {src/{help.cpp,onmainwindow.{cpp,h}},man/man1/x2goclient.1}: add new option --closebt. Fixes: #1227. Adds a close button in the top-left client corner (maybe next to the halt button) that currently just terminates the client. From unknown Thu Mar 28 23:04:12 2024 MIME-Version: 1.0 X-Mailer: MIME-tools 5.507 (Entity 5.507) X-Loop: owner@bugs.x2go.org From: owner@bugs.x2go.org (X2Go Bug Tracking System) Subject: Bug#559 closed by X2Go Release Manager X2Go Release Manager (X2Go issue (in src:x2goclient) has been marked as closed) Message-ID: References: <20180215204204.916825DAEB@ymir.das-netzwerkteam.de> X-X2go-PR-Keywords: pending X-X2go-PR-Message: they-closed 559 X-X2go-PR-Package: x2goclient X-X2go-PR-Source: x2goclient Date: Thu, 15 Feb 2018 20:45:07 +0000 Content-Type: multipart/mixed; boundary="----------=_1518727507-8548-0" This is a multi-part message in MIME format... ------------=_1518727507-8548-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 This is an automatic notification regarding your Bug report which was filed against the x2goclient package: #559: x2goclient: the local user name that is passed to x2gomountdirs comma= nd needs to be enclosed in quotation marks It has been closed by X2Go Release Manager X2Go Release Manager . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact X2Go Release Manager X= 2Go Release Manager by replying to this email. --=20 X2Go Bug Tracking System Contact owner@bugs.x2go.org with problems ------------=_1518727507-8548-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at control) by bugs.x2go.org; 15 Feb 2018 20:42:45 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.1 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id D208D5DAF0; Thu, 15 Feb 2018 21:42:12 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id W8mlbJLMk6Oz; Thu, 15 Feb 2018 21:42:06 +0100 (CET) Received: by ymir.das-netzwerkteam.de (Postfix, from userid 1005) id 916825DAEB; Thu, 15 Feb 2018 21:42:04 +0100 (CET) From: =?utf-8?q?X2Go_Release_Manager?= X2Go Release Manager To: 559-submitter@bugs.x2go.org Cc: control@bugs.x2go.org, 559@bugs.x2go.org Subject: X2Go issue (in src:x2goclient) has been marked as closed Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Message-Id: <20180215204204.916825DAEB@ymir.das-netzwerkteam.de> Date: Thu, 15 Feb 2018 21:42:04 +0100 (CET) close #559 thanks Hello, we are very hopeful that X2Go issue #559 reported by you has been resolved in the new release (4.1.1.1) of the X2Go source project »src:x2goclient«. You can view the complete changelog entry of src:x2goclient (4.1.1.1) below, and you can use the following link to view all the code changes between this and the last release of src:x2goclient. http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=eef4bf3e0e618b15cbf6649e9dbb07d99e57ad00;hp=f0fb9c49b1c30fd025c2c7c9094fa662b8b09b4d If you feel that the issue has not been resolved satisfyingly, feel free to reopen this bug report or submit a follow-up report with further observations described based on the new released version of src:x2goclient. Thanks a lot for contributing to X2Go!!! light+love X2Go Git Admin (on behalf of the sender of this mail) --- X2Go Component: src:x2goclient Version: 4.1.1.1-0x2go1 Status: RELEASE Date: Thu, 15 Feb 2018 21:38:31 +0100 Fixes: 408 559 1122 1209 1214 1227 Changes: x2goclient (4.1.1.1-0x2go1) RELEASED; urgency=medium . [ Mihai Moldovan ] * New upstream version (4.1.1.1): - src/pulsemanager.cpp: print out PA --version output as a debug message. - macbuild.sh: also bundle xauth binary as nxauth binary. - macbuild.sh: switch to bundling PulseAudio 11.1 since it's now available in MacPorts. - src/sshmasterconnection.cpp: don't ask for private key passphrase if auto-login merely failed due to the server denying the public key. Fixes: #1122. - src/{httpbrokerclient,onmainwindow,sshmasterconnection}.{cpp,h}: introduce new passphrase_type enum and replace the old verificationCode boolean value with that. Allows using more messages, including a new one for plain password prompts. Adapt usage accordingly. The implementation is ugly, but there's no good way around that (short of using C++11 features). The enum would really logically belong to ONMainWindow, but since we also have to use it in SshMasterConnection, that may not include onmainwindow.h to avoid a circular dependency, it has to be part of SshMasterConnection for now. - src/sshmasterconnection.cpp: query for password if it wasn't already provided. Fixes: #1122. This usually happens if auto-login is enabled, which bypasses the password prompt. If auto-login fails, authentication normally continues via challenge auth or plain passwords, but since users had no chance to input a password, such authentication will always fail. Give users a way to enter passwords, in case the auto-login failed. - src/onmainwindow.cpp: finally include version information in debug output. - res/i18n/x2goclient_*.ts: apply last change to translation files directly. - src/sshmasterconnection.cpp: error out with a useful error message in case no password has been provided when doing password authentication. - src/sshmasterconnection.cpp: don't output an empty error message if password authencation has been requested but the server does not support this mechanism. Fixes: #408. - src/onmainwindow.cpp: wrap user name for client-side mounts in quotes. Fixes: #559. Will fail with user names that contain quotes, but oh well... - {example/x2goclient-cli,src/onmainwindow.cpp}: remove hopefully obsolete HOSTNAME exporting into environment. - src/onmainwindow.cpp: remove client-side LD_LIBRARY_PATH meddling. Nothing of value is in that directory and nxproxy hasn't needed that for years. - src/settingswidgets.cpp: don't incorrectly enable whole display settings in single display setups. Let debugging mode override this behavior, though. - src/onmainwindow.cpp: pass X2GO_RANDR_XINERAMA=[yes,no] to x2gostartagent as an environment variable based upon the xinerama session setting. Has no effect when connecting to older X2Go Server versions and handles startup correctly with X2Go Server 4.1.0.0. - src/onmainwindow.cpp: fix another leaked X2goSettings object. - src/onmainwindow.cpp: rename xinerama env variable on session startup to X2GO_XINERAMA in accordance with server changes. - src/onmainwindow.cpp: supply xinerama option as another parameter to x2goresume-session on session resume. - src/sessionbutton.cpp: make button non-sensitive in bottom right part if it's editable. Fixes: #1214. - {src/{help.cpp,onmainwindow.{cpp,h}},man/man1/x2goclient.1}: reformat, whitespace fixes, split out close button slot in a separate function. - src/onmainwindow.{cpp,h}: let close button be a member variable. - src/onmainwindow.cpp: disable and enable close button during and after connection startup. - src/onmainwindow.cpp: initialize directRDP to false to be able to call slotSuspendSessFromSt () even if no session has previously been started. - src/onmainwindow.cpp: only initialize directRDP variable if platform is Linux. Fixes compile failures on Windows and OS X. - src/onmainwindow.cpp: always create close button, but either hide or show it based upon whether --closebt was provided or not. - src/onmainwindow.cpp: revert 3060183a78d8b6bd81bec9968c985c38bfd1e5c2. Being able to suspend sessions via the close button is complex and unnecessary, since in thinclient mode, for which this feature is useful, users will not be able to see the client window while a session is executing, due to it running in full screen mode. - src/onmainwindow.cpp: always enable close button, let it log out from a broker if already authenticated or close the client on click. Fixes: #1209. - man/man1/x2goclient.1: clarify what the close button now does. It either lets the user re-login to the broker or closes the client. - src/onmainwindow.cpp: correctly initialize brokerAuthentication member of ConfigFile struct. - {res/{img/png/close-button.png,resources.qrc}, src/{{onmainwindow,httpbrokerclient}.{cpp,h},help.cpp}, man/man1/x2goclient.1}: rename close button to broker logout button. Reimplement the way it is shown - disable it upon startup and only enable it after successful broker authentication. - man/man1/x2goclient.1: add missing escape signs before dash/minus characters. . [ Oleksandr Shneyder ] * New upstream version (4.1.1.1): - Change echo mode for user input in InteractionDialog. . [ Walid Moghrabi ] * New upstream version (4.1.1.1): - {res/img/png/,res/resources.qrc}: add close-button.png file. - {src/{help.cpp,onmainwindow.{cpp,h}},man/man1/x2goclient.1}: add new option --closebt. Fixes: #1227. Adds a close button in the top-left client corner (maybe next to the halt button) that currently just terminates the client. ------------=_1518727507-8548-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by bugs.x2go.org; 28 Jul 2014 20:11:15 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=ham version=3.3.2 Received: from mail-we0-f176.google.com (mail-we0-f176.google.com [74.125.82.176]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 7CD2A5DB52 for ; Mon, 28 Jul 2014 22:11:13 +0200 (CEST) Received: by mail-we0-f176.google.com with SMTP id q58so7949039wes.35 for ; Mon, 28 Jul 2014 13:11:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject :content-type; bh=2tLXrs9ymn6KN8vfbjhLpdIZeIPMJMHHsNjtP/c44SU=; b=Ud2OPIwwEQK41O6qjRrBme+HOXlRjva7++zeSBcTOJna1RNwyY1hpKTir1afpzbIzT dzNflYUgNo6+q0b0N0k1mlCM5uoHb1URJWmSack4mxl/+RtYdIhZ0L7LVCLdi2k1AxWA d/LjCiZS4dXZuZMIuwO3rK+LLNrWzXYu/UKN4hMuhtptqFERMCGdXbnMqm9cFnX0s9SV UUclQWL3OSN3wvaHrGi8kMmnIvryu1TgGb9bDXBcdDwqJLFlFZN7rczzbZhwWwCc/isx TpiGUQpX/QvoTji0HELX8z19UiTwdtDyRrb/Zdf0xFcmcmLkvEvnXfMUNJTexe8qnJXk LiDA== X-Received: by 10.180.99.102 with SMTP id ep6mr34671985wib.1.1406578272207; Mon, 28 Jul 2014 13:11:12 -0700 (PDT) Received: from [172.24.1.101] (BSN-143-119-239.dial-up.dsl.siol.net. [89.143.119.239]) by mx.google.com with ESMTPSA id lg7sm36426556wjb.9.2014.07.28.13.11.10 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 28 Jul 2014 13:11:11 -0700 (PDT) Message-ID: <53D6AE5D.5010107@gmail.com> Date: Mon, 28 Jul 2014 22:11:09 +0200 From: Rok Mandeljc User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: submit@bugs.x2go.org Subject: x2goclient: the local user name that is passed to x2gomountdirs command needs to be enclosed in quotation marks Content-Type: multipart/mixed; boundary="------------050208050306070000040809" This is a multi-part message in MIME format. --------------050208050306070000040809 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Package: x2goclient Version: 4.0.2.1+hotfix1 In startX2goMount(), the local user name (cuser) is passed as the third argument to the x2gomountdirs command that will be executed on the server side. This user name should be enclosed in quotation marks, otherwise the x2gomountdirs on server side fails for users who are unfortunate enough to have put a whitespace character in their Windows user name. --------------050208050306070000040809 Content-Type: text/x-patch; name="0001-startX2goMount-insert-quotation-marks-around-the-loc.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-startX2goMount-insert-quotation-marks-around-the-loc.pa"; filename*1="tch" >From 8e51e6835b2935777e83adb1823a7bbd37bbede0 Mon Sep 17 00:00:00 2001 From: Rok Mandeljc Date: Mon, 28 Jul 2014 21:51:12 +0200 Subject: [PATCH] startX2goMount(): insert quotation marks around the local user name (cuser) that is passed to x2gomountdirs command Unquoted user name means that the server-side x2gomountdirs command will fail for users who are unfortunate enough to have put a whitespace character in their Windows user name. Signed-off-by: Rok Mandeljc --- onmainwindow.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/onmainwindow.cpp b/onmainwindow.cpp index 8acec61..7751c69 100644 --- a/onmainwindow.cpp +++ b/onmainwindow.cpp @@ -9230,11 +9230,11 @@ void ONMainWindow::startX2goMount() dirs=dirs+"__REVERSESSH_PORT__"+resumingSession.fsPort; } if ( !rem ) - cmd="export HOSTNAME && x2gomountdirs dir "+sessionId+" "+cuser+ - " "+dir->dstKey+" "+dirs; + cmd="export HOSTNAME && x2gomountdirs dir "+sessionId+" \""+cuser+ + "\" "+dir->dstKey+" "+dirs; else - cmd="export HOSTNAME && x2gomountdirs rem "+sessionId+" "+cuser+ - " "+dir->dstKey+" "+dirs; + cmd="export HOSTNAME && x2gomountdirs rem "+sessionId+" \""+cuser+ + "\" "+dir->dstKey+" "+dirs; #ifdef Q_OS_WIN -- 1.9.3 --------------050208050306070000040809-- ------------=_1518727507-8548-0--