From unknown Tue Mar 19 03:00:14 2024 MIME-Version: 1.0 X-Mailer: MIME-tools 5.502 (Entity 5.502) X-Loop: owner@bugs.x2go.org From: owner@bugs.x2go.org (X2Go Bug Tracking System) Subject: Bug#558 closed by Mike Gabriel (X2Go issue (in src:x2goserver) has been marked as closed) Message-ID: References: <20140925224217.6CFF25E0B0@ymir.das-netzwerkteam.de> X-X2go-PR-Keywords: pending X-X2go-PR-Message: they-closed 558 X-X2go-PR-Package: x2goserver X-X2go-PR-Source: x2goserver Date: Thu, 25 Sep 2014 22:45:37 +0000 Content-Type: multipart/mixed; boundary="----------=_1411685137-21655-0" This is a multi-part message in MIME format... ------------=_1411685137-21655-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 This is an automatic notification regarding your Bug report which was filed against the x2goserver package: #558: Empty $USER env var makes x2go start an infinite loop It has been closed by Mike Gabriel . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Mike Gabriel by replying to this email. --=20 X2Go Bug Tracking System Contact owner@bugs.x2go.org with problems ------------=_1411685137-21655-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at control) by bugs.x2go.org; 25 Sep 2014 22:43:20 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_RELAYS autolearn=unavailable version=3.3.2 Received: by ymir.das-netzwerkteam.de (Postfix, from userid 1005) id 6CFF25E0B0; Fri, 26 Sep 2014 00:42:17 +0200 (CEST) From: Mike Gabriel To: 558-submitter@bugs.x2go.org Cc: control@bugs.x2go.org, 558@bugs.x2go.org Subject: X2Go issue (in src:x2goserver) has been marked as closed Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Message-Id: <20140925224217.6CFF25E0B0@ymir.das-netzwerkteam.de> Date: Fri, 26 Sep 2014 00:42:17 +0200 (CEST) close #558 thanks Hello, we are very hopeful that X2Go issue #558 reported by you has been resolved in the new release (4.0.1.16) of the X2Go source project »src:x2goserver«. You can view the complete changelog entry of src:x2goserver (4.0.1.16) below, and you can use the following link to view all the code changes between this and the last release of src:x2goserver. http://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=c43b862f2ae0e8980fb7ab5e519d692b07da5a45;hp=98c4f84d83d701823b7887f79d0d9f5ce8233bd4 If you feel that the issue has not been resolved satisfyingly, feel free to reopen this bug report or submit a follow-up report with further observations described based on the new released version of src:x2goserver. Thanks a lot for contributing to X2Go!!! light+love X2Go Git Admin (on behalf of the sender of this mail) --- X2Go Component: src:x2goserver Version: 4.0.1.16-0x2go1 Status: RELEASE Date: Fri, 26 Sep 2014 00:36:32 +0200 Fixes: 122 302 397 406 407 458 468 495 506 511 520 523 524 543 547 558 569 572 573 574 599 605 606 617 619 Changes: x2goserver (4.0.1.16-0x2go1) RELEASED; urgency=low . [ Mike DePaulo ] * New upstream release (4.0.1.16): - Make X2Go Server aware of the Openbox desktop environment (Command: OPENBOX) (Fixes: #605) - Make X2Go Server aware of the IceWM desktop environment (Command: ICEWM) (Fixes: #606) - Support GNOME Flashback session (GNOME 3.8+) on distro releases such as Ubuntu 13.10+ and debian Jessie (NOTE: For most users, GNOME Flashback currently will not work. This requires that gnome-flashback.session actually be installed. Not every Linux distro has it available. It also requires that the gnome-session binary not require hardware 3D acceleration for said session. Currently, upstream GNOME and GNOME 3.8+ in all Linux distros do require this, only 3rd party builds do not. See X2Go bug #599 for example.) (Thanks Eugene San (eugenesan@gmail.com)) - Fix launching GNOME 3 Fallback session (GNOME 3.4 & 3.6) on distros other than Ubuntu and Debian (Fixes: #599) - Fix support for Cinnamon 1.4 (Linux Mint 13) (Fixes: #569) - Fix the logic for launching Cinnamon 2.0 and 2.2 (Linux Mint 17). (Fixes: #572) NOTE: Fixing this bug in x2goserver is not sufficient to make Cinnamon 2.0 & 2.2 to work properly with X2Go. Bug #150 in nx-libs is still a problem. Fixing this bug enables Cinnamon 2.0 and 2.2 to launch to their "fallback mode", which has many bugs and missing features when compared to "software rendering" mode (cinnamon2d), but is still better than nothing. * debian/rules: + Improve dh_auto_clean override. . [ Mike Gabriel ] * New upstream version (4.0.1.16): - Let x2goversion exit with an error if the X2Go component cannot be found. - Detect terminated sessions from NX log file. Also interpret a session as terminated if terminating just has started. - Detect started/starting/resumed/resuming sessions by explicitly scanning the NX session log file for those keywords. - Interpret NX sessions marked as "aborting session" as (not yet) terminated sessions. - Provide config option for server-side/global clipboard behaviour in x2goagent.options. (Fixes: #506). - Be aware of poly-instantiated /tmp directories bind-mounted under /tmp-inst. (Fixes: #406). - On suspend: Call x2goumount-session before sending SIGHUP to x2goagent. - Refuse client communcation if server-side hostname is not set up correctly (Fixes: #468). - Fix string comparison in x2goumount-session. - Fix problems with unmounting shared folders on session suspension/ termination. Remove extra parentheses from the fusermount execution call. (Fixes: #407). - Use type -p instead of which in x2goumount-session. Suppress output to stdout properly. - Use if--then--else--fi during x2goagent resuming in x2goresume-session script. - More reliably sync the NX session state with the status information in the X2Go session DB. - x2golistdesktops: Also detect sharable desktop sessions behind abstract kernel namespace sockets. - Add logcheck rules for X2Go Server. Thanks to Frank Werner for sending them in. - Correctly use diversions from stderr to stdout in shell commands. (Fixes: #520). - Don't die if no session state file is found, as it will break X2Go completely after upgrading from versions << 4.0.1.16 if sessions are still running/suspended during package upgrade. - Provide support for client-side choice of clipboard security. (Fixes: #524). - Use more quotes in x2goruncommand. - Detect the exit of rootless applications that forked to background on application execution. (Fixes: #122). - Make x2goruncommand more robust. - Don't fail Xsession startup if any of the profile scripts returns with an error. - Silently timeout in x2golistdesktops if calls to x2golistsessions and/or xwininfo don't produce output within one second. (Fixes: #543). - Allow email addresses as login usernames. (Fixes: #573). - Abort session startup if env var $USER or $SSH_CLIENT are not set. (Fixes: #558). - Allow length of username up to 48 characters (was: 32 characters). (Fixes: #574). - Abort session if env var $HOME is not set or if $HOME contains non-ASCII characters. (Fixes: #397). - Export XAUTHORITY env var in x2goruncommand to enable privilege upgrade for applications started via pkexec. (Fixes: #458). - x2gocleansessions: Don't print to stderr if the session state file cannot be found. This can happen during session startups. Report to system log instead. - Don't use Perl package File::ReadBackwards anymore. - Fix x2gormforward for 4.0.1.x release series (the X2Go::Log Perl module only exists in X2Go Server >= 4.1.0.0, the 4.0.1.x release series has to use x2gologlevel.pm in `x2gopath lib`. (Fixes: #617). - Pick x2gogetagentstate from 4.1.0.0 release series and adapt to usage with X2Go Server 4.0.1.x. (Fixes: #619). * debian/control, x2goserver.spec: + Update versioned D: x2goagent (>= 3.5.0.25). This assures that X2Go works with poly-instantiated /tmp directories. + Make sure x2gogetagentstate gets packaged in bin:package x2goserver. + Bump Standards: to 3.9.5. No changes needed. + Mark x2goserver-pyhoca bin:package as deprecated. + Drop D (x2goserver): libfile-readbackwards-perl. * x2goserver.spec: + Install {libdir}/x2go/x2gormforward into bin:package x2goserver. + Drop R (x2goserver): perl(File::ReadBackwards). . [ Oleksandr Shneyder ] * New upstream version (4.0.1.16): - x2gostartagent, x2golistsession, x2gosuspend-session and x2goresume-session getting agent state from ~/.x2go/C-$SID/state. This should help to avoid session damage. Remove nxcleanup. (Fixes: #302, #511). - Move session file to /tmp/.x2go-$USER. (Fixes: #523). - Fix x2gostartagent failures if kbd is not "auto". Remove comma at end of options file. - Set default value for clipboard to "both" in x2gostartagent and x2goresume-session. - Clean user SSHD process if connection between server and client lost. This should fix error "Global request tcpip-forward failed". (Fixes: #495, #547). . [ Orion Paplowski ] * x2goserver.spec: + Sync Fedora .spec file with our upstream-provided x2goserver.spec. ------------=_1411685137-21655-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by bugs.x2go.org; 25 Jul 2014 15:45:37 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=ham version=3.3.2 Received: from mail-qg0-f50.google.com (mail-qg0-f50.google.com [209.85.192.50]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id F0D625DB51 for ; Fri, 25 Jul 2014 17:45:35 +0200 (CEST) Received: by mail-qg0-f50.google.com with SMTP id q108so5214515qgd.37 for ; Fri, 25 Jul 2014 08:45:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=52JT142cyBsvmgFFQR6NJp/E6AnqlEYTYn1+epG1xHo=; b=Bm6+lHBk0VAhtBpJZ8K48xZYy71IKMwsdkYnZ/ho8zHs4kgSedp/81x1vDbNVeYOry 7O4sSViqe89Fd6+8Gm05Sz376Rj2IEeRQ3jEF2NjrcXM8lTqqTRbLRvb5N5X2OlLjA3D m0HMUApbYSqU1Yoi25QygfLx5/2KRDDvbYRylgj4MD3hZxxas2/Bn0JmCnLJCZy9ZFBl p5dElqQMJu7Q4jHvSk09e1HoqB/Je78qgh67N7oLdme20YXO/4JISpD+stMzclOG030k 7bVZqUgMFQ7UtkwnlLeDyMY6rtx8jJ6+7Do2Qj+/+Luh2wjHQ1rUWKtkFGAJdEnzm0Vn mtVw== MIME-Version: 1.0 X-Received: by 10.224.21.9 with SMTP id h9mr27727091qab.67.1406303134206; Fri, 25 Jul 2014 08:45:34 -0700 (PDT) Received: by 10.96.97.98 with HTTP; Fri, 25 Jul 2014 08:45:34 -0700 (PDT) Date: Fri, 25 Jul 2014 11:45:34 -0400 Message-ID: Subject: Empty $USER env var makes x2go start an infinite loop From: Jacques-Olivier Goussard To: submit@bugs.x2go.org Content-Type: multipart/alternative; boundary=001a11c2b70ac2cf5704ff067624 --001a11c2b70ac2cf5704ff067624 Content-Type: text/plain; charset=UTF-8 Package: x2goserver Version: x2goserver.x86_64 4.0.1.13-4.el6 OS: Centos 5 I accidentally stumbled upon this one: if the $USER env var is empty (in my case that was a bug in my .bashrc that generated that), then X2GO doesn't properly reject and log the connection attempt. The client freezes in 'Connecting' state and the sqllite scripts seem to enter an infinite loop trying to do insert session. Once I kill the x2gostartagent process, I get the list of calls in x2gosqllitewrapper.pm and can see that the provided session ID is missing the username part (as USER is empty). Instead of being stuck in session insertion, the fact that USER is empty should be caught earlier, properly reported in syslog and session cleanly rejected. --001a11c2b70ac2cf5704ff067624 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Package: x2goserver
Version:=C2=A0x2goserver.x86_64 4.= 0.1.13-4.el6
OS: Centos 5

I accidentally= stumbled upon this one: if the $USER env var is empty (in my case that was= a bug in my .bashrc that generated that), then X2GO doesn't properly r= eject and log the connection attempt. The client freezes in 'Connecting= ' state and the sqllite scripts seem to enter an infinite loop trying t= o do insert session.
Once I kill the x2gostartagent process, I get the list of calls in x2gosqllitewrapper.pm and can see= that the provided session ID is missing the username part (as USER is empt= y).
Instead of being stuck in session insertion, the fact that USER is emp= ty should be caught earlier, properly reported in syslog and session cleanl= y rejected.


--001a11c2b70ac2cf5704ff067624-- ------------=_1411685137-21655-0--