From unknown Tue Apr 28 21:17:45 2026 X-Loop: owner@bugs.x2go.org Subject: Bug#547: Alex's fix in x2goserver Reply-To: Mike Gabriel , 547@bugs.x2go.org Resent-From: Mike Gabriel Resent-To: x2go-dev@lists.x2go.org Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Wed, 23 Jul 2014 11:00:01 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: followup 547 X-X2Go-PR-Package: x2goclient X-X2Go-PR-Keywords: Received: via spool by 547-submit@bugs.x2go.org id=B547.140611308822042 (code B ref 547); Wed, 23 Jul 2014 11:00:01 +0000 Received: (at 547) by bugs.x2go.org; 23 Jul 2014 10:58:08 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.2 Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 104965DB3E for <547@bugs.x2go.org>; Wed, 23 Jul 2014 12:58:07 +0200 (CEST) Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98]) by freya.das-netzwerkteam.de (Postfix) with ESMTPS id 2DAA835C6; Wed, 23 Jul 2014 12:58:06 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 93B843BAAB; Wed, 23 Jul 2014 12:58:06 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de Received: from grimnir.das-netzwerkteam.de ([127.0.0.1]) by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pJav9ZYpjVGE; Wed, 23 Jul 2014 12:58:06 +0200 (CEST) Received: from grimnir.das-netzwerkteam.de (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id 6F8A83B9DF; Wed, 23 Jul 2014 12:58:06 +0200 (CEST) Received: from 213-66-217-50-no214.tbcn.telia.com (213-66-217-50-no214.tbcn.telia.com [213.66.217.50]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP; Wed, 23 Jul 2014 10:58:06 +0000 Date: Wed, 23 Jul 2014 10:58:06 +0000 Message-ID: <20140723105806.Horde.MQdVFNr69muwt49utdoK0A6@mail.das-netzwerkteam.de> From: Mike Gabriel To: Michael DePaulo Cc: 547@bugs.x2go.org, Oleksandr Shneyder In-Reply-To: User-Agent: Internet Messaging Program (IMP) H5 (6.2.0) Accept-Language: en,de Organization: DAS-NETZWERKTEAM X-Originating-IP: 213.66.217.50 X-Remote-Browser: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:30.0) Gecko/20100101 Firefox/30.0 Content-Type: multipart/signed; boundary="=_gyUb7XOtjwm-pvXZENL7Ng8"; protocol="application/pgp-signature"; micalg=pgp-sha1 MIME-Version: 1.0 This message is in MIME format and has been PGP signed. --=_gyUb7XOtjwm-pvXZENL7Ng8 Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Mike#2 On Mi 23 Jul 2014 04:14:44 CEST, Michael DePaulo wrote: > I can confirm that Alex's commit to x2goserver (rather than > x2goclient) fixes this bug. > > bf318affee905cf7cdeaa5a248dfd07bc46a8a96 > Clean user SSHD process if connection between server and client lost. > This should fix error "Global request tcpip-forward failed". > http://code.x2go.org/gitweb?p=3Dx2goserver.git;a=3Dcommit;h=3Dbf318affee9= 05cf7cdeaa5a248dfd07bc46a8a96 > > Mike#1 > Should I retitle and reassign this bug (#547) to x2goserver? And Yes, please. Can you also check for the existence of duplicate bugs? > should we cherry-pick it for x2goserver release/4.0.0.x & > release/4.0.1.x? We should probably release updated versions of > 4.0.0.x (baikal) and 4.0.1.x at least a month before we release Yes. We should cherry-pick now. Actually, the two last commits on=20=20 x2goserver.git,=20but I'd suggest only to the release/4.0.1.x branch=20=20 (Baikal=20needs to be superceded by a new bundle release soon). (1) e125f82314aa53a4d6e68f779dc1282d9edc7d5f "Set default value for=20=20 clipboard=20to "both" in x2gostartagent and x2goresume-session." [1] -> on master branch revert this commit cherry-pick it again do "git reset HEAD~" move the changelog entry to 4.0.1.16 add bug closure if appropriate commit it again in Alex's name (--author=3D"Fullname ") ... Then cherry-pick it to release/4.0.1.x branch (2) Clean user SSHD process if connection between server and client lost.=20=20 This=20should fix error "Global request tcpip-forward failed".=20=20 bf318affee905cf7cdeaa5a248dfd07bc46a8a96=20[2] -> on master branch revert this commit cherry-pick it again do "git reset HEAD~" do "git add x2goserver/lib/x2gormforward" move the changelog entry to 4.0.1.16 add bug closure if appropriate commit it again in Alex's name (--author=3D"Fullname ") ... Then cherry-pick it to release/4.0.1.x branch > x2goclient 4.0.3.0. Otherwise, people will run into this bug if they > update their clients to 4.0.3.0 but do not update their servers. > > -Mike#2 Mike#1 [1]=20=20 http://code.x2go.org/gitweb?p=3Dx2goserver.git;a=3Dcommitdiff;h=3De125f8231= 4aa53a4d6e68f779dc1282d9edc7d5f [2]=20=20 http://code.x2go.org/gitweb?p=3Dx2goserver.git;a=3Dcommit;h=3Dbf318affee905= cf7cdeaa5a248dfd07bc46a8a96 --=20 DAS-NETZWERKTEAM mike=20gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.x= fb --=_gyUb7XOtjwm-pvXZENL7Ng8 Content-Type: application/pgp-signature Content-Description: Digitale PGP-Signatur Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABAgAGBQJTz5U+AAoJEJr0azAldxsxiTkQAI8NY9D5g3lQOi/jJgaRNSnz NFvZdtZqE7SmNdxS5bbPalqjwRrTwbKOgLfLsAnel0aBnSil3PwKr5pZCspSfTDI YxQEwAsyuQew15B7Q49IUJSOEr3Jes40gmH/c3J8F8ZfIlfCre/A3XRG5oQUYU4w /lAKZD524IfWt3uPk8gcXSeG91SGNtaHtbyQrVJ3/iDk7zROm6p5ETPl6Imx1Mjk Kv+LcbKpUq1reaUQHqYl/1NiqYYt3vgRbXjnb9ILwswhNr+Ypf6wHOfXkmr+OEDX pAoutNzVhowov+LzuGZwfqH8kINKXZvuvtSiFvewSWKqOkbZYSWMExQuhlBrdeY9 3xEyjiLTjLiWvXWbATpEu/GFnmy23yR0A3K1IPpEz146oOB3FMoeqcPdzW9YaTvP +uYliYvCJtj4GtmmdwUVUTj/IMPNBooPrsaFCMO6VZz/XPmKqqpQipYXGv+SMSnP sBBde1TFHzz6fzGcc1LI4TMbRJ6mPN3MNP7PInV0lRuJqFpZVrNUVzb0IZ/Rh9OX +X6qcFt6ftqlh9hgKOce8kc0UvdqJTkj+494o8W7cxbA3n9HJ4skc18wKf+ooVxr ZznqbEUZlelHLMGqPI8L5U99YWGPRcY+JLSdr0jlxNMMtANOfFi7pGxqoSz3krDy AxWCWO/i/exOQOSjUbtv =tZau -----END PGP SIGNATURE----- --=_gyUb7XOtjwm-pvXZENL7Ng8--