From jlukens@botch.com Thu Jul 10 03:48:42 2014 Received: (at submit) by bugs.x2go.org; 10 Jul 2014 01:48:43 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=ham version=3.3.2 X-Greylist: delayed 345 seconds by postgrey-1.34 at ymir.das-netzwerkteam.de; Thu, 10 Jul 2014 03:48:42 CEST Received: from felt.botch.com (felt.botch.com [207.145.43.98]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 325FC5DB24 for ; Thu, 10 Jul 2014 03:48:42 +0200 (CEST) Received: from [127.0.0.1] (unknown [192.168.254.1]) (Authenticated sender: jlukens) by felt.botch.com (Postfix) with ESMTP id 50B481AC0D5 for ; Wed, 9 Jul 2014 21:48:41 -0400 (EDT) Date: Wed, 9 Jul 2014 21:48:39 -0400 From: Josh Lukens To: submit@bugs.x2go.org Message-ID: <1757D526C14247C080198490BC055928@botch.com> Subject: base_broker.py has some typos and host/port mixups in the remote_sshproxy logic X-Mailer: sparrow 1.6.4 (build 1178) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="53bdf0f7_e7ffa2b_8ead" --53bdf0f7_e7ffa2b_8ead Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Package: x2gobroker Version: 0.0.3.0 Severity: wishlist base_broker.py has some typos and host/port mixups in the remote_sshproxy logic. Causes internal server error when using profiles with ssh proxy. Draft patch attached. --53bdf0f7_e7ffa2b_8ead Content-Type: application/octet-stream Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="=?utf-8?Q?remote=5Fsshproxy.patch?=" ZGlmZiAtLWdpdCBhL3gyZ29icm9rZXIvYnJva2Vycy9iYXNlX2Jyb2tlci5weSBiL3gyZ29icm9r ZXIvYnJva2Vycy9iYXNlX2Jyb2tlci5weQppbmRleCBlZjg5NWFiLi5lOTJjN2Q4IDEwMDY0NAot LS0gYS94MmdvYnJva2VyL2Jyb2tlcnMvYmFzZV9icm9rZXIucHkKKysrIGIveDJnb2Jyb2tlci9i cm9rZXJzL2Jhc2VfYnJva2VyLnB5CkBAIC0xMTgzLDExICsxMTgzLDEwIEBAIGNsYXNzIFgyR29C cm9rZXIob2JqZWN0KToKICAgICAgICAgaWYgcHJvZmlsZS5oYXNfa2V5KHUnc3NocHJveHlob3N0 JykgYW5kIHByb2ZpbGVbdSdzc2hwcm94eWhvc3QnXToKICAgICAgICAgICAgIHJlbW90ZV9zc2hw cm94eV9hZ2VudCA9IHsKICAgICAgICAgICAgICAgICB1J2hvc3RuYW1lJzogcHJvZmlsZVt1J3Nz aHByb3h5aG9zdCddLAorICAgICAgICAgICAgICAgIHUncG9ydCc6ICIyMiIKICAgICAgICAgICAg IH0KLSAgICAgICAgICAgIGlmIHByb2ZpbGUuaGFzX2tleSh1J3NzaHByb3h5aG9zdCcpIGFuZCBw cm9maWxlW3Unc3NocHJveHlob3N0J106Ci0gICAgICAgICAgICAgICAgcmVtb3RlX3NzaHJwb3h5 X2FnZW50W3UncG9ydCddID0gcHJvZmlsZVt1J3NzaHByb3h5aG9zdCddCi0gICAgICAgICAgICBl bHNlOgotICAgICAgICAgICAgICAgIHJlbW90ZV9zc2hycG94eV9hZ2VudFt1J3BvcnQnXSA9ICIy MiIKKyAgICAgICAgICAgIGlmIHByb2ZpbGUuaGFzX2tleSh1J3NzaHByb3h5cG9ydCcpIGFuZCBw cm9maWxlW3Unc3NocHJveHlwb3J0J106CisgICAgICAgICAgICAgICAgcmVtb3RlX3NzaHByb3h5 X2FnZW50W3UncG9ydCddID0gcHJvZmlsZVt1J3NzaHByb3h5cG9ydCddCiAgICAgICAgIGVsc2U6 CiAgICAgICAgICAgICByZW1vdGVfc3NocHJveHlfYWdlbnQgPSBOb25lCiAK --53bdf0f7_e7ffa2b_8ead--