X2Go Bug report logs - #516
X2go successfully connects to server, but no window is shown

version graph

Package: nxagent; Maintainer for nxagent is X2Go Developers <x2go-dev@lists.x2go.org>; Source for nxagent is src:nx-libs.

Reported by: sebastien chabrolles <s.chabrolles@fr.ibm.com>

Date: Sat, 14 Jun 2014 20:25:03 UTC

Severity: normal

Tags: pending

Found in version 3.5.0.24

Fixed in version 3.5.0.25

Done: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

Bug is archived. No further changes may be made.

Full log

🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#516: [X2Go-Dev] Bug#516: [PATCH 1/5] Create Windows on Big Endian 64bit systems
Reply-To: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>, 516@bugs.x2go.org
Resent-From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Sat, 21 Jun 2014 20:30:01 +0000
Resent-Message-ID: <handler.516.B516.140338241422248@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 516
X-X2Go-PR-Package: x2goserver
X-X2Go-PR-Keywords: 
Received: via spool by 516-submit@bugs.x2go.org id=B516.140338241422248
          (code B ref 516); Sat, 21 Jun 2014 20:30:01 +0000
Received: (at 516) by bugs.x2go.org; 21 Jun 2014 20:26:54 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham
	version=3.3.2
Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 8E31F5DB17
	for <516@bugs.x2go.org>; Sat, 21 Jun 2014 22:26:53 +0200 (CEST)
Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98])
	by freya.das-netzwerkteam.de (Postfix) with ESMTPS id 31C7513672;
	Sat, 21 Jun 2014 22:26:53 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 124243BA5D;
	Sat, 21 Jun 2014 22:26:53 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de
Received: from grimnir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id JvCzBzw29Sze; Sat, 21 Jun 2014 22:26:52 +0200 (CEST)
Received: from grimnir.das-netzwerkteam.de (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id CAADE3BA57;
	Sat, 21 Jun 2014 22:26:52 +0200 (CEST)
Received: from pD9E9FFDD.dip0.t-ipconnect.de (pD9E9FFDD.dip0.t-ipconnect.de
 [217.233.255.221]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP;
 Sat, 21 Jun 2014 20:26:52 +0000
Date: Sat, 21 Jun 2014 20:26:52 +0000
Message-ID: <20140621202652.Horde.LiYq_wQOnGyIyKjpwY8pEg1@mail.das-netzwerkteam.de>
From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
To: Mihai Moldovan <ionic@ionic.de>
Cc: 516@bugs.x2go.org
References: <OF70D11DD0.EF25FFDA-ONC1257CF7.006F3027-C1257CF7.006FFC35@fr.ibm.com>
 <53A4F5FE.4000206@ionic.de> <53A4F8DF.30404@ionic.de>
In-Reply-To: <53A4F8DF.30404@ionic.de>
User-Agent: Internet Messaging Program (IMP) H5 (6.1.7)
Accept-Language: en,de
Organization: DAS-NETZWERKTEAM
X-Originating-IP: 217.233.255.221
X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:30.0) Gecko/20100101
 Firefox/30.0 Iceweasel/30.0
Content-Type: multipart/signed; boundary="=_8Kp-RaWGLVcWuH5TyOHiMg1";
 protocol="application/pgp-signature"; micalg=pgp-sha1
MIME-Version: 1.0

[Message part 1 (text/plain, inline)]
Hi Mihai,

thanks for digging into this. I wish you could work more on NX!!! Good work!!!

On  Sa 21 Jun 2014 05:15:43 CEST, Mihai Moldovan wrote:

> An endiannes issue was setting incorrect event masks when creating  
> X11 windows.
>
> This time, a smaller integer has been casted to a bigger one and  
> passed to some
> function actually setting its value.
>
> This meant, that garbage from stack was attached to the smaller  
> integer value,
> putting unknown memory into the lower bytes of the bigger integer.
>
> Fix this by creating a big, initialized temporary variable, let the  
> function do
> its magic on that one and pass the value back to the smaller variable -- and
> cross your fingers the smaller variable can hold it without overrunning. (The
> last bit is a design issue we can't really fix and has been around  
> even before
> this patch.)

I have a question on this patch. While integrating it into the  
nx-libs.git repo, I realized, that it can be applied to Windows.c  
twice. Once at the position that you provide in the patch file,  
another (second) time around line 2895...

"""
mike@minobo:~/MyDocuments/4projects/x2go-upstream/nx-libs$ patch -p1 <  
nxagent_Window.c-ppc64-create-windows.patch
patching file nx-X11/programs/Xserver/hw/nxagent/Window.c
Hunk #1 succeeded at 2894 (offset 2559 lines).
"""

Maybe the same patch is needed at that second position?

Mike

-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

[Message part 2 (application/pgp-signature, inline)]

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Nov 21 15:24:21 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.