From unknown Tue Apr 21 08:41:57 2026 X-Loop: owner@bugs.x2go.org Subject: Bug#516: [X2Go-Dev] Bug#516: [PATCH 1/5 v2] Create Windows and fix drawing issues on Big Endian 64bit systems Reply-To: Mike Gabriel , 516@bugs.x2go.org Resent-From: Mike Gabriel Resent-To: x2go-dev@lists.x2go.org Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Sat, 21 Jun 2014 21:25:02 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: followup 516 X-X2Go-PR-Package: x2goserver X-X2Go-PR-Keywords: Received: via spool by 516-submit@bugs.x2go.org id=B516.140338578927362 (code B ref 516); Sat, 21 Jun 2014 21:25:02 +0000 Received: (at 516) by bugs.x2go.org; 21 Jun 2014 21:23:09 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.2 Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id BA2F65DB17 for <516@bugs.x2go.org>; Sat, 21 Jun 2014 23:23:08 +0200 (CEST) Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98]) by freya.das-netzwerkteam.de (Postfix) with ESMTPS id 4599A2FAB; Sat, 21 Jun 2014 23:23:08 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 31A783BA5D; Sat, 21 Jun 2014 23:23:08 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de Received: from grimnir.das-netzwerkteam.de ([127.0.0.1]) by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bTgnTo1A0FGE; Sat, 21 Jun 2014 23:23:08 +0200 (CEST) Received: from grimnir.das-netzwerkteam.de (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id DD91F3B9D5; Sat, 21 Jun 2014 23:23:07 +0200 (CEST) Received: from pD9E9FFDD.dip0.t-ipconnect.de (pD9E9FFDD.dip0.t-ipconnect.de [217.233.255.221]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP; Sat, 21 Jun 2014 21:23:07 +0000 Date: Sat, 21 Jun 2014 21:23:07 +0000 Message-ID: <20140621212307.Horde.Lb8d0ZTl6Jk-uQuFW1Bf_w2@mail.das-netzwerkteam.de> From: Mike Gabriel To: Mihai Moldovan Cc: 516@bugs.x2go.org References: <53A4F5FE.4000206@ionic.de> <53A4F8DF.30404@ionic.de> <53A5F55B.4020000@ionic.de> In-Reply-To: <53A5F55B.4020000@ionic.de> User-Agent: Internet Messaging Program (IMP) H5 (6.1.7) Accept-Language: en,de Organization: DAS-NETZWERKTEAM X-Originating-IP: 217.233.255.221 X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:30.0) Gecko/20100101 Firefox/30.0 Iceweasel/30.0 Content-Type: multipart/signed; boundary="=_DpfSZQ0oBqv18dJF2xBUxA1"; protocol="application/pgp-signature"; micalg=pgp-sha1 MIME-Version: 1.0 This message is in MIME format and has been PGP signed. --=_DpfSZQ0oBqv18dJF2xBUxA1 Content-Type: text/plain; charset=ISO-8859-1; format=flowed; DelSp=Yes Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Mihai, On Sa 21 Jun 2014 23:12:59 CEST, Mihai Moldovan wrote: > Multiple endiannes issues were setting incorrect event masks when=20=20 >=20creating and > drawing X11 windows. > > This time, a smaller integer has been casted to a bigger one and=20=20 >=20passed to some > function actually setting its value. > > This meant, that garbage from stack was attached to the smaller=20=20 >=20integer value, > putting unknown memory into the lower bytes of the bigger integer. > > Fix this by creating a big, initialized temporary variable, let the=20=20 >=20function do > its magic on that one and pass the value back to the smaller variable -- = and > cross your fingers the smaller variable can hold it without overrunning. = (The > last bit is a design issue we can't really fix and has been around=20=20 >=20even before > this patch.) > > > This fixes window creation and redrawing/updating issues on Big Endian 64= bit > systems. Fixed patch included. However, unfortunately I forgot to rebase before=20= =20 pushing... Mike --=20 DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.x= fb --=_DpfSZQ0oBqv18dJF2xBUxA1 Content-Type: application/pgp-signature Content-Description: Digitale PGP-Signatur Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABAgAGBQJTpfe7AAoJEJr0azAldxsxbScQAK6FoNx87heJGhwF2EEyVKO/ z/n++wr3ODkAubRl18dmiLyzFJH9Sknuk8JENgrSvduj3shJejnSGW8/K1Abv4Vq UocNOwH+uP+5Iflqqgiq+EPSBHt5qtm7p78kBCQT1HAYSoiI1lf9ACgGRHpb4hfS g5gqC/DlSvrNNctJRQjb9ExmS0iE62Sq3ZXXZ5cR+Zxt/eXXhIYVvWJNIHoSd4Ln Qa5AylhEMI0EHJqDbS/kDTbUF6KfkSErpgwQ0SfCFjjAOqBRMJlPvLU8k9FTsbMr ubS8UKolhJg9bQY94ILjc8c4QudV0Y2+ZtK97BhHkduqbHR3kcQmaw/TNM4nuWp/ SPhCW/GjGKTIl2RkByzVId37i1rXx25xmTrkkkyHbGyneNnZmfA0knqzh4/0eMx3 /0BmcXZ00YuNslz+LjKU7mWPTIW4LKdlXZogP9N6n9Oc5cv1I3sz6X4PKyCX3q23 F2ZHbxjS/invjGqMeivaWJZuFqwSbmK0JpZKJ7KmRc5KKXx7XM5kC5m0lsBJQIqn lon80K5eaKk2m7maeWYTvNy2Xx066yaxTxDojLo/3y47JotJtXejHyj2cHtVfw7R V5ypH+gvRAMZr/QbL5sFI3JTU+kC8A88rSdPa63ZdH9/ygN42BU6ZajqhQr0GHnR yO5z2uXz7Rr47RJH07MC =C/SA -----END PGP SIGNATURE----- --=_DpfSZQ0oBqv18dJF2xBUxA1--