From mike.gabriel@das-netzwerkteam.de Sat Jun 21 22:26:53 2014 Received: (at 516) by bugs.x2go.org; 21 Jun 2014 20:26:54 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.2 Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 8E31F5DB17 for <516@bugs.x2go.org>; Sat, 21 Jun 2014 22:26:53 +0200 (CEST) Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98]) by freya.das-netzwerkteam.de (Postfix) with ESMTPS id 31C7513672; Sat, 21 Jun 2014 22:26:53 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 124243BA5D; Sat, 21 Jun 2014 22:26:53 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de Received: from grimnir.das-netzwerkteam.de ([127.0.0.1]) by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JvCzBzw29Sze; Sat, 21 Jun 2014 22:26:52 +0200 (CEST) Received: from grimnir.das-netzwerkteam.de (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id CAADE3BA57; Sat, 21 Jun 2014 22:26:52 +0200 (CEST) Received: from pD9E9FFDD.dip0.t-ipconnect.de (pD9E9FFDD.dip0.t-ipconnect.de [217.233.255.221]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP; Sat, 21 Jun 2014 20:26:52 +0000 Date: Sat, 21 Jun 2014 20:26:52 +0000 Message-ID: <20140621202652.Horde.LiYq_wQOnGyIyKjpwY8pEg1@mail.das-netzwerkteam.de> From: Mike Gabriel To: Mihai Moldovan Cc: 516@bugs.x2go.org Subject: Re: [X2Go-Dev] Bug#516: [PATCH 1/5] Create Windows on Big Endian 64bit systems References: <53A4F5FE.4000206@ionic.de> <53A4F8DF.30404@ionic.de> In-Reply-To: <53A4F8DF.30404@ionic.de> User-Agent: Internet Messaging Program (IMP) H5 (6.1.7) Accept-Language: en,de Organization: DAS-NETZWERKTEAM X-Originating-IP: 217.233.255.221 X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:30.0) Gecko/20100101 Firefox/30.0 Iceweasel/30.0 Content-Type: multipart/signed; boundary="=_8Kp-RaWGLVcWuH5TyOHiMg1"; protocol="application/pgp-signature"; micalg=pgp-sha1 MIME-Version: 1.0 This message is in MIME format and has been PGP signed. --=_8Kp-RaWGLVcWuH5TyOHiMg1 Content-Type: text/plain; charset=ISO-8859-1; format=flowed; DelSp=Yes Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Mihai, thanks for digging into this. I wish you could work more on NX!!! Good work= !!! On Sa 21 Jun 2014 05:15:43 CEST, Mihai Moldovan wrote: > An endiannes issue was setting incorrect event masks when creating=20=20 >=20X11 windows. > > This time, a smaller integer has been casted to a bigger one and=20=20 >=20passed to some > function actually setting its value. > > This meant, that garbage from stack was attached to the smaller=20=20 >=20integer value, > putting unknown memory into the lower bytes of the bigger integer. > > Fix this by creating a big, initialized temporary variable, let the=20=20 >=20function do > its magic on that one and pass the value back to the smaller variable -- = and > cross your fingers the smaller variable can hold it without overrunning. = (The > last bit is a design issue we can't really fix and has been around=20=20 >=20even before > this patch.) I have a question on this patch. While integrating it into the=20=20 nx-libs.git=20repo, I realized, that it can be applied to Windows.c=20=20 twice.=20Once at the position that you provide in the patch file,=20=20 another=20(second) time around line 2895... """ mike@minobo:~/MyDocuments/4projects/x2go-upstream/nx-libs$ patch -p1 <=20= =20 nxagent_Window.c-ppc64-create-windows.patch patching=20file nx-X11/programs/Xserver/hw/nxagent/Window.c Hunk #1 succeeded at 2894 (offset 2559 lines). """ Maybe the same patch is needed at that second position? Mike --=20 DAS-NETZWERKTEAM mike=20gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.x= fb --=_8Kp-RaWGLVcWuH5TyOHiMg1 Content-Type: application/pgp-signature Content-Description: Digitale PGP-Signatur Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABAgAGBQJTpeqMAAoJEJr0azAldxsxM0AQAJyjbWU3jLt/V0m7tHa8nVxr QGnIqdqdezASCtquioJmC7at2G5aJ2yFdiCBahwdj5xX0rCz4UFwkkbdfj4macPL CXACkdFlrCFoLmYhBcZvovK5ud2grYoxVlTxnHYYDnxvKGxKJ8dorFTJ2m2DIxaw 7h+nykaab14B3i8kVNpjzuZEMcUe0SWSKnl7zQZrRU1CVr6nrsLE9hyOMONR/YWg Yc94UXPd02GQGGoUfG27HUuDQ9pjJmy/Xle9OsINjiymoBkodCnn9LbTvd1FyYnT 2UjmhXIDf2E/F1ZY2gA+70EVbol1GT4mBFMiKpMK5FZoHojia+oS8N6A3wrK1yma XRS61ZghfUUWCLxYUwtKQ1jjJWrWuy7BCGN3+DjyAIj5T8J01mv4++/qhvm5Th0c +YKRHzqmOaZ+WYMM9XUR25FQd0bMDjVcUCT61CW9nNK8ID3mmtsCWyHww9Tl+fGs T2cP4fk6+uKgC3gP0EtUgNnP2OMh9L9EoqC3IB1dgaDWbid1qWQbqc/eRPvJ0+8+ Y5xBWCvzB92gdiLqaYeUEI0hdcepwxhd1eM6JKDWzwsTbXfzWs8tdjaA/y4bWQe6 C1tLvBWRRI88GpXqKQyKDF2MwWnUixORXxKrpQymnYzZ/LrHJ+12yiTTmcZnPOAX G1tTPSMqld/KFb0hEOs6 =GWKz -----END PGP SIGNATURE----- --=_8Kp-RaWGLVcWuH5TyOHiMg1--