From s.chabrolles@fr.ibm.com Sun Jun 22 00:05:53 2014 Received: (at 516) by bugs.x2go.org; 21 Jun 2014 22:05:54 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,HTML_MESSAGE autolearn=ham version=3.3.2 Received: from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id EDED45DB17 for <516@bugs.x2go.org>; Sun, 22 Jun 2014 00:05:52 +0200 (CEST) Received: from /spool/local by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for <516@bugs.x2go.org> from ; Sat, 21 Jun 2014 23:05:51 +0100 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp12.uk.ibm.com (192.168.101.142) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Sat, 21 Jun 2014 23:05:50 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id D9AC517D8047 for <516@bugs.x2go.org>; Sat, 21 Jun 2014 23:07:15 +0100 (BST) Received: from d06av11.portsmouth.uk.ibm.com (d06av11.portsmouth.uk.ibm.com [9.149.37.252]) by b06cxnps4074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s5LM5nD521692524 for <516@bugs.x2go.org>; Sat, 21 Jun 2014 22:05:49 GMT Received: from d06av11.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av11.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s5LM5nBC006526 for <516@bugs.x2go.org>; Sat, 21 Jun 2014 16:05:49 -0600 Received: from d06ml381.portsmouth.uk.ibm.com (d06ml381.portsmouth.uk.ibm.com [9.149.104.236]) by d06av11.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id s5LM5n9d006523; Sat, 21 Jun 2014 16:05:49 -0600 To: "Mihai Moldovan" , "Mike Gabriel" , "Stefan Baur" In-Reply-To: <20140621202652.Horde.LiYq_wQOnGyIyKjpwY8pEg1@mail.das-netzwerkteam.de> Message-ID: <1D1AF40D-4B5B-469A-AB96-38194C127D65@fr.ibm.com> Date: Sat, 21 Jun 2014 23:05:49 +0100 From: sebastien chabrolles MIME-Version: 1.0 Subject: Re: [X2Go-Dev] Bug#516: Bug#516: [PATCH 1/5] Create Windows on Big Endian 64bit systems Cc: "516@bugs.x2go.org" <516@bugs.x2go.org> X-Mailer: Lotus Notes Traveler 8.5.3.200 Build 201307170759 X-MIMETrack: Itemize by Notes Server on D06WGW82/06/G/IBM(Release 8.5.3FP5HF210 | October 8, 2013) at 21/06/2014 23:05:48, Serialize by Router on D06ML381/06/M/IBM(Release 8.5.3FP5IF1HF3|November 07, 2013) at 22/06/2014 00:05:49 MIME-Version: 1.0 Content-Type: multipart/alternative; boundary=Apple-Mail-7CB3CB28-AAEF-49C1-8486-F8F4E05EE331 X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14062122-8372-0000-0000-00000048CD24 --Apple-Mail-7CB3CB28-AAEF-49C1-8486-F8F4E05EE331 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi all, I just test on the Power8 system and It works !!!!!!! Many thanks to all of you for your help; Especially to Mihai "the Endian bu= g killer" for his fantastic work.=20 ---=20 S=C3=A9bastien Chabrolles=20 Power Systems Benchmark Specialist IBM Client Center, Montpellier=20 1 rue vieille poste 34000 Montpellier FRANCE=20 Tel +33 4 67 34 40 95=20 Email : s.chabrolles@fr.ibm.com > Le 21 juin 2014 =C3=A0 22:30, "Mike Gabriel" a =C3=A9crit : >=20 > Hi Mihai, >=20 > thanks for digging into this. I wish you could work more on NX!!! Good wo= rk!!! >=20 > On Sa 21 Jun 2014 05:15:43 CEST, Mihai Moldovan wrote: >=20 > > An endiannes issue was setting incorrect event masks when creating > > X11 windows. > > > > This time, a smaller integer has been casted to a bigger one and > > passed to some > > function actually setting its value. > > > > This meant, that garbage from stack was attached to the smaller > > integer value, > > putting unknown memory into the lower bytes of the bigger integer. > > > > Fix this by creating a big, initialized temporary variable, let the > > function do > > its magic on that one and pass the value back to the smaller variable -= - and > > cross your fingers the smaller variable can hold it without overrunning= . (The > > last bit is a design issue we can't really fix and has been around > > even before > > this patch.) >=20 > I have a question on this patch. While integrating it into the > nx-libs.git repo, I realized, that it can be applied to Windows.c > twice. Once at the position that you provide in the patch file, > another (second) time around line 2895... >=20 > """ > mike@minobo:~/MyDocuments/4projects/x2go-upstream/nx-libs$ patch -p1 < > nxagent=5FWindow.c-ppc64-create-windows.patch > patching file nx-X11/programs/Xserver/hw/nxagent/Window.c > Hunk #1 succeeded at 2894 (offset 2559 lines). > """ >=20 > Maybe the same patch is needed at that second position? >=20 > Mike >=20 > -- >=20 > DAS-NETZWERKTEAM > mike gabriel, herweg 7, 24357 fleckeby > fon: +49 (1520) 1976 148 >=20 > GnuPG Key ID 0x25771B31 > mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de >=20 > freeBusy: > https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de= .xfb > =5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F= =5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F > x2go-dev mailing list > x2go-dev@lists.x2go.org > http://lists.x2go.org/listinfo/x2go-dev --Apple-Mail-7CB3CB28-AAEF-49C1-8486-F8F4E05EE331 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
Hi all,

I= just test on the Power8 system and It works !!!!!!!

Many thanks to all of you for your help; Especially to Mihai "the Endian= bug killer" for his fantastic work. 

--- 
S=C3=A9bastien = Chabrolles 
Power Systems Benchmark Specialist
IBM Client Center= , Montpellier 
1 rue vieille poste 34000 Montpellier FRANCE&nb= sp;
Tel +33 4 67 34 40 95 

Le 21 juin 2014 =C3=A0 22:30, "Mike Gabriel" <mike.gabriel@das-netzwerkteam.de&= gt; a =C3=A9crit :

Hi Mihai,

thanks for digging into this. I wish you could work more on NX!!! Good work=
!!!

On  Sa 21 Jun 2014 05:15:43 CEST, Mihai Moldovan wrote:

> An endiannes issue was setting incorrect event masks when creating
> X11 windows.
>
> This time, a smaller integer has been casted to a bigger one and
> passed to some
> function actually setting its value.
>
> This meant, that garbage from stack was attached to the smaller
> integer value,
> putting unknown memory into the lower bytes of the bigger integer.
>
> Fix this by creating a big, initialized temporary variable, let the
> function do
> its magic on that one and pass the value back to the smaller variable =
-- and
> cross your fingers the smaller variable can hold it without overrunnin=
g. (The
> last bit is a design issue we can't really fix and has been around
> even before
> this patch.)

I have a question on this patch. While integrating it into the
nx-libs.git repo, I realized, that it can be applied to Windows.c
twice. Once at the position that you provide in the patch file,
another (second) time around line 2895...

"""
mike@minobo:~/MyDocuments/4projects/x2go-upstream/nx-libs$ patch -p1 <
nxagent=5FWindow.c-ppc64-create-windows.patch
patching file nx-X11/programs/Xserver/hw/nxagent/Window.c
Hunk #1 succeeded at 2894 (offset 2559 lines).
"""

Maybe the same patch is needed at that second position?

Mike

--

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-=
netzwerkteam.de, http://das-netz=
werkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-ne=
tzwerkteam.de.xfb

=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=
=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=
=5F
x2go-dev mailing list
x2go-dev@lists.x2go.org
http://lists.x2go.org/l=
istinfo/x2go-dev
--Apple-Mail-7CB3CB28-AAEF-49C1-8486-F8F4E05EE331--