From ionic@ionic.de Sat Jun 21 23:35:26 2014 Received: (at 516) by bugs.x2go.org; 21 Jun 2014 21:35:27 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID autolearn=ham version=3.3.2 Received: from Root24.de (powered.by.root24.eu [91.121.15.64]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 27FA15DB17 for <516@bugs.x2go.org>; Sat, 21 Jun 2014 23:35:26 +0200 (CEST) Received: from nopileos.local (home.ionic.de [85.183.67.131]) by Root24.de (Postfix) with ESMTPSA id 9FD403B005C9; Sat, 21 Jun 2014 23:35:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ionic.de; s=default; t=1403386525; bh=vkYHBvHa92ni0UVMs0LL7/fstSYrUeKZdUkOEb1wvdE=; h=Date:From:To:CC:Subject:References:In-Reply-To:From; b=bRf+YPmm5a6w2SRfSNHIGo/lZkDfgmSwO5Og/ae2URNO0dhEs+AJMi5dZphCWK47T zpZ9sKQMhwq4NzuCzDNTjqi3oIHYUpEJpdjLZJrk9LGkjqFRbBLpkyJXoe4ouXZqzV EvkUGV3cqr5hFOwDVfK1Qy2E0eB9V+fdqu/dg9+Q= Message-ID: <53A5FA9E.307@ionic.de> Date: Sat, 21 Jun 2014 23:35:26 +0200 From: Mihai Moldovan User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Mike Gabriel CC: 516@bugs.x2go.org Subject: Re: [X2Go-Dev] Bug#516: [PATCH 1/5 v2] Create Windows and fix drawing issues on Big Endian 64bit systems References: <53A4F5FE.4000206@ionic.de> <53A4F8DF.30404@ionic.de> <53A5F55B.4020000@ionic.de> <20140621212307.Horde.Lb8d0ZTl6Jk-uQuFW1Bf_w2@mail.das-netzwerkteam.de> In-Reply-To: <20140621212307.Horde.Lb8d0ZTl6Jk-uQuFW1Bf_w2@mail.das-netzwerkteam.de> X-Enigmail-Version: 1.6 Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha1; boundary="------------ms080707070801040809020209" This is a cryptographically signed message in MIME format. --------------ms080707070801040809020209 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 * On 21.06.2014 11:23 pm, Mike Gabriel wrote: > Hi Mihai, > > On Sa 21 Jun 2014 23:12:59 CEST, Mihai Moldovan wrote: > >> Multiple endiannes issues were setting incorrect event masks when crea= ting and >> drawing X11 windows. >> >> This time, a smaller integer has been casted to a bigger one and passe= d to some >> function actually setting its value. >> >> This meant, that garbage from stack was attached to the smaller intege= r value, >> putting unknown memory into the lower bytes of the bigger integer. >> >> Fix this by creating a big, initialized temporary variable, let the fu= nction do >> its magic on that one and pass the value back to the smaller variable = -- and >> cross your fingers the smaller variable can hold it without overrunnin= g. (The >> last bit is a design issue we can't really fix and has been around eve= n before >> this patch.) >> >> >> This fixes window creation and redrawing/updating issues on Big Endian= 64bit >> systems. > > Fixed patch included. However, unfortunately I forgot to rebase before = pushing... Thanks, Mike! Unfortunately the "057_nx-X11-bigendian-ppc64-no-session-window.full.patc= h" description is still the "old" one. Mind updating that? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (Darwin) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCgAGBQJTpfqeAAoJEB/WLtluJTqHtc4P/3RB4o6sfk0xP8LAqxNRk42q beKzVXVUEBiRgXJmDfnkDbHav/AAe2M6ATxPMdut+EYUmk/+W9dzrJwZHPoD5shu /TmPRV3EYIaoGDOKo3ZXZP/k+rkFXg1eBrnDgzoJJf0bF7fn9NztJ3vqHjSA8Cu7 VMtw7/J/uXBffSni0UKjaCtMHOe/GnrZM6bcjph6AykiLT0xPOXOxx1kTXvGeNx0 uFG3maxHYJC/nf2zs8pPt9/5K/lc+v09RoJptrFjZpzzIldCki0Q1/n3jZhsm5mJ 9dDeQg59wIyCSo7OU2vVX2RLByvAzkfr8TaU1+zThYkf58NJNmpuXXqBPuDXC0PI Ve51GrUF4mLz2bdZD57d27iYyu9H41S+5c6GNkhcObVHd6C6MKfL5AqwIgGvSbie If3+s7kpDv8p6UqERL6PnSBT6HMk8cYbNc2+mA9cFisYwi/kwESc5jd8odz2oG08 uTT+AS6MIncg9l5OSPKT79BGLNm390beY3C+hIgo84zyRCFghMOmdPRbCSOOOjR2 0f8hiN5QHxH59m4ZNKkE0eE5RY61AFMdn+PE5zqX6p75e4YxYG8oOjYcE2L6mtTG miT0YqEItpP//v2m7jr0g1FfT73sFXGDSnL/VrXiRR0eJJ/QSahYWtkGEgRV6RYg Fi+nHSePnoeo04jx3twM =3DpKrh -----END PGP SIGNATURE----- --------------ms080707070801040809020209 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIMkTCC BjQwggQcoAMCAQICASAwDQYJKoZIhvcNAQEFBQAwfTELMAkGA1UEBhMCSUwxFjAUBgNVBAoT DVN0YXJ0Q29tIEx0ZC4xKzApBgNVBAsTIlNlY3VyZSBEaWdpdGFsIENlcnRpZmljYXRlIFNp Z25pbmcxKTAnBgNVBAMTIFN0YXJ0Q29tIENlcnRpZmljYXRpb24gQXV0aG9yaXR5MB4XDTA3 MTAyNDIxMDI1NVoXDTE3MTAyNDIxMDI1NVowgYwxCzAJBgNVBAYTAklMMRYwFAYDVQQKEw1T dGFydENvbSBMdGQuMSswKQYDVQQLEyJTZWN1cmUgRGlnaXRhbCBDZXJ0aWZpY2F0ZSBTaWdu aW5nMTgwNgYDVQQDEy9TdGFydENvbSBDbGFzcyAyIFByaW1hcnkgSW50ZXJtZWRpYXRlIENs aWVudCBDQTCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAMsohUWcASz7GfKrpTOM KqANy9BV7V0igWdGxA8IU77L3aTxErQ+fcxtDYZ36Z6GH0YFn7fq5RADteP0AYzrCA+EQTfi 8q1+kA3m0nwtwXG94M5sIqsvs7lRP1aycBke/s5g9hJHryZ2acScnzczjBCAo7X1v5G3yw8M DP2m2RCye0KfgZ4nODerZJVzhAlOD9YejvAXZqHksw56HzElVIoYSZ3q4+RJuPXXfIoyby+Y 2m1E+YzX5iCZXBx05gk6MKAW1vaw4/v2OOLy6FZH3XHHtOkzUreG//CsFnB9+uaYSlR65cdG zTsmoIK8WH1ygoXhRBm98SD7Hf/r3FELNvUCAwEAAaOCAa0wggGpMA8GA1UdEwEB/wQFMAMB Af8wDgYDVR0PAQH/BAQDAgEGMB0GA1UdDgQWBBSuVYNv7DHKufcd+q9rMfPIHeOsuzAfBgNV HSMEGDAWgBROC+8apEBbpRdphzDKNGhD0EGu8jBmBggrBgEFBQcBAQRaMFgwJwYIKwYBBQUH MAGGG2h0dHA6Ly9vY3NwLnN0YXJ0c3NsLmNvbS9jYTAtBggrBgEFBQcwAoYhaHR0cDovL3d3 dy5zdGFydHNzbC5jb20vc2ZzY2EuY3J0MFsGA1UdHwRUMFIwJ6AloCOGIWh0dHA6Ly93d3cu c3RhcnRzc2wuY29tL3Nmc2NhLmNybDAnoCWgI4YhaHR0cDovL2NybC5zdGFydHNzbC5jb20v c2ZzY2EuY3JsMIGABgNVHSAEeTB3MHUGCysGAQQBgbU3AQIBMGYwLgYIKwYBBQUHAgEWImh0 dHA6Ly93d3cuc3RhcnRzc2wuY29tL3BvbGljeS5wZGYwNAYIKwYBBQUHAgEWKGh0dHA6Ly93 d3cuc3RhcnRzc2wuY29tL2ludGVybWVkaWF0ZS5wZGYwDQYJKoZIhvcNAQEFBQADggIBADqp Jw3I07QWke9plNBpxUxcffc7nUrIQpJHDci91DFG7fVhHRkMZ1J+BKg5UNUxIFJ2Z9B90Mic c/NXcs7kPBRdn6XGO/vPc87Y6R+cWS9Nc9+fp3Enmsm94OxOwI9wn8qnr/6o3mD4noP9Jphw UPTXwHovjavRnhUQHLfo/i2NG0XXgTHXS2Xm0kVUozXqpYpAdumMiB/vezj1QHQJDmUdPYMc p+reg9901zkyT3fDW/ivJVv6pWtkh6Pw2ytZT7mvg7YhX3V50Nv860cV11mocUVcqBLv0gcT +HBDYtbuvexNftwNQKD5193A7zN4vG7CTYkXxytSjKuXrpEatEiFPxWgb84nVj25SU5q/r1X hwby6mLhkbaXslkVtwEWT3Van49rKjlK4XrUKYYWtnfzq6aSak5u0Vpxd1rY79tWhD3EdCvO hNz/QplNa+VkIsrcp7+8ZhP1l1b2U6MaxIVteuVMD3X0vziIwr7jxYae9FZjbxlpUemqXjcC 0QaFfN7qI0JsQMALL7iGRBg7K0CoOBzECdD3fuZil5kU/LP9cr1BK31U0Uy651bFnAMMMkqh AChIbn0ei72VnbpSsrrSdF0BAGYQ8vyHae5aCg+H75dVCV33K6FuxZrf09yTz+Vx/PkdRUYk XmZz/OTfyJXsUOUXrym6KvI2rYpccSk5MIIGVTCCBT2gAwIBAgICR5UwDQYJKoZIhvcNAQEL BQAwgYwxCzAJBgNVBAYTAklMMRYwFAYDVQQKEw1TdGFydENvbSBMdGQuMSswKQYDVQQLEyJT ZWN1cmUgRGlnaXRhbCBDZXJ0aWZpY2F0ZSBTaWduaW5nMTgwNgYDVQQDEy9TdGFydENvbSBD bGFzcyAyIFByaW1hcnkgSW50ZXJtZWRpYXRlIENsaWVudCBDQTAeFw0xNDAzMTkwNDMzMzFa Fw0xNjAzMTgxNTIzMjJaMHYxCzAJBgNVBAYTAkRFMRswGQYDVQQIExJCYWRlbi1XdWVydHRl bWJlcmcxEjAQBgNVBAcTCUthcmxzcnVoZTEXMBUGA1UEAxMOTWloYWkgTW9sZG92YW4xHTAb BgkqhkiG9w0BCQEWDmlvbmljQGlvbmljLmRlMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIB CgKCAQEAy1U08dzMfc3SpuUBHL+ZgUQJs4gX7DLBAr89BAoQkIEkMhlEGJ1OGBqvbOuGBlyd l/BSa/vrkTFqrHjxs4UhYG/nide97RsalQ39eolmd/WSn1I0M3Ohg/LAnCt2v9mMx1Sx8QpE jzLVvdMwO4mEJWH4+w8e8bLLIzN66/rAuD0EVeyWJh6pggCjI+Y59t0aqI7vzjcqgJGtmwHZ VPtBhWP3jsDUhLjwxUeydFEwteh/fpo3czx4aKKMH0K53HHGfGZHl5IK/E8ZdL+veF4JSRs5 nCKAikwbtua3sMY1ejPRc2L5CyZAJvmfaKjBCi5/3j/DxYrEK+sH32AYUxbgYQIDAQABo4IC 1DCCAtAwCQYDVR0TBAIwADALBgNVHQ8EBAMCBLAwHQYDVR0lBBYwFAYIKwYBBQUHAwIGCCsG AQUFBwMEMB0GA1UdDgQWBBSaZelU6HGlOzMKCINjBgsaA/nXxTAfBgNVHSMEGDAWgBSuVYNv 7DHKufcd+q9rMfPIHeOsuzAZBgNVHREEEjAQgQ5pb25pY0Bpb25pYy5kZTCCAUwGA1UdIASC AUMwggE/MIIBOwYLKwYBBAGBtTcBAgMwggEqMC4GCCsGAQUFBwIBFiJodHRwOi8vd3d3LnN0 YXJ0c3NsLmNvbS9wb2xpY3kucGRmMIH3BggrBgEFBQcCAjCB6jAnFiBTdGFydENvbSBDZXJ0 aWZpY2F0aW9uIEF1dGhvcml0eTADAgEBGoG+VGhpcyBjZXJ0aWZpY2F0ZSB3YXMgaXNzdWVk IGFjY29yZGluZyB0byB0aGUgQ2xhc3MgMiBWYWxpZGF0aW9uIHJlcXVpcmVtZW50cyBvZiB0 aGUgU3RhcnRDb20gQ0EgcG9saWN5LCByZWxpYW5jZSBvbmx5IGZvciB0aGUgaW50ZW5kZWQg cHVycG9zZSBpbiBjb21wbGlhbmNlIG9mIHRoZSByZWx5aW5nIHBhcnR5IG9ibGlnYXRpb25z LjA2BgNVHR8ELzAtMCugKaAnhiVodHRwOi8vY3JsLnN0YXJ0c3NsLmNvbS9jcnR1Mi1jcmwu Y3JsMIGOBggrBgEFBQcBAQSBgTB/MDkGCCsGAQUFBzABhi1odHRwOi8vb2NzcC5zdGFydHNz bC5jb20vc3ViL2NsYXNzMi9jbGllbnQvY2EwQgYIKwYBBQUHMAKGNmh0dHA6Ly9haWEuc3Rh cnRzc2wuY29tL2NlcnRzL3N1Yi5jbGFzczIuY2xpZW50LmNhLmNydDAjBgNVHRIEHDAahhho dHRwOi8vd3d3LnN0YXJ0c3NsLmNvbS8wDQYJKoZIhvcNAQELBQADggEBAH650RIseEtEpaRd Av66u9KEu5mxHpRH8IopkCkwGBk95sSKSWVqJ6XbTHywi66GAqQ7LPlD5ittkhTlYtyst8vb FLaafu6Ous2UDZhqJH1NHfRaG6m0Qt2Zm7KQsaxIhBEYFqqMxSq2E8DQU6WUB473bEqToVx+ pumW+T/KSnHq+FfCGSPvXtwkRP4eiJmvNPZKhGRk3RPkT3LzA380mX6DpcqEQ1a8TmsFBZ7c AMa7KKDe4YnxDFSE/2C1WA5bibpmkCGa+R/0KBBWxDrzNUv6W8Ui6OzpkHTaqg+c9NpC1wDl xt3r8GaytqtcHfB2VEbPd0Hrd+zrDh3co8/SkqgxggPaMIID1gIBATCBkzCBjDELMAkGA1UE BhMCSUwxFjAUBgNVBAoTDVN0YXJ0Q29tIEx0ZC4xKzApBgNVBAsTIlNlY3VyZSBEaWdpdGFs IENlcnRpZmljYXRlIFNpZ25pbmcxODA2BgNVBAMTL1N0YXJ0Q29tIENsYXNzIDIgUHJpbWFy eSBJbnRlcm1lZGlhdGUgQ2xpZW50IENBAgJHlTAJBgUrDgMCGgUAoIICGzAYBgkqhkiG9w0B CQMxCwYJKoZIhvcNAQcBMBwGCSqGSIb3DQEJBTEPFw0xNDA2MjEyMTM1MjZaMCMGCSqGSIb3 DQEJBDEWBBQZsaCjU8JveaOGRIhs3a7Y9tUcgDBsBgkqhkiG9w0BCQ8xXzBdMAsGCWCGSAFl AwQBKjALBglghkgBZQMEAQIwCgYIKoZIhvcNAwcwDgYIKoZIhvcNAwICAgCAMA0GCCqGSIb3 DQMCAgFAMAcGBSsOAwIHMA0GCCqGSIb3DQMCAgEoMIGkBgkrBgEEAYI3EAQxgZYwgZMwgYwx CzAJBgNVBAYTAklMMRYwFAYDVQQKEw1TdGFydENvbSBMdGQuMSswKQYDVQQLEyJTZWN1cmUg RGlnaXRhbCBDZXJ0aWZpY2F0ZSBTaWduaW5nMTgwNgYDVQQDEy9TdGFydENvbSBDbGFzcyAy IFByaW1hcnkgSW50ZXJtZWRpYXRlIENsaWVudCBDQQICR5UwgaYGCyqGSIb3DQEJEAILMYGW oIGTMIGMMQswCQYDVQQGEwJJTDEWMBQGA1UEChMNU3RhcnRDb20gTHRkLjErMCkGA1UECxMi U2VjdXJlIERpZ2l0YWwgQ2VydGlmaWNhdGUgU2lnbmluZzE4MDYGA1UEAxMvU3RhcnRDb20g Q2xhc3MgMiBQcmltYXJ5IEludGVybWVkaWF0ZSBDbGllbnQgQ0ECAkeVMA0GCSqGSIb3DQEB AQUABIIBAFtIR8MN/YMDfzIai1C0h4iCyTXGTIfMI1+r5JvUJ1W3CBTZaXbWGyfCs0oFCHan cgtqhGENX/FcHzXsckkXX/GXOvQSdD4Wl5XTj5mSb/0/TauSOn5VqhkbMM8orgcKcMl19jfZ PQpr4/VaikrAdyUEcl9ptGHl7m9fZU5WrOhicwnTbxFDArwllKy7DylwWfQF2ama1dviTkQg +acHbpv0U8sf+/gRnbb4MLbrNHDNfnEBXCXmx29WdU/tBpkl5/XwdAbV/dBSNi0vXyiUBp4y kzDj4GahyIk6baND+h86zxNKrJJ3YPdueVxBLwMn92gufrXisk3iLnNMykFcBWkAAAAAAAA= --------------ms080707070801040809020209--