From unknown Mon Apr 27 18:55:22 2026 X-Loop: owner@bugs.x2go.org Subject: Bug#499: Fwd: [Bug 1097757] New: [abrt] x2goclient: QString(): x2goclient killed by SIGSEGV Reply-To: Mihai Moldovan , 499@bugs.x2go.org Resent-From: Mihai Moldovan Resent-To: x2go-dev@lists.x2go.org Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Wed, 01 Mar 2017 07:20:01 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: followup 499 X-X2Go-PR-Package: x2goclient X-X2Go-PR-Keywords: pending Received: via spool by 499-submit@bugs.x2go.org id=B499.148835272824627 (code B ref 499); Wed, 01 Mar 2017 07:20:01 +0000 Received: (at 499) by bugs.x2go.org; 1 Mar 2017 07:18:48 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-0.1 required=3.0 tests=BAYES_20,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 0F5463BC8D for <499@bugs.x2go.org>; Wed, 1 Mar 2017 08:18:44 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FpAIntIaHMog for <499@bugs.x2go.org>; Wed, 1 Mar 2017 08:18:36 +0100 (CET) Received: from Root24.de (powered.by.root24.eu [5.135.3.88]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 459F53BC8C for <499@bugs.x2go.org>; Wed, 1 Mar 2017 08:18:36 +0100 (CET) Received: from nopileos.local (178.162.222.41.adsl.inet-telecom.org [178.162.222.41]) by mail.ionic.de (Postfix) with ESMTPSA id BE2BC4F002E1; Wed, 1 Mar 2017 08:18:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ionic.de; s=default; t=1488352714; bh=Im+KHhTkpf0stTEgBb9H3dptsNXwaPYIDrptub7ZZqA=; h=Subject:To:References:From:Date:In-Reply-To:From; b=XpneHbh20kzzaJC+iQ2sHdq3Dc7/5Yfbg8n/r1ZZmJo66eOLNPjLf6kqPYD6QXCVE 3SVRJWiog2JUg0ls2C7oi3A+bYo4NvE7jNludlGJ2xWwSjDALvpGH7peDlu/6SK5KN Cz70vWp+lvvR/Qs4kDLvvcnckbm2z5rBgd/pfIuU= To: Orion Poplawski , 499@bugs.x2go.org References: <53738360.6090505@cora.nwra.com> From: Mihai Moldovan Message-ID: <222cffd6-1e96-3dca-fdd4-1e1c8e02b173@ionic.de> Date: Wed, 1 Mar 2017 08:18:30 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <53738360.6090505@cora.nwra.com> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="r848xdcnCKVPrwXp2EHW2Lw1mS4emgUus" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --r848xdcnCKVPrwXp2EHW2Lw1mS4emgUus Content-Type: multipart/mixed; boundary="2xJODNXPC4FeWfxTRSENm7Gd021491Rgv"; protected-headers="v1" From: Mihai Moldovan To: Orion Poplawski , 499@bugs.x2go.org Message-ID: <222cffd6-1e96-3dca-fdd4-1e1c8e02b173@ionic.de> Subject: Re: Fwd: [Bug 1097757] New: [abrt] x2goclient: QString(): x2goclient killed by SIGSEGV References: <53738360.6090505@cora.nwra.com> In-Reply-To: <53738360.6090505@cora.nwra.com> --2xJODNXPC4FeWfxTRSENm7Gd021491Rgv Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 14.05.2014 04:53 PM, Orion Poplawski wrote: > Package: x2goclient > Version: 4.0.2.0 >=20 > Looks like: >=20 > #1 id (this=3D0x0) at ../sessionbutton.h:39 > No locals. > #2 ONMainWindow::slotSuspendSess (this=3Dthis@entry=3D0x1ad1ab0) at=20 > ../onmainwindow.cpp:4620 >=20 > X2goSettings st ( "sessions" ); > QString sid=3DlastSession->id(); >=20 > lastSession is null and not being checked. Probably applies to other p= arts of=20 > the code as well. I don't know if that's still a problem, since the session manager/explore= r feature was added in the meantime, but I've tried to add guards to most locations, except where it was obvious that getLastSession() must return non-NULL because we already checked it before. Should it ever actually be NULL, at least it shouldn't crash (at this poi= nt) any longer, but I admit that I don't know how the client behaves when just re= turning out of these functions without doing its work. Mihai --2xJODNXPC4FeWfxTRSENm7Gd021491Rgv-- --r848xdcnCKVPrwXp2EHW2Lw1mS4emgUus Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCgAGBQJYtnXIAAoJEB/WLtluJTqH+4AQAJt6nlSwmW5/1zPU6Mbq8MIs lRh7t+rxPNfFWwl8Gc/cql6V0sJzGUOeQmpebWM+bDrie+kRlYVB82egNjPPdUxJ cW3dp0v62MSNnFtwNFVG9WHmGPxIusmtTNXUqP7tRru+WHf3d1d5rN0opokEKTgB w0QEmgh4jXW6CLBooYNYYfjIEwwVIbGr7ysQKTDXmLbEySNa6EPPnBYt2l7FW8Mg tZ+Vtbc4jjmzoQti9XM0+q+eyrwV7qOUTEZJkbRc68LqsKTMOO9K+zsBUmZGPw3l Rxycn/WDb51N1lqo2EBxHYFtSGOtaxieh27Sw2lDlp8Kn47ruChm5ScCLDkDhDRV J/Ih5G4ermvV+23LP/y65DU44IsE/sYDUp3mvVhQ6gb2uW8E+o6Oc0669UTXaX2f buMllBgD2ulrMysSRd3Zi932LjuJXQcKY62LRQErU5idksG/hwCU9pRjHyGRm5er S7TLvpHzXlUG+mKK1HeG0CPGD+BjZEyBIISqMAYL94vtenc86D4g1h3apqAruGug xCX6Cz73ipjVGfqyRX933cMEkowOrG75j8NUUAhrveWqtYhvKVT89hGsM15Q7Dff Ltdm9ldhwICLGcZc/aCDctRenUNW9Ns+hoomEfLdfFVpOr6L7p0YRlfUJKjzqYeY WGimezmIDWszEvaM8CbX =xlDs -----END PGP SIGNATURE----- --r848xdcnCKVPrwXp2EHW2Lw1mS4emgUus--