X2Go Bug report logs - #440
Convert from using QHttp to QNetworkAccessManager for Session Broker

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: Joshua Lukens <jlukens@botch.com>

Date: Thu, 27 Feb 2014 14:45:01 UTC

Severity: wishlist

Tags: patch, pending

Found in version 4.0.1.3

Fixed in version 4.0.2.0

Done: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

Bug is archived. No further changes may be made.

Full log

Message #5 received at submit@bugs.x2go.org (full text, mbox, reply):

Received: (at submit) by bugs.x2go.org; 27 Feb 2014 14:41:41 +0000
From jlukens@botch.com  Thu Feb 27 15:41:40 2014
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=ham
	version=3.3.2
X-Greylist: delayed 1502 seconds by postgrey-1.34 at ymir; Thu, 27 Feb 2014 15:41:39 CET
Received: from felt.botch.com (felt.botch.com [207.145.43.98])
	by ymir (Postfix) with ESMTP id 01BD95DB16
	for <submit@bugs.x2go.org>; Thu, 27 Feb 2014 15:41:39 +0100 (CET)
Received: from [127.0.0.1] (unknown [192.168.254.1])
	(Authenticated sender: jlukens)
	by felt.botch.com (Postfix) with ESMTP id 706891AC0C7
	for <submit@bugs.x2go.org>; Thu, 27 Feb 2014 09:16:30 -0500 (EST)
Date: Thu, 27 Feb 2014 09:16:29 -0500
From: Joshua Lukens <jlukens@botch.com>
To: submit@bugs.x2go.org
Message-ID: <84F7E80E06784E5695FC31F4E72E3DC0@botch.com>
Subject: Convert from using QHttp to QNetworkAccessManager for Session
 Broker
X-Mailer: sparrow 1.6.4 (build 1178)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="530f48bd_567bd50a_233f"

[Message part 1 (text/plain, inline)]
Package: x2goclient
Version: 4.0.1.3
Severity: wishlist

QT lists QHttp as "This class is obsolete. It is provided to keep old source code working. We strongly advise against using it in new code."  The current preferred method for making http/https request is to use QNetworkAccessManager.  The attached patch makes that conversion.  I've done light testing on patch with both OSX and Windows clients and it appears functional.
[switch-to-QNetworkAccessManager.patch (application/octet-stream, attachment)]

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Sat Apr 20 11:38:42 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.