From o.shneyder@phoca-gmbh.de  Fri Feb 28 14:43:40 2014
Received: (at 440) by bugs.x2go.org; 28 Feb 2014 13:43:41 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED
	autolearn=ham version=3.3.2
X-Greylist: delayed 1188 seconds by postgrey-1.34 at ymir; Fri, 28 Feb 2014 14:43:40 CET
Received: from mail.cowic.de (mail.cowic.de [80.190.97.242])
	by ymir (Postfix) with ESMTP id 59BF05DB16
	for <440@bugs.x2go.org>; Fri, 28 Feb 2014 14:43:40 +0100 (CET)
Received: from [192.168.0.108] (188-195-168-164-dynip.superkabel.de [188.195.168.164])
	by mail.cowic.de (Postfix) with ESMTP id DC647380B875;
	Fri, 28 Feb 2014 14:23:51 +0100 (CET)
Message-ID: <53108DDC.2030909@phoca-gmbh.de>
Date: Fri, 28 Feb 2014 14:23:40 +0100
From: Oleksandr Shneyder <o.shneyder@phoca-gmbh.de>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10
MIME-Version: 1.0
To: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
CC: 440@bugs.x2go.org, o.schneyder@phoca-gmbh.de
Subject: Re: Request for patch review
References: <20140227151513.Horde.aM8IYVn5opfJd9ozoLbE6w8@mail.das-netzwerkteam.de>
In-Reply-To: <20140227151513.Horde.aM8IYVn5opfJd9ozoLbE6w8@mail.das-netzwerkteam.de>
X-Enigmail-Version: 1.5.1
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="----enig2ONCFBXTNQMORUGVQWJXU"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
------enig2ONCFBXTNQMORUGVQWJXU
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Mike,

it seems good to me. However I can not apply this patch on master branch:=


$ git apply --check switch-to-QNetworkAccessManager.patch
error: patch failed: httpbrokerclient.cpp:93
error: httpbrokerclient.cpp: patch does not apply
error: patch failed: httpbrokerclient.h:62
error: httpbrokerclient.h: patch does not apply

please send correct patch for master branch *without* trailing
whitespaces and I'll test and apply it.

regards,
Alex

Am 27.02.2014 16:15, schrieb Mike Gabriel:
> Hi Alex,
>=20
> can you please review the proposed patch in #440 [1]?
>=20
> Thanks,
> Mike
>=20
> [1] http://bugs.x2go.org/440


--=20
----------------------------------------------------
Oleksandr Shneyder  | Email: o.shneyder@phoca-gmbh.de
phoca GmbH          | Tel. : 0911 - 14870374 0
Br=C3=A4uhausgasse 9     | Fax. : 0911 - 14870374 9
D-82205 Gilching    | Mobil: 0163 - 49 64 461

Gesch=C3=A4ftsf=C3=BChrung:
Dipl.-Inf. Oleksandr Shneyder

Amtsgericht M=C3=BCnchen | http://www.phoca-gmbh.de
HRB 196 658         | http://www.x2go.org
USt-IdNr.: DE281977973
----------------------------------------------------


------enig2ONCFBXTNQMORUGVQWJXU
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Icedove - http://www.enigmail.net/

iEYEARECAAYFAlMQjeYACgkQxQmEC5b4kTNMuQCeLkn4aendN/fgtjQs9S1gHFvA
EIgAn2x5GPkPmpC4Vj78y//ekKBxKtMS
=c4SZ
-----END PGP SIGNATURE-----

------enig2ONCFBXTNQMORUGVQWJXU--