X2Go Bug report logs - #423
FIx more -Werror=format-security errors

version graph

Package: nx-libs; Maintainer for nx-libs is X2Go Developers <x2go-dev@lists.x2go.org>;

Reported by: Orion Poplawski <orion@cora.nwra.com>

Date: Thu, 30 Jan 2014 02:30:02 UTC

Severity: normal

Tags: patch, pending

Found in version 3.5.0.22

Fixed in version 2:3.5.0.23

Done: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

Bug is archived. No further changes may be made.

Full log

Message #52 received at 423@bugs.x2go.org (full text, mbox, reply):

Received: (at 423) by bugs.x2go.org; 7 May 2014 15:41:34 +0000
From orion@cora.nwra.com  Wed May  7 17:41:33 2014
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID,
	URIBL_BLOCKED autolearn=ham version=3.3.2
Received: from mail.cora.nwra.com (mercury.cora.nwra.com [4.28.99.165])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 305EC5DB15
	for <423@bugs.x2go.org>; Wed,  7 May 2014 17:41:32 +0200 (CEST)
Received: from [10.10.20.7] (barry.cora.nwra.com [10.10.20.7])
	(authenticated bits=0)
	by mail.cora.nwra.com (8.14.4/8.14.4) with ESMTP id s47FfUwY031172
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);
	Wed, 7 May 2014 09:41:30 -0600
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=cora.nwra.com;
	s=default; t=1399477290;
	bh=Xz6LwUA/kPGxMSHdYQrQNJiVl45C0r0Kv3lUjyT8kEQ=;
	h=Message-ID:Date:From:MIME-Version:To:Subject:References:
	 In-Reply-To:Content-Type:Content-Transfer-Encoding;
	b=nfWb1Y3FvJvcc8hnsi79EGffQQaytgZ6iJoXH5hS9joOIiP/sbGSa1abcnZVDXFCT
	 fQNlrduPKbjixCSe1OvoTMfhrqGssFSp/hFQNUIx+D2DUo9JTmuCM0DG1z08P/to15
	 ef8ulFmQ2GBv5A9eRnr1ie5DrRF9LU812Pfx90zI=
Message-ID: <536A542A.7090707@cora.nwra.com>
Date: Wed, 07 May 2014 09:41:30 -0600
From: Orion Poplawski <orion@cora.nwra.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0
MIME-Version: 1.0
To: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>, 423@bugs.x2go.org
Subject: Re: [X2Go-Dev] Bug#423: Still present in3.5.0.23
References: <53691FD4.2050503@cora.nwra.com> <20140507071119.Horde.yku6g9Tbpbhky0j-puVvRQ1@mail.das-netzwerkteam.de>
In-Reply-To: <20140507071119.Horde.yku6g9Tbpbhky0j-puVvRQ1@mail.das-netzwerkteam.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

On 05/07/2014 01:11 AM, Mike Gabriel wrote:
> Hi Orion,
>
> On  Di 06 Mai 2014 19:45:56 CEST, Orion Poplawski wrote:
>
>> I'm still seeing this in 3.5.0.23:
>>
>> In file included from x11trans.c:80:0:
>> ../../lib/xtrans/Xtranssock.c: In function '_NXGetUnixDir':
>> ../../lib/xtrans/Xtranssock.c:377:5: error: format not a string literal and
>> no format arguments [-Werror=format-security]
>>      PRMSG (3, "_NXGetUnixDir(%s)\n", dir, 0, 0);
>>      ^
>> ../../lib/xtrans/Xtranssock.c: In function '_NXGetUnixPath':
>> ../../lib/xtrans/Xtranssock.c:446:5: error: format not a string literal and
>> no format arguments [-Werror=format-security]
>>      PRMSG (3, "_NXGetUnixPath(%s)\n", path, 0, 0);
>>      ^
>> I don't see that this patch is actually applied.
>
> Dang... The patch 056 did not make it into the rolled release tarball.
>
> Fixing and re-releasing (as 3.5.0.24)...
>
> Mike
>

Looks good now, thanks.

-- 
Orion Poplawski
Technical Manager                     303-415-9701 x222
NWRA, Boulder/CoRA Office             FAX: 303-415-9702
3380 Mitchell Lane                       orion@nwra.com
Boulder, CO 80301                   http://www.nwra.com

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Nov 21 14:48:55 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.