X2Go Bug report logs - #423
FIx more -Werror=format-security errors

version graph

Package: nx-libs; Maintainer for nx-libs is X2Go Developers <x2go-dev@lists.x2go.org>;

Reported by: Orion Poplawski <orion@cora.nwra.com>

Date: Thu, 30 Jan 2014 02:30:02 UTC

Severity: normal

Tags: patch, pending

Found in version 3.5.0.22

Fixed in version 2:3.5.0.23

Done: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

Bug is archived. No further changes may be made.

Full log

Message #47 received at 423@bugs.x2go.org (full text, mbox, reply):

Received: (at 423) by bugs.x2go.org; 7 May 2014 07:11:20 +0000
From mike.gabriel@das-netzwerkteam.de  Wed May  7 09:11:19 2014
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,
	RCVD_IN_DNSWL_BLOCKED,URIBL_BLOCKED autolearn=ham version=3.3.2
Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id BF7CB5DB15
	for <423@bugs.x2go.org>; Wed,  7 May 2014 09:11:19 +0200 (CEST)
Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98])
	by freya.das-netzwerkteam.de (Postfix) with ESMTPS id BDC961FED;
	Wed,  7 May 2014 09:11:17 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 6EFE23BB40;
	Wed,  7 May 2014 09:11:19 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de
Received: from grimnir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id GJPENsghK3Mr; Wed,  7 May 2014 09:11:19 +0200 (CEST)
Received: from grimnir.das-netzwerkteam.de (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id 3F8B63B9A3;
	Wed,  7 May 2014 09:11:19 +0200 (CEST)
Received: from nocatv2.tng.de (nocatv2.tng.de [213.178.75.58]) by
 mail.das-netzwerkteam.de (Horde Framework) with HTTP; Wed, 07 May 2014
 07:11:19 +0000
Date: Wed, 07 May 2014 07:11:19 +0000
Message-ID: <20140507071119.Horde.yku6g9Tbpbhky0j-puVvRQ1@mail.das-netzwerkteam.de>
From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
To: Orion Poplawski <orion@cora.nwra.com>, 423@bugs.x2go.org
Subject: Re: [X2Go-Dev] Bug#423: Still present in3.5.0.23
References: <53691FD4.2050503@cora.nwra.com>
In-Reply-To: <53691FD4.2050503@cora.nwra.com>
User-Agent: Internet Messaging Program (IMP) H5 (6.1.7)
Accept-Language: en,de
Organization: DAS-NETZWERKTEAM
X-Originating-IP: 213.178.75.58
X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:26.0) Gecko/20100101
 Firefox/26.0 Iceweasel/26.0
Content-Type: multipart/signed; boundary="=_duXafy0BC0WVmahBN8nAUQ1";
 protocol="application/pgp-signature"; micalg=pgp-sha1
MIME-Version: 1.0

[Message part 1 (text/plain, inline)]
Hi Orion,

On  Di 06 Mai 2014 19:45:56 CEST, Orion Poplawski wrote:

> I'm still seeing this in 3.5.0.23:
>
> In file included from x11trans.c:80:0:
> ../../lib/xtrans/Xtranssock.c: In function '_NXGetUnixDir':
> ../../lib/xtrans/Xtranssock.c:377:5: error: format not a string  
> literal and no format arguments [-Werror=format-security]
>      PRMSG (3, "_NXGetUnixDir(%s)\n", dir, 0, 0);
>      ^
> ../../lib/xtrans/Xtranssock.c: In function '_NXGetUnixPath':
> ../../lib/xtrans/Xtranssock.c:446:5: error: format not a string  
> literal and no format arguments [-Werror=format-security]
>      PRMSG (3, "_NXGetUnixPath(%s)\n", path, 0, 0);
>      ^
> I don't see that this patch is actually applied.

Dang... The patch 056 did not make it into the rolled release tarball.

Fixing and re-releasing (as 3.5.0.24)...

Mike

-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

[Message part 2 (application/pgp-signature, inline)]

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Nov 21 14:59:56 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.