From mikedep333@gmail.com Fri Mar 14 06:24:59 2014 Received: (at 422) by bugs.x2go.org; 14 Mar 2014 05:25:00 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM, T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from mail-lb0-f178.google.com (mail-lb0-f178.google.com [209.85.217.178]) by ymir (Postfix) with ESMTPS id 8A70F5DB21 for <422@bugs.x2go.org>; Fri, 14 Mar 2014 06:24:59 +0100 (CET) Received: by mail-lb0-f178.google.com with SMTP id s7so1420111lbd.9 for <422@bugs.x2go.org>; Thu, 13 Mar 2014 22:24:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=W430feAvvvt9JaRbtIhr9LqnpBfsyTaB60vLbqUugHM=; b=iVQTzqqG6jvInH9AZgvFuog05OavLQYgfRj9l1QN238cKSTWeggUvk3itHixJMNDYo OZYbvkjnfIzKvL7c9xw5xhcOY9SKuIGqsQfGxLdYHqkENfNWp37mJHnzWi2Lt0FYd/rC IenXjj68PSW62/YvV2EiFYr5qiZPdGvaPQhQP4sp/RkxZD2H5zmPUXo67dR0yDVRhk/o 7fbdJFCX+1mxPzSChB5t++gADM3APHltn1omYjjK2+c7FB8M+YQ5LhwHOtTFDG1OFoUY g83gBKJKFNyBMypvuvQzrJih4vq2OMugHJEA+tohBnHd81AfVdYX6D9P/E6di84W9ryM jnpw== MIME-Version: 1.0 X-Received: by 10.152.23.227 with SMTP id p3mr602073laf.31.1394774698885; Thu, 13 Mar 2014 22:24:58 -0700 (PDT) Received: by 10.114.176.105 with HTTP; Thu, 13 Mar 2014 22:24:58 -0700 (PDT) Date: Fri, 14 Mar 2014 01:24:58 -0400 Message-ID: Subject: Just Create the .config/pulse/ dir! From: Michael DePaulo To: 422@bugs.x2go.org Content-Type: text/plain; charset=ISO-8859-1 After spending lots of time debugging this issue, largely involving comparing the debug output from pulseaudio.exe, I believe I've determined a simple fix. I observed that if I create this directory ahead of time, the pulseaudio.exe process launched by x2goclient.exe creates the "cookie" file under it & stays running. C:\Users\mike\.x2go\pulse\.config\pulse\ Therefore, I believe a simple fix for this bug is for x2goclient.exe, regardless of what version of pulseaudio.exe is installed, to: 1. Create that directory (if it DNE). 2. Include logic around onmainwindow.cpp:5149 to use the cookie at that path. If the cookie is not in that location, fall back to ".pulse-cookie". We already have this logic for Linux. I plan to write, test, and (hopefully) commit this fix tomorrow night. Note that we cannot override the cookie location due to PulseAudio Bug 75006: https://bugs.freedesktop.org/show_bug.cgi?id=75006 Note that although I am not sure why PulseAudio.exe is incapable of creating this file when launched by x2goclient.exe, compared to when it is launched by cmd.exe, I believe this is still safe approach to solving the bug. I say this because PulseAudio devs's comments & commit messages make it clear that they support both the directory already existing, and the directory not already existing. For example: http://cgit.freedesktop.org/pulseaudio/pulseaudio/commit/src/pulsecore/authkey.c?id=a91359956f166005749247eaa5f4001a4555689d