From unknown Sat May 16 01:59:38 2026 X-Loop: owner@bugs.x2go.org Subject: Bug#422: I simplified the approach Reply-To: Michael DePaulo , 422@bugs.x2go.org Resent-From: Michael DePaulo Resent-To: x2go-dev@lists.berlios.de Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Sun, 06 Apr 2014 19:15:01 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: followup 422 X-X2Go-PR-Package: x2goclient X-X2Go-PR-Keywords: build-win32 pending Received: via spool by 422-submit@bugs.x2go.org id=B422.139681161622339 (code B ref 422); Sun, 06 Apr 2014 19:15:01 +0000 Received: (at 422) by bugs.x2go.org; 6 Apr 2014 19:13:36 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from mail-we0-f171.google.com (mail-we0-f171.google.com [74.125.82.171]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 89A285DB26 for <422@bugs.x2go.org>; Sun, 6 Apr 2014 21:13:34 +0200 (CEST) Received: by mail-we0-f171.google.com with SMTP id t61so5872455wes.30 for <422@bugs.x2go.org>; Sun, 06 Apr 2014 12:13:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=ONpmS7/lU0AkZ3g3eRXUzYQMH404f1GrtvrBO7l0e1w=; b=HMewZMXuRKVz2zdSuUq7lGJ5RQQfKB+np90mAikudIyxAKcDSHpmVwn/7MCA3M4y31 3oZ7p88vjq0pvmyETvZ6AkNZ34E4SozFz0ElFZrGtesEjWRKxZKu2rF6iMutuMd9pabD uFnxk+Qpr7S02LTvsMb5+Za1ZGm5vBLl4UPx2HUdZ/O+msrK9gG7DBtvNXMcpnE3F7dc Gww0dLuZRmRtU1bYUFVtwoFIccjfxEcTXBZqa7PdXIIiMoQRFWTVxlHCNd+mKe9W8Nbz WU2gWiPPweuzsd/DuRgFAfoXcJ7LrbQlrDxf6FL0XMAtBjMXe7GUUaMHdeH6W9o+mtsw vydw== MIME-Version: 1.0 X-Received: by 10.180.98.67 with SMTP id eg3mr404716wib.38.1396811614151; Sun, 06 Apr 2014 12:13:34 -0700 (PDT) Received: by 10.181.11.130 with HTTP; Sun, 6 Apr 2014 12:13:33 -0700 (PDT) Date: Sun, 6 Apr 2014 15:13:33 -0400 Message-ID: From: Michael DePaulo To: 422@bugs.x2go.org Content-Type: text/plain; charset=ISO-8859-1 TLDR: X2Go Client 4.0.2.0 will now keep on using the old cookie path like "C:\Users\mike\.x2go\pulse\.pulse-cookie", same as it did with 4.0.1.3, no matter what version of PulseAudio is in use. Tanuk (the lead developer on PulseAudio) clarified that pulseaudio.exe (the PulseAudio server) isn't supposed to respect %PULSE_COOKIE%, only the client libs (on the x2go server) are supposed to respect it. (I should have read the pulseaudio (1) manpage more closely.) Instead, pulseaudio.exe respects "auth-cookie", that we need to specify for "module-native-protocol-tcp" in config.pa. "auth-cookie" doesn't seem to be in the manpages, but it is specified in the 2nd link below. https://bugs.freedesktop.org/show_bug.cgi?id=75006 http://www.freedesktop.org/wiki/Software/PulseAudio/Documentation/User/Modules/#index22h3 So I updated X2Go Client's Windows cookie handling logic to specify old the path for PulseAudio 3.0 & later. I then removed the logic to accommodate the new path. The end result is that when X2GoClient 4.0.2.0 is released, we will keep using the old cookie path, thus simplifying things for any power users who need to manage their .x2go directory. This change is in commits: a6ab2c7879e3fb23edee2acaa4e3e21d978aa201 034afc36143134ce0fe272422bd410ca5125834e And I've tested this change successfully.