From mike.gabriel@das-netzwerkteam.de Fri Mar 14 12:15:42 2014 Received: (at 422) by bugs.x2go.org; 14 Mar 2014 11:15:43 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199]) by ymir (Postfix) with ESMTPS id 6000E5DB21 for <422@bugs.x2go.org>; Fri, 14 Mar 2014 12:15:42 +0100 (CET) Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98]) by freya.das-netzwerkteam.de (Postfix) with ESMTPS id 7CBE91EB50; Fri, 14 Mar 2014 12:15:41 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 57F1B3BD6C; Fri, 14 Mar 2014 12:15:41 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de Received: from grimnir.das-netzwerkteam.de ([127.0.0.1]) by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U7UZtKmZYsW6; Fri, 14 Mar 2014 12:15:41 +0100 (CET) Received: from grimnir.das-netzwerkteam.de (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTPSA id 285083BAFB; Fri, 14 Mar 2014 12:15:41 +0100 (CET) Received: from listrac.informatik.uni-kiel.de (listrac.informatik.uni-kiel.de [134.245.252.114]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP; Fri, 14 Mar 2014 11:15:40 +0000 Date: Fri, 14 Mar 2014 11:15:40 +0000 Message-ID: <20140314111540.Horde.0Bt_d7M2fQrN1mpQn4kTaw8@mail.das-netzwerkteam.de> From: Mike Gabriel To: Michael DePaulo , 422@bugs.x2go.org Subject: Re: [X2Go-Dev] Bug#422: Just Create the .config/pulse/ dir! References: In-Reply-To: User-Agent: Internet Messaging Program (IMP) H5 (6.1.4) Accept-Language: en,de Organization: DAS-NETZWERKTEAM X-Originating-IP: 134.245.252.114 X-Remote-Browser: Mozilla/5.0 (X11; Linux i686; rv:26.0) Gecko/20100101 Firefox/26.0 Iceweasel/26.0 Content-Type: multipart/signed; boundary="=_PhPdFyf_jYFpY03DS6MJQw1"; protocol="application/pgp-signature"; micalg=pgp-sha1 MIME-Version: 1.0 This message is in MIME format and has been PGP signed. --=_PhPdFyf_jYFpY03DS6MJQw1 Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Michael, On Fr 14 M=C3=A4r 2014 06:24:58 CET, Michael DePaulo wrote: > After spending lots of time debugging this issue, largely involving > comparing the debug output from pulseaudio.exe, I believe I've > determined a simple fix. > > I observed that if I create this directory ahead of time, the > pulseaudio.exe process launched by x2goclient.exe creates the "cookie" > file under it & stays running. > C:\Users\mike\.x2go\pulse\.config\pulse\ > > Therefore, I believe a simple fix for this bug is for x2goclient.exe, > regardless of what version of pulseaudio.exe is installed, to: > 1. Create that directory (if it DNE). > 2. Include logic around onmainwindow.cpp:5149 to use the cookie at > that path. If the cookie is not in that location, fall back to > ".pulse-cookie". We already have this logic for Linux. Gosh! Very good work!!! Let's go that approach. > I plan to write, test, and (hopefully) commit this fix tomorrow night. > > Note that we cannot override the cookie location due to PulseAudio Bug 75= 006: > https://bugs.freedesktop.org/show_bug.cgi?id=3D75006 > > Note that although I am not sure why PulseAudio.exe is incapable of > creating this file when launched by x2goclient.exe, compared to when > it is launched by cmd.exe, I believe this is still safe approach to > solving the bug. > I say this because PulseAudio devs's comments & commit messages make > it clear that they support both the directory already existing, and > the directory not already existing. > For example: > http://cgit.freedesktop.org/pulseaudio/pulseaudio/commit/src/pulsecore/au= thkey.c?id=3Da91359956f166005749247eaa5f4001a4555689d Maybe the pulse directory does not get created because of .config=20=20 being=20missing. The pulsecore/core-utils.c contains a function name=20=20 pa_make_secure_dir=20which will create a directory for the pulse=20=20 cookies,=20but it (AFAICT) assumes that the parent dir (.config) already=20= =20 exists. It=20also may be that we don't set XDG variables not appropriately [1].=20= =20 The=20pulseaudio patch you mention earlier [2] alludes that, too. [1] http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html [2]=20=20 http://cgit.freedesktop.org/pulseaudio/pulseaudio/commit/?id=3D7fad67c46188= 991c04a42b190349ebb3f4a1756f I guess assuring that the .config/pulse dir exists is a simple=20=20 approach=20and we should go that instead of playing with XDG env vars=20=20 (which=20are part of the freedesktop specs and X2Go Client is not about=20= =20 being=20compliant with freedesktop specs if run on Windows). Greets, Mike --=20 DAS-NETZWERKTEAM mike=20gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.x= fb --=_PhPdFyf_jYFpY03DS6MJQw1 Content-Type: application/pgp-signature Content-Description: Digitale PGP-Signatur Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iQIcBAABAgAGBQJTIuTcAAoJEJr0azAldxsxeoIQAJ8LhF+uOIe08EsRMUed6XOJ bf7m+on9w4yLXqN9IBr8XBf0/UhBYSCATYB/yEudM4sxDP2pVJ+RQaVcCvaE+e9z MT7oLwgRcazP7tLaFscGswTcLQSAAuDWqRz/1smJZODvGPLxugSUrfGiCVqeEHh8 bSGRDFHgsrcfpP0satGH4kFCqL6XaQqf2GTvmpxVgzUN8wJ6C1IxZ9D+/9wLArka a7UeXCISCdrH4CHtgezXEFdLcFLu7Xtyf4V94H2IOdATyvJhklZPK8A4VYHDHoRl WzRXHLkYXDcH9v+quh4vZt/4iK/0px70QfSSpTgsx8xWvet/0/F8B4Yp13Nxgpns /S9M2lee6oI3VBSJCEpgyd2Gxqv/pgSbTqRJn8oR35PaIV57rKfVmAkuPw9JG6QU pk7R6ZUbMnnmQbNV7ka7HUl47V8JNwB3AGc0IWihqyJ6EUygUTkGqYDh0ScWhHFC VtCMcdB2zh3zOP855KsxdxIh3/iPiSwB5pc0tbGMZsAAgoDswfDYCWEps80900b/ Lf/QA45oH2YNg6llqs+rvqzN6O0yPbjnt7bnhieHfKcbVOibAJFKMrdtJkYky/Nx k64vnjJ8IHzAi6Xi5S+Ibj4DeVpupN5QeGHRyGCPnuYeAYsxQBoYGeb0OQUxHQOZ VsW1f3QqUWOcBxMLOt6C =ymbv -----END PGP SIGNATURE----- --=_PhPdFyf_jYFpY03DS6MJQw1--