Subject: Bug#420 closed by Mike Gabriel <[email-masked]> (X2Go issue (in src:x2goclient) has been marked as closed)

From: [email-masked] (X2Go Bug Tracking System)
Date: Thu, 10 Apr 2014 11:55:09 +0000

This is an automatic notification regarding your Bug report
which was filed against the x2goclient package:

#420: Fix password connection with libssh 0.6.0

It has been closed by Mike Gabriel <[email-masked]>.

Their explanation is attached below along with your original report.
If this explanation is unsatisfactory and you have not received a
better one in a separate message then please contact Mike Gabriel <[email-masked]> by
replying to this email.

-- 
X2Go Bug Tracking System
Contact [email-masked] with problems

Subject: X2Go issue (in src:x2goclient) has been marked as closed
From: Mike Gabriel <[email-masked]>
To: [email-masked]
Cc: [email-masked], [email-masked]
Date: Thu, 10 Apr 2014 13:52:12 +0200 (CEST)

close #420
thanks

Hello,

we are very hopeful that X2Go issue #420 reported by you
has been resolved in the new release (4.0.1.4) of the
X2Go source project »src:x2goclient«.

You can view the complete changelog entry of src:x2goclient (4.0.1.4)
below, and you can use the following link to view all the code changes
between this and the last release of src:x2goclient.

    http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=c701ee64098a4809d8458feeccb364044f27b2cc;hp=f84e4ed11d25365ff1e50ebbf83f199c4d748111

If you feel that the issue has not been resolved satisfyingly, feel
free to reopen this bug report or submit a follow-up report with
further observations described based on the new released version
of src:x2goclient.

Thanks a lot for contributing to X2Go!!!

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
X2Go Component: src:x2goclient
Version: 4.0.1.4-0x2go1
Status: RELEASE
Date: Thu, 10 Apr 2014 13:46:33 +0200
Fixes: 420 434
Changes: 
 x2goclient (4.0.1.4-0x2go1) RELEASED; urgency=low
 .
   [ Oleksandr Shneyder ]
   * New upstream version (4.0.1.4):
     - Increase ssh_select timeout to 0.5 sec.
     - Set mod map from client to server on Mac, hide keyboard settings on Mac.
     - Fix mod map on Mac with kerberos.
     - Fix focus on pass form.
 .
   [ Orion Poplawski ]
   * New upstream version (4.0.1.4):
     - Fix password connection with libssh 0.6.0. (Fixes: 420).
     - Don't use ancient Debianism's for ssh options (ProtocolKeepAlives).
       (Fixes: #434).
 .
   [ Martti Pitkanen ]
   * New upstream version (4.0.1.4):
     - Update Finnish translation file.
 .
   [ Robert Parts ]
   * New upstream version (4.0.1.4):
     - Add new translation of X2Go Client to Estonian.
 .
   [ Nicolai Hansen ]
   * New upstream version (4.0.1.4):
     - Update Danish translation file.
 .
   [ Jos ]
   * New upstream version (4.0.1.4):
     - Add new translation of X2Go Client to Dutch.

Subject: Fix password connection with libssh 0.6.0
From: Orion Poplawski <[email-masked]>
To: [email-masked]
Date: Wed, 29 Jan 2014 09:43:51 -0700

Package: x2goclient
Version: 4.0.1.3
Tags: patch

Starting with libssh 0.6.0, ssh_userauth_list() no longer automatically calls
ssh_userauth_none() if needed (auth_methods == 0) to populate the list of
methods available.  This patch calls it explicitly.  An alternative would be
to simply try authenticating.

Without this, attempts to connect with a password fails with an empty
"Authentication failed" error window.

-- 
Orion Poplawski
Technical Manager                     303-415-9701 x222
NWRA, Boulder/CoRA Office             FAX: 303-415-9702
3380 Mitchell Lane                       [email-masked]
Boulder, CO 80301                   http://www.nwra.com
diff -up x2goclient-4.0.1.3/sshmasterconnection.cpp.sshauth x2goclient-4.0.1.3/sshmasterconnection.cpp
--- x2goclient-4.0.1.3/sshmasterconnection.cpp.sshauth	2014-01-29 08:52:44.564013247 -0700
+++ x2goclient-4.0.1.3/sshmasterconnection.cpp	2014-01-29 09:32:31.963139911 -0700
@@ -924,6 +924,9 @@ bool SshMasterConnection::userChallengeA
 
 bool SshMasterConnection::userAuthWithPass()
 {
+    // Populate the userauth_list
+    ssh_userauth_none(my_ssh_session, NULL);
+
     int method = ssh_userauth_list(my_ssh_session, NULL);
 
     if (method& SSH_AUTH_METHOD_INTERACTIVE)