X2Go Bug report logs - #349
Make shadow sessions work with --hide option

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: marcoandredinis@gmail.com

Date: Tue, 26 Nov 2013 16:18:01 UTC

Severity: normal

Tags: patch, pending

Found in version 4.0.1.1

Fixed in version 4.0.2.0

Done: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

Bug is archived. No further changes may be made.

Full log


Message #31 received at 349@bugs.x2go.org (full text, mbox, reply):

Received: (at 349) by bugs.x2go.org; 9 Dec 2013 14:48:01 +0000
From mike.gabriel@das-netzwerkteam.de  Mon Dec  9 15:48:00 2013
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED
	autolearn=ham version=3.3.2
Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199])
	by ymir (Postfix) with ESMTPS id 7BBC45DA7B
	for <349@bugs.x2go.org>; Mon,  9 Dec 2013 15:48:00 +0100 (CET)
Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98])
	by freya.das-netzwerkteam.de (Postfix) with ESMTPS id 79B511ED3D;
	Mon,  9 Dec 2013 15:47:59 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id DB9883BE24;
	Mon,  9 Dec 2013 15:47:56 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de
Received: from grimnir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id DaIHsR1JA3FR; Mon,  9 Dec 2013 15:47:56 +0100 (CET)
Received: from grimnir.das-netzwerkteam.de (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTPSA id B88AE3BA05;
	Mon,  9 Dec 2013 15:47:55 +0100 (CET)
Received: from listrac.informatik.uni-kiel.de
 (listrac.informatik.uni-kiel.de [134.245.252.114]) by
 mail.das-netzwerkteam.de (Horde Framework) with HTTP; Mon, 09 Dec 2013
 14:47:55 +0000
Date: Mon, 09 Dec 2013 14:47:55 +0000
Message-ID: <20131209144755.Horde.UZ6lvpPZr8ZJIg4OHPNgrQ7@mail.das-netzwerkteam.de>
From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
To: Marco André Dinis <marcoandredinis@gmail.com>
Cc: 349@bugs.x2go.org
Subject: Re: [X2Go-Dev] Bug#349: Make shadow sessions work with --hide
 option
References: <14138471.B8Tpv8tqIx@mcdtux>
 <20131127104626.Horde.w5hvLxXG3VoCZDC6svrcQA2@mail.das-netzwerkteam.de>
 <CAJxG8spv3bF9v3f_F1U3mAZuzmjeuxmNyUrEqPDBaxhspyHEkQ@mail.gmail.com>
 <CAJxG8soAwOMnj0bVx7VWMuxcH0ZoaDX+7f2-Fim77kADeNe+=g@mail.gmail.com>
In-Reply-To: <CAJxG8soAwOMnj0bVx7VWMuxcH0ZoaDX+7f2-Fim77kADeNe+=g@mail.gmail.com>
User-Agent: Internet Messaging Program (IMP) H5 (6.1.4)
Accept-Language: en,de
Organization: DAS-NETZWERKTEAM
X-Originating-IP: 134.245.252.114
X-Remote-Browser: Mozilla/5.0 (X11; Linux i686; rv:23.0) Gecko/20100101
 Firefox/23.0 Iceweasel/23.0
Content-Type: multipart/signed; boundary="=_WYi1EelKx36Kt7jSQQD4dw1";
 protocol="application/pgp-signature"; micalg=pgp-sha1
MIME-Version: 1.0
[Message part 1 (text/plain, inline)]
Control: tag -1 patch
Control: tag -1 - moreinfo

Hi Marco,

this is still pending due to ENOTIME. Sorry. It won't get lost as long  
as it is in our bugtracker...

Mike

On  Mo 09 Dez 2013 12:03:34 CET, Marco André Dinis wrote:

> Any news on implementing this?
>
>
> On Thu, Nov 28, 2013 at 10:16 AM, Marco André Dinis <
> marcoandredinis@gmail.com> wrote:
>
>> Hi
>>
>> I'm sending the patch.
>>
>> However this is not the final fix. There are 2 modes: full access and
>> only view. Right now it starts full access.
>> That decision could be made using the session info. For example,
>> create the command SHADOWFULL
>>
>> On Wed, Nov 27, 2013 at 10:46 AM, Mike Gabriel
>> <mike.gabriel@das-netzwerkteam.de> wrote:
>> > Control: retitle -1 Make shadow sessions work with --hide option
>> > Control: tag -1 moreinfo
>> > Control: clone -1 -2
>> > Control: reassign -2 x2godesktopsharing
>> > Control: retitle -2 Add --no-icon cmdline option to x2godesktopsharing
>> > Control: severity -2 wishlist
>> >
>> > Hi Marco,
>> >
>> > with this mail I split up your report into to separate bug reports. One
>> for
>> > x2goclient, one for x2godesktopsharing...
>> >
>> > On  Di 26 Nov 2013 17:01:41 CET, marcoandredinis wrote:
>> >
>> >> I'm developing a program that will use X2Go software. I dont want
>> >> users to notice they are using any other program besides my own.
>> >>
>> >> I have two problems right now:
>> >>
>> >> A) X2GoClient
>> >> Using SHADOW mode with "--hide" does not work. The interface waits for
>> >> selection of Display (usually ":0") and, since there's no input from
>> >> user (there's no window) the program does not show anything.
>> >> There are possible ways of fixing/improving this situation:
>> >> -allow user to set the default display on sessions' file
>> >> -create one flag and run program like these: "x2goclient --hide
>> >> --sessionid=xxx --select-first-display"
>> >>
>> >> Anyway, i modified the code of x2goclient/onmainwindow.cpp and added
>> >> these lines:
>> >> l4348:..if( shadowSession )
>> >> l4349:....slotShadowSess();
>> >> Compiled the program, and now i can run "./x2goclient --hide
>> >> --sessionid=xxx" and the window will show up.
>> >> This is NOT a fix, this is a nasty workaround. It wontn show the list
>> >> even when the "hide" flag is not present.
>> >
>> >
>> > Please provide a patch for what you did.
>> >
>> > Please improve your patch so it is not a workaround anymore. I guess, I
>> > agree with you, that the X2Go Client window should pop up, if there are
>> more
>> > than one sharable desktops to select from. If there is only one sharable
>> > desktop, this should be auto-selected. Can you code that into X2Go
>> Client,
>> > please?
>> >
>> >> B) X2GoDesktopSharing
>> >> Just the icon on SystemTray. If we could pass a flag like "--no-icon"
>> >> would be great
>> >
>> >
>> > This part will be handled in a separate bug. I will reply to this once
>> the
>> > separate bug is created in X2Go BTS.
>> >
>> >> I could do these simple changes on my own, but i rather see this
>> >> changes on the official code.
>> >
>> >
>> > Let's try to get your needs into upstream code...
>> >
>> > Mike
>> >
>> > --
>> >
>> > DAS-NETZWERKTEAM
>> > mike gabriel, herweg 7, 24357 fleckeby
>> > fon: +49 (1520) 1976 148
>> >
>> > GnuPG Key ID 0x25771B31
>> > mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
>> >
>> > freeBusy:
>> >
>> https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb
>>


-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb
[Message part 2 (application/pgp-signature, inline)]

Send a report that this bug log contains spam.


X2Go Developers <owner@bugs.x2go.org>. Last modified: Fri Apr 19 20:15:52 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.