From oleksandr.shneyder@obviously-nice.de Tue Sep 25 01:18:09 2012 Received: (at 34) by bugs.x2go.org; 24 Sep 2012 23:18:09 +0000 Received: from phoca.obviouslynice.de (85-10-207-20.clients.your-server.de [85.10.207.20]) by ymir (Postfix) with ESMTP id 8AA3F5DB15 for <34@bugs.x2go.org>; Tue, 25 Sep 2012 01:18:09 +0200 (CEST) Received: from [192.168.0.108] (188-195-168-12-dynip.superkabel.de [188.195.168.12]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by phoca.obviouslynice.de (Postfix) with ESMTPSA id B12951A000D; Tue, 25 Sep 2012 00:56:38 +0200 (CEST) Message-ID: <5060EA24.7070600@obviously-nice.de> Date: Tue, 25 Sep 2012 01:17:56 +0200 From: Oleksandr Shneyder User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.6esrpre) Gecko/20120817 Icedove/10.0.6 MIME-Version: 1.0 To: Xypron CC: Moritz Struebe , 34@bugs.x2go.org Subject: Re: [X2Go-Dev] Bug#34: SSH_OPTIONS_FD References: <505CC771.20300@gmx.de> <505D9F99.10808@gmx.de> <505DA7B4.3030909@informatik.uni-erlangen.de> <505F6DDB.1070304@gmx.de> <5060251D.90202@informatik.uni-erlangen.de> <20120924132602.316510@gmx.net> <50607239.5090308@informatik.uni-erlangen.de> <5060CF1E.20700@gmx.de> In-Reply-To: <5060CF1E.20700@gmx.de> X-Enigmail-Version: 1.4.1 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig216B8E96EDADC72CC9D1FF6E" This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig216B8E96EDADC72CC9D1FF6E Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Am 24.09.2012 23:22, schrieb Xypron: > Using libssh compiled from > http://git.libssh.org/projects/libssh.git/log/?h=3Dv0-5 > I now can successfully connect via a proxy server to a SSH server. > My coding is available at > svn co http://www.xypron.de/svn/x2go/x2goclient/branches/proxy/ >=20 > The changes in sshmasterconnection.* and connectionwidget.* are complet= e > to my understanding. > In onmainwindow I have only treated one of three entrypoints to > sshmasterconnection. E.g. LDAP is not proxy enabled yet. > In onmainwindow the proxy password field I introduced possibly should > only be shown if a proxy is used and a login provided. >=20 > Best regards >=20 > Heinrich Hello Heinrich, I've checked your code and it looks good for me. I'll include it in master branch soon. You have developed support for HTTP proxy. I'm working now on a little more complex case - SSH proxy with password/public key authentication. In the future user should be able to choose between HTTP and SSH proxy. I have a one notice. In your case HTTP protocol is used for proxy. It is mean, that user name and password will be transmitted unencrypted. It can follow to security issues. Can you think about HTTPS support? This should be not very difficult, as Qt already supports SSL. You can check code of HttpBrockerClient class in X2Go Client, which can use HTTPS connections. And one more thing, as I understood, this code work only with recent version of libssh. We should think, how can we make it available for distributions like squeeze. Such distributions should be also supported by X2Go Client. regards, Alex --=20 Oleksandr Shneyder Dipl. Informatik X2go Core Developer Team email: oleksandr.shneyder@obviously-nice.de web: www.obviously-nice.de --> X2go - everywhere@home --------------enig216B8E96EDADC72CC9D1FF6E Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAlBg6jAACgkQxQmEC5b4kTOCHQCeO+SOwPso3pL+mPNlPKdg4cRX eg4AoJ48jsk2UfyAx+SEOaTIIMhynlEU =MPiE -----END PGP SIGNATURE----- --------------enig216B8E96EDADC72CC9D1FF6E--