From unknown Wed Apr 08 17:18:24 2026 MIME-Version: 1.0 X-Mailer: MIME-tools 5.502 (Entity 5.502) X-Loop: owner@bugs.x2go.org From: owner@bugs.x2go.org (X2Go Bug Tracking System) Subject: Bug#331 closed by Mike Gabriel (X2Go issue (in src:x2goserver) has been marked as closed) Message-ID: References: <20131122205927.9A6445DB22@ymir> X-X2go-PR-Keywords: pending X-X2go-PR-Message: they-closed 331 X-X2go-PR-Package: x2goserver X-X2go-PR-Source: x2goserver Date: Fri, 22 Nov 2013 21:03:04 +0000 Content-Type: multipart/mixed; boundary="----------=_1385154184-8534-0" This is a multi-part message in MIME format... ------------=_1385154184-8534-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 This is an automatic notification regarding your Bug report which was filed against the x2goserver package: #331: Default umask when mounting sshfs tunnel It has been closed by Mike Gabriel . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Mike Gabriel by replying to this email. --=20 X2Go Bug Tracking System Contact owner@bugs.x2go.org with problems ------------=_1385154184-8534-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at control) by bugs.x2go.org; 22 Nov 2013 20:59:44 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_RELAYS, URIBL_BLOCKED autolearn=ham version=3.3.2 Received: by ymir (Postfix, from userid 1005) id 9A6445DB22; Fri, 22 Nov 2013 21:59:27 +0100 (CET) From: Mike Gabriel To: 331-submitter@bugs.x2go.org Cc: control@bugs.x2go.org, 331@bugs.x2go.org Subject: X2Go issue (in src:x2goserver) has been marked as closed Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Message-Id: <20131122205927.9A6445DB22@ymir> Date: Fri, 22 Nov 2013 21:59:27 +0100 (CET) close #331 thanks Hello, we are very hopeful that X2Go issue #331 reported by you has been resolved in the new release (4.0.1.7) of the X2Go source project »src:x2goserver«. You can view the complete changelog entry of src:x2goserver (4.0.1.7) below, and you can use the following link to view all the code changes between this and the last release of src:x2goserver. http://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=447e68e8b82ea4b14e5072e57a0fbc82ef32d687;hp=2d19587c215d49048b6295d87c06c452939a1b8b If you feel that the issue has not been resolved satisfyingly, feel free to reopen this bug report or submit a follow-up report with further observations described based on the new released version of src:x2goserver. Thanks a lot for contributing to X2Go!!! light+love X2Go Git Admin (on behalf of the sender of this mail) --- X2Go Component: src:x2goserver Version: 4.0.1.7 Status: RELEASE Date: Fri, 22 Nov 2013 21:58:27 +0100 Fixes: 276 278 285 305 310 331 Changes: x2goserver (4.0.1.7) RELEASED; urgency=low . [ Orion Poplawski ] * New upstream version (4.0.1.7): - Install Xsession file as executable, make Xsession.d directory location configurable during build process, do not create unused Xsession.options. (Fixes: #278). . [ Mike Gabriel ] * New upstream version (4.0.1.7): - Fine-tune x2goserver-xsession/Makefile: if /etc/X11 has Xsession.d and/or Xsession.options they get symlinked into /etc/x2go. Otherwise Xsession.d and Xsession.options are created under /etc/x2go as empty dir/file. (Fixes: #278). - Fix automatic keyboard setup (via x2gosetkeyboard) while resuming a session. (Fixes: #285). - Provide sudoers.d/x2goserver file that allows sudoed commands under KDE (by pertaining the env var QT_GRAPHICSSYSTEM. (Fixes: #276). - With PostgreSQL as session db backend, prevent the root user from launching sessions. Also, prevent x2gouser_root from being added as a PostgreSQL user. (Fixes: #310). - Execute DB status changes as late as possible during suspend / terminate. - Start/resume rootless sessions without geometry parameter. Esp. using X2GO_GEOMETRY=fullscreen for rootless sessions lead to an extra 1x1 px session window (nxagentCreateIconWindow in nxagent's Window.c). - Typo fix in x2goruncommand (for MATE session startup). * debian/control: + Update LONG_DESCRIPTIONS. + Raise Standards: to 3.9.4 (no changes needed). + Move xfonts-base to Recommends: field of bin:package x2goserver. * debian/x2goserver.init: + Make init script LSB compliant. . [ Helmer Teles ] * New upstream version (4.0.1.7): - Make umask that is used when mounting client-side folders via SSHFS configurable in x2goserver.conf. (Fixes: #331). . [ Jürgen Hötzel ] * New upstream version (4.0.1.7): - Use bash-builtin 'type' instead of to be avoided 'which'. (Fixes: #305). . [ Oleksandr Shneyder ] * New upstream version (4.0.0.6): - Fix x2goruncommand: "type -P $cmd" can create new lines in EXEC variable if command have the arguments wich have same names as existing commands, for example "rdesktop -k nl" -> "/usr/bin/rdesktop\n/usr/bin/nl". Now we splitting $cmd and taking only first part. ------------=_1385154184-8534-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by bugs.x2go.org; 23 Oct 2013 12:54:16 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, HTML_MESSAGE,RCVD_IN_DNSWL_BLOCKED,URIBL_BLOCKED autolearn=ham version=3.3.2 X-Greylist: delayed 563 seconds by postgrey-1.34 at ymir; Wed, 23 Oct 2013 14:54:15 CEST Received: from mx01.mykolab.com (mx01.mykolab.com [95.128.36.1]) by ymir (Postfix) with ESMTPS id 7BD7F5DA79 for ; Wed, 23 Oct 2013 14:54:15 +0200 (CEST) X-Virus-Scanned: amavisd-new at kolabsys.net Sender: helmer.teles@mykolab.com From: Helmer Teles To: submit@bugs.x2go.org Subject: Default umask when mounting sshfs tunnel Date: Wed, 23 Oct 2013 13:44:47 +0100 Message-ID: <1456688.sWGnl1COIA@zen-touch> Content-Type: multipart/mixed; boundary="nextPart3529790.WpD8B2inZL" Content-Transfer-Encoding: 7Bit This is a multi-part message in MIME format. --nextPart3529790.WpD8B2inZL Content-Type: multipart/alternative; boundary="nextPart1486325.3Kpct7TGlk" Content-Transfer-Encoding: 7Bit This is a multi-part message in MIME format. --nextPart1486325.3Kpct7TGlk Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="iso-8859-1" Package: x2goserver Version: 4.0.1.6-0~712~precise1 Tag: Patch Hello dear mates. Just had a problem that when a user moves or copy a file from the mounted sshfs dir to a shared directory on the x2goserver, if this is a shared folder for a group with respective ACL's we've got a problem with the final permissions. The easy way to solve this is to change the x2gomountdirs to include the umask param. Also included is the modification required at /etc/x2goserver.conf If stay uncommented the umask will stay as is on the server side ( client local computer ) and the value provided ( 0117 ) will make all files to be with rw-rw---- P.S: As i don't have the original x2goserver.conf don't apply the diff as is, but use it as reference please. the diff's are attached as Mr. Michael kindly asked. Best regards, -- Com os melhores cumprimentos. Helmer Teles http://hteles.wordpress.com[1] "Sent from my Linux Device" Please don't send me proprietary file formats, use ISO standard ODF instead (ISO/IEC 26300) -------- [1] http://hteles.wordpress.com/ --nextPart1486325.3Kpct7TGlk Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset="iso-8859-1"

<= span style=3D" font-family:'Courier New,courier'; color:#000000;">Packa= ge: x2goserver

<= span style=3D" font-family:'Courier New,courier'; color:#000000;">Versi= on: 4.0.1.6-0~712~precise1

<= span style=3D" font-family:'Courier New,courier'; color:#000000;">Tag: = Patch

 

Hello dear mates.


Just had a problem that wh= en a user moves or copy a file from the mounted sshfs dir to a shared d= irectory on the x2goserver, if this is a shared folder for a group with= respective ACL's we've got a problem with the final permissions.


The easy way to solve this= is to change the x2gomountdirs to include the umask param.

=


Also included is the modif= ication required at /etc/x2goserver.conf

If stay uncommented the um= ask will stay as is on the server side ( client local computer ) and th= e value provided ( 0117 ) will make all files to be with rw-rw----


P.S: As i don't have the o= riginal x2goserver.conf don't apply the diff as is, but use it as refer= ence please.


the diff's are attached as= Mr. Michael kindly asked.


Best regards,


-= -

C= om os melhores cumprimentos.

H= elmer Teles=A0
http://hteles.wordpre= ss.com

&= quot;Sent from my Linux Device"

P= lease don't send me proprietary file formats, use ISO standard ODF inst= ead (ISO/IEC 26300)

--nextPart1486325.3Kpct7TGlk-- --nextPart3529790.WpD8B2inZL Content-Disposition: attachment; filename="x2gomountdirs.patch" Content-Transfer-Encoding: 7Bit Content-Type: application/octet-stream; name="x2gomountdirs.patch" --- x2gomountdirs.orig 2013-10-23 13:00:43.606513703 +0100 +++ x2gomountdirs 2013-10-23 13:03:04.398514662 +0100 @@ -267,15 +267,28 @@ if (db_insertmount( $session, $mntpath, $host)) { + + my $Config = new Config::Simple(syntax=>'ini'); + $Config->read('/etc/x2go/x2goserver.conf' ); + my $umask=$Config->param("security.umask"); + my $umaskstr=""; + + if ($umask ne "") + { + $umaskstr="umask=$umask"; + } else { + $umaskstr="default_permissions"; + } my $code_conv=$ENV{'X2GO_ICONV'}; + if ($code_conv ne "") { $code_conv="-o $code_conv"; } - $msg = "sshfs $code_conv -o idmap=user,uid=`id -u`,gid=`id -g`,ServerAliveInterval=300,Cipher=blowfish,IdentityFile=$key,UserKnownHostsFile=$key.ident \"$user\"\@$host:\"@dirs[$i]\" \"$mntpath\" -p $port"; + $msg = "sshfs $code_conv -o idmap=user,uid=`id -u`,gid=`id -g`,$umaskstr,ServerAliveInterval=300,Cipher=blowfish,IdentityFile=$key,UserKnownHostsFile=$key.ident \"$user\"\@$host:\"@dirs[$i]\" \"$mntpath\" -p $port"; syslog('debug', "executing: $msg"); print "inserted, $msg\n"; - if (system("sshfs $code_conv -o idmap=user,uid=`id -u`,gid=`id -g`,ServerAliveInterval=300,Cipher=blowfish,IdentityFile=$key,UserKnownHostsFile=$key.ident \"$user\"\@$host:\"@dirs[$i]\" \"$mntpath\" -p $port 2>>~/mounts.log")==0) + if (system("sshfs $code_conv -o idmap=user,uid=`id -u`,gid=`id -g`,$umaskstr,ServerAliveInterval=300,Cipher=blowfish,IdentityFile=$key,UserKnownHostsFile=$key.ident \"$user\"\@$host:\"@dirs[$i]\" \"$mntpath\" -p $port 2>>~/mounts.log")==0) { print "mount @dirs[$i] ok\n"; syslog('notice', "successfully mounted $user\@$host:$port@dirs[$i] to $mntpath"); --nextPart3529790.WpD8B2inZL Content-Disposition: attachment; filename="x2goserver.conf.patch" Content-Transfer-Encoding: 7Bit Content-Type: application/octet-stream; name="x2goserver.conf.patch" --- x2goserver.conf 2013-10-23 13:17:23.590515059 +0100 +++ x2goserver.conf.new 2013-10-23 13:16:51.490507049 +0100 @@ -4,6 +4,10 @@ [limit groups] #folder1=1 +[security] +# Leave uncommented to keep the default server umask +#umask="0117" + [log] # possible levels are: emerg, alert, crit, err, warning, notice, info, debug loglevel=warning --nextPart3529790.WpD8B2inZL-- ------------=_1385154184-8534-0--