From unknown Sat May 16 01:59:08 2026 X-Loop: owner@bugs.x2go.org Subject: Bug#314: Re: [X2Go-Dev] Bug#314: nx-libs compilation warnings Reply-To: "Mirraz Mirraz" , 314@bugs.x2go.org Resent-From: "Mirraz Mirraz" Resent-To: x2go-dev@lists.berlios.de Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Mon, 30 Sep 2013 14:33:01 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: followup 314 X-X2Go-PR-Package: nx-libs X-X2Go-PR-Keywords: Received: via spool by 314-submit@bugs.x2go.org id=B314.138055118520328 (code B ref 314); Mon, 30 Sep 2013 14:33:01 +0000 Received: (at 314) by bugs.x2go.org; 30 Sep 2013 14:26:25 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199]) by ymir (Postfix) with ESMTPS id 50D0D5DB11 for <314@bugs.x2go.org>; Mon, 30 Sep 2013 16:26:24 +0200 (CEST) Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98]) by freya.das-netzwerkteam.de (Postfix) with ESMTPS id 25F9EBCF for <314@bugs.x2go.org>; Mon, 30 Sep 2013 16:26:24 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 109FA3C06F for <314@bugs.x2go.org>; Mon, 30 Sep 2013 16:26:24 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de Received: from grimnir.das-netzwerkteam.de ([127.0.0.1]) by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0cOgCxCyVazx for <314@bugs.x2go.org>; Mon, 30 Sep 2013 16:26:23 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id DC1603C069 for <314@bugs.x2go.org>; Mon, 30 Sep 2013 16:26:23 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id B37C73C06F for <314@bugs.x2go.org>; Mon, 30 Sep 2013 16:26:23 +0200 (CEST) Received: from grimnir.das-netzwerkteam.de (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTPSA id C53E03C069 for <314@bugs.x2go.org>; Mon, 30 Sep 2013 16:26:22 +0200 (CEST) Resent-Date: Mon, 30 Sep 2013 14:26:22 +0000 Resent-From: Mike Gabriel Resent-To: 314@bugs.x2go.org Resent-Message-ID: <20130930142622.Horde.-DZjXafPdoyKZpZVEsVoaQ1@mail.das-netzwerkteam.de> Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Cyrus v2.2.13-Debian-2.2.13-9.1) with LMTPA; Mon, 30 Sep 2013 16:03:46 +0200 X-Sieve: CMU Sieve 2.2 Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 508593C06F for ; Mon, 30 Sep 2013 16:03:46 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de Received: from grimnir.das-netzwerkteam.de ([127.0.0.1]) by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2jHmYTpLHdgl for ; Mon, 30 Sep 2013 16:03:46 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 2C8E63C069 for ; Mon, 30 Sep 2013 16:03:46 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 0BE893C06F for ; Mon, 30 Sep 2013 16:03:46 +0200 (CEST) Received: from mxout2.rambler.ru (mxout2.rambler.ru [81.19.67.59]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 47A033C069 for ; Mon, 30 Sep 2013 16:03:45 +0200 (CEST) Received: from saddam4.rambler.ru (saddam4.rambler.ru [10.32.16.4]) by mxout2.rambler.ru (Postfix) with ESMTP id E05B625ED for ; Mon, 30 Sep 2013 18:03:44 +0400 (MSK) Received: from localhost.localdomain (localhost [127.0.0.1]) by saddam4.rambler.ru (Postfix) with ESMTP id CF448358F32 for ; Mon, 30 Sep 2013 18:03:44 +0400 (MSK) Received: from [91.191.225.65] by saddam4.rambler.ru with HTTP; Mon, 30 Sep 2013 18:03:44 +0400 From: "Mirraz Mirraz" To: "Mike Gabriel" Date: Mon, 30 Sep 2013 18:03:44 +0400 Content-Transfer-Encoding: 7bit Content-Type: multipart/mixed; boundary="_----------=_13805498242613634" Message-Id: <1380549824.783666.26136.45506@saddam4.rambler.ru> MIME-Version: 1.0 X-Mailer: Rambler WebMail, http://mail.rambler.ru/ X-Rambler-User: mirraz1@rambler.ru/91.191.225.65 X-Kolab-Scheduling-Message: FALSE This is a multi-part message in MIME format. --_----------=_13805498242613634 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8"; format="flowed" > =D0=9F=D0=BD. 30 =D1=81=D0=B5=D0=BD=D1=82. 2013 13:49:01 =D0=BF=D0=BE=D0= =BB=D1=8C=D0=B7=D0=BE=D0=B2=D0=B0=D1=82=D0=B5=C2=AD=D0=BB=D1=8C Mike Gabrie= l (mike.gabriel@das-netzwerkteam.de) wrote: >=20 > are you willing to provide a patch? Otherwise, I will mark this =C2=A0= =C2=A0=C2=A0=C2=A0 > reported issue as "won't fix" for now. >=20 > Mike OK, I didn't plan to do it, but if you want... Propose patch which fixes 3 evident bugs: 1 implicit function declaration a= nd 2 array index out of bounds. I agree "[-Waddress]" warnings are not so terrible and may be that code hel= ps to avoid future mistakes. What about warnings in get.c: I don't know what to do. --_----------=_13805498242613634 Content-Disposition: attachment; filename="nx-3.5.0.21-compilation_warnings.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="nx-3.5.0.21-compilation_warnings.patch" LS0tIGEvbngtWDExL2V4dHJhcy9NZXNhL3NyYy9tZXNhL3NoYWRlci9hcmJw cm9ncGFyc2UuYwkyMDEzLTA4LTMwIDIwOjE4OjQwLjAwMDAwMDAwMCArMDYw MAorKysgYi9ueC1YMTEvZXh0cmFzL01lc2Evc3JjL21lc2Evc2hhZGVyL2Fy YnByb2dwYXJzZS5jCTIwMTMtMDktMzAgMTg6Mzk6NDIuMzU3NTYwMTY5ICsw NjAwCkBAIC0zMjU5LDcgKzMyNTksNiBAQAogICAgdnAtPlNyY1JlZ1swXS5T d2l6emxlID0gU1dJWlpMRV9OT09QOwogICAgdnAtPlNyY1JlZ1sxXS5Td2l6 emxlID0gU1dJWlpMRV9OT09QOwogICAgdnAtPlNyY1JlZ1syXS5Td2l6emxl ID0gU1dJWlpMRV9OT09QOwotICAgdnAtPlNyY1JlZ1szXS5Td2l6emxlID0g U1dJWlpMRV9OT09QOwogICAgdnAtPkRzdFJlZy5Xcml0ZU1hc2sgPSAweGY7 CiAKICAgIHN3aXRjaCAodHlwZSkgewotLS0gYS9ueC1YMTEvbGliL1gxMS9p bUxjUHJzLmMJMjAxMy0wOC0zMCAyMDoxODo0MC4wMDAwMDAwMDAgKzA2MDAK KysrIGIvbngtWDExL2xpYi9YMTEvaW1MY1Bycy5jCTIwMTMtMDktMzAgMTk6 MDI6NTYuOTI1MTI1Njc4ICswNjAwCkBAIC01ODksNyArNTg5LDcgQEAKIAog ICAgIGwgPSBfWG1ic3RvdXRmOChsb2NhbF91dGY4X2J1ZiwgcmhzX3N0cmlu Z19tYiwgTE9DQUxfVVRGOF9CVUZTSVpFIC0gMSk7CiAgICAgaWYgKGwgPT0g TE9DQUxfVVRGOF9CVUZTSVpFIC0gMSkgewotCWxvY2FsX3djX2J1ZltsXSA9 ICdcMCc7CisJbG9jYWxfdXRmOF9idWZbbF0gPSAnXDAnOwogICAgIH0KICAg ICBpZiggKHJoc19zdHJpbmdfdXRmOCA9IChjaGFyICopWG1hbGxvYyhsICsg MSkpID09IE5VTEwgKSB7CiAJWGZyZWUoIHJoc19zdHJpbmdfd2MgKTsKLS0t IGEvbngtWDExL3Byb2dyYW1zL1hzZXJ2ZXIveGtiL2RkeExvYWQuYwkyMDEz LTA4LTMwIDIwOjE4OjQwLjAwMDAwMDAwMCArMDYwMAorKysgYi9ueC1YMTEv cHJvZ3JhbXMvWHNlcnZlci94a2IvZGR4TG9hZC5jCTIwMTMtMDktMzAgMTg6 NTY6MjcuMzU4OTk1OTIwICswNjAwCkBAIC0zNyw2ICszNywxMiBAQAogI2lu Y2x1ZGUgPGVycm5vLmg+CiAjaW5jbHVkZSA8c3RkaW8uaD4KICNpbmNsdWRl IDxjdHlwZS5oPgorCisvKiBzdGF0KCkgKi8KKyNpbmNsdWRlIDxzeXMvdHlw ZXMuaD4KKyNpbmNsdWRlIDxzeXMvc3RhdC5oPgorI2luY2x1ZGUgPHVuaXN0 ZC5oPgorCiAjZGVmaW5lCU5FRURfRVZFTlRTIDEKICNpbmNsdWRlIDxYMTEv WC5oPgogI2luY2x1ZGUgPFgxMS9Yb3MuaD4K --_----------=_13805498242613634--