From unknown Fri Mar 29 13:57:34 2024 X-Loop: owner@bugs.x2go.org Subject: Bug#266: x2goclient does not handle exporting dirs correctly in broker-mode Reply-To: Anders Bruun Olsen , 266@bugs.x2go.org Resent-From: Anders Bruun Olsen Resent-To: x2go-dev@lists.berlios.de Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Fri, 19 Jul 2013 15:03:01 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: report 266 X-X2Go-PR-Package: x2goclient X-X2Go-PR-Keywords: Received: via spool by submit@bugs.x2go.org id=B.13742458198366 (code B); Fri, 19 Jul 2013 15:03:01 +0000 Received: (at submit) by bugs.x2go.org; 19 Jul 2013 14:56:59 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=HTML_MESSAGE, RCVD_IN_DNSWL_MED,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham version=3.3.2 X-Greylist: delayed 342 seconds by postgrey-1.34 at ymir; Fri, 19 Jul 2013 16:56:56 CEST Received: from eu1sys200aog104.obsmtp.com (eu1sys200aog104.obsmtp.com [207.126.144.117]) by ymir (Postfix) with SMTP id C32885DB0A for ; Fri, 19 Jul 2013 16:56:56 +0200 (CEST) Received: from mail-oa0-f43.google.com ([209.85.219.43]) (using TLSv1) by eu1sys200aob104.postini.com ([207.126.147.11]) with SMTP ID DSNKUelTuOPFbFMIWo9x7EA7FizyqHpvwkzQ@postini.com; Fri, 19 Jul 2013 14:56:56 UTC Received: by mail-oa0-f43.google.com with SMTP id i7so6179847oag.16 for ; Fri, 19 Jul 2013 07:56:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dsl.dk; s=google; h=mime-version:date:message-id:subject:from:to:content-type; bh=sYkyTyZjXZvpmg3PY+TlH3azMntz7X1zsHvyzsZlr1k=; b=Ffn/eEHXbO9Q05lVq5wHrEvkeLZLyWrFVmiqWCZon1jXNNGE52uWT0ZvvPG0cstoK7 YnMOjPDnyZMWg6TZqhdy0+4yFS/fICd/B/iVT/kE7aWUm4RY2xcPvH6118jeFy4Y+7L/ WwYQNQhszVkYGWJXdK6ffnzTCEwVA5jbEdD/E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type :x-gm-message-state; bh=sYkyTyZjXZvpmg3PY+TlH3azMntz7X1zsHvyzsZlr1k=; b=Em7DTPwQXgNDjhUrLpfv6pa4gSIu5Pp5ZvD0aEMSHNqhRhi/cikVIHGczAakaQc6fh 53AaDuRi6+Os2rZs9CaZ65JILYhsKjFtyxfZW7z40RB96Shcl4Hx+FK13PBh/0kYmQ/O A1jr7A4U5RrIfgnMFNEtWdiTfZPIfZwFrWZsBo9a8pu0mQ7G5qKAJ0X1QjBDQm6sVdiE nIB6aHiu80UDbzt99jzdYE5ONnDlGq7CBox69Wc8MUATLoif2T2F9JC1+f6CUc/s8/kU nqT7VzHQzvC/DUuf5Tvjjq5qMuR+QYKDtV+YkWdQVVddlK92P60RmJjPu8YuVIUlF1oU 0BpQ== X-Received: by 10.182.87.73 with SMTP id v9mr12446537obz.90.1374245472822; Fri, 19 Jul 2013 07:51:12 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.182.87.73 with SMTP id v9mr12446518obz.90.1374245472576; Fri, 19 Jul 2013 07:51:12 -0700 (PDT) Received: by 10.182.241.33 with HTTP; Fri, 19 Jul 2013 07:51:12 -0700 (PDT) Date: Fri, 19 Jul 2013 16:51:12 +0200 Message-ID: From: Anders Bruun Olsen To: X2go bugs Content-Type: multipart/alternative; boundary=089e013cb6e43a35b904e1de7562 X-Gm-Message-State: ALoCoQm8SEIz9OI3tITfJbAAFyI8B9/NTfsAxZTaH0ssRDkYzAsihk3Uklx3Rh8S+Czv73Fvm/OhxBxdramyi9OI3YXhKsBwmocjZ7hMIFoDmwh7up8qKmn/yUDA8j1KV3l5rF55G5vFG6ExGn9fiQNoayTI9cmP0A== --089e013cb6e43a35b904e1de7562 Content-Type: text/plain; charset=UTF-8 Package: x2goclient Version: 4.0.1.1 (git) Severity: minor ONMainWindow::exportDirs does not handle broker-mode correctly. I discovered this because the combination of x2goclient on Mac and XFCE means that xfdesktop hangs on login, waiting for a timeout somewhere. If fstunnel is turned off, this problem (with xfdesktop) goes away. My broker sets fstunnel=false, but x2goclient does not respect this. Digging into the code reveals that ONMainWindow::exportDirs initialises an X2goSettings object from "sessions" rather than the way it should be done when in broker-mode. Since it sets the default value for fstunnel to true, and since there isn't a local session for the session ID currently running through the broker, fstunnel is always true when in broker-mode. -- Anders Bruun Olsen It-ansvarlig Det Danske Sprog- og Litteraturselskab (Society for Danish Language and Literature) --089e013cb6e43a35b904e1de7562 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Package: x2goclient
Version: 4.0.1.1 (git)
S= everity: minor

ONMainWindow::exportDirs does not h= andle broker-mode correctly.
I discovered this because the combin= ation of x2goclient on Mac and XFCE means that xfdesktop hangs on login, wa= iting for a timeout somewhere. If fstunnel is turned off, this problem (wit= h xfdesktop) goes away. My broker sets fstunnel=3Dfalse, but x2goclient doe= s not respect this. Digging into the code reveals that ONMainWindow::export= Dirs initialises an X2goSettings object from "sessions" rather th= an the way it should be done when in broker-mode. Since it sets the default= value for fstunnel to true, and since there isn't a local session for = the session ID currently running through the broker, fstunnel is always tru= e when in broker-mode.

--
Anders Bruun Olsen
It-ansvarlig
Det Danske Spro= g- og Litteraturselskab
(Society for Danish Language and Literature)
--089e013cb6e43a35b904e1de7562--