From abo@dsl.dk Tue Jun 11 11:11:07 2013 Received: (at submit) by bugs.x2go.org; 11 Jun 2013 09:11:08 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=HTML_MESSAGE, RCVD_IN_DNSWL_MED,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from eu1sys200aog106.obsmtp.com (eu1sys200aog106.obsmtp.com [207.126.144.121]) by ymir (Postfix) with SMTP id 613325DB15 for ; Tue, 11 Jun 2013 11:11:07 +0200 (CEST) Received: from mail-oa0-f43.google.com ([209.85.219.43]) (using TLSv1) by eu1sys200aob106.postini.com ([207.126.147.11]) with SMTP ID DSNKUbbpqyvU4OSmehYfSa5i2RvmwXxpgZD9@postini.com; Tue, 11 Jun 2013 09:11:07 UTC Received: by mail-oa0-f43.google.com with SMTP id i7so5726360oag.30 for ; Tue, 11 Jun 2013 02:11:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dsl.dk; s=google; h=mime-version:date:message-id:subject:from:to:content-type; bh=o2dxXP08kx9XFjozWV0nV77kzHmJXYPJS62eLPU2GLQ=; b=VTsIlvWd2GiZMPN7ky1YzAB3PI7MN8/jgHxp4dwNCG/qRVUcTcVuF+BxbKi9LugAjr kbZlRKCiAYjvZtpDSmGAPi6P56wkSTpE8UkVTof1MUOLlleNhrZzbSitMhlp3NCqxx21 jKakRd1kU6E/PNJGs59XvXZpJMqeojGVFkNvs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type :x-gm-message-state; bh=o2dxXP08kx9XFjozWV0nV77kzHmJXYPJS62eLPU2GLQ=; b=gLIr7xqIoFR/84NdmyncX4o+uoTCxCpMavzw/9+ekMo4BzwkAqGU7KNlpuE7rySSQS 2RLkADvlJVBUZd4oZFYuxIS0tRoYyYrlwl6S8Ck4YsfA6+IIoredDUZ7xdzjcHEX9HTq DLFu9xLK0ByDSeGthewJn98FNcyUcjN2Ewbsw9wussIBuC3wU/PPuLilNTHn+ZeFxJxO +SbAql02N2QcAYf7cvCwlgKR5r9WB78TpF6/fPCYnc9P2n7Wwj1G/dzrw1ech976t7Va Hjv7AQpdGuj5VZi0gzSVmBNjOprAgoamSwUfZRON8XqE8n/a61IdDs8elhv/pSuZPFYq cwTQ== X-Received: by 10.182.125.1 with SMTP id mm1mr11036759obb.47.1370941866198; Tue, 11 Jun 2013 02:11:06 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.182.125.1 with SMTP id mm1mr11036757obb.47.1370941866119; Tue, 11 Jun 2013 02:11:06 -0700 (PDT) Received: by 10.182.45.193 with HTTP; Tue, 11 Jun 2013 02:11:06 -0700 (PDT) Date: Tue, 11 Jun 2013 11:11:06 +0200 Message-ID: Subject: x2goclient error messages regarding sshd are confusing From: Anders Bruun Olsen To: submit@bugs.x2go.org Content-Type: multipart/alternative; boundary=089e0122ac50f0197b04dedd4602 X-Gm-Message-State: ALoCoQnAUoflBGqBAvlNAQ1oBbF9BHzkYEBMTf4o3KFvTstVDypVzLcXV05Eexrh1JE1OlvSM6dAPomaQEjE9oED7waNrFQTErEifl8q2NORMmbvXw7D4XLjRQA2kkE6OaFjrpSTv56gEsiZwMtBUiCmMqGLTWG7tg== --089e0122ac50f0197b04dedd4602 Content-Type: text/plain; charset=UTF-8 Package: x2goclient Version: 4.0.1.0 Severity: minor X2goclient uses the same error dialog for three different (but related) problems. The error message is the one about sshd not running (printSshDError() in onmainwindow.cpp). The conditions are: 1. Unable to open host public key (line 7319) 2. Unable to open key for exports (line 7438) 3. Unable to open authorized_keys (line 7455) These should have distinct error messages, that does not just claim that sshd isn't running. Also, the current message tells the user to install sshd with "apt-get install openssh-server". While I am an Ubuntu user, this message most definitely shouldn't be Debian/Ubuntu specific, since it is also given to both Windows and Mac users, not to mention Linux users on different distributions. -- Anders Bruun Olsen It-ansvarlig Det Danske Sprog- og Litteraturselskab (Society for Danish Language and Literature) --089e0122ac50f0197b04dedd4602 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Package: x2goclient
Version: 4.0.1.0
Severit= y: minor

X2goclient uses the same error dialog for= three different (but related) problems. The error message is the one about= sshd not running (printSshDError() in onmainwindow.cpp). The conditions ar= e:

1. Unable to open host public key (line 7319)
2. Unable to open key for exports (line 7438)
3. Unable to open = authorized_keys (line 7455)

These should have dist= inct error messages, that does not just claim that sshd isn't running.<= /div>

Also, the current message tells the user to install ssh= d with "apt-get install openssh-server". While I am an Ubuntu use= r, this message most definitely shouldn't be Debian/Ubuntu specific, si= nce it is also given to both Windows and Mac users, not to mention Linux us= ers on different distributions.

--
Anders Bruun Olsen
It-ansvarlig
Det Danske Spro= g- og Litteraturselskab
(Society for Danish Language and Literature)
--089e0122ac50f0197b04dedd4602--