From unknown Sun Apr 12 22:55:16 2026
X-Loop: owner@bugs.x2go.org
Subject: Bug#214: [X2Go-Dev] Bug#214: Bug#214: Add maximun available desktop area to session resolutions combo box
Reply-To: Ricardo =?UTF-8?Q?D=C3=ADaz_?= =?UTF-8?Q?Mart=C3=ADn?= <ricardo.diaz@oceanosoft.com>, 214@bugs.x2go.org
Resent-From: Ricardo =?UTF-8?Q?D=C3=ADaz_?= =?UTF-8?Q?Mart=C3=ADn?= <ricardo.diaz@oceanosoft.com>
Original-Sender: oceanosoftlapalma@gmail.com
Resent-To: x2go-dev@lists.berlios.de
Resent-CC: X2Go Developers <x2go-dev@lists.berlios.de>
X-Loop: owner@bugs.x2go.org
Resent-Date: Tue, 21 May 2013 21:03:01 +0000
Resent-Message-ID: <handler.214.B214.136916940021080@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 214
X-X2Go-PR-Package: x2goclient
X-X2Go-PR-Keywords: moreinfo
Received: via spool by 214-submit@bugs.x2go.org id=B214.136916940021080
          (code B ref 214); Tue, 21 May 2013 21:03:01 +0000
Received: (at 214) by bugs.x2go.org; 21 May 2013 20:50:00 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-0.7 required=5.0 tests=HTML_MESSAGE,
	RCVD_IN_DNSWL_LOW,T_DKIM_INVALID,T_REMOTE_IMAGE,URIBL_BLOCKED
	autolearn=unavailable version=3.3.2
Received: from mail-ie0-f170.google.com (mail-ie0-f170.google.com [209.85.223.170])
	by ymir (Postfix) with ESMTPS id 8B4485DB13;
	Tue, 21 May 2013 22:49:51 +0200 (CEST)
Received: by mail-ie0-f170.google.com with SMTP id aq17so3184500iec.1
        for <multiple recipients>; Tue, 21 May 2013 13:49:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:cc:content-type;
        bh=fQ3iuBzD1p1APDWUfEHF1tvA+vyE6nyi80wY9dGrrzs=;
        b=WS9qWkLSBS44wqDUm9JhzNrSZlWUQFXfSbmdm4V6fwdbYdHkw0VCKt0O+fYveTBgA3
         B4enO+AL0HbRvDmhYRIaw8g1IUcsY5j8sa99mhNEA2qb4WKmeepdfySu2D6jv2gIuj+U
         UmRpmpuHkkWSZ/ZtqjdIhEqSr2OZHx2GY79t7rs4ShcdcVQHP5a7enRUYxZ6zgtT3Ppd
         Us+6vkDEZtsKFiktY5iNDSKZmTRF6l2Bl552IsOvaBXgzPkPDszXhFlkVpF9mjxXoaFa
         fefalcH4LrdJ5FSDXqXu+1k3VudX4MYR7qL6pj6Jc+Tb40JmNQ58ePZyMGr7whKN5JU3
         v00Q==
MIME-Version: 1.0
X-Received: by 10.50.141.163 with SMTP id rp3mr8974987igb.72.1369169389926;
 Tue, 21 May 2013 13:49:49 -0700 (PDT)
Sender: oceanosoftlapalma@gmail.com
Received: by 10.231.250.84 with HTTP; Tue, 21 May 2013 13:49:49 -0700 (PDT)
In-Reply-To: <20130520221048.12336maibngtnqko@mail.das-netzwerkteam.de>
References: <CAPWth0++jOCCKWqzC+hxpwGqEYkcAxVY6DmDoQZ2id0zSZ4gpw@mail.gmail.com>
	<20130520221048.12336maibngtnqko@mail.das-netzwerkteam.de>
Date: Tue, 21 May 2013 20:49:49 +0000
X-Google-Sender-Auth: cVW6SV6fd00Y_HGqgIm_OYAg274
Message-ID: <CAPWth0+CnM4m6_MKYrVgPNPJRZ19JdYC7PPZU=ptoGM4j22s+A@mail.gmail.com>
From: Ricardo =?UTF-8?Q?D=C3=ADaz_?= =?UTF-8?Q?Mart=C3=ADn?= <ricardo.diaz@oceanosoft.com>
To: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>, 214@bugs.x2go.org, 
	x2go-dev@lists.berlios.de
Cc: control@bugs.x2go.org
Content-Type: multipart/mixed; boundary=089e013c6c2c1fc4bf04dd4097eb

--089e013c6c2c1fc4bf04dd4097eb
Content-Type: multipart/alternative; boundary=089e013c6c2c1fc4bb04dd4097e9

--089e013c6c2c1fc4bb04dd4097e9
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

This new patch add an option box in windows/mac clients (in linux it
isn't necessary because this feature is working in current stable).

If user set "max available area" max height and max width are stored in
session settings.

It was tested in linux and in windows and works as expected.

Anyway I'd like to include patch #0006 too because I think it's useful too.

Cheers,
Ricardo


--
<http://www.oceanosoft.com>


2013/5/20 Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

> tag #214 - patch
> tag #214 moreinfo
> thanks
>
> Hi Ricardo,
>
> On Mo 20 Mai 2013 18:18:04 CEST Ricardo D=C3=ADaz Mart=C3=ADn wrote:
>
>  Package: x2goclient
>> Severity: wishlist
>> Tag: patch
>>
>> I attach a patch to add the maximun available resolution for each monito=
r
>> in the session display resolutions combo box.
>>
>> I think it will be useful for the users.
>>
>> Regards,
>>
>
> thanks for this patch. Counter-suggestion: add a radio button to the
> session profile GUI that always sets the maxdim of the currently used loc=
al
> desktop.
>
> Check the pyhoca-gui session profile manager for a comparison.
>
> Normally, in the session profile options, you either set width=3D and
> height=3D, or you set fullscreen=3Dtrue, or you set maxdim=3Dtrue.
>
> If maxdim is set to true, then it has precedence over the width=3D / heig=
ht=3D
> parameters.
>
> Could you rather implement that?
>
> Thanks+Greets,
> Mike
>
>
> --
>
> DAS-NETZWERKTEAM
> mike gabriel, herweg 7, 24357 fleckeby
> fon: +49 (1520) 1976 148
>
> GnuPG Key ID 0x25771B31
> mail: mike.gabriel@das-netzwerkteam.**de<mike.gabriel@das-netzwerkteam.de=
>,
> http://das-netzwerkteam.de
>
> freeBusy:
> https://mail.das-netzwerkteam.**de/freebusy/m.gabriel%40das-**
> netzwerkteam.de.xfb<https://mail.das-netzwerkteam.de/freebusy/m.gabriel%4=
0das-netzwerkteam.de.xfb>
> _______________________________________________
> X2Go-Dev mailing list
> X2Go-Dev@lists.berlios.de
> https://lists.berlios.de/mailman/listinfo/x2go-dev
>

--089e013c6c2c1fc4bb04dd4097e9
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">This new patch add an option box in windows/mac clients (i=
n linux it isn&#39;t=C2=A0necessary=C2=A0because this feature is working in=
 current stable).<div><br></div><div style>If user set &quot;max available =
area&quot; max height and max=C2=A0width=C2=A0are stored in session setting=
s.</div>
<div style><br></div><div style>It was tested in linux and in windows and w=
orks as expected.</div><div style><br></div><div style>Anyway I&#39;d like =
to=C2=A0include=C2=A0patch #0006 too because I think it&#39;s=C2=A0useful=
=C2=A0too.</div><div style>
<br></div><div style>Cheers,</div><div style>Ricardo</div></div><div class=
=3D"gmail_extra"><br clear=3D"all"><div><div><br></div><div>--</div><a href=
=3D"http://www.oceanosoft.com" target=3D"_blank"><img src=3D"https://lh3.go=
ogleusercontent.com/CypK-pdqxWOXz6gN11bCmkvgrP87Q3nGwCMi4ESOBfQI2_KL-ILSkwv=
R2QKpSGPrnaxSXFXsGhvxFmTqegUI1mOhIYPpD11BOlziwYKTVh2DPrq1Vw"></a><br>
</div>
<br><br><div class=3D"gmail_quote">2013/5/20 Mike Gabriel <span dir=3D"ltr"=
>&lt;<a href=3D"mailto:mike.gabriel@das-netzwerkteam.de" target=3D"_blank">=
mike.gabriel@das-netzwerkteam.de</a>&gt;</span><br><blockquote class=3D"gma=
il_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-lef=
t:1ex">
tag #214 - patch<br>
tag #214 moreinfo<br>
thanks<br>
<br>
Hi Ricardo,<br>
<br>
On Mo 20 Mai 2013 18:18:04 CEST Ricardo D=C3=ADaz Mart=C3=ADn wrote:<br>
<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">
Package: x2goclient<br>
Severity: wishlist<br>
Tag: patch<br>
<br>
I attach a patch to add the maximun available resolution for each monitor<b=
r>
in the session display resolutions combo box.<br>
<br>
I think it will be useful for the users.<br>
<br>
Regards,<br>
</blockquote>
<br>
thanks for this patch. Counter-suggestion: add a radio button to the sessio=
n profile GUI that always sets the maxdim of the currently used local deskt=
op.<br>
<br>
Check the pyhoca-gui session profile manager for a comparison.<br>
<br>
Normally, in the session profile options, you either set width=3D and heigh=
t=3D, or you set fullscreen=3Dtrue, or you set maxdim=3Dtrue.<br>
<br>
If maxdim is set to true, then it has precedence over the width=3D / height=
=3D parameters.<br>
<br>
Could you rather implement that?<br>
<br>
Thanks+Greets,<br>
Mike<span class=3D"HOEnZb"><font color=3D"#888888"><br>
<br>
<br>
-- <br>
<br>
DAS-NETZWERKTEAM<br>
mike gabriel, herweg 7, 24357 fleckeby<br>
fon: <a href=3D"tel:%2B49%20%281520%29%201976%20148" value=3D"+491520197614=
8" target=3D"_blank">+49 (1520) 1976 148</a><br>
<br>
GnuPG Key ID 0x25771B31<br>
mail: <a href=3D"mailto:mike.gabriel@das-netzwerkteam.de" target=3D"_blank"=
>mike.gabriel@das-netzwerkteam.<u></u>de</a>, <a href=3D"http://das-netzwer=
kteam.de" target=3D"_blank">http://das-netzwerkteam.de</a><br>
<br>
freeBusy:<br>
<a href=3D"https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwe=
rkteam.de.xfb" target=3D"_blank">https://mail.das-netzwerkteam.<u></u>de/fr=
eebusy/m.gabriel%40das-<u></u>netzwerkteam.de.xfb</a></font></span><br>____=
___________________________________________<br>

X2Go-Dev mailing list<br>
<a href=3D"mailto:X2Go-Dev@lists.berlios.de">X2Go-Dev@lists.berlios.de</a><=
br>
<a href=3D"https://lists.berlios.de/mailman/listinfo/x2go-dev" target=3D"_b=
lank">https://lists.berlios.de/mailman/listinfo/x2go-dev</a><br></blockquot=
e></div><br></div>

--089e013c6c2c1fc4bb04dd4097e9--
--089e013c6c2c1fc4bf04dd4097eb
Content-Type: application/octet-stream; 
	name="0007-add-max-resolution-option-box-in-settings-for-win-an.patch"
Content-Disposition: attachment; 
	filename="0007-add-max-resolution-option-box-in-settings-for-win-an.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_hgzk0t2z1

RnJvbSAzMDVlY2Y2YzE3ZGUzYTRmMjYyMDQzMDZmZmE0NTY0MmRmMjVjMmRiIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBSaWNhcmRvIERpYXogPG9jZWFub3NvZnRsYXBhbG1hQGdtYWls
LmNvbT4KRGF0ZTogVHVlLCAyMSBNYXkgMjAxMyAyMDo0MTozMyArMDAwMApTdWJqZWN0OiBbUEFU
Q0ggNy83XSBhZGQgbWF4IHJlc29sdXRpb24gb3B0aW9uIGJveCBpbiBzZXR0aW5ncyBmb3Igd2lu
IGFuZCBtYWMKCi0tLQogc2V0dGluZ3N3aWRnZXQuY3BwIHwgMzEgKysrKysrKysrKysrKysrKysr
KysrKystLS0tLS0tLQogc2V0dGluZ3N3aWRnZXQuaCAgIHwgIDIgLS0KIDIgZmlsZXMgY2hhbmdl
ZCwgMjMgaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc2V0dGlu
Z3N3aWRnZXQuY3BwIGIvc2V0dGluZ3N3aWRnZXQuY3BwCmluZGV4IDk4Y2I5YjAuLjE1ZWI5MWUg
MTAwNjQ0Ci0tLSBhL3NldHRpbmdzd2lkZ2V0LmNwcAorKysgYi9zZXR0aW5nc3dpZGdldC5jcHAK
QEAgLTY4LDE2ICs2OCwxMiBAQCBTZXR0aW5nc1dpZGdldDo6U2V0dGluZ3NXaWRnZXQgKCBRU3Ry
aW5nIGlkLCBPTk1haW5XaW5kb3cgKiBtdywKICAgICBjdXN0b209bmV3IFFSYWRpb0J1dHRvbiAo
IHRyICggIldpbmRvdyIgKSxkZ2IgKTsKICNlbmRpZgogICAgIGRpc3BsYXk9bmV3IFFSYWRpb0J1
dHRvbiAoIHRyICggIlVzZSB3aG9sZSBkaXNwbGF5IiApLGRnYiApOwotI2lmZGVmIFFfT1NfTElO
VVgKICAgICBtYXhSZXM9bmV3IFFSYWRpb0J1dHRvbiAoIHRyICggIk1heGltdW0gYXZhaWxhYmxl
IiApLGRnYiApOwotI2VuZGlmCiAgICAgcmFkaW8tPmFkZEJ1dHRvbiAoIGZzICk7CiAgICAgcmFk
aW8tPmFkZEJ1dHRvbiAoIGN1c3RvbSApOwogICAgIHJhZGlvLT5zZXRFeGNsdXNpdmUgKCB0cnVl
ICk7CiAgICAgcmFkaW8tPmFkZEJ1dHRvbihkaXNwbGF5KTsKLSNpZmRlZiBRX09TX0xJTlVYCiAg
ICAgcmFkaW8tPmFkZEJ1dHRvbihtYXhSZXMpOwotI2VuZGlmCiAgICAgd2lkdGg9bmV3IFFTcGlu
Qm94ICggZGdiICk7CiAgICAgaGVpZ2h0PW5ldyBRU3BpbkJveCAoIGRnYiApOwogICAgIGNiU2V0
RFBJPW5ldyBRQ2hlY2tCb3ggKCB0ciAoICJTZXQgZGlzcGxheSBEUEkiICksZGdiICk7CkBAIC0x
MTAsOSArMTA2LDcgQEAgU2V0dGluZ3NXaWRnZXQ6OlNldHRpbmdzV2lkZ2V0ICggUVN0cmluZyBp
ZCwgT05NYWluV2luZG93ICogbXcsCiAgICAgZHdMYXktPmFkZFN0cmV0Y2goKTsKIAogICAgIGRp
c3BMYXktPmFkZFdpZGdldChkaXNwbGF5KTsKLSNpZmRlZiBRX09TX0xJTlVYCiAgICAgZGlzcExh
eS0+YWRkV2lkZ2V0KG1heFJlcyk7Ci0jZW5kaWYKICAgICBkaXNwTGF5LT5hZGRTcGFjaW5nKDE1
KTsKICAgICBkaXNwTGF5LT5hZGRXaWRnZXQobERpc3BsYXk9bmV3IFFMYWJlbCh0cigiJkRpc3Bs
YXk6IiksZGdiKSk7CiAgICAgZGlzcExheS0+YWRkV2lkZ2V0KGRpc3BsYXlOdW1iZXI9bmV3IFFT
cGluQm94KGRnYikpOwpAQCAtNjY1LDggKzY1OSw2IEBAIHZvaWQgU2V0dGluZ3NXaWRnZXQ6OnNh
dmVTZXR0aW5ncygpCiAKICAgICBzdC5zZXR0aW5nKCktPnNldFZhbHVlICggc2Vzc2lvbklkKyIv
ZnVsbHNjcmVlbiIsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICggUVZhcmlhbnQgKSBm
cy0+aXNDaGVja2VkKCkgKTsKLSAgICBzdC5zZXR0aW5nKCktPnNldFZhbHVlICggc2Vzc2lvbklk
KyIvd2lkdGgiLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoIFFWYXJpYW50ICkgd2lk
dGgtPnZhbHVlKCkgKTsKICAgICBzdC5zZXR0aW5nKCktPnNldFZhbHVlICggc2Vzc2lvbklkKyIv
bXVsdGlkaXNwIiwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKCBRVmFyaWFudCApIGRp
c3BsYXktPmlzQ2hlY2tlZCgpICk7CiAgICAgc3Quc2V0dGluZygpLT5zZXRWYWx1ZSAoIHNlc3Np
b25JZCsiL2Rpc3BsYXkiLApAQCAtNjg3LDggKzY3OSwzMSBAQCB2b2lkIFNldHRpbmdzV2lkZ2V0
OjpzYXZlU2V0dGluZ3MoKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoIFFWYXJpYW50
ICkgcGFyYW1zLT50ZXh0KCkpOwogI2VuZGlmCiAjZW5kaWYKKworICAgIHN0LnNldHRpbmcoKS0+
c2V0VmFsdWUgKCBzZXNzaW9uSWQrIi93aWR0aCIsCisgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICggUVZhcmlhbnQgKSB3aWR0aC0+dmFsdWUoKSApOworCiAgICAgc3Quc2V0dGluZygpLT5z
ZXRWYWx1ZSAoIHNlc3Npb25JZCsiL2hlaWdodCIsCiAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICggUVZhcmlhbnQgKSBoZWlnaHQtPnZhbHVlKCkgKTsKKworICAgIC8vaWYgbWF4UmVzIGlz
IGNoZWNrZWQgd2lkdGggYW5kIGhlaWdodCBhcmUgc2V0dGVkIHRvIG1heCBhcmVhIGF2YWlsYWJs
ZQorICAgIGlmIChtYXhSZXMtPmlzQ2hlY2tlZCgpCisgICAgICAgICAgICB8fCBzdC5zZXR0aW5n
KCktPnZhbHVlKHNlc3Npb25JZCArICIvbXVsdGlkaXNwIiwgKFFWYXJpYW50KSBmYWxzZSkudG9C
b29sKCkKKyAgICAgICAgICAgIHx8IHN0LnNldHRpbmcoKS0+dmFsdWUoc2Vzc2lvbklkICsgIi9t
YXhkaW0iLCAoUVZhcmlhbnQpIGZhbHNlKS50b0Jvb2woKSkgeworCisgICAgICAgIC8vZ2V0IHNj
cmVlbiBudW1iZXIKKyAgICAgICAgaW50IHNlbGVjdGVkU2NyZWVuID0gc3Quc2V0dGluZygpLT52
YWx1ZShzZXNzaW9uSWQgKyAiL2Rpc3BsYXkiLCAoUVZhcmlhbnQpIC0xKS50b0ludCgpOworCisg
ICAgICAgIC8vZ2V0IG1heCBhdmFpbGFibGUgZGVza3RvcCBhcmVhIGZvciBzZWxlY3RlZCBzY3Jl
ZW4KKyAgICAgICAgaW50IGhlaWdodCA9IFFBcHBsaWNhdGlvbjo6ZGVza3RvcCgpLT5hdmFpbGFi
bGVHZW9tZXRyeShzZWxlY3RlZFNjcmVlbikuaGVpZ2h0KCk7CisgICAgICAgIGludCB3aWR0aCA9
IFFBcHBsaWNhdGlvbjo6ZGVza3RvcCgpLT5hdmFpbGFibGVHZW9tZXRyeShzZWxlY3RlZFNjcmVl
bikud2lkdGgoKTsKKworICAgICAgICAvL3NhdmUgbWF4IHJlc29sdXRpb24KKyAgICAgICAgc3Qu
c2V0dGluZygpLT5zZXRWYWx1ZSAoc2Vzc2lvbklkICsgIi93aWR0aCIsIChRVmFyaWFudCkgd2lk
dGgpOworICAgICAgICBzdC5zZXR0aW5nKCktPnNldFZhbHVlIChzZXNzaW9uSWQgKyAiL2hlaWdo
dCIsIChRVmFyaWFudCkgaGVpZ2h0KTsKKyAgICB9CisKKwogICAgIHN0LnNldHRpbmcoKS0+c2V0
VmFsdWUgKCBzZXNzaW9uSWQrIi9kcGkiLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAo
IFFWYXJpYW50ICkgRFBJLT52YWx1ZSgpICk7CiAgICAgc3Quc2V0dGluZygpLT5zZXRWYWx1ZSAo
IHNlc3Npb25JZCsiL3NldGRwaSIsCmRpZmYgLS1naXQgYS9zZXR0aW5nc3dpZGdldC5oIGIvc2V0
dGluZ3N3aWRnZXQuaAppbmRleCA1OTBlNzI4Li43NWQ2NzI0IDEwMDY0NAotLS0gYS9zZXR0aW5n
c3dpZGdldC5oCisrKyBiL3NldHRpbmdzd2lkZ2V0LmgKQEAgLTY4LDkgKzY4LDcgQEAgcHJpdmF0
ZToKICAgICBRTGluZUVkaXQqIHR5cGU7CiAgICAgUVJhZGlvQnV0dG9uKiBjdXN0b207CiAgICAg
UVJhZGlvQnV0dG9uKiBkaXNwbGF5OwotI2lmZGVmIFFfT1NfTElOVVgKICAgICBRUmFkaW9CdXR0
b24qIG1heFJlczsKLSNlbmRpZgogICAgIFFSYWRpb0J1dHRvbiogYXJ0czsKICAgICBRUmFkaW9C
dXR0b24qIHB1bHNlOwogICAgIFFSYWRpb0J1dHRvbiogZXNkOwotLSAKMS44LjEuMgoK
--089e013c6c2c1fc4bf04dd4097eb--