From oceanosoftlapalma@gmail.com Tue May 21 16:34:19 2013 Received: (at 214) by bugs.x2go.org; 21 May 2013 14:34:20 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=FREEMAIL_FROM,HTML_MESSAGE, RCVD_IN_DNSWL_LOW,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from mail-ie0-f174.google.com (mail-ie0-f174.google.com [209.85.223.174]) by ymir (Postfix) with ESMTPS id EE6385DB13; Tue, 21 May 2013 16:34:18 +0200 (CEST) Received: by mail-ie0-f174.google.com with SMTP id 10so1763129ied.19 for ; Tue, 21 May 2013 07:34:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=7O0u3pImFSBxsyQ5KGtO6Y5EAXoSpV5Zn0H/bSuQl2w=; b=ExyUGlD8lyECB6y9xwjezLG/Rd4V2MnjDr+m4SzWs7rVcPC3vgKmgAn8bm3CZQa+65 PvXD9G/XT5rD17lvuL8tJwob0lxM8mqAMNGAns6nB6VKwcanC95rEKiibpG7Vr6yWhjx h/+i86yS9t6HyDmqiq9RxstRnHI2cLiYjsGgGzfpM7AZVuB+nzgvWkYcsF8S1z8vTQla ZAybUSf0vfd3slCN8XgmAhnmE5pYYUt2wdAQxlxprKLJK5liKeCh7+iFGuEVHDQUlv16 2VS2Cqvx50CKVCdd4yaiEiiaU82v7fTyQHnywSEM2Hd/L9C+v6IRBSFvBvycQNBtrKIV NRFg== MIME-Version: 1.0 X-Received: by 10.50.128.134 with SMTP id no6mr8457339igb.10.1369146857170; Tue, 21 May 2013 07:34:17 -0700 (PDT) Received: by 10.231.250.84 with HTTP; Tue, 21 May 2013 07:34:17 -0700 (PDT) In-Reply-To: <20130520221048.12336maibngtnqko@mail.das-netzwerkteam.de> References: <20130520221048.12336maibngtnqko@mail.das-netzwerkteam.de> Date: Tue, 21 May 2013 15:34:17 +0100 Message-ID: Subject: Re: [X2Go-Dev] Bug#214: Bug#214: Add maximun available desktop area to session resolutions combo box From: =?UTF-8?B?UmljYXJkbyBEw61heiBNYXJ0w61u?= To: Mike Gabriel , 214@bugs.x2go.org, x2go-dev@lists.berlios.de Cc: control@bugs.x2go.org Content-Type: multipart/alternative; boundary=047d7b10c94b112fec04dd3b58d8 --047d7b10c94b112fec04dd3b58d8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable 2013/5/20 Mike Gabriel > tag #214 - patch > tag #214 moreinfo > thanks > > Hi Ricardo, > > On Mo 20 Mai 2013 18:18:04 CEST Ricardo D=C3=ADaz Mart=C3=ADn wrote: > > Package: x2goclient >> Severity: wishlist >> Tag: patch >> >> I attach a patch to add the maximun available resolution for each monito= r >> in the session display resolutions combo box. >> >> I think it will be useful for the users. >> >> Regards, >> > > thanks for this patch. Counter-suggestion: add a radio button to the > session profile GUI that always sets the maxdim of the currently used loc= al > desktop. > > Check the pyhoca-gui session profile manager for a comparison. > I'll take a look to pyhoca-gui session profile! > > Normally, in the session profile options, you either set width=3D and > height=3D, or you set fullscreen=3Dtrue, or you set maxdim=3Dtrue. > > If maxdim is set to true, then it has precedence over the width=3D / heig= ht=3D > parameters. > > Could you rather implement that? > Note that maxdim is only available in x2goclient linux version. Looks like Alex found some problem with this feature in windows/mac/maemo. I was working some weeks ago to do it and I show lots of #ifdef sentences to avoid this feature in no linux enviroments. So I decided to implement this "uggly" feature and sent the patch. I can do the work but I'd have to change a lot of Alex code. Maybe I have to write to Alex to know if he found problem with "use max available area". What do you think about? > > Thanks+Greets, > Mike > --047d7b10c94b112fec04dd3b58d8 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

= 2013/5/20 Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
tag #214 - patc= h
tag #214 moreinfo
thanks

Hi Ricardo,

On Mo 20 Mai 2013 18:18:04 CEST Ricardo D=C3=ADaz Mart=C3=ADn wrote:

Package: x2goclient
Severity: wishlist
Tag: patch

I attach a patch to add the maximun available resolution for each monitor in the session display resolutions combo box.

I think it will be useful for the users.

Regards,

thanks for this patch. Counter-suggestion: add a radio button to the sessio= n profile GUI that always sets the maxdim of the currently used local deskt= op.

Check the pyhoca-gui session profile manager for a comparison.



I'll = take a look to pyhoca-gui session profile!

=C2=A0<= /div>

Normally, in the session profile options, you either set width=3D and heigh= t=3D, or you set fullscreen=3Dtrue, or you set maxdim=3Dtrue.

If maxdim is set to true, then it has precedence over the width=3D / height= =3D parameters.

Could you rather implement that?

=
Note that maxdim is only available in x2goclient linux= version. Looks like Alex found some problem with this feature in windows/m= ac/maemo. I was working some weeks ago to do it and I show lots of #ifdef s= entences to avoid this feature in no linux enviroments. So I decided to imp= lement this "uggly" feature and sent the patch. I can do the work= but I'd have to change a lot of Alex code. Maybe I have to write to Al= ex to know if he found problem with "use max available area". Wha= t do you think about?

=C2=A0

Thanks+Greets,
Mike


--047d7b10c94b112fec04dd3b58d8--