#205 - Patch for fix cairo issue - X2Go Bug report logs

X2Go Bug report logs - #205
Patch for fix cairo issue

Reported by: Nicolas DEFFAYET <nicolas@deffayet.com>

Date: Fri, 10 May 2013 21:18:01 UTC

Severity: normal

Tags: moreinfo, patch

Found in version 3.5.0.20-0

Done: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

Bug is archived. No further changes may be made.

Received: (at 205) by bugs.x2go.org; 15 May 2015 13:24:33 +0000
From mike.gabriel@das-netzwerkteam.de  Fri May 15 15:24:32 2015
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED
	autolearn=ham version=3.3.2
Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 1B7A25DA82
	for <205@bugs.x2go.org>; Fri, 15 May 2015 15:24:32 +0200 (CEST)
Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98])
	by freya.das-netzwerkteam.de (Postfix) with ESMTPS id D82CAA76;
	Fri, 15 May 2015 15:24:31 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 7C04D3B980;
	Fri, 15 May 2015 15:24:31 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de
Received: from grimnir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id Ni64WB8wktde; Fri, 15 May 2015 15:24:31 +0200 (CEST)
Received: from grimnir.das-netzwerkteam.de (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id 0DE0B3B977;
	Fri, 15 May 2015 15:24:31 +0200 (CEST)
Received: from m-097.informatik.uni-kiel.de (m-097.informatik.uni-kiel.de
 [134.245.254.97]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP;
 Fri, 15 May 2015 13:24:31 +0000
Date: Fri, 15 May 2015 13:24:30 +0000
Message-ID: <20150515132430.Horde.MRXuGCQsIQxESiMSLx-Odw1@mail.das-netzwerkteam.de>
From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
To: Ulrich Sibiller <uli42@gmx.de>, 205@bugs.x2go.org
Subject: Re: [X2Go-Dev] Bug#205: Some comments on this
In-Reply-To: <CANVnVYKX4vj1O2OUWYZpLCnNi=c6MtAKSK6HWO3uaC1pkErZ1A@mail.gmail.com>
User-Agent: Internet Messaging Program (IMP) H5 (6.2.2)
Accept-Language: de,en
Organization: DAS-NETZWERKTEAM
X-Originating-IP: 134.245.254.97
X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101
 Firefox/32.0 Iceweasel/32.0
Content-Type: multipart/signed; boundary="=_P-g_Vkg1X81vfjZAwXDxXA1";
 protocol="application/pgp-signature"; micalg=pgp-sha1
MIME-Version: 1.0

[Message part 1 (text/plain, inline)]

Control: close -1 On Di 02 Dez 2014 23:58:01 CET, Ulrich Sibiller wrote: > In nxagent-3.5.0-8 NoMachine has tweaked the version number of > nxagent to work better with cairo. So doing this is not completely > unusual for NX... > > In nx-X11/programs/Xserver/hw/ > nxagent/Init.c you can find these lines: > ----------------------------------------------------------- > /* > * Avoid slowness due to buggy_repeat workaround > * in libcairo versions >= 1.10. > */ > > SetVendorRelease(70000000); > ----------------------------------------------------------- > > And in the CHANGELOG: > ----------------------------------------------------------- > nxagent-3.5.0-8 > > - Fixed TR01J02646. Performance issues with cairo version 1.12. > ----------------------------------------------------------- > > > However, the current cairo code contains this > (http://cgit.freedesktop.org/cairo/tree/src/cairo-xlib-display.c > around line 300): > ----------------------------------------------------------- > if (VendorRelease (dpy) >= 60700000) { > if (VendorRelease (dpy) < 70000000) > display->buggy_repeat = TRUE; > } > ----------------------------------------------------------- > > As NX is presenting itself as 70000000 the condition is false already > and changing the version to 70100000 would not change the cairo > behaviour here. > > BTW: Xorg 6.9 and 7.0 are the same code. 7.0 has just been > restructured completely and adapted to automake. Agreeing with Uli on this and thus closing. Mike -- DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

[Message part 2 (application/pgp-signature, inline)]

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Nov 21 15:04:04 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

X2Go Bug report logs - #205 Patch for fix cairo issue

X2Go Bug report logs - #205
Patch for fix cairo issue