X2Go Bug report logs - #205
Patch for fix cairo issue

version graph

Package: nx-libs; Maintainer for nx-libs is X2Go Developers <x2go-dev@lists.x2go.org>;

Reported by: Nicolas DEFFAYET <nicolas@deffayet.com>

Date: Fri, 10 May 2013 21:18:01 UTC

Severity: normal

Tags: moreinfo, patch

Found in version 3.5.0.20-0

Done: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

Bug is archived. No further changes may be made.

Full log

🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#205: Some comments on this
Reply-To: Ulrich Sibiller <uli42@gmx.de>, 205@bugs.x2go.org
Resent-From: Ulrich Sibiller <uli42@gmx.de>
Original-Sender: ulrich.sibiller@gmail.com
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Tue, 02 Dec 2014 23:00:02 +0000
Resent-Message-ID: <handler.205.B205.141756110315551@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 205
X-X2Go-PR-Package: nx-libs
X-X2Go-PR-Keywords: moreinfo patch
Received: via spool by 205-submit@bugs.x2go.org id=B205.141756110315551
          (code B ref 205); Tue, 02 Dec 2014 23:00:02 +0000
Received: (at 205) by bugs.x2go.org; 2 Dec 2014 22:58:23 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM,
	T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham version=3.3.2
Received: from mail-lb0-f176.google.com (mail-lb0-f176.google.com [209.85.217.176])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 1CBC83D7BC
	for <205@bugs.x2go.org>; Tue,  2 Dec 2014 23:58:22 +0100 (CET)
Received: by mail-lb0-f176.google.com with SMTP id p9so11080904lbv.7
        for <205@bugs.x2go.org>; Tue, 02 Dec 2014 14:58:21 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:sender:from:date:message-id:subject:to:content-type;
        bh=52ANNbmRcItOAi2wtn+3glyLeudt5YyON2WKLXUiWm0=;
        b=wrU5Br2TZ5/T1eYRgGWWtfjbwuxAVlkplaxMdT1mgEZCUAdtEXUYiM8SjbX2/W7GNa
         JHuyj3GWq1tZpBLuYO1ezW9y0bU0kIlrIzj18CaPM582Gu6vBeOmRQSzZVfKGN71ziUV
         iEtdW7Nsc4Ni2XMVcvr5EPeq2xhuXRT5R9gFaeaUzbD5upKX6UbQ2UVyAh5CZtS0fXEs
         K8deZ+jbIWG5vqn+naN/lySVWHiMYCUeh+dYcsjXuVf6x8WRIO5viBpzBUgK9DKJGZso
         WQPuy044YA3l/SmThZ4xxdYZx7YBO5mcyZ/+LZqBBk9ZeshZJWkeOweRqL0rRY8vPUCk
         cEEw==
X-Received: by 10.112.199.233 with SMTP id jn9mr1585472lbc.18.1417561101248;
 Tue, 02 Dec 2014 14:58:21 -0800 (PST)
MIME-Version: 1.0
Sender: ulrich.sibiller@gmail.com
Received: by 10.112.89.101 with HTTP; Tue, 2 Dec 2014 14:58:01 -0800 (PST)
From: Ulrich Sibiller <uli42@gmx.de>
Date: Tue, 2 Dec 2014 23:58:01 +0100
X-Google-Sender-Auth: eN1pY3nvrjhRiGr5i0OrqseNn5A
Message-ID: <CANVnVYKX4vj1O2OUWYZpLCnNi=c6MtAKSK6HWO3uaC1pkErZ1A@mail.gmail.com>
To: 205@bugs.x2go.org
Content-Type: text/plain; charset=UTF-8

In nxagent-3.5.0-8 NoMachine has tweaked the version number of
nxagent to work better with cairo. So doing this is not completely
unusual for NX...

In nx-X11/programs/Xserver/hw/
nxagent/Init.c you can find these lines:
-----------------------------------------------------------
/*
* Avoid slowness due to buggy_repeat workaround
* in libcairo versions >= 1.10.
*/

SetVendorRelease(70000000);
-----------------------------------------------------------

And in the CHANGELOG:
-----------------------------------------------------------
nxagent-3.5.0-8

- Fixed TR01J02646. Performance issues with cairo version 1.12.
-----------------------------------------------------------


However, the current cairo code contains this
(http://cgit.freedesktop.org/cairo/tree/src/cairo-xlib-display.c
around line 300):
-----------------------------------------------------------
if (VendorRelease (dpy) >= 60700000) {
   if (VendorRelease (dpy) < 70000000)
display->buggy_repeat = TRUE;
}
-----------------------------------------------------------

As NX is presenting itself as 70000000 the condition is false already
and changing the version to 70100000 would not change the cairo
behaviour here.

BTW: Xorg 6.9 and 7.0 are the same code. 7.0 has just been
restructured completely and adapted to automake.

Uli

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Nov 21 15:34:33 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.