From unknown Sat Apr 11 03:35:56 2026 MIME-Version: 1.0 X-Mailer: MIME-tools 5.502 (Entity 5.502) X-Loop: owner@bugs.x2go.org From: owner@bugs.x2go.org (X2Go Bug Tracking System) Subject: Bug#205 closed by Mike Gabriel (Re: [X2Go-Dev] Bug#205: Some comments on this) Message-ID: References: <20150515132430.Horde.MRXuGCQsIQxESiMSLx-Odw1@mail.das-netzwerkteam.de> X-X2go-PR-Keywords: moreinfo patch X-X2go-PR-Message: they-closed 205 X-X2go-PR-Package: nx-libs Date: Fri, 15 May 2015 13:24:46 +0000 Content-Type: multipart/mixed; boundary="----------=_1431696286-18020-0" This is a multi-part message in MIME format... ------------=_1431696286-18020-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 This is an automatic notification regarding your Bug report which was filed against the nx-libs package: #205: Patch for fix cairo issue It has been closed by Mike Gabriel . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Mike Gabriel by replying to this email. --=20 205: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=3D205 X2Go Bug Tracking System Contact owner@bugs.x2go.org with problems ------------=_1431696286-18020-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 205) by bugs.x2go.org; 15 May 2015 13:24:33 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 1B7A25DA82 for <205@bugs.x2go.org>; Fri, 15 May 2015 15:24:32 +0200 (CEST) Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98]) by freya.das-netzwerkteam.de (Postfix) with ESMTPS id D82CAA76; Fri, 15 May 2015 15:24:31 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 7C04D3B980; Fri, 15 May 2015 15:24:31 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de Received: from grimnir.das-netzwerkteam.de ([127.0.0.1]) by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ni64WB8wktde; Fri, 15 May 2015 15:24:31 +0200 (CEST) Received: from grimnir.das-netzwerkteam.de (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id 0DE0B3B977; Fri, 15 May 2015 15:24:31 +0200 (CEST) Received: from m-097.informatik.uni-kiel.de (m-097.informatik.uni-kiel.de [134.245.254.97]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP; Fri, 15 May 2015 13:24:31 +0000 Date: Fri, 15 May 2015 13:24:30 +0000 Message-ID: <20150515132430.Horde.MRXuGCQsIQxESiMSLx-Odw1@mail.das-netzwerkteam.de> From: Mike Gabriel To: Ulrich Sibiller , 205@bugs.x2go.org Subject: Re: [X2Go-Dev] Bug#205: Some comments on this In-Reply-To: User-Agent: Internet Messaging Program (IMP) H5 (6.2.2) Accept-Language: de,en Organization: DAS-NETZWERKTEAM X-Originating-IP: 134.245.254.97 X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0 Iceweasel/32.0 Content-Type: multipart/signed; boundary="=_P-g_Vkg1X81vfjZAwXDxXA1"; protocol="application/pgp-signature"; micalg=pgp-sha1 MIME-Version: 1.0 This message is in MIME format and has been PGP signed. --=_P-g_Vkg1X81vfjZAwXDxXA1 Content-Type: text/plain; charset=us-ascii; format=flowed; DelSp=Yes Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Control: close -1 On Di 02 Dez 2014 23:58:01 CET, Ulrich Sibiller wrote: > In nxagent-3.5.0-8 NoMachine has tweaked the version number of > nxagent to work better with cairo. So doing this is not completely > unusual for NX... > > In nx-X11/programs/Xserver/hw/ > nxagent/Init.c you can find these lines: > ----------------------------------------------------------- > /* > * Avoid slowness due to buggy_repeat workaround > * in libcairo versions >=3D 1.10. > */ > > SetVendorRelease(70000000); > ----------------------------------------------------------- > > And in the CHANGELOG: > ----------------------------------------------------------- > nxagent-3.5.0-8 > > - Fixed TR01J02646. Performance issues with cairo version 1.12. > ----------------------------------------------------------- > > > However, the current cairo code contains this > (http://cgit.freedesktop.org/cairo/tree/src/cairo-xlib-display.c > around line 300): > ----------------------------------------------------------- > if (VendorRelease (dpy) >=3D 60700000) { > if (VendorRelease (dpy) < 70000000) > display->buggy_repeat =3D TRUE; > } > ----------------------------------------------------------- > > As NX is presenting itself as 70000000 the condition is false already > and changing the version to 70100000 would not change the cairo > behaviour here. > > BTW: Xorg 6.9 and 7.0 are the same code. 7.0 has just been > restructured completely and adapted to automake. Agreeing with Uli on this and thus closing. Mike --=20 DAS-NETZWERKTEAM mike=20gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.x= fb --=_P-g_Vkg1X81vfjZAwXDxXA1 Content-Type: application/pgp-signature Content-Description: Digitale PGP-Signatur Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABAgAGBQJVVfOOAAoJEJr0azAldxsxmjgP/29/INnEyjqM9BNXNkZdLgx4 ldHtJgiOJOYtIBvDXx/CtpJaKfvkutKmyHvuHJSK55JUYLCYKC/WbPYhMNCctD0E JknqcmTqocD4FK2UL9EJtNS1PMRQ9WG5uU6qcF3RQb7CMgSwquAlHbjuDN8W0nmd lpo0c4ns2mBHNsqIMoGCNzqMaAEXcZmUzvUCmDuKb66e0/t8zkqX+WkJ3mag3Kcq MasHZXdYvTwz0lS3xpky9+JZUj5bjfPqc8y8eXg4KFSquXomJsDaqurc2mAEFEuU 3xzwwCnDp4609z0ArI6+4dHX+qDf5DY7Jj9zT1cyrMxt4fsMhVDBmBv0B5htMpJ+ S7Uz0UenPxImuF5Ka6eg3iAQ9+9XCBp202OLCa9QRMKBBwNrBj3RIRtWlYmP+Igv qNwH0BNOZUqlXZ4m8kPSyEGT2cr6/fElVZDG0FLKCtDrn6FJWIrtqq5cS9EEG4Ko dG+W81v32/qlH9w7xy4cskhA+AtTsW0HwVmZrKKUC6WclX7ElpIyhn73apqDeb8b pqUN3MgMdQ9hbHkG0Og0yh/gVP8g9Hj6NtDx5VHq8fzIz74a3Zwuxk9jL5eMrnRE k/xq59FnFWG4RUlH3Zc+VLCKNvixeb89lvxmq9ELNi1PvVuadf0OjpBXUJ7jFNid 1jFq5m3YeXTLA0lr4bsX =S2Ol -----END PGP SIGNATURE----- --=_P-g_Vkg1X81vfjZAwXDxXA1-- ------------=_1431696286-18020-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by bugs.x2go.org; 10 May 2013 21:17:52 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=URIBL_BLOCKED autolearn=ham version=3.3.2 X-Greylist: delayed 591 seconds by postgrey-1.34 at ymir; Fri, 10 May 2013 23:17:51 CEST Received: from smtp.novso.com (smtp1.novso.com [193.189.104.85]) by ymir (Postfix) with ESMTPS id ABC715DB21 for ; Fri, 10 May 2013 23:17:51 +0200 (CEST) Subject: Patch for fix cairo issue From: Anonymous To: submit@bugs.x2go.org Content-Type: text/plain; charset="UTF-8" Organization: DEFFAYET.COM Date: Fri, 10 May 2013 23:07:59 +0200 Message-ID: <1368220079.30773.10.camel@fr-wks3.corp.novso.com> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Package: nx-libs Version: 3.5.0.20-0 As cairo enable buggy_repeat (src/cairo-xlib-display.c) for XFree86 <= 40500000; X.Org >= 60700000 & < 70000000; X.Org < 10400000, it's required to have version 70100000 shown to cairo. On Debian Wheezy, with original cairo, this will result of no fount displayed as show on https://bbs.archlinux.org/viewtopic.php?id=141884. The problem is already know: https://bugs.freedesktop.org/show_bug.cgi?id=32014 Ubuntu ***seem*** (require more investigation) to have patched their cairo but not Debian. Patching nx-X11 for show fake version to cairo is for me the best solution as there is no dependance of a patched cairo. Suggested patch (need more test): $ vi debian/patches/999_nx-X11_version_hack_for_cairo.patch --- Description: Version hack for cairo As cairo enable buggy_repeat (src/cairo-xlib-display.c) for XFree86 <= 40500000; X.Org >= 60700000 & < 70000000; X.Org < 10400000, it's required to have version 70100000 shown to cairo. https://bugs.freedesktop.org/show_bug.cgi?id=32014. --- a/nx-X11/config/cf/X11.tmpl 2013-03-28 20:36:38.000000000 +0000 +++ b/nx-X11/config/cf/X11.tmpl 2013-05-10 18:20:18.000000000 +0000 @@ -45,7 +45,7 @@ # if defined XorgVersionString # define XOrgReleaseString Release XorgVersionString # else -# define XOrgReleaseString Release 6.9 +# define XOrgReleaseString Release 7.1 # endif #endif --- a/nx-X11/config/util/makedef.cmd 2013-03-28 20:36:38.000000000 +0000 +++ b/nx-X11/config/util/makedef.cmd 2013-05-10 18:41:40.000000000 +0000 @@ -23,13 +23,13 @@ sASDFeatureId = ''; sCountryCode = ''; sDateTime = left(' 'date()' 'time(), 26); -sDescription = 'X.Org 6.9'; +sDescription = 'X.Org 7.1'; sFixPakVer = ''; sHostname = strip(substr(VALUE('HOSTNAME',,'OS2ENVIRONMENT'), 1, 11)); sLanguageCode = ''; sMiniVer = ''; sVendor = 'X.Org'; -sVersion = '6.9'; +sVersion = '7.1'; /* --- $ echo "999_nx-X11_version_hack_for_cairo.patch" >> debian/patches/series Thanks -- Anonymous ------------=_1431696286-18020-0--