From unknown Sun Apr 12 21:16:44 2026 MIME-Version: 1.0 X-Mailer: MIME-tools 5.502 (Entity 5.502) X-Loop: owner@bugs.x2go.org From: owner@bugs.x2go.org (X2Go Bug Tracking System) Subject: Bug#164 closed by Mike Gabriel (X2Go issue (in src:x2goclient) has been marked as closed) Message-ID: References: <20130911100707.B05605DB20@ymir> X-X2go-PR-Keywords: pending patch X-X2go-PR-Message: they-closed 164 X-X2go-PR-Package: x2goclient X-X2go-PR-Source: x2goclient Date: Wed, 11 Sep 2013 10:18:15 +0000 Content-Type: multipart/mixed; boundary="----------=_1378894695-25056-0" This is a multi-part message in MIME format... ------------=_1378894695-25056-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 This is an automatic notification regarding your Bug report which was filed against the x2goclient package: #164: Set DPI to same as local display by default It has been closed by Mike Gabriel . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Mike Gabriel by replying to this email. --=20 X2Go Bug Tracking System Contact owner@bugs.x2go.org with problems ------------=_1378894695-25056-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at control) by bugs.x2go.org; 11 Sep 2013 10:08:20 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_RELAYS, URIBL_BLOCKED autolearn=unavailable version=3.3.2 Received: by ymir (Postfix, from userid 1005) id B05605DB20; Wed, 11 Sep 2013 12:07:07 +0200 (CEST) From: Mike Gabriel To: 164-submitter@bugs.x2go.org Cc: control@bugs.x2go.org, 164@bugs.x2go.org Subject: X2Go issue (in src:x2goclient) has been marked as closed Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Message-Id: <20130911100707.B05605DB20@ymir> Date: Wed, 11 Sep 2013 12:07:07 +0200 (CEST) close #164 thanks Hello, we are very hopeful that X2Go issue #164 reported by you has been resolved in the new release (4.0.1.1) of the X2Go source project »src:x2goclient«. You can view the complete changelog entry of src:x2goclient (4.0.1.1) below, and you can use the following link to view all the code changes between this and the last release of src:x2goclient. http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=dad4fcc24868504be24ccc9a3ab0fcac41859080;hp=1b4260f86a6fda01c5263fa3d27504677a3cdfac If you feel that the issue has not been resolved satisfyingly, feel free to reopen this bug report or submit a follow-up report with further observations described based on the new released version of src:x2goclient. Thanks a lot for contributing to X2Go!!! light+love X2Go Git Admin (on behalf of the sender of this mail) --- X2Go Component: src:x2goclient Version: 4.0.1.1 Status: RELEASE Date: Wed, 11 Sep 2013 12:06:02 +0200 Fixes: 141 142 151 164 165 177 179 183 214 222 226 243 255 Changes: x2goclient (4.0.1.1) RELEASED; urgency=low . [ Nicolai Hansen ] * New upstream version (4.0.1.1): - Update Danish translation file. . [ Terje Andersen ] * New upstream version (4.0.1.1): - Update Norwegian Bokmaal translation file. . [ Oleksandr Shneyder ] * New upstream version (4.0.1.1): - Use "127.0.0.1" instead of localhost to avoid wrong IPv6 hostname resolution. (Fixes: #151). - Wait for x2gocmdexitmessage to return before closing in hidden mode. - Support for published applications in X2Go Plugin - Support for "shadow" mode in X2Go Plugin . [ Mike Gabriel ] * New upstream version (4.0.1.1): - If a priv SSH key has been specified, skip the autologin procedure. Let's consider a given SSH private key that fails to log the user in as an overall login failure. (Fixes: #141). - Avoid multiple selectUserSession requests when in broker mode. - Properly set the remote server address received via selectUserSession method when in broker mode. (Fixes: #226). - Fix segmentation fault that started occurring since the custom trayIcon patch was applied. Segfault only occurred if the tray icon was not used. - Show session name in notification bubbles. - Update German translation. - Add cmdline option --broker-autologoff: Enforce re-authentication against X2Go Session Broker after a session has been suspended or terminated. (Fixes: #179). - Enable full access desktop sharing across user accounts. (Fixes: #222). - Make X2Go Client aware of the MATE desktop environment. - Make X2Go Client work in SSH broker mode without the need of a auth-id file. . [ Heinrich Schuchardt ] * New upstream version (4.0.1.1): - Call ssh_clean_pubkey_hash() for deallocating public key hashes instead of just calling free(). Required under MS Windows as documented in libssh2 API. (Fixes: #243). (For further details see: http://api.libssh.org/master/group__libssh__session.html). * Provide bin:package with debug symbols for X2Go Client. (Fixes: #255). . [ Ezra Bühler ] * New upstream version (4.0.1.1): - Fix auto-resume when session type is »Single Application«. (Fixes: #183). . [ Ricardo Díaz Martín ] * New upstream version (4.0.1.1): - Fix detection of maximum screen area available for a session. (Fixes: #165). - Use the session icon as tray icon, pop up notification bubble that informs about current session actions. (Fixes: #177). - Allow for setting maximum available desktop size as window size via the session profile card. Unfortunately, this feature is for now only available on Linux. (Fixes: #214). . [ Otto Kjell ] * New upstream version (4.0.1.1): - Enable debug mode through cmd line parameter. (Fixes: #142). - Standardize output to stdout+stderr and make it parseable. . [ Orion Poplawski ] * New upstream version (4.0.1.1): - Instead of using a hard-code DPI of 96, use local DPI settings for new sessions if not explicitly set in session profile (Fixes: #164). . [ Daniel Lindgren ] * New upstream version (4.0.1.1): - Update Swedish translation file. . [ Ricardo Díaz Martín ] * New upstream version (4.0.1.1): - Update Spanish translation file. ------------=_1378894695-25056-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by bugs.x2go.org; 10 Apr 2013 18:16:52 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from mail.cora.nwra.com (mercury.cora.nwra.com [4.28.99.165]) by ymir (Postfix) with ESMTPS id D2CD55DA6C for ; Wed, 10 Apr 2013 20:16:48 +0200 (CEST) Received: from barry.cora.nwra.com (barry.cora.nwra.com [10.10.20.7]) (authenticated bits=0) by mail.cora.nwra.com (8.14.4/8.14.4) with ESMTP id r3AIGjKO029539 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO) for ; Wed, 10 Apr 2013 12:16:46 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=cora.nwra.com; s=default; t=1365617806; bh=5Xi83ZeyVIcByZLqnbInE/ifjdwBxl49jyOlHnGN220=; h=Message-ID:Date:From:MIME-Version:To:Subject:Content-Type; b=YNYf9Yn2f4fwSecK4ACVXStavihVOQsTfH5Y4fHFyoOiWVWpKWTMGUl/iNtzpolnA wkLjL5qxwwlrfT7HjHxXpWX6nz8E4B0nw7H7wNyzaQEa/oQ2qmqsArQbdEP/1u+IMu UkX2OH1JVfKwBh9ZDJihAJVKfPDBJl0E2Zfh0n+s= Message-ID: <5165AC8D.1050801@cora.nwra.com> Date: Wed, 10 Apr 2013 12:16:45 -0600 From: Orion Poplawski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5 MIME-Version: 1.0 To: submit@bugs.x2go.org Subject: Set DPI to same as local display by default Content-Type: multipart/mixed; boundary="------------030703050407090705050902" This is a multi-part message in MIME format. --------------030703050407090705050902 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Package: x2goclient Version: 4.0.1.0 Tags: patch I think it would be nice to have sessions set the DPI to that of the local display by default. I'm not entirely sure if physicalDpiX or logicalDpiX is better here. -- Orion Poplawski Technical Manager 303-415-9701 x222 NWRA, Boulder/CoRA Office FAX: 303-415-9702 3380 Mitchell Lane orion@nwra.com Boulder, CO 80301 http://www.nwra.com --------------030703050407090705050902 Content-Type: text/x-patch; name="x2goclient-dpi.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="x2goclient-dpi.patch" diff --git a/onmainwindow.cpp b/onmainwindow.cpp index 31dbc17..5f37cc1 100644 --- a/onmainwindow.cpp +++ b/onmainwindow.cpp @@ -61,8 +61,6 @@ ONMainWindow::ONMainWindow ( QWidget *parent ) :QMainWindow ( parent ) showHaltBtn=false; defaultUseSound=true; defaultSetKbd=true; - defaultSetDPI=false; - defaultDPI=96; extStarted=false; cmdAutologin=false; defaultLink=2; @@ -107,6 +105,16 @@ ONMainWindow::ONMainWindow ( QWidget *parent ) :QMainWindow ( parent ) cmdAutologin=false; +// Try to determine the native DPI and use it for the default + int dpix = QApplication::desktop()->physicalDpiX(); + int dpiy = QApplication::desktop()->physicalDpiY(); + if ( dpix >0 && dpiy >0) { + defaultSetDPI=true; + defaultDPI=(dpix+dpiy)/2; + } else { + defaultSetDPI=false; + defaultDPI=96; + } #ifdef Q_OS_WIN clientSshPort="7022"; @@ -6661,7 +6669,7 @@ void ONMainWindow::showHelp() "--user=\t\t select user 'username'\n" "--geomerty=x|fullscreen\t set default geometry, default " "value '800x600'\n" - "--dpi=\t\t\t set dpi of x2goagent to dpi, default not set\n" + "--dpi=\t\t\t set dpi of x2goagent to dpi, default set to same as local display\n" "--link= set default link type, " "default 'adsl'\n" "--pack=\t\t set default pack method, default " --------------030703050407090705050902-- ------------=_1378894695-25056-0--